October 2022 - flashrom-gerrit

[M] Change in flashrom[master]: flashrom_tester: Use Path type and tempdir for test data
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Evan Benn. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68643 ) Change subject: flashrom_tester: Use Path type and tempdir for test data ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/68643/comment/57ed5ff3_f9a99a22 PS1, Line 10: Update many str to Path. Can this be done separately from the tempdir stuff? -- To view, visit https://review.coreboot.org/c/flashrom/+/68643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4a0b25c8c70fa6dfd682fba3db7d3bf06b2eb7ac Gerrit-Change-Number: 68643 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 09:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Get rid of temporary `prog_type` string
by Anastasia Klimchuk (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68239 ) Change subject: rayer_spi.c: Get rid of temporary `prog_type` string ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68239 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I83e34382ee9814f224025e21e5099fdab73cee8c Gerrit-Change-Number: 68239 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 06:39:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: programmer: Add rget_io_perms programmer req framework
by Edward O'Callaghan (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68662 to look at the new patch set (#3). Change subject: programmer: Add rget_io_perms programmer req framework ...................................................................... programmer: Add rget_io_perms programmer req framework Some programmers require special i/o port access permissions. Add a flag in the programmer entry to allow the programmer to flag this requirement to the flashrom core logic rather than each bespoke programmer init() calling rget_io_perms() in their own ways. This allows for flashrom core logic to assume and drop privileges exactly where they are needed rather than for the entire life-time of the program. It also deduplicates the assuming privilege code in each driver. Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/programmer.h 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/68662/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2 Gerrit-Change-Number: 68662 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: programmer: Add rget_io_perms programmer req framework
by Edward O'Callaghan (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68662 to look at the new patch set (#2). Change subject: programmer: Add rget_io_perms programmer req framework ...................................................................... programmer: Add rget_io_perms programmer req framework Some programmers require special i/o port access permissions. Add a flag in the programmer entry to allow the programmer to flag this requirement to the flashrom core logic rather than each bespoke programmer init() calling rget_io_perms() in their own ways. This allows for flashrom core logic to assume and drop privileges exactly where they are needed rather than for the entire life-time of the program. It also deduplicates the assuming privilege code in each driver. Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/programmer.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/68662/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2 Gerrit-Change-Number: 68662 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tree/drivers: Migrate to rget_io_perms_req framework
by Edward O'Callaghan (Code Review) 21 Oct '22

21 Oct '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68663 ) Change subject: tree/drivers: Migrate to rget_io_perms_req framework ...................................................................... tree/drivers: Migrate to rget_io_perms_req framework Drop bespoke calls in driver init() entry-points in favour of using the programmer requirements flag. Change-Id: Idbb53e97e1cc208bfdb94bd66c5d5840750c8f40 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M atahpt.c M atapromise.c M internal.c M nic3com.c M nicnatsemi.c M nicrealtek.c M rayer_spi.c M satamv.c 8 files changed, 21 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/68663/1 diff --git a/atahpt.c b/atahpt.c index 89b44c2..12d1c57 100644 --- a/atahpt.c +++ b/atahpt.c @@ -89,9 +89,6 @@ struct pci_dev *dev = NULL; uint32_t io_base_addr; - if (rget_io_perms()) - return 1; - dev = pcidev_init(cfg, ata_hpt, PCI_BASE_ADDRESS_4); if (!dev) return 1; @@ -118,6 +115,7 @@ const struct programmer_entry programmer_atahpt = { .name = "atahpt", .type = PCI, + .rget_io_perms_req = true, .devs.dev = ata_hpt, .init = atahpt_init, }; diff --git a/atapromise.c b/atapromise.c index 625eb83..197fd82 100644 --- a/atapromise.c +++ b/atapromise.c @@ -131,9 +131,6 @@ uint8_t *bar; size_t rom_size; - if (rget_io_perms()) - return 1; - dev = pcidev_init(cfg, ata_promise, PCI_BASE_ADDRESS_4); if (!dev) return 1; @@ -182,6 +179,7 @@ const struct programmer_entry programmer_atapromise = { .name = "atapromise", .type = PCI, + .rget_io_perms_req = true, .devs.dev = ata_promise, .init = atapromise_init, }; diff --git a/internal.c b/internal.c index 8c834e2..798fa69 100644 --- a/internal.c +++ b/internal.c @@ -236,11 +236,6 @@ } #if defined(__i386__) || defined(__x86_64__) - if (rget_io_perms()) { - ret = 1; - goto internal_init_exit; - } - if ((cb_parse_table(&cb_vendor, &cb_model) == 0) && (board_vendor != NULL) && (board_model != NULL)) { if (strcasecmp(board_vendor, cb_vendor) || strcasecmp(board_model, cb_model)) { msg_pwarn("Warning: The mainboard IDs set by -p internal:mainboard (%s:%s) do not\n" @@ -347,6 +342,7 @@ const struct programmer_entry programmer_internal = { .name = "internal", .type = OTHER, + .rget_io_perms_req = true, .devs.note = NULL, .init = internal_init, }; diff --git a/nic3com.c b/nic3com.c index efba979..7ab6ef3 100644 --- a/nic3com.c +++ b/nic3com.c @@ -108,9 +108,6 @@ uint32_t internal_conf = 0; uint16_t id; - if (rget_io_perms()) - return 1; - dev = pcidev_init(cfg, nics_3com, PCI_BASE_ADDRESS_0); if (!dev) return 1; @@ -166,6 +163,7 @@ const struct programmer_entry programmer_nic3com = { .name = "nic3com", .type = PCI, + .rget_io_perms_req = true, .devs.dev = nics_3com, .init = nic3com_init, }; diff --git a/nicnatsemi.c b/nicnatsemi.c index efa879a..96425a5 100644 --- a/nicnatsemi.c +++ b/nicnatsemi.c @@ -93,9 +93,6 @@ struct pci_dev *dev = NULL; uint32_t io_base_addr; - if (rget_io_perms()) - return 1; - dev = pcidev_init(cfg, nics_natsemi, PCI_BASE_ADDRESS_0); if (!dev) return 1; @@ -125,6 +122,7 @@ const struct programmer_entry programmer_nicnatsemi = { .name = "nicnatsemi", .type = PCI, + .rget_io_perms_req = true, .devs.dev = nics_natsemi, .init = nicnatsemi_init, }; diff --git a/nicrealtek.c b/nicrealtek.c index 103ea9e..4aa1305 100644 --- a/nicrealtek.c +++ b/nicrealtek.c @@ -104,9 +104,6 @@ int bios_rom_addr; int bios_rom_data; - if (rget_io_perms()) - return 1; - dev = pcidev_init(cfg, nics_realtek, PCI_BASE_ADDRESS_0); if (!dev) return 1; @@ -144,6 +141,7 @@ const struct programmer_entry programmer_nicrealtek = { .name = "nicrealtek", .type = PCI, + .rget_io_perms_req = true, .devs.dev = nics_realtek, .init = nicrealtek_init, }; diff --git a/rayer_spi.c b/rayer_spi.c index 8fdcc01..00a873a 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -294,9 +294,6 @@ msg_pinfo("Using %s pinout.\n", prog->description); pinout = (struct rayer_pinout *)prog->dev_data; - if (rget_io_perms()) - return 1; - /* Get the initial value before writing to any line. */ lpt_outbyte = INB(lpt_iobase); @@ -327,6 +324,7 @@ .name = "rayer_spi", .type = OTHER, /* FIXME */ + .rget_io_perms_req = true, .devs.note = "RayeR parallel port programmer\n", .init = rayer_spi_init, }; diff --git a/satamv.c b/satamv.c index dcd53c7..e046d56 100644 --- a/satamv.c +++ b/satamv.c @@ -122,9 +122,6 @@ uint16_t iobar; uint8_t *bar; - if (rget_io_perms()) - return 1; - /* BAR0 has all internal registers memory mapped. */ dev = pcidev_init(cfg, satas_mv, PCI_BASE_ADDRESS_0); if (!dev) @@ -209,6 +206,7 @@ const struct programmer_entry programmer_satamv = { .name = "satamv", .type = PCI, + .rget_io_perms_req = true, .devs.dev = satas_mv, .init = satamv_init, }; -- To view, visit https://review.coreboot.org/c/flashrom/+/68663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idbb53e97e1cc208bfdb94bd66c5d5840750c8f40 Gerrit-Change-Number: 68663 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: programmer: Add rget_io_perms programmer req framework
by Edward O'Callaghan (Code Review) 21 Oct '22

21 Oct '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68662 ) Change subject: programmer: Add rget_io_perms programmer req framework ...................................................................... programmer: Add rget_io_perms programmer req framework Some programmers require special i/o port access permissions. Add a flag in the programmer entry to allow the programmer to flag this requirement to the flashrom core logic rather than each bespoke programmer init() calling rget_io_perms() in their own ways. This allows for flashrom core logic to assume and drop privileges exactly where they are needed rather than for the entire life-time of the program. It also deduplicates the assuming privilege code in each driver. Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/programmer.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/68662/1 diff --git a/flashrom.c b/flashrom.c index 624c463..908f46e 100644 --- a/flashrom.c +++ b/flashrom.c @@ -32,6 +32,7 @@ #include "flashchips.h" #include "programmer.h" #include "hwaccess_physmap.h" +#include "hwaccess_x86_io.h" /* required for rget_io_perms() */ #include "chipdrivers.h" const char flashrom_version[] = FLASHROM_VERSION; @@ -149,6 +150,13 @@ /* Default to allowing writes. Broken programmers set this to 0. */ programmer_may_write = true; + if (prog->rget_io_perms) { +#if defined(__i386__) || defined(__x86_64__) + if (rget_io_perms()) + return -2; +#endif + } + struct programmer_cfg cfg; if (param) { diff --git a/include/programmer.h b/include/programmer.h index 9603443..6da1be9 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -43,6 +43,7 @@ struct programmer_entry { const char *name; const enum programmer_type type; + const bool rget_io_perms_req; union { const struct dev_entry *const dev; const char *const note; -- To view, visit https://review.coreboot.org/c/flashrom/+/68662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2 Gerrit-Change-Number: 68662 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flash.h: extend `struct tested` with .wp field
by Anastasia Klimchuk (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68179 ) Change subject: flash.h: extend `struct tested` with .wp field ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: Sergii, would you mind rebasing this chain? it looks ready. thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/68179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I791400889159bc6f305fb05f3e2dd9a90dbe18a4 Gerrit-Change-Number: 68179 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 06:15:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: raiden_debug_spi: Remove fixme with explanation
by Anastasia Klimchuk (Code Review) 21 Oct '22

21 Oct '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68364 ) Change subject: raiden_debug_spi: Remove fixme with explanation ...................................................................... raiden_debug_spi: Remove fixme with explanation The raiden_debug_spi programmer will query the connected USB devices and match against criteria other than the pid rather than iterate through the vid:pid table. The fixme has been updated to explain why the dev_entry table is empty. TICKET: https://ticket.coreboot.org/issues/394 BUG=b:253320285 TEST=build Change-Id: I43e364c02f42dd499d3c9ca3e0a03ead673da3e6 Signed-off-by: Liam Flaherty <liamflaherty(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68364 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M raiden_debug_spi.c 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index fb068c8..517b173 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -350,7 +350,11 @@ #include <string.h> #include <unistd.h> -/* FIXME: Add some programmer IDs here */ +/* + * Table is empty as raiden_debug_spi matches against the class and + * subclass of the connected USB devices, rather than looking for a + * device with a specific vid:pid. + */ static const struct dev_entry devs_raiden[] = { {0}, }; -- To view, visit https://review.coreboot.org/c/flashrom/+/68364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43e364c02f42dd499d3c9ca3e0a03ead673da3e6 Gerrit-Change-Number: 68364 Gerrit-PatchSet: 5 Gerrit-Owner: Liam Flaherty <liamflaherty(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: cli_classic.c: Make count_max_decode_exceedings() pure
by Edward O'Callaghan (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68479 ) Change subject: cli_classic.c: Make count_max_decode_exceedings() pure ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/68479/comment/31e1c540_71e94723 PS1, Line 10: it's > Possessive pronoun `its` doesn't have an apostrophe 😊 Fixed, thank you. -- To view, visit https://review.coreboot.org/c/flashrom/+/68479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia01f77993deab68e251850008e885828e55b9462 Gerrit-Change-Number: 68479 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 05:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic.c: Factor out rom bus limits exceeded validation
by Edward O'Callaghan (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68661 to look at the new patch set (#2). Change subject: cli_classic.c: Factor out rom bus limits exceeded validation ...................................................................... cli_classic.c: Factor out rom bus limits exceeded validation Cave out relevant logic relating to validating the rom decode limits fit within the common buses with certain flash-programmer pairingings into it's own function. Move the comment to the top of the new symbol while we are here and rewrite the grammar to be a bit more understandable. Change-Id: Iba1c3c8ab2edc094ede59156ae5e846900fc0777 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M cli_classic.c 1 file changed, 43 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/68661/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba1c3c8ab2edc094ede59156ae5e846900fc0777 Gerrit-Change-Number: 68661 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022