October 2022 - flashrom-gerrit

[M] Change in flashrom[1.0.x]: ichspi: Unify timeouts across all SPI operations to 30s
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68640 ) Change subject: ichspi: Unify timeouts across all SPI operations to 30s ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Icb632d28c2c8420b9e47a8a0abd0dbf84dc200eb Gerrit-Change-Number: 68640 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:02:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[1.2.x]: ichspi: Unify timeouts across all SPI operations to 30s
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68597 ) Change subject: ichspi: Unify timeouts across all SPI operations to 30s ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I588b02da78fe26327d44bee455afb8272b34ed16 Gerrit-Change-Number: 68597 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 13:46:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom: add support for MX77L25650F chip
by Felix Singer (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Artur Kowalski. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557 ) Change subject: flashrom: add support for MX77L25650F chip ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/68557/comment/67aebc88_5a365c07 PS1, Line 7: flashrom flashchips https://review.coreboot.org/c/flashrom/+/68557/comment/282ebe27_2daa6afa PS1, Line 9: read and write What about erasing? File flashchips.c: https://review.coreboot.org/c/flashrom/+/68557/comment/76878aea_ffc2b359 PS1, Line 10215: // TODO: add 64K block erase What about this todo? -- To view, visit https://review.coreboot.org/c/flashrom/+/68557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c Gerrit-Change-Number: 68557 Gerrit-PatchSet: 1 Gerrit-Owner: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 13:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom: add support for MX77L25650F chip
by Maciej Pijanowski (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Artur Kowalski. Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557 ) Change subject: flashrom: add support for MX77L25650F chip ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/68557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c Gerrit-Change-Number: 68557 Gerrit-PatchSet: 1 Gerrit-Owner: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 13:13:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: Don't install git hooks automatically
by Felix Singer (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68647 to look at the new patch set (#4). Change subject: Makefile: Don't install git hooks automatically ...................................................................... Makefile: Don't install git hooks automatically These specific git hooks are only needed when someone wants to push a patch to upstream and so it's not needed to run it in every make call. Beside that, we also don't know the environment in which this is executed and it might not be wanted. Thus, add a new make target `gitconfig` and move the install command to it. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd --- M Makefile 1 file changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/68647/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/68647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd Gerrit-Change-Number: 68647 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: Makefile: Don't install git hooks automatically
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68647 ) Change subject: Makefile: Don't install git hooks automatically ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/68647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd Gerrit-Change-Number: 68647 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Oct 2022 12:30:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: Don't install git hooks automatically
by Felix Singer (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68647 to look at the new patch set (#3). Change subject: Makefile: Don't install git hooks automatically ...................................................................... Makefile: Don't install git hooks automatically These specific git hooks are only needed when someone wants to push a patch to upstream and so it's not needed to run it in every make call. Beside that, we also don't know the environment in which this is executed and it might not be wanted. Thus, add a new make target `gitconfig` and move the install command to it. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd --- M Makefile 1 file changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/68647/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd Gerrit-Change-Number: 68647 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: Makefile: Don't install git hooks automatically
by Felix Singer (Code Review) 21 Oct '22

21 Oct '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68647 ) Change subject: Makefile: Don't install git hooks automatically ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/68647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd Gerrit-Change-Number: 68647 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Oct 2022 12:27:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flash.h: extend `struct tested` with .wp field
by Sergii Dmytruk (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Nico Huber. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68179 ) Change subject: flash.h: extend `struct tested` with .wp field ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > Sergii, would you mind rebasing this chain? it looks ready. […] Rebased. However, CB:68221 is probably better be abandoned. Without a reliable way of chip identification (e.g., by hashing SFDP) there can be no precise diagnostics on the status of WP for a chip as one chip record can cover unknown number of chips (including those that don't yet exist). -- To view, visit https://review.coreboot.org/c/flashrom/+/68179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I791400889159bc6f305fb05f3e2dd9a90dbe18a4 Gerrit-Change-Number: 68179 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 11:52:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: rayer_spi.c: Roll up programmer type search logic into func
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Felix Singer, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68238 ) Change subject: rayer_spi.c: Roll up programmer type search logic into func ...................................................................... Patch Set 4: (1 comment) File rayer_spi.c: https://review.coreboot.org/c/flashrom/+/68238/comment/12b0232c_6bb45e01 PS2, Line 276: const struct rayer_programmer rayer_spi_types[] = { > Resolved? Oh, thought it had been marked as resolved already. Sorry for the delay. -- To view, visit https://review.coreboot.org/c/flashrom/+/68238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id226ea61132ecc30fd8696e1d8ea50373e752cac Gerrit-Change-Number: 68238 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Oct 2022 10:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022