January 2022 - flashrom-gerrit

Change in flashrom[master]: gfxnvidia: remove unused rget_io_perms()
by Thomas Heijligen (Code Review) 06 Jan '22

06 Jan '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/60843 ) Change subject: gfxnvidia: remove unused rget_io_perms() ...................................................................... gfxnvidia: remove unused rget_io_perms() The gfxnvidia programmer does not use x86 IO Prots. Remove the dependency to it. Change-Id: I1f0341390ccb698bc435760f4ead7de54e429a6e Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M gfxnvidia.c 2 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/60843/1 diff --git a/Makefile b/Makefile index 595c9cf..7859362 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,6 @@ DEPENDS_ON_X86_PORT_IO := \ CONFIG_ATAHPT \ CONFIG_ATAPROMISE \ - CONFIG_GFXNVIDIA \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ CONFIG_NICINTEL \ diff --git a/gfxnvidia.c b/gfxnvidia.c index 30c94b9..535467e 100644 --- a/gfxnvidia.c +++ b/gfxnvidia.c @@ -19,7 +19,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -89,9 +88,6 @@ struct pci_dev *dev = NULL; uint32_t reg32; - if (rget_io_perms()) - return 1; - dev = pcidev_init(gfx_nvidia, PCI_BASE_ADDRESS_0); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1f0341390ccb698bc435760f4ead7de54e429a6e Gerrit-Change-Number: 60843 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: atavia: remove unused rget_io_perms()
by Thomas Heijligen (Code Review) 06 Jan '22

06 Jan '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/60841 ) Change subject: atavia: remove unused rget_io_perms() ...................................................................... atavia: remove unused rget_io_perms() The atavia programmer does not use x86 IO Prots. Remove the dependency to it. Change-Id: I1fa866b3b07adf5f7a51d58f53d6cad1f88d7210 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M atavia.c 2 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/41/60841/1 diff --git a/Makefile b/Makefile index 9a6d7b0..a914382 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,6 @@ DEPENDS_ON_X86_PORT_IO := \ CONFIG_ATAHPT \ CONFIG_ATAPROMISE \ - CONFIG_ATAVIA \ CONFIG_DRKAISER \ CONFIG_GFXNVIDIA \ CONFIG_INTERNAL \ diff --git a/atavia.c b/atavia.c index 8109768..e8bc945 100644 --- a/atavia.c +++ b/atavia.c @@ -20,7 +20,6 @@ #include <string.h> #include "flash.h" #include "programmer.h" -#include "hwaccess_x86_io.h" #include "platform/pci.h" #define PCI_VENDOR_ID_VIA 0x1106 @@ -164,9 +163,6 @@ } free(arg); - if (rget_io_perms()) - return 1; - dev = pcidev_init(ata_via, PCI_ROM_ADDRESS); /* Actually no BAR setup needed at all. */ if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1fa866b3b07adf5f7a51d58f53d6cad1f88d7210 Gerrit-Change-Number: 60841 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Makefile: rename FEATURE_CFLAGS to FEATURE_FLAGS
by Thomas Heijligen (Code Review) 06 Jan '22

06 Jan '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59231 ) Change subject: Makefile: rename FEATURE_CFLAGS to FEATURE_FLAGS ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/59231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I819f5d76e6f37a0e0ed6481a051ed85126622503 Gerrit-Change-Number: 59231 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 06 Jan 2022 10:59:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: merge compiler, hwlibs, features targets into config target
by Thomas Heijligen (Code Review) 06 Jan '22

06 Jan '22

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60107 ) Change subject: Makefile: merge compiler, hwlibs, features targets into config target ...................................................................... Patch Set 8: (3 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/60107/comment/2db4feda_0d05a536 PS2, Line 918: %.o: %.c config : $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $< : : : $(PROGRAM)$(EXEC_SUFFIX): $(OBJS) : $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS) : : libflashrom.a: $(LIBFLASHROM_OBJS) : $(AR) rcs $@ $^ : $(RANLIB) $@ : : # TAROPTIONS reduces information leakage from the packager's system. : # If other tar programs support command line arguments for setting uid/gid of : # stored files, they can be handled here as well. : TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root") : : : # Make sure to add all names of generated binaries here. : # This includes all frontends and libflashrom. : # We don't use EXEC_SUFFIX here because we want to clean everything. : clean: : rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE) : @+$(MAKE) -C util/ich_descriptors_tool/ clean : : distclean: clean : rm -f .libdeps : : strip: $(PROGRAM)$(EXEC_SUFFIX) : $(STRIP) $(STRIP_ARGS) $(PROGRAM)$(EXEC_SUFFIX) > Ack Done https://review.coreboot.org/c/flashrom/+/60107/comment/dae4b028_38769a02 PS2, Line 948: # to define test programs we use verbatim variables, which get exported : # to environment variables and are referenced with $$<varname> later > I think this is obsolete by now. Done https://review.coreboot.org/c/flashrom/+/60107/comment/30e3713f_1be52373 PS2, Line 953: > Ack Done -- To view, visit https://review.coreboot.org/c/flashrom/+/60107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic76f923bca2beb6f95b8ea0cced4569b07e9b9ba Gerrit-Change-Number: 60107 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 06 Jan 2022 10:15:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: reorder make targets
by Thomas Heijligen (Code Review) 06 Jan '22

06 Jan '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/60836 ) Change subject: Makefile: reorder make targets ...................................................................... Makefile: reorder make targets Change-Id: Ic45c2fc98c679ac7be4ee2860d72b517b8b67a17 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 36 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/60836/1 diff --git a/Makefile b/Makefile index 63737a6..77e8668 100644 --- a/Makefile +++ b/Makefile @@ -912,34 +912,6 @@ @+$(MAKE) -C util/ich_descriptors_tool/ HOST_OS=$(HOST_OS) TARGET_OS=$(TARGET_OS) endif -$(PROGRAM)$(EXEC_SUFFIX): $(OBJS) - $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS) - -libflashrom.a: $(LIBFLASHROM_OBJS) - $(AR) rcs $@ $^ - $(RANLIB) $@ - -# TAROPTIONS reduces information leakage from the packager's system. -# If other tar programs support command line arguments for setting uid/gid of -# stored files, they can be handled here as well. -TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root") - -%.o: %.c features - $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $< - -# Make sure to add all names of generated binaries here. -# This includes all frontends and libflashrom. -# We don't use EXEC_SUFFIX here because we want to clean everything. -clean: - rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE) - @+$(MAKE) -C util/ich_descriptors_tool/ clean - -distclean: clean - rm -f .libdeps - -strip: $(PROGRAM)$(EXEC_SUFFIX) - $(STRIP) $(STRIP_ARGS) $(PROGRAM)$(EXEC_SUFFIX) - # to define test programs we use verbatim variables, which get exported # to environment variables and are referenced with $$<varname> later @@ -987,6 +959,14 @@ echo " LDFLAGS: $(CONFIG_LIBFTDI1_LDFLAGS)"; \ fi +features: hwlibs + @echo "Checking for header \"mtd/mtd-user.h\": $(HAS_LINUX_MTD)" + @echo "Checking for header \"linux/spi/spidev.h\": $(HAS_LINUX_SPI)" + @echo "Checking for header \"linux/i2c-dev.h\": $(HAS_LINUX_I2C)" + @echo "Checking for header \"linux/i2c.h\": $(HAS_LINUX_I2C)" + @echo "Checking for header \"sys/utsname.h\": $(HAS_UTSNAME)" + @echo "Checking for function \"clock_gettime\": $(HAS_CLOCK_GETTIME)" + # If a user does not explicitly request a non-working feature, we should # silently disable it. However, if a non-working (does not compile) feature # is explicitly requested, we should bail out with a descriptive error message. @@ -1001,13 +981,15 @@ @false endif -features: hwlibs - @echo "Checking for header \"mtd/mtd-user.h\": $(HAS_LINUX_MTD)" - @echo "Checking for header \"linux/spi/spidev.h\": $(HAS_LINUX_SPI)" - @echo "Checking for header \"linux/i2c-dev.h\": $(HAS_LINUX_I2C)" - @echo "Checking for header \"linux/i2c.h\": $(HAS_LINUX_I2C)" - @echo "Checking for header \"sys/utsname.h\": $(HAS_UTSNAME)" - @echo "Checking for function \"clock_gettime\": $(HAS_CLOCK_GETTIME)" +%.o: %.c features + $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $< + +$(PROGRAM)$(EXEC_SUFFIX): $(OBJS) + $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS) + +libflashrom.a: $(LIBFLASHROM_OBJS) + $(AR) rcs $@ $^ + $(RANLIB) $@ $(PROGRAM).8.html: $(PROGRAM).8 @groff -mandoc -Thtml $< >$@ @@ -1016,6 +998,19 @@ @# Add the man page change date and version to the man page @sed -e 's#.TH FLASHROM 8 .*#.TH FLASHROM 8 "$(MAN_DATE)" "$(VERSION)" "$(MAN_DATE)"#' <$< >$@ +strip: $(PROGRAM)$(EXEC_SUFFIX) + $(STRIP) $(STRIP_ARGS) $(PROGRAM)$(EXEC_SUFFIX) + +# Make sure to add all names of generated binaries here. +# This includes all frontends and libflashrom. +# We don't use EXEC_SUFFIX here because we want to clean everything. +clean: + rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE) + @+$(MAKE) -C util/ich_descriptors_tool/ clean + +distclean: clean + rm -f .libdeps + install: $(PROGRAM)$(EXEC_SUFFIX) $(PROGRAM).8 mkdir -p $(DESTDIR)$(PREFIX)/sbin mkdir -p $(DESTDIR)$(MANDIR)/man8 @@ -1050,6 +1045,12 @@ export: _export @echo "Exported $(EXPORTDIR)/flashrom-$(RELEASENAME)/" + +# TAROPTIONS reduces information leakage from the packager's system. +# If other tar programs support command line arguments for setting uid/gid of +# stored files, they can be handled here as well. +TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root") + tarball: _export @tar -cj --format=ustar -f "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2" -C $(EXPORTDIR)/ \ $(TAROPTIONS) "flashrom-$(RELEASENAME)/" -- To view, visit https://review.coreboot.org/c/flashrom/+/60836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic45c2fc98c679ac7be4ee2860d72b517b8b67a17 Gerrit-Change-Number: 60836 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Makefile: merge compiler, hwlibs, features targets into config target
by Thomas Heijligen (Code Review) 06 Jan '22

06 Jan '22

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/60107 to look at the new patch set (#8). Change subject: Makefile: merge compiler, hwlibs, features targets into config target ...................................................................... Makefile: merge compiler, hwlibs, features targets into config target Change-Id: Ic76f923bca2beb6f95b8ea0cced4569b07e9b9ba Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 12 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/60107/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/60107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic76f923bca2beb6f95b8ea0cced4569b07e9b9ba Gerrit-Change-Number: 60107 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: chipset_enable.c: Add TGP-H IDs
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/57533 ) Change subject: chipset_enable.c: Add TGP-H IDs ...................................................................... chipset_enable.c: Add TGP-H IDs Add IDs for: H510, B560, H570, Q570, Z590, W580, HM570, QM570, WM590 Tested on system76/oryp8 (HM570). flashrom is able to read the image using the internal programmer. Change-Id: I96f63253d42578151f99dcbb42347afecc03f49d Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/57533 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Benjamin Doron <benjamin.doron00(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M chipset_enable.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Benjamin Doron: Looks good to me, but someone else must approve diff --git a/chipset_enable.c b/chipset_enable.c index e216722..02a93a8 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2123,6 +2123,15 @@ {0x8086, 0x068d, B_S, NT, "Intel", "HM470", enable_flash_pch400}, {0x8086, 0x068e, B_S, NT, "Intel", "WM490", enable_flash_pch400}, {0x8086, 0x0697, B_S, NT, "Intel", "W480", enable_flash_pch400}, + {0x8086, 0x4384, B_S, NT, "Intel", "Q570", enable_flash_pch500}, + {0x8086, 0x4385, B_S, NT, "Intel", "Z590", enable_flash_pch500}, + {0x8086, 0x4386, B_S, NT, "Intel", "H570", enable_flash_pch500}, + {0x8086, 0x4387, B_S, NT, "Intel", "B560", enable_flash_pch500}, + {0x8086, 0x4388, B_S, NT, "Intel", "H510", enable_flash_pch500}, + {0x8086, 0x438f, B_S, NT, "Intel", "W580", enable_flash_pch500}, + {0x8086, 0x4389, B_S, NT, "Intel", "WM590", enable_flash_pch500}, + {0x8086, 0x438a, B_S, NT, "Intel", "QM580", enable_flash_pch500}, + {0x8086, 0x438b, B_S, DEP, "Intel", "HM570", enable_flash_pch500}, #endif {0}, }; -- To view, visit https://review.coreboot.org/c/flashrom/+/57533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96f63253d42578151f99dcbb42347afecc03f49d Gerrit-Change-Number: 57533 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: chipset_enable.c: Add TGP-H IDs
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Tim Crawford, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57533 ) Change subject: chipset_enable.c: Add TGP-H IDs ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS7: Doing a rebase before submitting just in case. -- To view, visit https://review.coreboot.org/c/flashrom/+/57533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96f63253d42578151f99dcbb42347afecc03f49d Gerrit-Change-Number: 57533 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:26:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_msr: fix build for FreeBSD
by Nico Huber (Code Review) 05 Jan '22

05 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60342 ) Change subject: hwaccess_x86_msr: fix build for FreeBSD ...................................................................... hwaccess_x86_msr: fix build for FreeBSD Add missing includes for FreeBSD Change-Id: I2045345878392436b0ea4d6bd4f2896edc645673 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60342 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Idwer Vollering <vidwer(a)gmail.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M hwaccess_x86_msr.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Idwer Vollering: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved diff --git a/hwaccess_x86_msr.c b/hwaccess_x86_msr.c index fa7df72..79cf2f8 100644 --- a/hwaccess_x86_msr.c +++ b/hwaccess_x86_msr.c @@ -204,6 +204,13 @@ } #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) +#include <stdint.h> +#include <stdlib.h> +#include <errno.h> +#include <fcntl.h> +#include <string.h> +#include <unistd.h> + #include <sys/ioctl.h> typedef struct { 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/60342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2045345878392436b0ea4d6bd4f2896edc645673 Gerrit-Change-Number: 60342 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: chipset_enable.c: Add TGP-H IDs
by Benjamin Doron (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Tim Crawford, Nico Huber. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57533 ) Change subject: chipset_enable.c: Add TGP-H IDs ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/57533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96f63253d42578151f99dcbb42347afecc03f49d Gerrit-Change-Number: 57533 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 22:55:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2022