Change in flashrom[master]: Makefile: merge compiler, hwlibs, features targets into config target
Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60107 )
Change subject: Makefile: merge compiler, hwlibs, features targets into config target ......................................................................
Patch Set 8:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/60107/comment/2db4feda_0d05a536 PS2, Line 918: %.o: %.c config : $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $< : : : $(PROGRAM)$(EXEC_SUFFIX): $(OBJS) : $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS) : : libflashrom.a: $(LIBFLASHROM_OBJS) : $(AR) rcs $@ $^ : $(RANLIB) $@ : : # TAROPTIONS reduces information leakage from the packager's system. : # If other tar programs support command line arguments for setting uid/gid of : # stored files, they can be handled here as well. : TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root") : : : # Make sure to add all names of generated binaries here. : # This includes all frontends and libflashrom. : # We don't use EXEC_SUFFIX here because we want to clean everything. : clean: : rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE) : @+$(MAKE) -C util/ich_descriptors_tool/ clean : : distclean: clean : rm -f .libdeps : : strip: $(PROGRAM)$(EXEC_SUFFIX) : $(STRIP) $(STRIP_ARGS) $(PROGRAM)$(EXEC_SUFFIX)
Ack
Done
https://review.coreboot.org/c/flashrom/+/60107/comment/dae4b028_38769a02 PS2, Line 948: # to define test programs we use verbatim variables, which get exported : # to environment variables and are referenced with $$<varname> later
I think this is obsolete by now.
Done
https://review.coreboot.org/c/flashrom/+/60107/comment/30e3713f_1be52373 PS2, Line 953:
Ack
Done
-
Thomas Heijligen (Code Review)