January 2022 - flashrom-gerrit

Change in flashrom[master]: SFDP: drop static table length check to make newer SFDP revisions work
by Anastasia Klimchuk (Code Review) 09 Jan '22

09 Jan '22

Attention is currently required from: Edward O'Callaghan, Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60055 ) Change subject: SFDP: drop static table length check to make newer SFDP revisions work ...................................................................... Patch Set 2: (2 comments) File sfdp.c: https://review.coreboot.org/c/flashrom/+/60055/comment/f8ac5ed6_451c9bdb PS2, Line 133: msg_cdbg("Parsing JEDEC flash parameter table... "); : msg_cdbg2("\n"); Looks like these two message can be merged into one now. It is not very clear why first one is cdbg and second (which is just a new line) is cdbg2? Since this is now only informational, not an error message, that's probably cdbg2? https://review.coreboot.org/c/flashrom/+/60055/comment/b84834da_af35021d PS2, Line 372: } else if (sfdp_fill_flash(flash->chip, tbuf, len) == 0) Oh so length of table was checked twice? -- To view, visit https://review.coreboot.org/c/flashrom/+/60055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id84cde4ebc805d68e2984e8041fbc48d7ceebe34 Gerrit-Change-Number: 60055 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 09 Jan 2022 23:22:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it8212: remove unused rget_io_perms()
by David Hendricks (Code Review) 08 Jan '22

08 Jan '22

Attention is currently required from: Nico Huber, Thomas Heijligen. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60869 ) Change subject: it8212: remove unused rget_io_perms() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/60869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iab859fb6be6cab094c9c6ce4b3e8eac0e5ff84ab Gerrit-Change-Number: 60869 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 08 Jan 2022 22:09:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO
by David Hendricks (Code Review) 08 Jan '22

08 Jan '22

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/60887 ) Change subject: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO ...................................................................... Abandoned Abandoned in favor of CB:60869 -- To view, visit https://review.coreboot.org/c/flashrom/+/60887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04104ee5dcbff49e809a48bdaf07e2ad6bc7f896 Gerrit-Change-Number: 60887 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO
by Angel Pons (Code Review) 08 Jan '22

08 Jan '22

Attention is currently required from: Felix Singer, Thomas Heijligen, David Hendricks. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60887 ) Change subject: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: > https://review.coreboot.org/c/flashrom/+/60869 removes the need for X86_PORT_IO. […] I also prefer CB:60869. David, does CB:60869 fix the build error you're experiencing? -- To view, visit https://review.coreboot.org/c/flashrom/+/60887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04104ee5dcbff49e809a48bdaf07e2ad6bc7f896 Gerrit-Change-Number: 60887 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Sat, 08 Jan 2022 16:59:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: replace RAW_ACCESS with RAW_MEM_ACCESS X86_MSR X86_PORT_IO
by Paul Menzel (Code Review) 07 Jan '22

07 Jan '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60325 ) Change subject: Makefile: replace RAW_ACCESS with RAW_MEM_ACCESS X86_MSR X86_PORT_IO ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/60325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5bdafaa3c5023ad6c4a695493eeddf11bc148085 Gerrit-Change-Number: 60325 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Jan 2022 13:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Make pkg-config mandatory to find libpci
by Paul Menzel (Code Review) 07 Jan '22

07 Jan '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59050 ) Change subject: Makefile: Make pkg-config mandatory to find libpci ...................................................................... Patch Set 17: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/59050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I21b4a261b34b7e688635fc6e20b7beebfa64c7ed Gerrit-Change-Number: 59050 Gerrit-PatchSet: 17 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 07 Jan 2022 13:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: layout: Hoist get_region_range() into libflashrom API
by Edward O'Callaghan (Code Review) 07 Jan '22

07 Jan '22

Attention is currently required from: Edward O'Callaghan, Angel Pons. Hello Sam McNally, build bot (Jenkins), Angel Pons, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/60881 to look at the new patch set (#3). Change subject: layout: Hoist get_region_range() into libflashrom API ...................................................................... layout: Hoist get_region_range() into libflashrom API While using the libflashrom API to read specific regions there is no currently no general way to find the offset into the read buffer of the expected region. flashrom_layout_include_region() probably should have returned the region offset and size if it was included. However to avoid a change in API signature we can instead hoist up get_region_range() into the API to be called after. BUG=b:207808292 TEST=`make` && tested in porting cbfstool use-case. Change-Id: I8cf95b5eaec943a51d0ea668f26a56bf6d6b4446 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M cli_classic.c M layout.c M layout.h M libflashrom.h M libflashrom.map M tests/layout.c 6 files changed, 28 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/60881/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/60881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8cf95b5eaec943a51d0ea668f26a56bf6d6b4446 Gerrit-Change-Number: 60881 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO
by Thomas Heijligen (Code Review) 07 Jan '22

07 Jan '22

Attention is currently required from: Felix Singer, David Hendricks. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60887 ) Change subject: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: https://review.coreboot.org/c/flashrom/+/60869 removes the need for X86_PORT_IO. The it8212 programmer does not use X86_PORT_IO. The code was a just a leftover. Can you try the patch (series) I mention? -- To view, visit https://review.coreboot.org/c/flashrom/+/60887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04104ee5dcbff49e809a48bdaf07e2ad6bc7f896 Gerrit-Change-Number: 60887 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Jan 2022 09:36:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO
by David Hendricks (Code Review) 07 Jan '22

07 Jan '22

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/60887 ) Change subject: Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO ...................................................................... Makefile: Add CONFIG_IT8212 to DEPENDS_ON_X86_PORT_IO This fixes the build on non-x86 systems. Change-Id: I04104ee5dcbff49e809a48bdaf07e2ad6bc7f896 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/60887/1 diff --git a/Makefile b/Makefile index 9a6d7b0..42b4245 100644 --- a/Makefile +++ b/Makefile @@ -130,6 +130,7 @@ CONFIG_DRKAISER \ CONFIG_GFXNVIDIA \ CONFIG_INTERNAL \ + CONFIG_IT8212 \ CONFIG_NIC3COM \ CONFIG_NICINTEL \ CONFIG_NICINTEL_EEPROM \ -- To view, visit https://review.coreboot.org/c/flashrom/+/60887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04104ee5dcbff49e809a48bdaf07e2ad6bc7f896 Gerrit-Change-Number: 60887 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: layout: Hoist get_region_range() into libflashrom API
by Nikolai Artemiev (Code Review) 07 Jan '22

07 Jan '22

Attention is currently required from: Edward O'Callaghan, Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60881 ) Change subject: layout: Hoist get_region_range() into libflashrom API ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/60881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8cf95b5eaec943a51d0ea668f26a56bf6d6b4446 Gerrit-Change-Number: 60881 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Jan 2022 04:01:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2022