January 2022 - flashrom-gerrit

Change in flashrom[master]: writeprotect, cli_classic: delete old writeprotect code
by Nikolai Artemiev (Code Review) 11 Jan '22

11 Jan '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58474 to look at the new patch set (#13). Change subject: writeprotect, cli_classic: delete old writeprotect code ...................................................................... writeprotect, cli_classic: delete old writeprotect code Delete writeprotect code that was previously extracted from the cros tree. This is the first of a series of commits adding writeprotect support. Following commits incrementally implement writeprotect operations, culminating in writeprotect support for three example chips: GD25LQ128, GD25Q32, and GD25Q256. BUG=b:195381327,b:153800563 TEST=flashrom --wp-{enable,disable,range,list,status} at end of patch series BRANCH=none Change-Id: I67e9b31f86465e5a8f7d3def637198671ee818a8 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M cli_classic.c M flash.h M s25f.c M writeprotect.c M writeprotect.h 5 files changed, 8 insertions(+), 570 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/58474/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/58474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I67e9b31f86465e5a8f7d3def637198671ee818a8 Gerrit-Change-Number: 58474 Gerrit-PatchSet: 13 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: spi25_statusreg.c: add SR3 read/write support
by Sergii Dmytruk (Code Review) 10 Jan '22

10 Jan '22

Attention is currently required from: Nico Huber, Anastasia Klimchuk, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60230 ) Change subject: spi25_statusreg.c: add SR3 read/write support ...................................................................... Patch Set 2: (1 comment) File flash.h: https://review.coreboot.org/c/flashrom/+/60230/comment/66266d62_19978c85 PS2, Line 148: FEATURE_SR3 > Maybe it's silly question, but why the name is different from the others above? […] SR2 can be written in two different ways, but read in one. It seems that `FEATURE_RDSR3 | FEATURE_WRSR3` would always come together, effectively being a single flag. -- To view, visit https://review.coreboot.org/c/flashrom/+/60230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id987c544c02da2b956e6ad2c525265cac8f15be1 Gerrit-Change-Number: 60230 Gerrit-PatchSet: 2 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 10 Jan 2022 13:51:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it8212: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60869 ) Change subject: it8212: remove unused rget_io_perms() ...................................................................... it8212: remove unused rget_io_perms() The it8212 programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: Iab859fb6be6cab094c9c6ce4b3e8eac0e5ff84ab Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60869 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M it8212.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/it8212.c b/it8212.c index 6488b15..ca82d9c 100644 --- a/it8212.c +++ b/it8212.c @@ -18,7 +18,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -58,9 +57,6 @@ static int it8212_init(void) { - if (rget_io_perms()) - return 1; - struct pci_dev *dev = pcidev_init(devs_it8212, PCI_ROM_ADDRESS); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iab859fb6be6cab094c9c6ce4b3e8eac0e5ff84ab Gerrit-Change-Number: 60869 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: satasii: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60848 ) Change subject: satasii: remove unused rget_io_perms() ...................................................................... satasii: remove unused rget_io_perms() The satasii programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: I54d65561ff024d3c181d11c6518a4612c2ab0399 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60848 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M satasii.c 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index b351990..b8287a9 100644 --- a/Makefile +++ b/Makefile @@ -132,7 +132,6 @@ CONFIG_NICREALTEK \ CONFIG_RAYER_SPI \ CONFIG_SATAMV \ - CONFIG_SATASII \ DEPENDS_ON_LIBPCI := \ CONFIG_ATAHPT \ diff --git a/satasii.c b/satasii.c index f9cb5da..a27fc29 100644 --- a/satasii.c +++ b/satasii.c @@ -18,7 +18,6 @@ #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -102,9 +101,6 @@ uint32_t addr; uint16_t reg_offset; - if (rget_io_perms()) - return 1; - dev = pcidev_init(satas_sii, PCI_BASE_ADDRESS_0); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60848 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I54d65561ff024d3c181d11c6518a4612c2ab0399 Gerrit-Change-Number: 60848 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: ogp_spi: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60847 ) Change subject: ogp_spi: remove unused rget_io_perms() ...................................................................... ogp_spi: remove unused rget_io_perms() The ogp_spi programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: I1f3f34e33f77159fa0cdea150e1f408ce9d943f0 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60847 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M ogp_spi.c 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index 34d517e..b351990 100644 --- a/Makefile +++ b/Makefile @@ -130,7 +130,6 @@ CONFIG_NIC3COM \ CONFIG_NICNATSEMI \ CONFIG_NICREALTEK \ - CONFIG_OGP_SPI \ CONFIG_RAYER_SPI \ CONFIG_SATAMV \ CONFIG_SATASII \ diff --git a/ogp_spi.c b/ogp_spi.c index d4218d1..830cfe7 100644 --- a/ogp_spi.c +++ b/ogp_spi.c @@ -19,7 +19,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -142,9 +141,6 @@ } free(type); - if (rget_io_perms()) - return 1; - dev = pcidev_init(ogp_spi, PCI_BASE_ADDRESS_0); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1f3f34e33f77159fa0cdea150e1f408ce9d943f0 Gerrit-Change-Number: 60847 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: nicintel_spi: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60846 ) Change subject: nicintel_spi: remove unused rget_io_perms() ...................................................................... nicintel_spi: remove unused rget_io_perms() The nicintel_spi programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: I3e7451eceb1f01de21da934c9559dbf2f06e7e54 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60846 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M nicintel_spi.c 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index 93fc657..34d517e 100644 --- a/Makefile +++ b/Makefile @@ -128,7 +128,6 @@ CONFIG_ATAPROMISE \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ - CONFIG_NICINTEL_SPI \ CONFIG_NICNATSEMI \ CONFIG_NICREALTEK \ CONFIG_OGP_SPI \ diff --git a/nicintel_spi.c b/nicintel_spi.c index 852c042..004af66 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -35,7 +35,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -293,9 +292,6 @@ { struct pci_dev *dev = NULL; - if (rget_io_perms()) - return 1; - dev = pcidev_init(nics_intel_spi, PCI_BASE_ADDRESS_0); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e7451eceb1f01de21da934c9559dbf2f06e7e54 Gerrit-Change-Number: 60846 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: nicintel_eeprom: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60845 ) Change subject: nicintel_eeprom: remove unused rget_io_perms() ...................................................................... nicintel_eeprom: remove unused rget_io_perms() The nicintel_eeprom programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: I5fd42572fd29f5d7fd749c2836eac3e68c947946 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60845 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M nicintel_eeprom.c 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index da38d6b..93fc657 100644 --- a/Makefile +++ b/Makefile @@ -128,7 +128,6 @@ CONFIG_ATAPROMISE \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ - CONFIG_NICINTEL_EEPROM \ CONFIG_NICINTEL_SPI \ CONFIG_NICNATSEMI \ CONFIG_NICREALTEK \ diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c index 7b92958..ea0e768 100644 --- a/nicintel_eeprom.c +++ b/nicintel_eeprom.c @@ -35,7 +35,6 @@ #include "spi.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -462,9 +461,6 @@ static int nicintel_ee_init(void) { - if (rget_io_perms()) - return 1; - struct pci_dev *dev = pcidev_init(nics_intel_ee, PCI_BASE_ADDRESS_0); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5fd42572fd29f5d7fd749c2836eac3e68c947946 Gerrit-Change-Number: 60845 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: nicintel: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60844 ) Change subject: nicintel: remove unused rget_io_perms() ...................................................................... nicintel: remove unused rget_io_perms() The nicintel programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: Ibe609ff8f8fdbdf2a7de8e1922325ca4ad56a9e7 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60844 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M nicintel.c 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index 7859362..da38d6b 100644 --- a/Makefile +++ b/Makefile @@ -128,7 +128,6 @@ CONFIG_ATAPROMISE \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ - CONFIG_NICINTEL \ CONFIG_NICINTEL_EEPROM \ CONFIG_NICINTEL_SPI \ CONFIG_NICNATSEMI \ diff --git a/nicintel.c b/nicintel.c index 21dfad2..c8a8789 100644 --- a/nicintel.c +++ b/nicintel.c @@ -19,7 +19,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -71,12 +70,6 @@ struct pci_dev *dev = NULL; uintptr_t addr; - /* Needed only for PCI accesses on some platforms. - * FIXME: Refactor that into get_mem_perms/rget_io_perms/get_pci_perms? - */ - if (rget_io_perms()) - return 1; - /* FIXME: BAR2 is not available if the device uses the CardBus function. */ dev = pcidev_init(nics_intel, PCI_BASE_ADDRESS_2); if (!dev) -- To view, visit https://review.coreboot.org/c/flashrom/+/60844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibe609ff8f8fdbdf2a7de8e1922325ca4ad56a9e7 Gerrit-Change-Number: 60844 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: gfxnvidia: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60843 ) Change subject: gfxnvidia: remove unused rget_io_perms() ...................................................................... gfxnvidia: remove unused rget_io_perms() The gfxnvidia programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: I1f0341390ccb698bc435760f4ead7de54e429a6e Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60843 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M gfxnvidia.c 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index 595c9cf..7859362 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,6 @@ DEPENDS_ON_X86_PORT_IO := \ CONFIG_ATAHPT \ CONFIG_ATAPROMISE \ - CONFIG_GFXNVIDIA \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ CONFIG_NICINTEL \ diff --git a/gfxnvidia.c b/gfxnvidia.c index 30c94b9..535467e 100644 --- a/gfxnvidia.c +++ b/gfxnvidia.c @@ -19,7 +19,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -89,9 +88,6 @@ struct pci_dev *dev = NULL; uint32_t reg32; - if (rget_io_perms()) - return 1; - dev = pcidev_init(gfx_nvidia, PCI_BASE_ADDRESS_0); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1f0341390ccb698bc435760f4ead7de54e429a6e Gerrit-Change-Number: 60843 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: drkaiser: remove unused rget_io_perms()
by Nico Huber (Code Review) 10 Jan '22

10 Jan '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60842 ) Change subject: drkaiser: remove unused rget_io_perms() ...................................................................... drkaiser: remove unused rget_io_perms() The drkaiser programmer does not use x86 IO Ports. Remove the dependency to it. Change-Id: I86bad947298a1166ff1e768f7d0b75a90e574696 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/60842 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M drkaiser.c 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index a914382..595c9cf 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,6 @@ DEPENDS_ON_X86_PORT_IO := \ CONFIG_ATAHPT \ CONFIG_ATAPROMISE \ - CONFIG_DRKAISER \ CONFIG_GFXNVIDIA \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ diff --git a/drkaiser.c b/drkaiser.c index 0930c1f..3738930 100644 --- a/drkaiser.c +++ b/drkaiser.c @@ -18,7 +18,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h" @@ -68,9 +67,6 @@ struct pci_dev *dev = NULL; uint32_t addr; - if (rget_io_perms()) - return 1; - dev = pcidev_init(drkaiser_pcidev, PCI_BASE_ADDRESS_2); if (!dev) return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/60842 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I86bad947298a1166ff1e768f7d0b75a90e574696 Gerrit-Change-Number: 60842 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2022