Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/37777 )
Change subject: chipset_enable.c: Enable Tiger Lake U support
......................................................................
chipset_enable.c: Enable Tiger Lake U support
Did a basic local test with --flash-name and -r bios and
ran strings to see if the bios contained reasonable data.
BUG=b:146089922
Change-Id: I2c13e0173c9b5e17d2ae197f4a4ab9aa2825c1b3
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M chipset_enable.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/37777/1
diff --git a/chipset_enable.c b/chipset_enable.c
index b55852c..d5a2f03 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -1996,6 +1996,7 @@
{0x8086, 0x9d56, B_S, NT, "Intel", "Kaby Lake Y Premium", enable_flash_pch100},
{0x8086, 0x9d58, B_S, NT, "Intel", "Kaby Lake U Premium", enable_flash_pch100},
{0x8086, 0x9d84, B_S, DEP, "Intel", "Cannon Lake U Premium", enable_flash_pch300},
+ {0x8086, 0xa082, B_FS, NT, "Intel", "Tiger Lake U", enable_flash_pch300},
{0x8086, 0xa141, B_S, NT, "Intel", "Sunrise Point Desktop Sample", enable_flash_pch100},
{0x8086, 0xa142, B_S, NT, "Intel", "Sunrise Point Unknown Sample", enable_flash_pch100},
{0x8086, 0xa143, B_S, NT, "Intel", "H110", enable_flash_pch100},
--
To view, visit https://review.coreboot.org/c/flashrom/+/37777
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2c13e0173c9b5e17d2ae197f4a4ab9aa2825c1b3
Gerrit-Change-Number: 37777
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Miklós Márton has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34641 )
Change subject: usbdev: fix accepting shorter serial numbers than the real one.
......................................................................
usbdev: fix accepting shorter serial numbers than the real one.
Change-Id: Ife8c4e0a957c4345e27ec9ae9e1480ca80fe505c
---
M usbdev.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/41/34641/1
diff --git a/usbdev.c b/usbdev.c
index 764ac04..7e41235 100644
--- a/usbdev.c
+++ b/usbdev.c
@@ -104,7 +104,8 @@
msg_pdbg("Serial number is %s\n", myserial);
/* Filter out any serial number that does not commence with serialno */
- return 0 != strncmp(serialno, (char *)myserial, strlen(serialno));
+ return strlen((char *)myserial) == strlen(serialno)
+ && 0 != strncmp(serialno, (char *)myserial, strlen(serialno));
}
struct libusb_device_handle *usb_dev_get_by_vid_pid_serial(
--
To view, visit https://review.coreboot.org/c/flashrom/+/34641
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ife8c4e0a957c4345e27ec9ae9e1480ca80fe505c
Gerrit-Change-Number: 34641
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-MessageType: newchange
Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48361 )
Change subject: Fix segfault when iomem=strict
......................................................................
Fix segfault when iomem=strict
As I can see, physmap_common() only returns ERROR_PTR or a real pointer
but never NULL.
Tested on Linux 5.9.12.
Change-Id: I5b11957fc10fd5c7a4fbb7f54fb94d791590f373
Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io>
---
M dmi.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/48361/1
diff --git a/dmi.c b/dmi.c
index c44221c..7488d61 100644
--- a/dmi.c
+++ b/dmi.c
@@ -164,7 +164,7 @@
unsigned int i = 0, j = 0;
uint8_t *dmi_table_mem = physmap_ro("DMI Table", base, len);
- if (dmi_table_mem == NULL) {
+ if (dmi_table_mem == ERROR_PTR) {
msg_perr("Unable to access DMI Table\n");
return;
}
--
To view, visit https://review.coreboot.org/c/flashrom/+/48361
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5b11957fc10fd5c7a4fbb7f54fb94d791590f373
Gerrit-Change-Number: 48361
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61523 )
Change subject: Makefile: check if librt is an external library
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61523/comment/05b77a1d_b3669760
PS1, Line 9: OpenBSD
> e.g. […]
Done
https://review.coreboot.org/c/flashrom/+/61523/comment/82335864_474b74d2
PS1, Line 10: to link
> linking
Done
https://review.coreboot.org/c/flashrom/+/61523/comment/697989d9_9ec0cafb
PS1, Line 10: therefor
> therefor_e_
Done
https://review.coreboot.org/c/flashrom/+/61523/comment/ff3f25a4_a080ebc0
PS1, Line 10: Detect
> Thus, detect [... […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/61523
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2c1668a350aa0806fccfb4e9cd8b04861f085ee9
Gerrit-Change-Number: 61523
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 23:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/61525 )
Change subject: platform/pci.h: adapt NetBSD include path to pkg-config
......................................................................
platform/pci.h: adapt NetBSD include path to pkg-config
The pkg-config include path resolves the pciutils directory. So the
include is only the pci.h file.
Change-Id: I69dc8184d1d012fb695770cbf6f7c64e5a024453
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com>
---
M platform/pci.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/61525/1
diff --git a/platform/pci.h b/platform/pci.h
index f63529b..93bc163 100644
--- a/platform/pci.h
+++ b/platform/pci.h
@@ -15,7 +15,7 @@
#define index shadow_workaround_index
#if defined (__NetBSD__)
-#include <pciutils/pci.h>
+#include <pci.h>
#else
#include <pci/pci.h>
#endif
--
To view, visit https://review.coreboot.org/c/flashrom/+/61525
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I69dc8184d1d012fb695770cbf6f7c64e5a024453
Gerrit-Change-Number: 61525
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Nico Huber, Angel Pons.
Hello Felix Singer, Nico Huber, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/61524
to look at the new patch set (#2).
Change subject: Makefile: use pkg-config --libs --static for LDFLAGS
......................................................................
Makefile: use pkg-config --libs --static for LDFLAGS
The --static flag of pkg-config returns also the LDFLAGS which are
required to link the library static. Use this flag to successfully
link against static libraries when the shared variant is not available.
This is the case in OpenBSD with libpci.
Change-Id: I6029a096c1ceca625789d18c88119d912d79bc0e
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com>
---
M Makefile
M Makefile.include
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/61524/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/61524
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6029a096c1ceca625789d18c88119d912d79bc0e
Gerrit-Change-Number: 61524
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset