January 2022 - flashrom-gerrit

Change in flashrom[master]: Makeile: reenable internal programmer for mipsel
by Nico Huber (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Thomas Heijligen, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makeile: reenable internal programmer for mipsel ...................................................................... Patch Set 3: (2 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/61300/comment/a5ba1dbd_d97cadbd PS3, Line 104: CONFIG_INTERNAL_MIPSLE \ Is this actually true? https://review.coreboot.org/c/flashrom/+/61300/comment/d284d3d3_5073a47c PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel) > I think this is overly strict, because the internal programmer will delegate to MTD if enabled, whic […] Sounds like it compiled with the meson.build by coincidence all the time? Looking at the code, it seems possible, but there's a shitload of dead, code not making any sense. I guess we could have a CONFIG_INTERNAL (with raw mem and libpci (spurious?) dependencies) and CONFIG_INTERNAL_X86 like suggested by this patch. Thomas, WDYT? For the dependencies, we'd have to disable CONFIG_INTERNAL if CONFIG_INTERNAL_X86 = no. -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jan 2022 23:22:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: fix build on non-x86 targets
by Peter Marheine (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Paul Menzel. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 ) Change subject: hwaccess: fix build on non-x86 targets ...................................................................... Patch Set 5: (3 comments) Patchset: PS1: > I've started working on an overhaul of the hwaccess code in CB:61275 and CB:61276. […] 61276 in particular looks like a nice cleanup of these headers. Fixing the build regression seems like the important aspect of this change, and calling it a temporary solution until the headers are cleaned up more comprehensively sounds fine to me. File hwaccess_x86_io.h: https://review.coreboot.org/c/flashrom/+/61194/comment/3796a02d_fc2baee8 PS4, Line 41: #define HAVE_RGET_IO_PERMS 1 > not needed Done File internal.c: https://review.coreboot.org/c/flashrom/+/61194/comment/4343a592_6843769f PS4, Line 245: if (rget_io_perms()) { > You can move this under the x86 guard at line 275. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/61194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e Gerrit-Change-Number: 61194 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 23 Jan 2022 22:22:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: fix build on non-x86 targets
by Peter Marheine (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Nico Huber, Paul Menzel, Peter Marheine. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61194 to look at the new patch set (#5). Change subject: hwaccess: fix build on non-x86 targets ...................................................................... hwaccess: fix build on non-x86 targets The changes to hwaccess in commit 49d758698a0dd166679c48b1a2785e50e9b0cc83 cause build failure on non-x86 systems because the hwaccess_x86_* headers are included in some files that are built for all platforms (particularly those in the internal programmer) and those headers in turn include <sys/io.h> which only exists on x86. This change makes the hwaccess_x86 headers a nop on non-x86 platforms so the internal programmer can be built without errors. The comment on the stub implementation of rget_io_perms() is also modified to remove references to non-x86 platforms, since that file is only built on x86 now. BUG=None TEST=meson build succeeds for both x86 and ARM targets Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e --- M hwaccess_x86_io.c M hwaccess_x86_io.h M hwaccess_x86_msr.h M internal.c 4 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/61194/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/61194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e Gerrit-Change-Number: 61194 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makeile: reenable internal programmer for mipsel
by Peter Marheine (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makeile: reenable internal programmer for mipsel ...................................................................... Patch Set 3: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/61300/comment/df6055da_360b8bcb PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel) I think this is overly strict, because the internal programmer will delegate to MTD if enabled, which is supported on more than just x86 and mipsel. For Chromium we use that delegation on ARM, for instance. -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 23 Jan 2022 22:01:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add Elkhart Lake support
by Nico Huber (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Werner Zeh. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60711 ) Change subject: Add Elkhart Lake support ...................................................................... Patch Set 2: Code-Review+2 (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/60711/comment/ddf2ee0b_f024667c PS2, Line 15: TEST=Read and flash complete flash on Siemens MC EHL1 Some tests with --ifd and writing only specific regions would be nice to have. This can also happen with an external programmer. File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/60711/comment/26618e8d_2db36d6d PS1, Line 709: boot_straps = boot_straps_pch500; > In EDS there is just SPI defined (bbs=0), whereas bbs=1 is marked as reserved. […] Hmmm, I was looking at revision 1.3 which says UFS. But I wouldn't mind to leave it as `reserved`, it feels unlikely to find it in the wild and we would return BUS_NONE, anyway. https://review.coreboot.org/c/flashrom/+/60711/comment/46df6eb8_892a62a9 PS1, Line 995: dev > I guess this would be something for a follow-up patch, right? Yep, at your convenience. Just something that could be done better for newer platforms in general. AIUI, at least Tiger Lake could be treated the same. Don't know actually since when it's not hidden anymore. File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/60711/comment/3ac0ee97_2d88b46f PS1, Line 1033: return CHIPSET_500_SERIES_TIGER_POINT; > Yes, I was starring at this code back than for a while. […] Please also test if it detects the right platform. Should be easy with ich_descriptors_tool (in util/) run on one of your EHL images ;) File ichspi.c: https://review.coreboot.org/c/flashrom/+/60711/comment/8d4e0af0_ef3f6085 PS1, Line 2027: ich_gen == CHIPSET_ELKHART_LAKE)) { > If moved below, something like this? […] Sounds good. -- To view, visit https://review.coreboot.org/c/flashrom/+/60711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I711e39a3ec9cd7098389231eaa1cb864d615a475 Gerrit-Change-Number: 60711 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sun, 23 Jan 2022 20:02:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Upgrade linux_spi test to run probe lifecycle
by Nico Huber (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59742 ) Change subject: tests: Upgrade linux_spi test to run probe lifecycle ...................................................................... Patch Set 4: (3 comments) File tests/lifecycle.c: https://review.coreboot.org/c/flashrom/+/59742/comment/97d87212_96adb405 PS4, Line 18: #include <linux/spi/spidev.h> > This include seems inevitable... […] IIRC, we asked this before. It depends on whether we want the tests to compile everywhere or just on Linux. I think it's fine as is for now. If we'd guard the include, we'd also have to guard the function below that depends on it etc. If we'd want that, it would be better to put the code into a separate .c file, e.g. one specific to linux_spi tests (which wouldn't need guards inside, just the build system should only compile it when needed). https://review.coreboot.org/c/flashrom/+/59742/comment/f9b3c865_d7e27165 PS4, Line 321: 0x40406b00 Isn't this covered by the include, something like `SPI_IOC_MESSAGE(2)`? https://review.coreboot.org/c/flashrom/+/59742/comment/564fd459_31a2b6c4 PS4, Line 327: readcnt == 3 Checking the actual command would be more accurate and not much harder, I guess, e.g. if (msg[0].len == 1 && msg[0].tx_buf[0] == JEDEC_RDID && readcnt == 3) -- To view, visit https://review.coreboot.org/c/flashrom/+/59742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72 Gerrit-Change-Number: 59742 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Jan 2022 19:19:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: SFDP: drop static table length check to make newer SFDP revisions work
by Nico Huber (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Edward O'Callaghan, Felix Singer, Angel Pons, Anastasia Klimchuk, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60055 ) Change subject: SFDP: drop static table length check to make newer SFDP revisions work ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/60055/comment/eca0edc4_33f2e601 PS1, Line 28: ***RFC*** We could maintain a list of revisions/lengths but is it really : worth it? : > > and that the major version is 1. > > That's already checked. Ack. I missed that the actual action is inside an else-if condition. > But..... > According to JESD216 there is a conflict between JESD216 and Intel legacy. It reads like Intel used 1.x, x=[1-4] \o/ I couldn't find *anything* about that, though....... Well, the code seems to assume legacy Intel has a length of 16. It also seems unlikely that any newer legacy-Intel version would show up with a higher length. So we'd just have to maintain the current quirk: always allow length 16 for major version 1. We allow that already, so it won't get worse. Checking the minimum length would avoid undefined behavior (accessing bytes we didn't read). IMO, that's all we have to do. We can either use the minimum we need (36, currently) or the minimum mandated by the spec. So either } else if (len != 4 * 4 && len < 9 * 4) { or trying to be more accurate } else if (len != 4 * 4 && len < mandated_length[minor_idx]) { with `minor_idx = MIN(ARRAY_SIZE(mandated_length) - 1, hdrs[i].v_minor);`. -- To view, visit https://review.coreboot.org/c/flashrom/+/60055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id84cde4ebc805d68e2984e8041fbc48d7ceebe34 Gerrit-Change-Number: 60055 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 23 Jan 2022 18:21:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add mediatek_i2c_spi interface.
by Nico Huber (Code Review) 23 Jan '22

23 Jan '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Neill Corlett. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 ) Change subject: Add mediatek_i2c_spi interface. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Neill, thanks for your patch. I've some questions ahead of review: * The basic SPI command interface looks a lot like the one of the mstarddc_spi driver. Have you looked into that? maybe there can be some code shared. * There are two implementations to use either I2C or SMBus transfers. Are both paths tested? I only gave it a short glimpse, but it looked like the SMBus path would be doing something different. * There are some hard-coded GPIO numbers. Is this a reference design or maybe specific to a particular board? -- To view, visit https://review.coreboot.org/c/flashrom/+/61288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I24adb14e7b4f7160e1c3ff941774064d5a81e820 Gerrit-Change-Number: 61288 Gerrit-PatchSet: 1 Gerrit-Owner: Neill Corlett <corlett(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Neill Corlett <corlett(a)google.com> Gerrit-Comment-Date: Sun, 23 Jan 2022 15:14:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: fix build on non-x86 targets
by Thomas Heijligen (Code Review) 22 Jan '22

22 Jan '22

Attention is currently required from: Nico Huber, Paul Menzel, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 ) Change subject: hwaccess: fix build on non-x86 targets ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > > I've now opted to put the x86 guards in the headers rather than in the files that include them bec […] I've started working on an overhaul of the hwaccess code in CB:61275 and CB:61276. But this will need some time and testing due to the mess of #if. I'm fine with this patch as temporary solution. -- To view, visit https://review.coreboot.org/c/flashrom/+/61194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e Gerrit-Change-Number: 61194 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Jan 2022 22:50:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Move do_*() helpers into cli_classic.c
by Edward O'Callaghan (Code Review) 22 Jan '22

22 Jan '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60070 ) Change subject: flashrom.c: Move do_*() helpers into cli_classic.c ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/60070 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1112155e2421e0178fd73f847cbb80868387433 Gerrit-Change-Number: 60070 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Jan 2022 00:14:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2022