September 2021 - flashrom-gerrit

Change in flashrom[master]: remove compile guards
by Thomas Heijligen (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Nico Huber, Paul Menzel. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57797 ) Change subject: remove compile guards ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57797/comment/024ebc1d_6ef618b2 PS1, Line 9: buildsystem > build system Done -- To view, visit https://review.coreboot.org/c/flashrom/+/57797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76a76e05c7a7dd27637325ab1e9d8946fd5f9076 Gerrit-Change-Number: 57797 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Sep 2021 11:25:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: remove compile guards
by Thomas Heijligen (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57797 to look at the new patch set (#2). Change subject: remove compile guards ...................................................................... remove compile guards The build system handles the decision when to build a file. Exta compile guards for the source files are not neccessery. Change-Id: I76a76e05c7a7dd27637325ab1e9d8946fd5f9076 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M amd_imc.c M atahpt.c M atapromise.c M ene_lpc.c M ft2232_spi.c M ichspi.c M it85spi.c M it87spi.c M linux_spi.c M mcp6x_spi.c M mec1308.c M mstarddc_spi.c M nic3com.c M nicnatsemi.c M nicrealtek.c M rayer_spi.c M satamv.c M sb600spi.c M usbblaster_spi.c M wbsio_spi.c 20 files changed, 0 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/57797/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76a76e05c7a7dd27637325ab1e9d8946fd5f9076 Gerrit-Change-Number: 57797 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: remove compile guards
by Paul Menzel (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57797 ) Change subject: remove compile guards ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57797/comment/2d25ecab_04cf4ab8 PS1, Line 9: buildsystem build system -- To view, visit https://review.coreboot.org/c/flashrom/+/57797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76a76e05c7a7dd27637325ab1e9d8946fd5f9076 Gerrit-Change-Number: 57797 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 21 Sep 2021 10:59:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ene_lpc: remove ENE LPC programmer
by Victor Ding (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Mike Banon, Nico Huber, Matt DeVillier, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Anastasia Klimchuk, Iru Cai, Alexandru Gagniuc. Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56475 ) Change subject: ene_lpc: remove ENE LPC programmer ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > > It's not known if the code worked on any device when merged. […] Thank you all for looking into this, especially for the great effort to keep these two programmers alive. What should I do next? I believe this can be useful for certain users (e.g. Lenovo G505s); however the last Chromebook using it is now EOL. I'm afraid that I won't be able to find a device to debug and verify the programmer, despite how much I'd like to keep them alive. -- To view, visit https://review.coreboot.org/c/flashrom/+/56475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b Gerrit-Change-Number: 56475 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Sep 2021 08:53:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Iru Cai <mytbk920423(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: remove compile guards
by Thomas Heijligen (Code Review) 21 Sep '21

21 Sep '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57797 ) Change subject: remove compile guards ...................................................................... remove compile guards The buildsystem handles the decision when to build a file. Exta compile guards for the source files are not neccessery. Change-Id: I76a76e05c7a7dd27637325ab1e9d8946fd5f9076 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M amd_imc.c M atahpt.c M atapromise.c M ene_lpc.c M ft2232_spi.c M ichspi.c M it85spi.c M it87spi.c M linux_spi.c M mcp6x_spi.c M mec1308.c M mstarddc_spi.c M nic3com.c M nicnatsemi.c M nicrealtek.c M rayer_spi.c M satamv.c M sb600spi.c M usbblaster_spi.c M wbsio_spi.c 20 files changed, 0 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/57797/1 diff --git a/amd_imc.c b/amd_imc.c index 8b0bcf2..a3959e6 100644 --- a/amd_imc.c +++ b/amd_imc.c @@ -15,8 +15,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include "flash.h" #include "programmer.h" #include "hwaccess.h" @@ -151,5 +149,3 @@ return ret; } - -#endif diff --git a/atahpt.c b/atahpt.c index c627e0b..d9b56bc 100644 --- a/atahpt.c +++ b/atahpt.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <stdlib.h> #include <string.h> #include "flash.h" @@ -97,7 +95,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#else -#error PCI port I/O access is not supported on this architecture yet. -#endif diff --git a/atapromise.c b/atapromise.c index e3009e4..0c187e3 100644 --- a/atapromise.c +++ b/atapromise.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <string.h> #include <stdlib.h> #include "flash.h" @@ -170,7 +168,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#else -#error PCI port I/O access is not supported on this architecture yet. -#endif diff --git a/ene_lpc.c b/ene_lpc.c index 374d1fd..2103137 100644 --- a/ene_lpc.c +++ b/ene_lpc.c @@ -35,7 +35,6 @@ * Software Foundation. */ -#if defined(__i386__) || defined(__x86_64__) #include <inttypes.h> #include <stdlib.h> #include <string.h> @@ -587,5 +586,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#endif /* __i386__ || __x86_64__ */ diff --git a/ft2232_spi.c b/ft2232_spi.c index 15837d9..0962f1c 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#if CONFIG_FT2232_SPI == 1 - #include <stdio.h> #include <strings.h> #include <string.h> @@ -599,4 +597,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; -#endif diff --git a/ichspi.c b/ichspi.c index 091e4e2..d345af2 100644 --- a/ichspi.c +++ b/ichspi.c @@ -19,8 +19,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <string.h> #include <stdlib.h> #include "flash.h" @@ -2113,5 +2111,3 @@ return 0; } - -#endif diff --git a/it85spi.c b/it85spi.c index dd0cb6c..17e4e10 100644 --- a/it85spi.c +++ b/it85spi.c @@ -20,8 +20,6 @@ * Contains the ITE IT85* SPI specific routines */ -#if defined(__i386__) || defined(__x86_64__) - #include <string.h> #include <stdio.h> #include <stdlib.h> @@ -362,5 +360,3 @@ /* Set this as SPI controller. */ return register_spi_master(&spi_master_it85xx, data); } - -#endif diff --git a/it87spi.c b/it87spi.c index 3e422d7..5f6fb65 100644 --- a/it87spi.c +++ b/it87spi.c @@ -19,8 +19,6 @@ * Contains the ITE IT87* SPI specific routines */ -#if defined(__i386__) || defined(__x86_64__) - #include <string.h> #include <stdlib.h> #include <errno.h> @@ -464,5 +462,3 @@ } return ret; } - -#endif /* defined(__i386__) || defined(__x86_64__) */ diff --git a/linux_spi.c b/linux_spi.c index bd9ffb3..27a9a0d 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */ -#if CONFIG_LINUX_SPI == 1 - #include <stdio.h> #include <string.h> #include <stdlib.h> @@ -256,5 +254,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#endif // CONFIG_LINUX_SPI == 1 diff --git a/mcp6x_spi.c b/mcp6x_spi.c index fa309ca..29d2663 100644 --- a/mcp6x_spi.c +++ b/mcp6x_spi.c @@ -19,8 +19,6 @@ * created by Michael Karcher. */ -#if defined(__i386__) || defined(__x86_64__) - #include <stdlib.h> #include <ctype.h> #include "flash.h" @@ -192,5 +190,3 @@ return 0; } - -#endif diff --git a/mec1308.c b/mec1308.c index e9c6214..c7176b6 100644 --- a/mec1308.c +++ b/mec1308.c @@ -35,7 +35,6 @@ * Software Foundation. */ -#if defined(__i386__) || defined(__x86_64__) #include <inttypes.h> #include <stdlib.h> #include <string.h> @@ -528,5 +527,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#endif diff --git a/mstarddc_spi.c b/mstarddc_spi.c index 8e2d5a8..71b02c0 100644 --- a/mstarddc_spi.c +++ b/mstarddc_spi.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */ -#if CONFIG_MSTARDDC_SPI == 1 - #include <stdio.h> #include <string.h> #include <stdlib.h> @@ -259,5 +257,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#endif diff --git a/nic3com.c b/nic3com.c index 2af0a52..79964ac 100644 --- a/nic3com.c +++ b/nic3com.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <stdlib.h> #include "flash.h" #include "programmer.h" @@ -173,7 +171,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#else -#error PCI port I/O access is not supported on this architecture yet. -#endif diff --git a/nicnatsemi.c b/nicnatsemi.c index b2f381a..6216728 100644 --- a/nicnatsemi.c +++ b/nicnatsemi.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <stdlib.h> #include "flash.h" #include "programmer.h" @@ -110,7 +108,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#else -#error PCI port I/O access is not supported on this architecture yet. -#endif diff --git a/nicrealtek.c b/nicrealtek.c index ec821b4..70daeec 100644 --- a/nicrealtek.c +++ b/nicrealtek.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <stdlib.h> #include "flash.h" #include "programmer.h" @@ -151,7 +149,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#else -#error PCI port I/O access is not supported on this architecture yet. -#endif diff --git a/rayer_spi.c b/rayer_spi.c index 1102ff1..e65eb78 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -22,7 +22,6 @@ * most OS parport drivers will perform many unnecessary accesses although * this driver just treats the parallel port as a GPIO set. */ -#if defined(__i386__) || defined(__x86_64__) #include <stdlib.h> #include <strings.h> @@ -334,7 +333,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#else -#error PCI port I/O access is not supported on this architecture yet. -#endif diff --git a/satamv.c b/satamv.c index 32ac11a..cdd2f27 100644 --- a/satamv.c +++ b/satamv.c @@ -15,7 +15,6 @@ */ /* Datasheets are not public (yet?) */ -#if defined(__i386__) || defined(__x86_64__) #include <stdlib.h> #include "flash.h" @@ -191,7 +190,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#else -#error PCI port I/O access is not supported on this architecture yet. -#endif diff --git a/sb600spi.c b/sb600spi.c index fe7920f..7fa01af 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -18,8 +18,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <string.h> #include <stdlib.h> #include "flash.h" @@ -799,5 +797,3 @@ return 0; } - -#endif diff --git a/usbblaster_spi.c b/usbblaster_spi.c index bd4b1c9..8957df8 100644 --- a/usbblaster_spi.c +++ b/usbblaster_spi.c @@ -30,8 +30,6 @@ * See also the USB-Blaster Download Cable User Guide: http://www.altera.com/literature/ug/ug_usb_blstr.pdf */ -#if CONFIG_USBBLASTER_SPI == 1 - #include <stdio.h> #include <string.h> #include <stdlib.h> @@ -237,5 +235,3 @@ .unmap_flash_region = fallback_unmap, .delay = internal_delay, }; - -#endif diff --git a/wbsio_spi.c b/wbsio_spi.c index a175b21..60b725f 100644 --- a/wbsio_spi.c +++ b/wbsio_spi.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#if defined(__i386__) || defined(__x86_64__) - #include <stdlib.h> #include "flash.h" @@ -217,5 +215,3 @@ return register_spi_master(&spi_master_wbsio, data); } - -#endif /* defined(__i386__) || defined(__x86_64__) */ -- To view, visit https://review.coreboot.org/c/flashrom/+/57797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76a76e05c7a7dd27637325ab1e9d8946fd5f9076 Gerrit-Change-Number: 57797 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ich_descriptors: Normalize chipset detection
by David Hendricks (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Nico Huber. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55651 ) Change subject: ich_descriptors: Normalize chipset detection ...................................................................... Patch Set 5: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/55651/comment/473eb2b3_5f45bdb3 PS5, Line 936: if (content->ISL <= 16) : return CHIPSET_5_SERIES_IBEX_PEAK; > For instance, when I wrote this patch, > I would not have guessed that a server platform will land on this ICCRIBA > == 0 branch. Trying to predict such details can lead to walking in circles > patch wise. I'm sure you did what seemed right with the information that you had at the time. Intel threw a curvaball at us with this. > For instance, I assume that it's easier to follow the code > when it's more condensed, like after this patch. Before the entire patch > train it was a forest of if's and nobody knew where to put anything. We > should avoid that this happens again. Yeah, flashrom tends to accumulate cruft as new similar-but-slightly-different hardware gets added. I'm glad you refactored this, and FWIW the original EBG patch (CB:54965) definitely looked better after rebasing. > Only one thing I have to ask you: As the purpose of this patch was to > normalize, please do so with explicit if's for all chipsets then. > warn_peculiar_desc() probably shouldn't have to check anything then. Done: CB:57793 -- To view, visit https://review.coreboot.org/c/flashrom/+/55651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5a5fee870202173b3a9813b03ec261e8ee45155 Gerrit-Change-Number: 55651 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 21 Sep 2021 05:20:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Add explicit checks for all chipsets
by David Hendricks (Code Review) 21 Sep '21

21 Sep '21

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57793 ) Change subject: ich_descriptors: Add explicit checks for all chipsets ...................................................................... ich_descriptors: Add explicit checks for all chipsets This partially undoes changes made in CB:55651. There was a new chipset added that necessitated adding back a check for an older chipset. To keep things normalized we'll use the same pattern in all cases. Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f Signed-off-by: David Hendricks <ddaveh(a)amazon.com> --- M ich_descriptors.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/57793/1 diff --git a/ich_descriptors.c b/ich_descriptors.c index d56ade7..9b63006 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -933,15 +933,19 @@ return CHIPSET_ICH9; if (content->ISL <= 10) return CHIPSET_ICH10; + if (content->ISL <= 16) + return CHIPSET_5_SERIES_IBEX_PEAK; if (content->FLMAP2 == 0) { if (content->ISL == 19) return CHIPSET_APOLLO_LAKE; - warn_peculiar_desc(content->ISL != 23, "Gemini Lake"); + if (content->ISL == 23) + return CHIPSET_GEMINI_LAKE; + warn_peculiar_desc(true, "Gemini Lake"); return CHIPSET_GEMINI_LAKE; } if (content->ISL <= 80) return CHIPSET_C620_SERIES_LEWISBURG; - warn_peculiar_desc(content->ISL != 16, "Ibex Peak"); + warn_peculiar_desc(true, "Ibex Peak"); return CHIPSET_5_SERIES_IBEX_PEAK; } else if (upper->MDTBA == 0x00) { if (content->ICCRIBA < 0x31 && content->FMSBA < 0x30) { @@ -949,7 +953,9 @@ return CHIPSET_BAYTRAIL; if (content->MSL <= 1 && content->ISL <= 18) return CHIPSET_6_SERIES_COUGAR_POINT; - warn_peculiar_desc(content->MSL != 1 || content->ISL != 21, "Lynx Point"); + if (content->MSL <= 1 && content->ISL <= 21) + return CHIPSET_8_SERIES_LYNX_POINT; + warn_peculiar_desc(true, "Lynx Point"); return CHIPSET_8_SERIES_LYNX_POINT; } if (content->NM == 6) { -- To view, visit https://review.coreboot.org/c/flashrom/+/57793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f Gerrit-Change-Number: 57793 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: chipset_enable.c: Add Ids for recent Intel chipsets
by Nikolai Artemiev (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Paul Menzel. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57560 ) Change subject: chipset_enable.c: Add Ids for recent Intel chipsets ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/57560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iff387076567e639485ac15c25c1bcc8c37a07037 Gerrit-Change-Number: 57560 Gerrit-PatchSet: 7 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Sep 2021 00:30:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ene_lpc: remove ENE LPC programmer
by Michael Niewöhner (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Mike Banon, Nico Huber, Victor Ding, Matt DeVillier, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Iru Cai, Alexandru Gagniuc. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56475 ) Change subject: ene_lpc: remove ENE LPC programmer ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > It's not known if the code worked on any device when merged. I highly doubt it... first issue when testing here: missing iopl/ioperm \o/ > It's also not known if the code is device specific and what firmware, if any, is expected on the EC. Firmware is definitely expected. Take a look at lines 138ff. These are EC fw commands. Unfortunately, I'm having massive issues with EDI flashing atm. It looks my EC is dying .... (It worked many times before without problems.) That means I can't test/fix this programmer, anyway :/ > I'd say it's best to get it through a proper review if anybody finds a use case for it. Same story for the follow-up commit. Ack. -- To view, visit https://review.coreboot.org/c/flashrom/+/56475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b Gerrit-Change-Number: 56475 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Sep 2021 00:14:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Iru Cai <mytbk920423(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add Tiger Lake U Premium support
by Nico Huber (Code Review) 20 Sep '21

20 Sep '21

Attention is currently required from: Michał Żygowski, Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 ) Change subject: Add Tiger Lake U Premium support ...................................................................... Patch Set 12: Code-Review+2 (2 comments) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/55578/comment/78f6f661_6d602c55 PS3, Line 659: { "eSPI", BUS_LPC | BUS_FWH } }; > Done. […] Thanks! that's even better :) File flash.h: https://review.coreboot.org/c/flashrom/+/55578/comment/76e544de_050f20ed PS10, Line 71: BUS_NONSPI = BUS_PARALLEL | BUS_LPC | BUS_FWH, > Hard to tell. BUS_NONSPI is mostly used on older southbridges/chipsets in chipset_enable. […] Heh, I was wondering about that comment too. Maybe it means that once we treat all bus types similarly in common code, we won't have to check for SPI/NONSPI explicitly anywhere. -- To view, visit https://review.coreboot.org/c/flashrom/+/55578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd Gerrit-Change-Number: 55578 Gerrit-PatchSet: 12 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 20 Sep 2021 21:00:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021