September 2021 - flashrom-gerrit

Change in flashrom[master]: ft2232_spi: prevent use of reserved pins on some programmers
by Michael Niewöhner (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57809 ) Change subject: ft2232_spi: prevent use of reserved pins on some programmers ...................................................................... Patch Set 2: (1 comment) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57809/comment/1e5391a8_d2301e36 PS2, Line 488: rsv_bits > Alternatively, could we use `… [View More]

1 0

Change in flashrom[master]: remove compile guards
by Felix Singer (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Nico Huber, Thomas Heijligen, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57797 ) Change subject: remove compile guards ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project:… [View More]

1 0

Change in flashrom[master]: remove compile guards
by Thomas Heijligen (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57797 ) Change subject: remove compile guards ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > Looks good but I've merged the ene/mec removals, so this needs manual work I guess. I've manually rebased -- To view, visit https://review.coreboot.org/… [View More]

1 0

Change in flashrom[master]: remove compile guards
by Thomas Heijligen (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Paul Menzel. Hello Felix Singer, build bot (Jenkins), Nico Huber, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57797 to look at the new patch set (#4). Change subject: remove compile guards ...................................................................... remove compile guards The build system handles the decision when to build a file. Extra … [View More]

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by Angel Pons (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Stefan Reinauer, David Hendricks, Christian Walter, Deomid "rojer" Ryabkov, Tim Chu. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 3: -Code-Review (2 comments) Patchset: PS3: > That is true, -2 can … [View More]and has been abused in this project. But the mere possibility does not constitute that every -2 is an act of abuse. And particularly if you read the history of this exchange you will no doubt agree that this is not the case here. I agree with you that David wasn't abusing his -2 rights here. Still, I'd say a -1 would've achieved the same goal (stop this change from being submitted without discussing the matter beforehand) without heating things up as much. But this is how it went, and here we are. PS3: I'm removing my review score from this change because I don't want to be associated with this change nor what happened during review. -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 22 Sep 2021 15:24:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment [View Less]

1 0

Change in flashrom[master]: ft2232_spi: prevent use of reserved pins on some programmers
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57809 ) Change subject: ft2232_spi: prevent use of reserved pins on some programmers ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57809/comment/9a77a9de_68da7821 PS2, Line 488: rsv_bits … [View More]

1 0

Change in flashrom[master]: ft2232_spi: clarify the comment about gpio configuration
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57808 ) Change subject: ft2232_spi: clarify the comment about gpio configuration ...................................................................... Patch Set 2: (1 comment) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57808/comment/09cfd2dc_a15733d6 PS2, Line 94: GPIOL* pins are : * … [View More]

1 0

Change in flashrom[master]: flashrom.8: add missing entry for `--flash-contents`
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57807 ) Change subject: flashrom.8: add missing entry for `--flash-contents` ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/57807/comment/00d44c68_380cb396 PS2, Line 295: .BR <ref\-file> … [View More]

1 0

Change in flashrom[master]: flashrom.8: replace `svn changelog` with `git history`
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57811 ) Change subject: flashrom.8: replace `svn changelog` with `git history` ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Alternatively, s/git/VCS/ but it seems unlikely at the moment that this will matter ;) -- To view, visit https:… [View More]

1 0

Change in flashrom[master]: remove compile guards
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57797 ) Change subject: remove compile guards ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Looks good but I've merged the ene/mec removals, so this needs manual work I guess. -- To view, visit https://review.coreboot.org/c/flashrom/+/… [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021