September 2021 - flashrom-gerrit

Change in flashrom[master]: ene_lpc: remove ENE LPC programmer
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/56475 ) Change subject: ene_lpc: remove ENE LPC programmer ...................................................................... ene_lpc: remove ENE LPC programmer Best efforts were made to upstream older Chromebook support for good intentions for folks interested. However, we no longer have the hardware available to test and maintain the code as the hardware is now end of life. Therefore the code state has sadly fallen into a unknown state. BUG=none BRANCH=none TEST=builds and ninja test passes Signed-off-by: Victor Ding <victording(a)google.com> Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b Reviewed-on: https://review.coreboot.org/c/flashrom/+/56475 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile D ene_lpc.c M meson.build M meson_options.txt M programmer.h M programmer_table.c M tests/init_shutdown.c M tests/tests.c M tests/tests.h 9 files changed, 3 insertions(+), 681 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/Makefile b/Makefile index 27f66a9..2182121 100644 --- a/Makefile +++ b/Makefile @@ -217,8 +217,6 @@ $(call mark_unsupported,$(DEPENDS_ON_SERIAL)) # Libraries not available for DOS $(call mark_unsupported,$(DEPENDS_ON_LIBUSB1) $(DEPENDS_ON_LIBFTDI) $(DEPENDS_ON_LIBJAYLINK)) -# Odd ones (FIXME: why are they unsupported?) -$(call mark_unsupported,CONFIG_ENE_LPC CONFIG_MEC1308) endif # FIXME: Should we check for Cygwin/MSVC as well? @@ -233,7 +231,7 @@ # For now we disable all PCI-based programmers on Windows/MinGW (no libpci). $(call mark_unsupported,$(DEPENDS_ON_LIBPCI)) # And programmers that need raw access. -$(call mark_unsupported,CONFIG_ENE_LPC CONFIG_MEC1308 CONFIG_RAYER_SPI) +$(call mark_unsupported,CONFIG_MEC1308 CONFIG_RAYER_SPI) else # No MinGW @@ -256,7 +254,7 @@ # Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported with libpayload (missing libusb support). $(call mark_unsupported,$(DEPENDS_ON_LIBUSB1) $(DEPENDS_ON_LIBFTDI) $(DEPENDS_ON_LIBJAYLINK)) # Odd ones. (FIXME: why?) -$(call mark_unsupported,CONFIG_ENE_LPC CONFIG_MEC1308) +$(call mark_unsupported,CONFIG_MEC1308) endif # Android is handled internally as separate OS, but it supports about the same drivers as Linux. @@ -297,7 +295,7 @@ ifneq ($(ARCH), x86) $(call mark_unsupported,CONFIG_NIC3COM CONFIG_NICREALTEK CONFIG_NICNATSEMI) $(call mark_unsupported,CONFIG_RAYER_SPI CONFIG_ATAHPT CONFIG_ATAPROMISE) -$(call mark_unsupported,CONFIG_SATAMV CONFIG_ENE_LPC CONFIG_MEC1308) +$(call mark_unsupported,CONFIG_SATAMV CONFIG_MEC1308) endif # Additionally disable all drivers needing raw access (memory, PCI, port I/O) @@ -382,9 +380,6 @@ # Promise ATA controller support. CONFIG_ATAPROMISE ?= no -# ENE LPC interface keyboard controller -CONFIG_ENE_LPC ?= yes - # Always enable FT2232 SPI dongles for now. CONFIG_FT2232_SPI ?= yes @@ -534,12 +529,6 @@ endif endif -ifeq ($(CONFIG_ENE_LPC), yes) -FEATURE_CFLAGS += -D'CONFIG_ENE_LPC=1' -PROGRAMMER_OBJS += ene_lpc.o -NEED_RAW_ACCESS += CONFIG_ENE_LPC -endif - ifeq ($(CONFIG_MEC1308), yes) FEATURE_CFLAGS += -D'CONFIG_MEC1308=1' PROGRAMMER_OBJS += mec1308.o diff --git a/ene_lpc.c b/ene_lpc.c deleted file mode 100644 index 374d1fd..0000000 --- a/ene_lpc.c +++ /dev/null @@ -1,591 +0,0 @@ -/* - * This file is part of the flashrom project. - * - * Copyright (C) 2012-2020, Google Inc. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following disclaimer - * in the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Google Inc. nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - * - * Alternatively, this software may be distributed under the terms of the - * GNU General Public License ("GPL") version 2 as published by the Free - * Software Foundation. - */ - -#if defined(__i386__) || defined(__x86_64__) -#include <inttypes.h> -#include <stdlib.h> -#include <string.h> -#include <unistd.h> -#include <sys/time.h> - -#include "chipdrivers.h" -#include "flash.h" -#include "programmer.h" -#include "hwaccess.h" -#include "spi.h" - -/* MCU registers */ -#define REG_EC_HWVER 0xff00 -#define REG_EC_FWVER 0xff01 -#define REG_EC_EDIID 0xff24 -#define REG_8051_CTRL 0xff14 -#define REG_EC_EXTCMD 0xff10 - -#define CPU_RESET 1 - -/* MCU SPI peripheral registers */ -#define REG_SPI_DATA 0xfeab -#define REG_SPI_COMMAND 0xfeac -#define REG_SPI_CONFIG 0xfead - -#define CFG_CSn_FORCE_LOW (1 << 4) -#define CFG_COMMAND_WRITE_ENABLE (1 << 3) -#define CFG_STATUS (1 << 1) -#define CFG_ENABLE_BUSY_STATUS_CHECK (1 << 0) - -/* Timeout */ -#define EC_COMMAND_TIMEOUT 4 -#define EC_RESTART_TIMEOUT 10 -#define ENE_SPI_DELAY_CYCLE 4 -#define EC_PAUSE_TIMEOUT 12 -#define EC_RESET_TRIES 3 - -#define ENE_KB94X_PAUSE_WAKEUP_PORT 0x64 - -#define MASK_INPUT_BUFFER_FULL 2 -#define MASK_OUTPUT_BUFFER_FULL 1 - -const int port_ene_bank = 1; -const int port_ene_offset = 2; -const int port_ene_data = 3; - -/* Supported ENE ECs, ENE_LAST should always be LAST member */ -enum ene_chip_id { - ENE_KB932 = 0, - ENE_KB94X, - ENE_LAST -}; - -/* EC state */ -enum ene_ec_state { - EC_STATE_NORMAL, - EC_STATE_IDLE, - EC_STATE_RESET, - EC_STATE_UNKNOWN -}; - -/* chip-specific parameters */ -typedef struct { - enum ene_chip_id chip_id; - uint8_t hwver; - uint8_t ediid; - uint32_t port_bios; - uint32_t port_ec_command; - uint32_t port_ec_data; - uint8_t ec_reset_cmd; - uint8_t ec_reset_data; - uint8_t ec_restart_cmd; - uint8_t ec_restart_data; - uint8_t ec_pause_cmd; - uint8_t ec_pause_data; - uint16_t ec_status_buf; - uint8_t ec_is_stopping; - uint8_t ec_is_running; - uint8_t ec_is_pausing; - uint32_t port_io_base; -} ene_chip_t; - -typedef struct -{ - /* pointer to table entry of identified chip */ - ene_chip_t *chip; - /* current ec state */ - enum ene_ec_state ec_state; - struct timeval pause_begin; -} ene_lpc_data_t; - -/* table of supported chips + parameters */ -static ene_chip_t ene_chips[] = { - { - ENE_KB932, /* chip_id */ - 0xa2, 0x02, /* hwver + ediid */ - 0x66, /* port_bios */ - 0x6c, 0x68, /* port_ec_{command,data} */ - 0x59, 0xf2, /* ec_reset_{cmd,data} */ - 0x59, 0xf9, /* ec_restart_{cmd,data} */ - 0x59, 0xf1, /* ec_pause_{cmd,data} */ - 0xf554, /* ec_status_buf */ - 0xa5, 0x00, /* ec_is_{stopping,running} masks */ - 0x33, /* ec_is_pausing mask */ - 0xfd60 /* port_io_base */ - }, - { - ENE_KB94X, /* chip_id */ - 0xa3, 0x05, /* hwver + ediid */ - 0x66, /* port_bios */ - 0x66, 0x68, /* port_ec_{command,data} */ - 0x7d, 0x10, /* ec_reset_{cmd,data} */ - 0x7f, 0x10, /* ec_restart_{cmd,data} */ - 0x7e, 0x10, /* ec_pause_{cmd,data} */ - 0xf710, /* ec_status_buf */ - 0x02, 0x00, /* ec_is_{stopping,running} masks */ - 0x01, /* ec_is_pausing mask */ - 0x0380 /* port_io_base */ - } -}; - -static void ec_command(const ene_chip_t *chip, uint8_t cmd, uint8_t data) -{ - struct timeval begin, now; - - /* Spin wait for EC input buffer empty */ - gettimeofday(&begin, NULL); - while (INB(chip->port_ec_command) & MASK_INPUT_BUFFER_FULL) { - gettimeofday(&now, NULL); - if (now.tv_sec - begin.tv_sec >= EC_COMMAND_TIMEOUT) { - msg_pdbg("%s: buf not empty\n", __func__); - return; - } - } - - /* Write command */ - OUTB(cmd, chip->port_ec_command); - - if (chip->chip_id == ENE_KB932) { - /* Spin wait for EC input buffer empty */ - gettimeofday(&begin, NULL); - while (INB(chip->port_ec_command) & MASK_INPUT_BUFFER_FULL) { - gettimeofday(&now, NULL); - if (now.tv_sec - begin.tv_sec >= EC_COMMAND_TIMEOUT) { - msg_pdbg("%s: buf not empty\n", __func__); - return; - } - } - /* Write data */ - OUTB(data, chip->port_ec_data); - } -} - -static uint8_t ene_read(const ene_chip_t *chip, uint16_t addr) -{ - uint8_t bank; - uint8_t offset; - uint8_t data; - uint32_t port_io_base; - - bank = addr >> 8; - offset = addr & 0xff; - port_io_base = chip->port_io_base; - - OUTB(bank, port_io_base + port_ene_bank); - OUTB(offset, port_io_base + port_ene_offset); - data = INB(port_io_base + port_ene_data); - - return data; -} - -static void ene_write(const ene_chip_t *chip, uint16_t addr, uint8_t data) -{ - uint8_t bank; - uint8_t offset; - uint32_t port_io_base; - - bank = addr >> 8; - offset = addr & 0xff; - port_io_base = chip->port_io_base; - - OUTB(bank, port_io_base + port_ene_bank); - OUTB(offset, port_io_base + port_ene_offset); - - OUTB(data, port_io_base + port_ene_data); -} - -/** - * wait_cycles, wait for n LPC bus clock cycles - * - * @param n: number of LPC cycles to wait - * @return void - */ -static void wait_cycles(const ene_chip_t *chip,int n) -{ - while (n--) - INB(chip->port_io_base + port_ene_bank); -} - -static int is_spicmd_write(uint8_t cmd) -{ - switch (cmd) { - case JEDEC_WREN: - /* Chip Write Enable */ - case JEDEC_EWSR: - /* Write Status Enable */ - case JEDEC_CE_60: - /* Chip Erase 0x60 */ - case JEDEC_CE_C7: - /* Chip Erase 0xc7 */ - case JEDEC_BE_52: - /* Block Erase 0x52 */ - case JEDEC_BE_D8: - /* Block Erase 0xd8 */ - case JEDEC_BE_D7: - /* Block Erase 0xd7 */ - case JEDEC_SE: - /* Sector Erase */ - case JEDEC_BYTE_PROGRAM: - /* Write memory byte */ - case JEDEC_AAI_WORD_PROGRAM: - /* Write AAI word */ - return 1; - } - return 0; -} - -static void ene_spi_start(const ene_chip_t *chip) -{ - int cfg; - - cfg = ene_read(chip, REG_SPI_CONFIG); - cfg |= CFG_CSn_FORCE_LOW; - cfg |= CFG_COMMAND_WRITE_ENABLE; - ene_write(chip, REG_SPI_CONFIG, cfg); - - wait_cycles(chip, ENE_SPI_DELAY_CYCLE); -} - -static void ene_spi_end(const ene_chip_t *chip) -{ - int cfg; - - cfg = ene_read(chip, REG_SPI_CONFIG); - cfg &= ~CFG_CSn_FORCE_LOW; - cfg |= CFG_COMMAND_WRITE_ENABLE; - ene_write(chip, REG_SPI_CONFIG, cfg); - - wait_cycles(chip, ENE_SPI_DELAY_CYCLE); -} - -static int ene_spi_wait(const ene_chip_t *chip) -{ - struct timeval begin, now; - - gettimeofday(&begin, NULL); - while (ene_read(chip, REG_SPI_CONFIG) & CFG_STATUS) { - gettimeofday(&now, NULL); - if (now.tv_sec - begin.tv_sec >= EC_COMMAND_TIMEOUT) { - msg_pdbg("%s: spi busy\n", __func__); - return 1; - } - } - return 0; -} - -static int ene_pause_ec(ene_lpc_data_t *ctx_data) -{ - struct timeval begin, now; - const ene_chip_t *chip = ctx_data->chip; - - if (!chip->ec_pause_cmd) - return -1; - - /* EC prepare pause */ - ec_command(chip, chip->ec_pause_cmd, chip->ec_pause_data); - - gettimeofday(&begin, NULL); - /* Spin wait for EC ready */ - while (ene_read(chip, chip->ec_status_buf) != chip->ec_is_pausing) { - gettimeofday(&now, NULL); - if (now.tv_sec - begin.tv_sec >= EC_COMMAND_TIMEOUT) { - msg_pdbg("%s: unable to pause ec\n", __func__); - return -1; - } - } - - gettimeofday(&ctx_data->pause_begin, NULL); - ctx_data->ec_state = EC_STATE_IDLE; - return 0; -} - -static int ene_resume_ec(ene_lpc_data_t *ctx_data) -{ - struct timeval begin, now; - const ene_chip_t *chip = ctx_data->chip; - - if (chip->chip_id == ENE_KB94X) - OUTB(0xff, ENE_KB94X_PAUSE_WAKEUP_PORT); - else - /* Trigger 8051 interrupt to resume */ - ene_write(chip, REG_EC_EXTCMD, 0xff); - - gettimeofday(&begin, NULL); - while (ene_read(chip, chip->ec_status_buf) != chip->ec_is_running) { - gettimeofday(&now, NULL); - if (now.tv_sec - begin.tv_sec >= EC_COMMAND_TIMEOUT) { - msg_pdbg("%s: unable to resume ec\n", __func__); - return -1; - } - } - - ctx_data->ec_state = EC_STATE_NORMAL; - return 0; -} - -static int ene_pause_timeout_check(ene_lpc_data_t *ctx_data) -{ - struct timeval pause_now; - gettimeofday(&pause_now, NULL); - if (pause_now.tv_sec - ctx_data->pause_begin.tv_sec >= EC_PAUSE_TIMEOUT) { - if (ene_resume_ec(ctx_data) == 0) - ene_pause_ec(ctx_data); - } - return 0; -} - -static int ene_reset_ec(ene_lpc_data_t *ctx_data) -{ - uint8_t reg; - struct timeval begin, now; - const ene_chip_t *chip = ctx_data->chip; - - gettimeofday(&begin, NULL); - - /* EC prepare reset */ - ec_command(chip, chip->ec_reset_cmd, chip->ec_reset_data); - - /* Spin wait for EC ready */ - while (ene_read(chip, chip->ec_status_buf) != chip->ec_is_stopping) { - gettimeofday(&now, NULL); - if (now.tv_sec - begin.tv_sec >= EC_COMMAND_TIMEOUT) { - msg_pdbg("%s: unable to reset ec\n", __func__); - return -1; - } - } - - /* Wait 1 second */ - sleep(1); - - /* Reset 8051 */ - reg = ene_read(chip, REG_8051_CTRL); - reg |= CPU_RESET; - ene_write(chip, REG_8051_CTRL, reg); - - ctx_data->ec_state = EC_STATE_RESET; - return 0; -} - -static int ene_enter_flash_mode(ene_lpc_data_t *ctx_data) -{ - if (ene_pause_ec(ctx_data)) - return ene_reset_ec(ctx_data); - return 0; -} - -static int ene_spi_send_command(const struct flashctx *flash, - unsigned int writecnt, - unsigned int readcnt, - const unsigned char *writearr, - unsigned char *readarr) -{ - unsigned int i; - int tries = EC_RESET_TRIES; - ene_lpc_data_t *ctx_data = (ene_lpc_data_t *)flash->mst->spi.data; - const ene_chip_t *chip = ctx_data->chip; - - if (ctx_data->ec_state == EC_STATE_IDLE && is_spicmd_write(writearr[0])) { - do { - /* Enter reset mode if we need to write/erase */ - if (ene_resume_ec(ctx_data)) - continue; - - if (!ene_reset_ec(ctx_data)) - break; - } while (--tries > 0); - - if (!tries) { - msg_perr("%s: EC failed reset, skipping write\n", __func__); - ctx_data->ec_state = EC_STATE_IDLE; - return 1; - } - } else if (chip->chip_id == ENE_KB94X && ctx_data->ec_state == EC_STATE_IDLE) { - ene_pause_timeout_check(ctx_data); - } - - ene_spi_start(chip); - - for (i = 0; i < writecnt; i++) { - ene_write(chip, REG_SPI_COMMAND, writearr[i]); - if (ene_spi_wait(chip)) { - msg_pdbg("%s: write count %d\n", __func__, i); - return 1; - } - } - - for (i = 0; i < readcnt; i++) { - /* Push data by clock the serial bus */ - ene_write(chip, REG_SPI_COMMAND, 0); - if (ene_spi_wait(chip)) { - msg_pdbg("%s: read count %d\n", __func__, i); - return 1; - } - readarr[i] = ene_read(chip, REG_SPI_DATA); - if (ene_spi_wait(chip)) { - msg_pdbg("%s: read count %d\n", __func__, i); - return 1; - } - } - - ene_spi_end(chip); - return 0; -} - -static int ene_leave_flash_mode(void *data) -{ - ene_lpc_data_t *ctx_data = (ene_lpc_data_t *)data; - const ene_chip_t *chip = ctx_data->chip; - int rv = 0; - uint8_t reg; - struct timeval begin, now; - - if (ctx_data->ec_state == EC_STATE_RESET) { - reg = ene_read(chip, REG_8051_CTRL); - reg &= ~CPU_RESET; - ene_write(chip, REG_8051_CTRL, reg); - - gettimeofday(&begin, NULL); - /* EC restart */ - while (ene_read(chip, chip->ec_status_buf) != chip->ec_is_running) { - gettimeofday(&now, NULL); - if (now.tv_sec - begin.tv_sec >= EC_RESTART_TIMEOUT) { - msg_pdbg("%s: ec restart busy\n", __func__); - rv = 1; - goto exit; - } - } - msg_pdbg("%s: send ec restart\n", __func__); - ec_command(chip, chip->ec_restart_cmd, chip->ec_restart_data); - - ctx_data->ec_state = EC_STATE_NORMAL; - rv = 0; - goto exit; - } - - rv = ene_resume_ec(ctx_data); - -exit: - /* - * Trigger ec interrupt after pause/reset by sending 0x80 - * to bios command port. - */ - OUTB(0x80, chip->port_bios); - free(data); - return rv; -} - -static const struct spi_master spi_master_ene = { - .max_data_read = 256, - .max_data_write = 256, - .command = ene_spi_send_command, - .multicommand = default_spi_send_multicommand, - .read = default_spi_read, - .write_256 = default_spi_write_256, - .write_aai = default_spi_write_aai, - .shutdown = ene_leave_flash_mode, -}; - -static int check_params(void) -{ - int ret = 0; - char *const p = extract_programmer_param("type"); - if (p && strcmp(p, "ec")) { - msg_pdbg("ene_lpc only supports \"ec\" type devices\n"); - ret = 1; - } - - free(p); - return ret; -} - -static int ene_lpc_init() -{ - uint8_t hwver, ediid, i; - ene_lpc_data_t *ctx_data = NULL; - - msg_pdbg("%s\n", __func__); - - ctx_data = calloc(1, sizeof(ene_lpc_data_t)); - if (!ctx_data) { - msg_perr("Unable to allocate space for extra context data.\n"); - return 1; - } - ctx_data->ec_state = EC_STATE_NORMAL; - - if (check_params()) - goto init_err_exit; - - for (i = 0; i < ENE_LAST; ++i) { - ctx_data->chip = &ene_chips[i]; - - hwver = ene_read(ctx_data->chip, REG_EC_HWVER); - ediid = ene_read(ctx_data->chip, REG_EC_EDIID); - - if(hwver == ene_chips[i].hwver && - ediid == ene_chips[i].ediid) { - break; - } - } - - if (i == ENE_LAST) { - msg_pdbg("ENE EC not found (probe failed)\n"); - goto init_err_exit; - } - - /* TODO: probe the EC stop protocol - * - * Compal - ec_command(0x41, 0xa1) returns 43 4f 4d 50 41 4c 9c - */ - - ene_enter_flash_mode(ctx_data); - - internal_buses_supported |= BUS_LPC; - - return register_spi_master(&spi_master_ene, ctx_data); - -init_err_exit: - free(ctx_data); - return 1; -} - -const struct programmer_entry programmer_ene_lpc = { - .name = "ene_lpc", - .type = OTHER, - .devs.note = "ENE LPC interface keyboard controller\n", - .init = ene_lpc_init, - .map_flash_region = fallback_map, - .unmap_flash_region = fallback_unmap, - .delay = internal_delay, -}; - -#endif /* __i386__ || __x86_64__ */ diff --git a/meson.build b/meson.build index 6ebf3dc..f08ec24 100644 --- a/meson.build +++ b/meson.build @@ -41,7 +41,6 @@ config_jlink_spi = get_option('config_jlink_spi') config_drkaiser = get_option('config_drkaiser') config_dummy = get_option('config_dummy') -config_ene_lpc = get_option('config_ene_lpc') config_ft2232_spi = get_option('config_ft2232_spi') config_gfxnvidia = get_option('config_gfxnvidia') config_raiden_debug_spi = get_option('config_raiden_debug_spi') @@ -213,10 +212,6 @@ cargs += '-DCONFIG_INTERNAL_DMI=1' endif endif -if config_ene_lpc - srcs += 'ene_lpc.c' - cargs += '-DCONFIG_ENE_LPC=1' -endif if config_it8212 srcs += 'it8212.c' cargs += '-DCONFIG_IT8212=1' diff --git a/meson_options.txt b/meson_options.txt index 86a38c8..fa0c90a 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -15,7 +15,6 @@ option('config_jlink_spi', type : 'boolean', value : false, description : 'SEGGER J-Link and compatible devices') option('config_drkaiser', type : 'boolean', value : true, description : 'Dr. Kaiser') option('config_dummy', type : 'boolean', value : true, description : 'dummy tracing') -option('config_ene_lpc', type : 'boolean', value : true, description : 'ENE LPC interface keyboard controller') option('config_ft2232_spi', type : 'boolean', value : true, description : 'FT2232 SPI dongles') option('config_gfxnvidia', type : 'boolean', value : true, description : 'NVIDIA graphics cards') option('config_raiden_debug_spi', type : 'boolean', value : true, description : 'ChromiumOS Servo DUT debug board') diff --git a/programmer.h b/programmer.h index 982343a..b175b51 100644 --- a/programmer.h +++ b/programmer.h @@ -68,7 +68,6 @@ extern const struct programmer_entry programmer_digilent_spi; extern const struct programmer_entry programmer_drkaiser; extern const struct programmer_entry programmer_dummy; -extern const struct programmer_entry programmer_ene_lpc; extern const struct programmer_entry programmer_ft2232_spi; extern const struct programmer_entry programmer_gfxnvidia; extern const struct programmer_entry programmer_internal; diff --git a/programmer_table.c b/programmer_table.c index 6eb6b77..feaa73d 100644 --- a/programmer_table.c +++ b/programmer_table.c @@ -92,10 +92,6 @@ &programmer_developerbox, #endif -#if CONFIG_ENE_LPC == 1 - &programmer_ene_lpc, -#endif - #if CONFIG_RAYER_SPI == 1 &programmer_rayer_spi, #endif diff --git a/tests/init_shutdown.c b/tests/init_shutdown.c index 3236b22..d5c951b 100644 --- a/tests/init_shutdown.c +++ b/tests/init_shutdown.c @@ -134,69 +134,6 @@ #endif } -struct ene_lpc_io_state { - unsigned char outb_val; - int pause_cmd; -}; - -void ene_lpc_outb_kb932(void *state, unsigned char value, unsigned short port) -{ - struct ene_lpc_io_state *io_state = state; - - io_state->outb_val = value; - if (value == 0x59 /* ENE_KB932.ec_pause_cmd */) - io_state->pause_cmd = 1; -} - -unsigned char ene_lpc_inb_kb932(void *state, unsigned short port) -{ - struct ene_lpc_io_state *io_state = state; - unsigned char ene_hwver_offset = 0; /* REG_EC_HWVER & 0xff */ - unsigned char ene_ediid_offset = 0x24; /* REG_EC_EDIID & 0xff */ - unsigned char ec_status_buf_offset = 0x54; /* ENE_KB932.ec_status_buf & 0xff */ - - if (port == 0xfd63 /* ENE_KB932.port_io_base + port_ene_data */) { - if (io_state->outb_val == ene_hwver_offset) - return 0xa2; /* ENE_KB932.hwver */ - if (io_state->outb_val == ene_ediid_offset) - return 0x02; /* ENE_KB932.ediid */ - if (io_state->outb_val == ec_status_buf_offset) { - if (io_state->pause_cmd == 1) { - io_state->pause_cmd = 0; - return 0x33; /* ENE_KB932.ec_is_pausing mask */ - } else { - return 0x00; /* ENE_KB932.ec_is_running mask */ - } - } - } - - return 0; -} - -void ene_lpc_init_and_shutdown_test_success(void **state) -{ -#if CONFIG_ENE_LPC == 1 - /* - * Current implementation tests for chip ENE_KB932. - * Another chip which is not tested here is ENE_KB94X. - */ - struct ene_lpc_io_state ene_lpc_io_state = { 0, 0 }; - const struct io_mock ene_lpc_io = { - .state = &ene_lpc_io_state, - .outb = ene_lpc_outb_kb932, - .inb = ene_lpc_inb_kb932, - }; - - io_mock_register(&ene_lpc_io); - - run_lifecycle(state, &programmer_ene_lpc, ""); - - io_mock_register(NULL); -#else - skip(); -#endif -} - struct linux_mtd_io_state { char *fopen_path; }; diff --git a/tests/tests.c b/tests/tests.c index 4965fe1..0611f6e 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -339,7 +339,6 @@ cmocka_unit_test(mec1308_init_and_shutdown_test_success), cmocka_unit_test(nicrealtek_init_and_shutdown_test_success), cmocka_unit_test(dediprog_init_and_shutdown_test_success), - cmocka_unit_test(ene_lpc_init_and_shutdown_test_success), cmocka_unit_test(linux_mtd_init_and_shutdown_test_success), cmocka_unit_test(linux_spi_init_and_shutdown_test_success), cmocka_unit_test(realtek_mst_init_and_shutdown_test_success), diff --git a/tests/tests.h b/tests/tests.h index df4a41c..ef7a399 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -45,7 +45,6 @@ void mec1308_init_and_shutdown_test_success(void **state); void nicrealtek_init_and_shutdown_test_success(void **state); void dediprog_init_and_shutdown_test_success(void **state); -void ene_lpc_init_and_shutdown_test_success(void **state); void linux_mtd_init_and_shutdown_test_success(void **state); void linux_spi_init_and_shutdown_test_success(void **state); void realtek_mst_init_and_shutdown_test_success(void **state); -- To view, visit https://review.coreboot.org/c/flashrom/+/56475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b Gerrit-Change-Number: 56475 Gerrit-PatchSet: 4 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: mec1308: remove MEC1308 EC programmer
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Victor Ding, Matt DeVillier, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56476 ) Change subject: mec1308: remove MEC1308 EC programmer ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I535b6380846734c999474519e9e60a73eb6a2ec4 Gerrit-Change-Number: 56476 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 22 Sep 2021 13:19:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ene_lpc: remove ENE LPC programmer
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Mike Banon, Victor Ding, Matt DeVillier, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Anastasia Klimchuk, Iru Cai, Alexandru Gagniuc. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56475 ) Change subject: ene_lpc: remove ENE LPC programmer ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/56475/comment/5cb8ea6f_9a414df4 PS1, Line 10: reached Auto Update Expiration (AUE) a.k.a. end-of-life. > So, what's the problem with testing this, actually? I can test on an Acer ES1-572 with KB9022. […] Not only a matter of testing as the code was merged broken. If somebody gets it working again, I'd be happy to review. Going to apply the reverts now as there is conflicting cleanup work. -- To view, visit https://review.coreboot.org/c/flashrom/+/56475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b Gerrit-Change-Number: 56475 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Sep 2021 13:19:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Victor Ding <victording(a)google.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Add explicit checks for all chipsets
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Michał Żygowski, Jonathan Zhang, David Hendricks, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 ) Change subject: ich_descriptors: Add explicit checks for all chipsets ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/57793/comment/2e2a978a_2fffe480 PS1, Line 9: CB:55651 Please reference merged commits by their commit hash, e.g. commit cd9b7b427 (ich_descriptors: Normalize chipset detection) This way, one doesn't need Gerrit or a manual search to find it. File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57793/comment/3f291eb1_b1cd7cb7 PS1, Line 962: warn_peculiar_desc(content->ICCRIBA > 0x34, "C620 series"); Another case, https://review.coreboot.org/c/flashrom/+/57793/comment/ef44f561_a562c5d0 PS1, Line 965: warn_peculiar_desc(content->ICCRIBA != 0x31, "100 series"); and another one. Basically, if there is an expression given as the first argument to warn_peculiar_desc(), it's an explicit `if` missing. When these arguments are all `true`, we won't need the `warn_if` parameter anymore. -- To view, visit https://review.coreboot.org/c/flashrom/+/57793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f Gerrit-Change-Number: 57793 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Sep 2021 13:10:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API
by Nico Huber (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Michał Żygowski, Angel Pons, Michael Niewöhner, Sergii Dmytruk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 ) Change subject: acpi_ec: Implement basic ACPI embedded controller API ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: Look good enough to me now. However, some remarks: I'm really not a fan of avoidable timeouts. I don't mean the code handling them, but the fact that we risk to run into a timeout. When, for instance, for one command waiting 100ms is enough but for another we'd want to wait 300ms, what harm would be done if we always wait 500ms? Of course there are limits; we don't want a user to become impatient. This is why I came up with two classes of timeouts: 1. those we just check to ensure that a program terminates gracefully; 2. those that we actually handle and know how to recover and see a chance to continue. In the former case we usually want to avoid the timeout at all costs but bail out if we hit it just once. Thus, the timeout can and should be very long. 1, 2, 3 full seconds, it wouldn't hurt. For the second class of timeouts, we might hit it more than once, we should find a trade-off between functionality and responsiveness. Looking at other implementations I've notice that even coreboot's are slightly more complex. Those wait for 10us between reads of the status register. This brings the timeout numbers closer to realtime. But it might also matter for the EC. Imagine, for instance, an implementation where every status read triggers an interrupt in the controller. In a polling loop like the one implemented here, the controller might get stalled answering those interrupts, leaving less processing time to do the work we are waiting for. -- To view, visit https://review.coreboot.org/c/flashrom/+/55714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d Gerrit-Change-Number: 55714 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 22 Sep 2021 10:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Add Ids for recent Intel chipsets
by Selma Bensaid (Code Review) 22 Sep '21

22 Sep '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons. Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57560 ) Change subject: chipset_enable.c: Add Ids for recent Intel chipsets ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/57560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iff387076567e639485ac15c25c1bcc8c37a07037 Gerrit-Change-Number: 57560 Gerrit-PatchSet: 7 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Sep 2021 05:28:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] [WIP] ft2232_spi: reintroduce generic GPIOL control
by Alan Green (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner. Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 ) Change subject: [RFC] [WIP] ft2232_spi: reintroduce generic GPIOL control ...................................................................... Patch Set 4: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/57810/comment/7f83baa5_352bd8d0 PS2, Line 22: : TODOs: : - discuss merging `csgpiol` into `gpiol` as 'C' (see RFC comment) : - reword commit message : - man page for both `csgpiol`, `gpiol` : > TODOs Thank you for being thorough about this! Commit Message: https://review.coreboot.org/c/flashrom/+/57810/comment/20a01611_b147c4bb PS4, Line 20: In the event that : both arguments are specified, gpiol is used. This paragraph is also the original commit message, right? Patchset: PS4: This is a thoughtful proposal. Thank you! File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57810/comment/ce3a1449_9c765e4c PS2, Line 530: /* * * * * * * * * * * * * * * * * * * * * * * * * * * : * REQUEST FOR COMMENTS: 'C' could replace `csgpiol` * : * * * * * * * * * * * * * * * * * * * * * * * * * * */ : case 'C': : cs_bits |= 1 << gpiol_pin; : pindir |= 1 << gpiol_pin; : break; : > RFC: 'C' could replace `csgpiol` […] I like it. File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57810/comment/d48e6ef4_334c0266 PS4, Line 90: * The variables `cs_bits` and `pindir` store the values for the : * "set data bits low byte" MPSSE command that sets the initial : * state and the direction of the I/O pins. `cs_bits` pins default : * to high and will be toggled during SPI transactions. All other : * output pins will be kept low all the time. GPIOL* pins are : * configured as inputs, while it's possible to use one of them as : * additional CS# signal through the parameter `csgpiol`. On exit, : * all pins will be reconfigured as inputs Reminder: this comment will need updating. -- To view, visit https://review.coreboot.org/c/flashrom/+/57810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a Gerrit-Change-Number: 57810 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 21 Sep 2021 19:57:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] [WIP] ft2232_spi: reintroduce generic GPIOL control
by Michael Niewöhner (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Felix Singer, Alan Green, Nico Huber, Angel Pons. Hello Felix Singer, Alan Green, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57810 to look at the new patch set (#4). Change subject: [RFC] [WIP] ft2232_spi: reintroduce generic GPIOL control ...................................................................... [RFC] [WIP] ft2232_spi: reintroduce generic GPIOL control This reintroduces a reworked version of the GPIOL pin control first introduced in commit 3207844 (CB:49637), which was reverted in commit 6518cf3 (CB:55692). Original commit message (will be reworked/corrected later): Adds a new arg "gpiol" to allow the four FT2232 GPIOL pins to be set to any combination of high, low or high-impedance. The existing arg "csgpiol", is intended to function as an additional "cs" signal, allowing pins to be set high but not low. This patch preserves the csgpiol arg for backward compatibility. In the event that both arguments are specified, gpiol is used. TODOs: - discuss merging `csgpiol` into `gpiol` as 'C' (see RFC comment) - reword commit message - man page for both `csgpiol`, `gpiol` Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a Signed-off-by: Alan Green <avg(a)google.com> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M ft2232_spi.c 1 file changed, 76 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/57810/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/57810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a Gerrit-Change-Number: 57810 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: remove compile guards
by Michael Niewöhner (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Paul Menzel. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57797 ) Change subject: remove compile guards ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: +2 but give others a chance -- To view, visit https://review.coreboot.org/c/flashrom/+/57797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76a76e05c7a7dd27637325ab1e9d8946fd5f9076 Gerrit-Change-Number: 57797 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Sep 2021 18:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8: replace `svn changelog` with `git history`
by Michael Niewöhner (Code Review) 21 Sep '21

21 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57811 ) Change subject: flashrom.8: replace `svn changelog` with `git history` ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/57811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If8659dd603cbabdb8e20d89f818072986373e24f Gerrit-Change-Number: 57811 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Sep 2021 18:16:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021