September 2021 - flashrom-gerrit

Change in flashrom[master]: os.h: remove unneeded include
by Angel Pons (Code Review) 27 Sep '21

27 Sep '21

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/57936 ) Change subject: os.h: remove unneeded include ...................................................................... os.h: remove unneeded include No symbol from platform.h is used in os.h Change-Id: Ia8f463ab8f9f064fe79f5ee0840b851ae497a080 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/57936 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M os.h 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/os.h b/os.h index ddfa46b..d6fbfe0 100644 --- a/os.h +++ b/os.h @@ -17,8 +17,6 @@ * Header file for OS checking. */ -#include "platform.h" - // Solaris #if defined (__sun) && (defined(__i386) || defined(__amd64)) #define __FLASHROM_OS__ "SunOS" -- To view, visit https://review.coreboot.org/c/flashrom/+/57936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia8f463ab8f9f064fe79f5ee0840b851ae497a080 Gerrit-Change-Number: 57936 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: ft2232_spi.c: change the chunksize to 280
by Simon Buhrow (Code Review) 27 Sep '21

27 Sep '21

Simon Buhrow has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/43282 ) Change subject: ft2232_spi.c: change the chunksize to 280 ...................................................................... ft2232_spi.c: change the chunksize to 280 Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> Change-Id: I5e096937834fc8fc8623c8c59ade529de081b72a --- M ft2232_spi.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/43282/1 diff --git a/ft2232_spi.c b/ft2232_spi.c index 0799af4..0a8d631 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -398,7 +398,18 @@ msg_perr("Unable to set latency timer (%s).\n", ftdi_get_error_string(ftdic)); } - if (ftdi_write_data_set_chunksize(ftdic, 270)) { + if (ftdi_write_data_set_chunksize(ftdic, 280)) { + /* + * 280 bytes = + * + 9 B (CMD) + * + 1 B (WREN) + * + 9 B (CMD) + * + 1 B (op) + * + 4 B (addr) + * + 256 B (page data) + * + * With op: PageProgram or Erase; CMD: FTDI-Chip commands + */ msg_perr("Unable to set chunk size (%s).\n", ftdi_get_error_string(ftdic)); } -- To view, visit https://review.coreboot.org/c/flashrom/+/43282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5e096937834fc8fc8623c8c59ade529de081b72a Gerrit-Change-Number: 43282 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-MessageType: newchange

4 17

Change in flashrom[master]: raiden_debug_spi: Use new API to register shutdown function
by Anastasia Klimchuk (Code Review) 27 Sep '21

27 Sep '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57975 ) Change subject: raiden_debug_spi: Use new API to register shutdown function ...................................................................... raiden_debug_spi: Use new API to register shutdown function This allows programmer to register shutdown function in spi_master struct, which means there is no need to call register_shutdown in init function, since this call is now a part of register_spi_master. As a consequence of using new API, two things are happening here: 1) No resource leakage anymore in case register_shutdown() would fail, 2) Fixed propagation of register_spi_master() return values. TRY TO TEST ME ON HW BUG=b:185191942 TEST=test in CB:57918 Change-Id: I8927224779f24d1fda088991337e54d7272775a6 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M raiden_debug_spi.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/57975/1 diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 40090f2..d9ca565 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -1298,6 +1298,7 @@ .read = default_spi_read, .write_256 = default_spi_write_256, .write_aai = default_spi_write_aai, + .shutdown = raiden_debug_spi_shutdown, }; static int match_endpoint(struct libusb_endpoint_descriptor const *descriptor, @@ -1613,10 +1614,7 @@ return SPI_GENERIC_ERROR; } - register_spi_master(spi_config, data); - register_shutdown(raiden_debug_spi_shutdown, data); - - return 0; + return register_spi_master(spi_config, data); } const struct programmer_entry programmer_raiden_debug_spi = { -- To view, visit https://review.coreboot.org/c/flashrom/+/57975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8927224779f24d1fda088991337e54d7272775a6 Gerrit-Change-Number: 57975 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: raiden_debug_spi: Move shutdown function above spi_master struct
by Anastasia Klimchuk (Code Review) 27 Sep '21

27 Sep '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57974 ) Change subject: raiden_debug_spi: Move shutdown function above spi_master struct ...................................................................... raiden_debug_spi: Move shutdown function above spi_master struct This patch prepares the programmer to use new API which allows to register shutdown function in spi_master struct. See also later patch in this chain, where the programmer is converted to new API. BUG=b:185191942 TEST=test in CB:57918 Change-Id: I567e24c9d39e24a4a1634ddcbdd05930760afcdc Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M raiden_debug_spi.c 1 file changed, 31 insertions(+), 31 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/57974/1 diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index d783fef..40090f2 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -1258,6 +1258,37 @@ return status; } +static int raiden_debug_spi_shutdown(void * data) +{ + struct raiden_debug_spi_data *ctx_data = (struct raiden_debug_spi_data *)data; + struct spi_master *spi_config = ctx_data->spi_config; + + int ret = LIBUSB(libusb_control_transfer( + ctx_data->dev->handle, + LIBUSB_ENDPOINT_OUT | + LIBUSB_REQUEST_TYPE_VENDOR | + LIBUSB_RECIPIENT_INTERFACE, + RAIDEN_DEBUG_SPI_REQ_DISABLE, + 0, + ctx_data->dev->interface_descriptor->bInterfaceNumber, + NULL, + 0, + TRANSFER_TIMEOUT_MS)); + if (ret != 0) { + msg_perr("Raiden: Failed to disable SPI bridge\n"); + free(ctx_data); + free(spi_config); + return ret; + } + + usb_device_free(ctx_data->dev); + libusb_exit(NULL); + free(ctx_data); + free(spi_config); + + return 0; +} + static const struct spi_master spi_master_raiden_debug = { .features = SPI_MASTER_4BA, .max_data_read = 0, @@ -1377,37 +1408,6 @@ return 0; } -static int raiden_debug_spi_shutdown(void * data) -{ - struct raiden_debug_spi_data *ctx_data = (struct raiden_debug_spi_data *)data; - struct spi_master *spi_config = ctx_data->spi_config; - - int ret = LIBUSB(libusb_control_transfer( - ctx_data->dev->handle, - LIBUSB_ENDPOINT_OUT | - LIBUSB_REQUEST_TYPE_VENDOR | - LIBUSB_RECIPIENT_INTERFACE, - RAIDEN_DEBUG_SPI_REQ_DISABLE, - 0, - ctx_data->dev->interface_descriptor->bInterfaceNumber, - NULL, - 0, - TRANSFER_TIMEOUT_MS)); - if (ret != 0) { - msg_perr("Raiden: Failed to disable SPI bridge\n"); - free(ctx_data); - free(spi_config); - return ret; - } - - usb_device_free(ctx_data->dev); - libusb_exit(NULL); - free(ctx_data); - free(spi_config); - - return 0; -} - static int get_ap_request_type(void) { int ap_request = RAIDEN_DEBUG_SPI_REQ_ENABLE_AP; -- To view, visit https://review.coreboot.org/c/flashrom/+/57974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I567e24c9d39e24a4a1634ddcbdd05930760afcdc Gerrit-Change-Number: 57974 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: raiden_debug_spi: Use spi data in configure_protocol
by Anastasia Klimchuk (Code Review) 27 Sep '21

27 Sep '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57973 ) Change subject: raiden_debug_spi: Use spi data in configure_protocol ...................................................................... raiden_debug_spi: Use spi data in configure_protocol Spi data for this programmer now contains pointer to spi_master struct, and can be used in configure_protocol. This patch is making init code of raiden_debug_spi a bit more consistent with other programmers. BUG=b:185191942 TEST=test in CB:57918 Change-Id: I5df0609efcd1fdb274b8cc84536253d5dbae5270 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M raiden_debug_spi.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/57973/1 diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 9cba2a8..d783fef 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -1317,15 +1317,16 @@ * is being used by the device USB SPI interface and if needed query the * device for its capabilities. * - * @param spi_config Raiden SPI config which will be modified. + * @param data Raiden SPI data, data contains pointer to config which will be modified. * - * @returns Returns status code with 0 on success. + * @returns Returns status code with 0 on success. */ -static int configure_protocol(struct spi_master *spi_config) +static int configure_protocol(struct raiden_debug_spi_data *data) { int status = 0; struct raiden_debug_spi_data *ctx_data = - (struct raiden_debug_spi_data *)spi_config->data; + (struct raiden_debug_spi_data *)data; + struct spi_master *spi_config = ctx_data->spi_config; ctx_data->protocol_version = ctx_data->dev->interface_descriptor->bInterfaceProtocol; @@ -1596,13 +1597,12 @@ data->out_ep = out_endpoint; data->spi_config = spi_config; - spi_config->data = data; /* data is needed to configure protocol below */ /* * The SPI master needs to be configured based on the device connected. * Using the device protocol interrogation, we will set the limits on * the write and read sizes and switch command functions. */ - ret = configure_protocol(spi_config); + ret = configure_protocol(data); if (ret) { msg_perr("Raiden: Error configuring protocol\n" " protocol = %u\n" -- To view, visit https://review.coreboot.org/c/flashrom/+/57973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5df0609efcd1fdb274b8cc84536253d5dbae5270 Gerrit-Change-Number: 57973 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: raiden_debug_spi: Link spi_master struct to spi data
by Anastasia Klimchuk (Code Review) 27 Sep '21

27 Sep '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57972 ) Change subject: raiden_debug_spi: Link spi_master struct to spi data ...................................................................... raiden_debug_spi: Link spi_master struct to spi data For this programmer, spi_master struct is dynamically allocated and needs to be freed on shutdown. Adding a pointer to spi data struct allows to link spi_master from spi data, which in turn allows to pass spi data into shutdown function. As a result, both register_spi_master and register_shutdown use the same data, and this unblocks moving raiden_debug_spi to new API (like all the other spi masters in commit a69c5196d20d136b1de120f0fa5ea1e06c3776da). See further patches in this chain. BUG=b:185191942 TEST=test in CB:57918 Change-Id: I5400802aa6961538df12fcd5339f7e2a5db145a1 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M raiden_debug_spi.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/57972/1 diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 92779fc..9cba2a8 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -441,6 +441,7 @@ */ uint16_t max_spi_write_count; uint16_t max_spi_read_count; + struct spi_master *spi_config; }; /* * USB permits a maximum bulk transfer of 64B. @@ -1377,9 +1378,8 @@ static int raiden_debug_spi_shutdown(void * data) { - struct spi_master *spi_config = data; - struct raiden_debug_spi_data *ctx_data = - (struct raiden_debug_spi_data *)spi_config->data; + struct raiden_debug_spi_data *ctx_data = (struct raiden_debug_spi_data *)data; + struct spi_master *spi_config = ctx_data->spi_config; int ret = LIBUSB(libusb_control_transfer( ctx_data->dev->handle, @@ -1594,6 +1594,7 @@ data->dev = device; data->in_ep = in_endpoint; data->out_ep = out_endpoint; + data->spi_config = spi_config; spi_config->data = data; /* data is needed to configure protocol below */ /* @@ -1613,7 +1614,7 @@ } register_spi_master(spi_config, data); - register_shutdown(raiden_debug_spi_shutdown, spi_config); + register_shutdown(raiden_debug_spi_shutdown, data); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/57972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5400802aa6961538df12fcd5339f7e2a5db145a1 Gerrit-Change-Number: 57972 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE
by Anastasia Klimchuk (Code Review) 26 Sep '21

26 Sep '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57269 ) Change subject: tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > Generally, if there is hope that it is fixed, one can just hit the rebase […] it works thank you! my chain is now all green :) -- To view, visit https://review.coreboot.org/c/flashrom/+/57269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ad6ee4aa9091447c6c9108c92bf7f6e755fca48 Gerrit-Change-Number: 57269 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 26 Sep 2021 23:51:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Add explicit checks for all chipsets
by David Hendricks (Code Review) 26 Sep '21

26 Sep '21

Attention is currently required from: Nico Huber, Michał Żygowski, Jonathan Zhang, Angel Pons. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 ) Change subject: ich_descriptors: Add explicit checks for all chipsets ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/57793/comment/9d7aa624_a574e8a4 PS3, Line 10: A new chipset : was added that necessitated adding back a check for an older : chipset. > That's not accurate. It was the way that the new check was written […] I've reworded this to focus on what's being done in this patch. If somebody wants more context they can easily find it in the commit mentioned in the previous sentence. File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57793/comment/badc142e_6d1f4a48 PS1, Line 968: if (content->ICCRIBA != 0x34) : msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n"); > This one had a different message. "Unknown flash descriptor, assuming 300 series compatibility" and "Peculiar flash descriptor, assuming 300 series compatibility" mean the same thing. Both are msg_pwarn(), too. Regardless, this is not worth splitting hairs so I've reverted back to using msg_pwarn() since you seem to prefer it that way. -- To view, visit https://review.coreboot.org/c/flashrom/+/57793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f Gerrit-Change-Number: 57793 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 26 Sep 2021 21:15:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Add explicit checks for all chipsets
by David Hendricks (Code Review) 26 Sep '21

26 Sep '21

Attention is currently required from: Michał Żygowski, Jonathan Zhang, David Hendricks, Angel Pons. Hello build bot (Jenkins), Michał Żygowski, Jonathan Zhang, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57793 to look at the new patch set (#4). Change subject: ich_descriptors: Add explicit checks for all chipsets ...................................................................... ich_descriptors: Add explicit checks for all chipsets This partially undoes changes made in commit cd9b7b427 (ich_descriptors: Normalize chipset detection) to re-add explicit matching of each chipset with one or more strap length values. Since ranges are checked explicitly, the `warn_if` parameter to warn_peculiar_desc() is no longer necessary and is removed. Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f Signed-off-by: David Hendricks <ddaveh(a)amazon.com> --- M ich_descriptors.c 1 file changed, 19 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/57793/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/57793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f Gerrit-Change-Number: 57793 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ft2232_spi: prevent use of reserved pins on some programmers
by Michael Niewöhner (Code Review) 26 Sep '21

26 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57809 ) Change subject: ft2232_spi: prevent use of reserved pins on some programmers ...................................................................... Patch Set 7: (1 comment) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57809/comment/278b810d_c2cf60d1 PS6, Line 424: resered > reser*v*ed Done -- To view, visit https://review.coreboot.org/c/flashrom/+/57809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied450fa5ef358153adefec3beabc63a62c9f60cd Gerrit-Change-Number: 57809 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 26 Sep 2021 19:22:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021