September 2021 - flashrom-gerrit

Change in flashrom[master]: ft2232_spi: prevent use of reserved pins on some programmers
by Michael Niewöhner (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57809 to look at the new patch set (#8). Change subject: ft2232_spi: prevent use of reserved pins on some programmers ...................................................................... ft2232_spi: prevent use of reserved pins on some programmers On some programmers an output buffer needs to be enabled by pulling a gpio high/low. This gpio can not be used for `csgpiol`. Prevent this by printing an error. Change-Id: Ied450fa5ef358153adefec3beabc63a62c9f60cd Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M ft2232_spi.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/57809/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/57809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied450fa5ef358153adefec3beabc63a62c9f60cd Gerrit-Change-Number: 57809 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: move functions and macros to own file
by Thomas Heijligen (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57935 ) Change subject: Makefile: move functions and macros to own file ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57935/comment/5a0c1321_9ac9aa04 PS1, Line 9: Moving > Use imperative mood: `Move` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/57935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I451f2eeab2773982e02b2f2fdc9e8abe1cc87630 Gerrit-Change-Number: 57935 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 27 Sep 2021 10:20:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move functions and macros to own file
by Thomas Heijligen (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57935 to look at the new patch set (#2). Change subject: Makefile: move functions and macros to own file ...................................................................... Makefile: move functions and macros to own file Move all define statements in its own file to tidy up the main Makefile. Change-Id: I451f2eeab2773982e02b2f2fdc9e8abe1cc87630 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile A Makefile.include 2 files changed, 215 insertions(+), 197 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/57935/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I451f2eeab2773982e02b2f2fdc9e8abe1cc87630 Gerrit-Change-Number: 57935 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: raiden_debug_spi: Move shutdown function above spi_master struct
by Anastasia Klimchuk (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57974 ) Change subject: raiden_debug_spi: Move shutdown function above spi_master struct ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: One thing that I don't understand: why this change results in binary diffs? I was looking into this some time ago, and comparing objdump -d gives a difference in one mov instruction in raiden_debug_spi_shutdown section. I will look once again, why the diff is produced. Leaving the comment unresolved. -- To view, visit https://review.coreboot.org/c/flashrom/+/57974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I567e24c9d39e24a4a1634ddcbdd05930760afcdc Gerrit-Change-Number: 57974 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 27 Sep 2021 10:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: reintroduce generic GPIOL control
by Angel Pons (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 ) Change subject: ft2232_spi: reintroduce generic GPIOL control ...................................................................... Patch Set 17: Code-Review+1 (4 comments) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/57810/comment/60592f80_b44e96a2 PS17, Line 493: unsigned int pin = temp + 4; Is this change intentional? https://review.coreboot.org/c/flashrom/+/57810/comment/c1e9b64b_19f9a517 PS17, Line 503: pindir |= 1 << pin; Is this change intentional? https://review.coreboot.org/c/flashrom/+/57810/comment/57ff1b54_1647e1b5 PS17, Line 524: int Why not `uint8_t`? https://review.coreboot.org/c/flashrom/+/57810/comment/5a9c7db5_f8ea4dda PS17, Line 526: %i Out of curiosity, why use `%i` here and `%d` in `snprintf()`? -- To view, visit https://review.coreboot.org/c/flashrom/+/57810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a Gerrit-Change-Number: 57810 Gerrit-PatchSet: 17 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 27 Sep 2021 09:57:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8: carve out `csgpiol` into its own section
by Angel Pons (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57893 ) Change subject: flashrom.8: carve out `csgpiol` into its own section ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/57893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic7379331d36b3068eacde5a983b4ccb3afc56c51 Gerrit-Change-Number: 57893 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 27 Sep 2021 09:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: prevent use of reserved pins on some programmers
by Angel Pons (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57809 ) Change subject: ft2232_spi: prevent use of reserved pins on some programmers ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57809/comment/2c403541_a6c776d2 PS7, Line 9: a nit: `an` -- To view, visit https://review.coreboot.org/c/flashrom/+/57809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied450fa5ef358153adefec3beabc63a62c9f60cd Gerrit-Change-Number: 57809 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 27 Sep 2021 09:50:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Remove preprocessor closing comments
by Angel Pons (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57800 ) Change subject: Remove preprocessor closing comments ...................................................................... Patch Set 2: -Code-Review (1 comment) Patchset: PS2: > There was at least one case where I had to ask Gerrit for additional […] Same -- To view, visit https://review.coreboot.org/c/flashrom/+/57800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74288afde108e764adc651039aae81857abffedf Gerrit-Change-Number: 57800 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 27 Sep 2021 09:47:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: internal.c: unify the macro for x86 only code
by Angel Pons (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57942 ) Change subject: internal.c: unify the macro for x86 only code ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/57942/comment/10b4a04c_41014f63 PS1, Line 9: \#if defined(__i386__) || defined(__x86_64__) nit: To avoid having to escape the `#`, how about: The #if defined(__i386__) || defined(__x86_64__) guard is commonly used for ... https://review.coreboot.org/c/flashrom/+/57942/comment/70a7f80f_bb9226cf PS1, Line 11: uses plural: `use` https://review.coreboot.org/c/flashrom/+/57942/comment/eb8b356c_c9b44a6a PS1, Line 11: platfrom typo: `platform` Patchset: PS1: I'd personally use the IS_X86 macro everywhere for consistency, but I don't have a strong preference. -- To view, visit https://review.coreboot.org/c/flashrom/+/57942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I94a599431f58666189c8cd601286e9b30c8bf62b Gerrit-Change-Number: 57942 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 27 Sep 2021 09:45:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move functions and macros to own file
by Angel Pons (Code Review) 27 Sep '21

27 Sep '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57935 ) Change subject: Makefile: move functions and macros to own file ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57935/comment/e414f97f_2ea15d69 PS1, Line 9: Moving Use imperative mood: `Move` -- To view, visit https://review.coreboot.org/c/flashrom/+/57935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I451f2eeab2773982e02b2f2fdc9e8abe1cc87630 Gerrit-Change-Number: 57935 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 27 Sep 2021 09:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021