July 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: programmer_table: Remove space between address operator and variable
by Anastasia Klimchuk (Code Review) 21 Jul '21

21 Jul '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56469 ) Change subject: programmer_table: Remove space between address operator and variable ...................................................................... programmer_table: Remove space between address operator and variable BUG=none TEST=builds Change-Id: Iba29b1bc3d77b8c17c51fc0552c129e6965fa308 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M programmer_table.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/56469/1 diff --git a/programmer_table.c b/programmer_table.c index e7f2c98..6eb6b77 100644 --- a/programmer_table.c +++ b/programmer_table.c @@ -33,7 +33,7 @@ #endif #if CONFIG_NICREALTEK == 1 - & programmer_nicrealtek, + &programmer_nicrealtek, #endif #if CONFIG_NICNATSEMI == 1 @@ -173,4 +173,4 @@ #endif }; -const size_t programmer_table_size = ARRAY_SIZE(programmer_table); \ No newline at end of file +const size_t programmer_table_size = ARRAY_SIZE(programmer_table); -- To view, visit https://review.coreboot.org/c/flashrom/+/56469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba29b1bc3d77b8c17c51fc0552c129e6965fa308 Gerrit-Change-Number: 56469 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: programmer.h: Minor tidy up
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56466 to look at the new patch set (#2). Change subject: programmer.h: Minor tidy up ...................................................................... programmer.h: Minor tidy up Align comments and #ifdef terminations to be clear. BUG=none BRANCH=none TEST=builds Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M programmer.h 1 file changed, 29 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/56466/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77 Gerrit-Change-Number: 56466 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer.h: Allow compilation without dummyflasher
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Namyoon Woo, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56467 to look at the new patch set (#2). Change subject: programmer.h: Allow compilation without dummyflasher ...................................................................... programmer.h: Allow compilation without dummyflasher Fix a regression introduced when variable sized chips was added to dummyflasher that prevented flashrom from compiling without dummyflasher. The purposed solution is neither ideal nor egregious however there is no clear way to handle this specialiation of the probe function pointer. BUG=none BRANCH=none TEST=builds Change-Id: I5d1d42628519861c9cd28c96d5c49fa4f6b229ef Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M programmer.h 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/56467/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d1d42628519861c9cd28c96d5c49fa4f6b229ef Gerrit-Change-Number: 56467 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer.h: Allow compilation without dummyflasher
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Nico Huber. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56467 ) Change subject: programmer.h: Allow compilation without dummyflasher ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: never mind, life didn't let me off that easy. -- To view, visit https://review.coreboot.org/c/flashrom/+/56467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d1d42628519861c9cd28c96d5c49fa4f6b229ef Gerrit-Change-Number: 56467 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 21 Jul 2021 01:04:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: Allow compilation without dummyflasher
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Nico Huber. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56467 ) Change subject: programmer.h: Allow compilation without dummyflasher ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d1d42628519861c9cd28c96d5c49fa4f6b229ef Gerrit-Change-Number: 56467 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 21 Jul 2021 00:56:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: Allow compilation without dummyflasher
by Namyoon Woo (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Nico Huber, Edward O'Callaghan. Namyoon Woo has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56467 ) Change subject: programmer.h: Allow compilation without dummyflasher ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/56467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d1d42628519861c9cd28c96d5c49fa4f6b229ef Gerrit-Change-Number: 56467 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Jul 2021 00:56:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: Allow compilation without dummyflasher
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56467 ) Change subject: programmer.h: Allow compilation without dummyflasher ...................................................................... programmer.h: Allow compilation without dummyflasher Fix a regression introduced when variable sized chips was added to dummyflasher that prevented flashrom from compiling without dummyflasher. The purposed solution is neither ideal nor egregious however there is no clear way to handle this specialiation of the probe function pointer. BUG=none BRANCH=none TEST=builds Change-Id: I5d1d42628519861c9cd28c96d5c49fa4f6b229ef Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M programmer.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/56467/1 diff --git a/programmer.h b/programmer.h index 61673a8..d1c5ab3 100644 --- a/programmer.h +++ b/programmer.h @@ -211,6 +211,10 @@ void internal_sleep(unsigned int usecs); void internal_delay(unsigned int usecs); +#if CONFIG_DUMMY == 0 +int probe_variable_size(struct flashctx *flash) { return 1; } +#endif + #if CONFIG_INTERNAL == 1 /* board_enable.c */ int selfcheck_board_enables(void); -- To view, visit https://review.coreboot.org/c/flashrom/+/56467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5d1d42628519861c9cd28c96d5c49fa4f6b229ef Gerrit-Change-Number: 56467 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: programmer.h: Minor tidy up
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56466 ) Change subject: programmer.h: Minor tidy up ...................................................................... programmer.h: Minor tidy up Align comments and #ifdef terminations to be clear. BUG=none BRANCH=none TEST=builds Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M programmer.h 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/56466/1 diff --git a/programmer.h b/programmer.h index 95e2cda..61673a8 100644 --- a/programmer.h +++ b/programmer.h @@ -397,8 +397,8 @@ CHIPSET_GEMINI_LAKE, }; -/* ichspi.c */ #if CONFIG_INTERNAL == 1 +/* ichspi.c */ int ich_init_spi(void *spibar, enum ich_chipset ich_generation); int via_init_spi(uint32_t mmio_base); @@ -419,19 +419,17 @@ static inline int try_mtd(void) { return programmer_linux_mtd.init(); }; #else static inline int try_mtd(void) { return 1; }; -#endif +#endif /* CONFIG_LINUX_MTD == 1 */ /* mcp6x_spi.c */ int mcp6x_spi_init(int want_spi); - - /* sb600spi.c */ int sb600_probe_spi(struct pci_dev *dev); /* wbsio_spi.c */ int wbsio_check_for_spi(void); -#endif +#endif /* CONFIG_INTERNAL == 1 */ /* opaque.c */ struct opaque_master { -- To view, visit https://review.coreboot.org/c/flashrom/+/56466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77 Gerrit-Change-Number: 56466 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Trim excessive new lines from layout test output
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56439 ) Change subject: tests: Trim excessive new lines from layout test output ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I36a39505f8db508672cde5a848684a3a22f5ccc4 Gerrit-Change-Number: 56439 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Jul 2021 00:06:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add unit tests for layout sanity checks
by Edward O'Callaghan (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56440 ) Change subject: tests: Add unit tests for layout sanity checks ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia21585d60443b2741f3868d7887476090e35f79b Gerrit-Change-Number: 56440 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Jul 2021 00:06:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2021