July 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: tests: Add unit tests for layout sanity checks
by Edward O'Callaghan (Code Review) 22 Jul '21

22 Jul '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/56440 ) Change subject: tests: Add unit tests for layout sanity checks ...................................................................... tests: Add unit tests for layout sanity checks Three more tests in this patch where layout does / does not pass sanity checks. BUG=b:193584590 TEST=ninja test Change-Id: Ia21585d60443b2741f3868d7887476090e35f79b Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56440 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M tests/layout.c M tests/tests.c M tests/tests.h 3 files changed, 111 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved diff --git a/tests/layout.c b/tests/layout.c index 5f0aee5..59e409b 100644 --- a/tests/layout.c +++ b/tests/layout.c @@ -16,6 +16,7 @@ #include <include/test.h> #include <stdio.h> +#include "flash.h" #include "layout.h" #include "libflashrom.h" @@ -101,3 +102,107 @@ flashrom_layout_release(layout); printf("done\n"); } + +void layout_pass_sanity_checks_test_success(void **state) +{ + (void) state; /* unused */ + + unsigned int region_start = 0x00021000; + unsigned int region_end = 0x00031000; + unsigned int start = 0; + unsigned int len = 0; + + struct flashrom_layout *layout; + + printf("Creating layout with one included region... "); + assert_int_equal(0, flashrom_layout_new(&layout)); + assert_int_equal(0, flashrom_layout_add_region(layout, region_start, region_end, "region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "region")); + printf("done\n"); + + printf("Asserting region range... "); + get_region_range(layout, "region", &start, &len); + assert_int_equal(start, region_start); + assert_int_equal(len, region_end - region_start + 1); + printf("done\n"); + + printf("Layout passes sanity checks... "); + + struct flashchip chip = { + .total_size = 1024, + }; + struct flashrom_flashctx flash = { + .chip = &chip, + }; + flashrom_layout_set(&flash, layout); + assert_int_equal(0, layout_sanity_checks(&flash)); + + printf("done\n"); + + printf("Releasing layout... "); + flashrom_layout_release(layout); + printf("done\n"); +} + +void layout_region_invalid_address_test_success(void **state) +{ + (void) state; /* unused */ + + struct flashrom_layout *layout; + + printf("Creating layout with one included region... "); + assert_int_equal(0, flashrom_layout_new(&layout)); + assert_int_equal(0, flashrom_layout_add_region(layout, 0x60000000, 0x70000000, "region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "region")); + printf("done\n"); + + printf("Layout does not pass sanity checks... "); + + struct flashchip chip = { + /* Make sure layout region addresses exceed total size on chip. */ + .total_size = 1, + }; + struct flashrom_flashctx flash = { + .chip = &chip, + }; + flashrom_layout_set(&flash, layout); + assert_int_equal(1, layout_sanity_checks(&flash)); + + printf("done\n"); + + printf("Releasing layout... "); + flashrom_layout_release(layout); + printf("done\n"); +} + +void layout_region_invalid_range_test_success(void **state) +{ + (void) state; /* unused */ + + struct flashrom_layout *layout; + + printf("Creating layout with one included region... "); + assert_int_equal(0, flashrom_layout_new(&layout)); + /* Make sure address range of region is not positive i.e. start > end. */ + assert_int_equal(0, flashrom_layout_add_region(layout, 0x00000020, 0x00000010, "region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "region")); + printf("done\n"); + + printf("Layout does not pass sanity checks... "); + + struct flashchip chip = { + /* Make sure layout region addresses fit into total size on chip. */ + .total_size = 1024, + }; + struct flashrom_flashctx flash = { + .chip = &chip, + }; + flashrom_layout_set(&flash, layout); + assert_int_equal(1, layout_sanity_checks(&flash)); + + printf("done\n"); + + printf("Releasing layout... "); + flashrom_layout_release(layout); + printf("done\n"); +} diff --git a/tests/tests.c b/tests/tests.c index 78258b0..00c987c 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -240,6 +240,9 @@ cmocka_unit_test(included_regions_dont_overlap_test_success), cmocka_unit_test(included_regions_overlap_test_success), cmocka_unit_test(region_not_included_overlap_test_success), + cmocka_unit_test(layout_pass_sanity_checks_test_success), + cmocka_unit_test(layout_region_invalid_address_test_success), + cmocka_unit_test(layout_region_invalid_range_test_success), }; ret |= cmocka_run_group_tests_name("layout.c tests", layout_tests, NULL, NULL); diff --git a/tests/tests.h b/tests/tests.h index eccc05f..14cfee0 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -51,5 +51,8 @@ void included_regions_dont_overlap_test_success(void **state); void included_regions_overlap_test_success(void **state); void region_not_included_overlap_test_success(void **state); +void layout_pass_sanity_checks_test_success(void **state); +void layout_region_invalid_address_test_success(void **state); +void layout_region_invalid_range_test_success(void **state); #endif /* TESTS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/56440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia21585d60443b2741f3868d7887476090e35f79b Gerrit-Change-Number: 56440 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: tests: Trim excessive new lines from layout test output
by Edward O'Callaghan (Code Review) 22 Jul '21

22 Jul '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/56439 ) Change subject: tests: Trim excessive new lines from layout test output ...................................................................... tests: Trim excessive new lines from layout test output This patch is making layout test output more compact, spanning less vertical lines while logging the same information. No changes made to the test functionality. BUG=b:193584590 TEST=ninja test Change-Id: I36a39505f8db508672cde5a848684a3a22f5ccc4 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56439 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M tests/layout.c 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/tests/layout.c b/tests/layout.c index e3e9539..5f0aee5 100644 --- a/tests/layout.c +++ b/tests/layout.c @@ -23,26 +23,26 @@ { (void) state; /* unused */ - printf("Creating layout...\n"); + printf("Creating layout... "); struct flashrom_layout *layout; assert_int_equal(0, flashrom_layout_new(&layout)); printf("done\n"); - printf("Adding and including first region...\n"); + printf("Adding and including first region... "); assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region")); assert_int_equal(0, flashrom_layout_include_region(layout, "first region")); - printf("done\n"); + printf("done"); - printf("Adding and including second (non-overlapping) region...\n"); + printf(", second (non-overlapping) region... "); assert_int_equal(0, flashrom_layout_add_region(layout, 0x00031001, 0x0023efc0, "second region")); assert_int_equal(0, flashrom_layout_include_region(layout, "second region")); printf("done\n"); - printf("Asserting included regions do not overlap...\n"); + printf("Asserting included regions do not overlap... "); assert_int_equal(0, included_regions_overlap(layout)); printf("done\n"); - printf("Releasing layout...\n"); + printf("Releasing layout... "); flashrom_layout_release(layout); printf("done\n"); } @@ -51,26 +51,26 @@ { (void) state; /* unused */ - printf("Creating layout...\n"); + printf("Creating layout... "); struct flashrom_layout *layout; assert_int_equal(0, flashrom_layout_new(&layout)); printf("done\n"); - printf("Adding and including first region...\n"); + printf("Adding and including first region... "); assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region")); assert_int_equal(0, flashrom_layout_include_region(layout, "first region")); - printf("done\n"); + printf("done"); - printf("Adding and including second (overlapping) region...\n"); + printf(", second (overlapping) region... "); assert_int_equal(0, flashrom_layout_add_region(layout, 0x00027100, 0x0023efc0, "second region")); assert_int_equal(0, flashrom_layout_include_region(layout, "second region")); printf("done\n"); - printf("Asserting included regions overlap...\n"); + printf("Asserting included regions overlap... "); assert_int_equal(1, included_regions_overlap(layout)); printf("done\n"); - printf("Releasing layout...\n"); + printf("Releasing layout... "); flashrom_layout_release(layout); printf("done\n"); } @@ -79,25 +79,25 @@ { (void) state; /* unused */ - printf("Creating layout...\n"); + printf("Creating layout... "); struct flashrom_layout *layout; assert_int_equal(0, flashrom_layout_new(&layout)); printf("done\n"); - printf("Adding and including first region...\n"); + printf("Adding and including first region... "); assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region")); assert_int_equal(0, flashrom_layout_include_region(layout, "first region")); - printf("done\n"); + printf("done"); - printf("Adding second (overlapping) region, not included...\n"); + printf(", second (overlapping) region, not included... "); assert_int_equal(0, flashrom_layout_add_region(layout, 0x00027100, 0x0023efc0, "second region")); printf("done\n"); - printf("Asserting included regions do not overlap...\n"); + printf("Asserting included regions do not overlap... "); assert_int_equal(0, included_regions_overlap(layout)); printf("done\n"); - printf("Releasing layout...\n"); + printf("Releasing layout... "); flashrom_layout_release(layout); printf("done\n"); } -- To view, visit https://review.coreboot.org/c/flashrom/+/56439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I36a39505f8db508672cde5a848684a3a22f5ccc4 Gerrit-Change-Number: 56439 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: mec1308: remove MEC1308 EC programmer
by Edward O'Callaghan (Code Review) 22 Jul '21

22 Jul '21

Attention is currently required from: Nico Huber, Victor Ding, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56476 ) Change subject: mec1308: remove MEC1308 EC programmer ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/56476/comment/0a977426_f2e8c06b PS1, Line 9: Last known device that uses MEC1308 Embedded Controller has reached Auto : Update Expiration (AUE) a.k.a. end-of-life. : see https://review.coreboot.org/c/flashrom/+/56475/ discussion for perhaps a more informative commit message. -- To view, visit https://review.coreboot.org/c/flashrom/+/56476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I535b6380846734c999474519e9e60a73eb6a2ec4 Gerrit-Change-Number: 56476 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 22 Jul 2021 01:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: mec1308: remove MEC1308 EC programmer
by Edward O'Callaghan (Code Review) 22 Jul '21

22 Jul '21

Attention is currently required from: Nico Huber, Victor Ding, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56476 ) Change subject: mec1308: remove MEC1308 EC programmer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I535b6380846734c999474519e9e60a73eb6a2ec4 Gerrit-Change-Number: 56476 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 22 Jul 2021 01:39:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ene_lpc: remove ENE LPC programmer
by Edward O'Callaghan (Code Review) 22 Jul '21

22 Jul '21

Attention is currently required from: Nico Huber, Victor Ding, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56475 ) Change subject: ene_lpc: remove ENE LPC programmer ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/56475/comment/b6f1abe2_6ac854a1 PS1, Line 10: reached Auto Update Expiration (AUE) a.k.a. end-of-life. > I suppose this is why nobody will object to the removal. Generally, […] I guess the reason is similar to what you stated but slightly different; 'Best efforts were made to upstream older Chromebook support for good intentions for folks interested. However, we no longer have the hardware available to test and maintain the code as the hardware is now end of life. Therefore the code state has sadly fallen into a unknown state.' I would add it is sort of sad for the ENE to go as this supports the KB9012 EC in the Lenovo G505s coreboot I once did with damo22. -- To view, visit https://review.coreboot.org/c/flashrom/+/56475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b Gerrit-Change-Number: 56475 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 22 Jul 2021 01:38:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Replace freenode references
by Patrick Georgi (Code Review) 21 Jul '21

21 Jul '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/56031 ) Change subject: Replace freenode references ...................................................................... Replace freenode references The flashrom project no longer uses freenode. To avoid having outdated man pages in the future, the contact methods are now listed in the wiki. Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56031 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M README M flashrom.8.tmpl M flashrom.c 3 files changed, 15 insertions(+), 30 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/README b/README index 4e7bd4f..71e8735 100644 --- a/README +++ b/README @@ -183,10 +183,6 @@ http://www.flashrom.org/ -The IRC channel is +Available contact methods are - #flashrom at irc.freenode.net - -The mailing list address is - - flashrom(a)flashrom.org + https://www.flashrom.org/Contact diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index c7964d4..6962637 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -1454,24 +1454,13 @@ .B "/etc/rc.securelevel" and rebooting, or rebooting into single user mode. .SH BUGS -Please report any bugs to the -.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" . +You can report bugs, ask us questions or send success reports +via our communication channels listed here: +.URLB "https://www.flashrom.org/Contact" "" . .sp -We recommend to subscribe first at -.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" . -.sp -Many of the developers communicate via the -.B "#flashrom" -IRC channel on -.BR chat.freenode.net . -If you don't have an IRC client, you can use the -.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" . -You are welcome to join and ask questions, send us bug and success reports there -too. Please provide a way to contact you later (e.g.\& a mail address) and be -patient if there is no immediate reaction. Also, we provide a +Also, we provide a .URLB https://paste.flashrom.org "pastebin service" -that is very useful when you want to share logs etc.\& without spamming the -channel. +that is very useful to share logs without spamming the communication channels. .SS .B Laptops .sp diff --git a/flashrom.c b/flashrom.c index debe60c..3987bb9 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1543,16 +1543,16 @@ #if CONFIG_INTERNAL == 1 if (programmer == &programmer_internal) msg_gerr("This means we have to add special support for your board, programmer or flash\n" - "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n" + "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n" + "IRC (see https://www.flashrom.org/Contact for details), thanks!\n" "-------------------------------------------------------------------------------\n" "You may now reboot or simply leave the machine running.\n"); else #endif msg_gerr("Please check the connections (especially those to write protection pins) between\n" "the programmer and the flash chip. If you think the error is caused by flashrom\n" - "please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n" + "https://www.flashrom.org/Contact for details), thanks!\n"); } static void emergency_help_message(void) @@ -1560,14 +1560,14 @@ msg_gerr("Your flash chip is in an unknown state.\n"); #if CONFIG_INTERNAL == 1 if (programmer == &programmer_internal) - msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n" + msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n" + "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!" "-------------------------------------------------------------------------------\n" "DO NOT REBOOT OR POWEROFF!\n"); else #endif - msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n" + "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n"); } void list_programmers_linebreak(int startcol, int cols, int paren) -- To view, visit https://review.coreboot.org/c/flashrom/+/56031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Gerrit-Change-Number: 56031 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: print_wiki.c: Update mailing list reference
by Patrick Georgi (Code Review) 21 Jul '21

21 Jul '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/56030 ) Change subject: print_wiki.c: Update mailing list reference ...................................................................... print_wiki.c: Update mailing list reference Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56030 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M print_wiki.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/print_wiki.c b/print_wiki.c index 9af2e3e..2c8c109 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -80,7 +80,7 @@ or may not be added later.\n\n\ Mainboards (or individual revisions) which don't appear in the list may or may \ not work (we don't know, someone has to give it a try). Please report any \ -further verified mainboards on the [[Mailinglist|mailing list]].\n"; +further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n"; #endif static const char chip_th[] = "\ -- To view, visit https://review.coreboot.org/c/flashrom/+/56030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026 Gerrit-Change-Number: 56030 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: ene_lpc: remove ENE LPC programmer
by Nico Huber (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Victor Ding, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56475 ) Change subject: ene_lpc: remove ENE LPC programmer ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/56475/comment/57a39be1_997aec61 PS1, Line 10: reached Auto Update Expiration (AUE) a.k.a. end-of-life. I suppose this is why nobody will object to the removal. Generally, EOL products is not a reason to remove code from upstream flashrom. The real reason, I guess, is that it was submitted in an untested, unknown, undocumented state and nobody wants to fix that? -- To view, visit https://review.coreboot.org/c/flashrom/+/56475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b Gerrit-Change-Number: 56475 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Jul 2021 10:59:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: Remove space between address operator and variable
by Nico Huber (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56469 ) Change subject: programmer_table: Remove space between address operator and variable ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File programmer_table.c: https://review.coreboot.org/c/flashrom/+/56469/comment/3f0a7314_b66e9803 PS1, Line 176: const size_t programmer_table_size = ARRAY_SIZE(programmer_table); > coreboot has a lint check for this. My editor automatically adds the newline. We avoid /empty/ lines at the end. ASCII text files are supposed to end with a new-line character, though (only broken editors don't add it). This fixes it. (Gerrit shows the last new-line as an empty line but there is none.) -- To view, visit https://review.coreboot.org/c/flashrom/+/56469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba29b1bc3d77b8c17c51fc0552c129e6965fa308 Gerrit-Change-Number: 56469 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Jul 2021 10:53:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: Minor tidy up
by Nico Huber (Code Review) 21 Jul '21

21 Jul '21

Attention is currently required from: Edward O'Callaghan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56466 ) Change subject: programmer.h: Minor tidy up ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Do we need any of the #ifdef at all? -- To view, visit https://review.coreboot.org/c/flashrom/+/56466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77 Gerrit-Change-Number: 56466 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Jul 2021 10:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2021