May 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: drkaiser.c: Reshuffle to remove forward declarations
by Angel Pons (Code Review) 23 May '21

23 May '21

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54850 ) Change subject: drkaiser.c: Reshuffle to remove forward declarations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/54850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee550dc8055eabfe8c7c4ad32003b6eec4f1e496 Gerrit-Change-Number: 54850 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 23 May 2021 10:25:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson/: Add missing config for NI845_SPI drv
by Angel Pons (Code Review) 23 May '21

23 May '21

Attention is currently required from: Miklós Márton, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54849 ) Change subject: meson/: Add missing config for NI845_SPI drv ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: AFAIK, NI845_SPI is Windows-only. Does Meson run on Windows? -- To view, visit https://review.coreboot.org/c/flashrom/+/54849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I85387e94f1b159733d0124f1a6dfde1e3d16827f Gerrit-Change-Number: 54849 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 23 May 2021 10:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Move 'flashchip_contents' into emu_data
by Angel Pons (Code Review) 23 May '21

23 May '21

Attention is currently required from: Namyoon Woo, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54722 ) Change subject: dummyflasher.c: Move 'flashchip_contents' into emu_data ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54722/comment/72e9f772_71283b40 PS2, Line 987: return 1; There's lots of memory leaks here, e.g. `data` and `flashchip_contents`. Would be great to address them in a follow-up. -- To view, visit https://review.coreboot.org/c/flashrom/+/54722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11dfe713dd2fecfd3981ab50e31c9215d00bc787 Gerrit-Change-Number: 54722 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 23 May 2021 10:21:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data
by Angel Pons (Code Review) 23 May '21

23 May '21

Attention is currently required from: Namyoon Woo, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54721 ) Change subject: dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data ...................................................................... Patch Set 2: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54721/comment/e1d2699a_03a3bf00 PS2, Line 713: data->spi_write_256_chunksize = atoi(tmp); For another patch: This can result in overflow because `spi_write_256_chunksize` is of an unsigned type. -- To view, visit https://review.coreboot.org/c/flashrom/+/54721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I633f4df4bd47e661cd69801f21910b667899d505 Gerrit-Change-Number: 54721 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 23 May 2021 10:16:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data
by Angel Pons (Code Review) 23 May '21

23 May '21

Attention is currently required from: Namyoon Woo, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54721 ) Change subject: dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/54721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I633f4df4bd47e661cd69801f21910b667899d505 Gerrit-Change-Number: 54721 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 23 May 2021 10:14:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Make entry struct names consistent
by Angel Pons (Code Review) 23 May '21

23 May '21

Attention is currently required from: Namyoon Woo, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54720 ) Change subject: dummyflasher.c: Make entry struct names consistent ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/54720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib8ade96c47b4e4d358ba1fe34d06f22de326c60a Gerrit-Change-Number: 54720 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 23 May 2021 10:12:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: drkaiser.c: Reshuffle to remove forward declarations
by Edward O'Callaghan (Code Review) 23 May '21

23 May '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54850 ) Change subject: drkaiser.c: Reshuffle to remove forward declarations ...................................................................... drkaiser.c: Reshuffle to remove forward declarations BUG=none BRANCH=none TEST=builds Change-Id: Iee550dc8055eabfe8c7c4ad32003b6eec4f1e496 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M drkaiser.c 1 file changed, 10 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/54850/1 diff --git a/drkaiser.c b/drkaiser.c index fa562b4..4858b35 100644 --- a/drkaiser.c +++ b/drkaiser.c @@ -38,9 +38,17 @@ static uint8_t *drkaiser_bar; static void drkaiser_chip_writeb(const struct flashctx *flash, uint8_t val, - chipaddr addr); + chipaddr addr) +{ + pci_mmio_writeb(val, drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK)); +} + static uint8_t drkaiser_chip_readb(const struct flashctx *flash, - const chipaddr addr); + const chipaddr addr) +{ + return pci_mmio_readb(drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK)); +} + static const struct par_master par_master_drkaiser = { .chip_readb = drkaiser_chip_readb, .chip_readw = fallback_chip_readw, @@ -81,15 +89,3 @@ return 0; } - -static void drkaiser_chip_writeb(const struct flashctx *flash, uint8_t val, - chipaddr addr) -{ - pci_mmio_writeb(val, drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK)); -} - -static uint8_t drkaiser_chip_readb(const struct flashctx *flash, - const chipaddr addr) -{ - return pci_mmio_readb(drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK)); -} -- To view, visit https://review.coreboot.org/c/flashrom/+/54850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee550dc8055eabfe8c7c4ad32003b6eec4f1e496 Gerrit-Change-Number: 54850 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson/: Add missing config for NI845_SPI drv
by Edward O'Callaghan (Code Review) 23 May '21

23 May '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54849 ) Change subject: meson/: Add missing config for NI845_SPI drv ...................................................................... meson/: Add missing config for NI845_SPI drv Configuration is only present in the Makefile however is missing in the corresponding meson configs. BUG=none BRANCH=none TEST=meson continues to build. Change-Id: I85387e94f1b159733d0124f1a6dfde1e3d16827f Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M meson.build M meson_options.txt 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/54849/1 diff --git a/meson.build b/meson.build index 81d63a9..1d92ae9 100644 --- a/meson.build +++ b/meson.build @@ -51,6 +51,7 @@ config_linux_spi = get_option('config_linux_spi') config_mec1308 = get_option('config_mec1308') config_mstarddc_spi = get_option('config_mstarddc_spi') +config_ni845x_spi = get_option('config_ni845x_spi') config_nic3com = get_option('config_nic3com') config_nicintel_eeprom = get_option('config_nicintel_eeprom') config_nicintel = get_option('config_nicintel') @@ -100,6 +101,7 @@ config_developerbox_spi = false config_pickit2_spi = false config_raiden_debug_spi = false + config_ni845x_spi = false endif # some programmers require libpci @@ -235,6 +237,11 @@ srcs += 'mstarddc_spi.c' cargs += '-DCONFIG_MSTARDDC_SPI=1' endif +if config_ni845x_spi + srcs += 'ni845x_spi.c' + cargs += '-DCONFIG_NI845X_SPI=1' + deps += dependency('libni845x') +endif if config_nic3com srcs += 'nic3com.c' cargs += '-DCONFIG_NIC3COM=1' diff --git a/meson_options.txt b/meson_options.txt index cd92f10..eee51ea 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -24,6 +24,7 @@ option('config_linux_spi', type : 'boolean', value : true, description : 'Linux spidev interfaces') option('config_mec1308', type : 'boolean', value : true, description : 'Microchip MEC1308 Embedded Controller') option('config_mstarddc_spi', type : 'boolean', value : false, description : 'MSTAR DDC support') +option('config_ni845x_spi', type : 'boolean', value : false, description : 'National Instruments USB-845x') option('config_nic3com', type : 'boolean', value : true, description : '3Com NICs') option('config_nicintel_eeprom', type : 'boolean', value : true, description : 'EEPROM on Intel NICs') option('config_nicintel_spi', type : 'boolean', value : true, description : 'SPI on Intel NICs') -- To view, visit https://review.coreboot.org/c/flashrom/+/54849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I85387e94f1b159733d0124f1a6dfde1e3d16827f Gerrit-Change-Number: 54849 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data
by Edward O'Callaghan (Code Review) 23 May '21

23 May '21

Attention is currently required from: Namyoon Woo, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Namyoon Woo, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/54721 to look at the new patch set (#2). Change subject: dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data ...................................................................... dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data Move 'spi_write_256_chunksize' out of global scope and into the emu_data reentrent struct. BUG=none BRANCH=none TEST=builds Change-Id: I633f4df4bd47e661cd69801f21910b667899d505 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M dummyflasher.c 1 file changed, 17 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/54721/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/54721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I633f4df4bd47e661cd69801f21910b667899d505 Gerrit-Change-Number: 54721 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: dummyflasher.c: Make entry struct names consistent
by Edward O'Callaghan (Code Review) 23 May '21

23 May '21

Attention is currently required from: Namyoon Woo, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Namyoon Woo, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/54720 to look at the new patch set (#2). Change subject: dummyflasher.c: Make entry struct names consistent ...................................................................... dummyflasher.c: Make entry struct names consistent Just make spi_master_dummyflasher and par_master_dummyflasher identifiers consistently named for easier parsing. BUG=none BRANCH=none TEST=builds Change-Id: Ib8ade96c47b4e4d358ba1fe34d06f22de326c60a Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M dummyflasher.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/54720/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/54720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib8ade96c47b4e4d358ba1fe34d06f22de326c60a Gerrit-Change-Number: 54720 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2021