May 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: sb600spi.c: Make use of new register_spi_master() API
by Anastasia Klimchuk (Code Review) 26 May '21

26 May '21

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54713 ) Change subject: sb600spi.c: Make use of new register_spi_master() API ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/54713/comment/b81acc59_bfc70c81 PS1, Line 13: TEST=builds > Ack I tested on AMD device: probe, read, write, and then rebooted device. All good! Sorry for messaging after this patch is already merged, but better late than never :) -- To view, visit https://review.coreboot.org/c/flashrom/+/54713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id555dc5e125309883a816e00afb26d7141fd870d Gerrit-Change-Number: 54713 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 26 May 2021 05:03:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for TerribleFire TF530 SPI controller
by Stefan Reinauer (Code Review) 26 May '21

26 May '21

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54944 ) Change subject: Add support for TerribleFire TF530 SPI controller ...................................................................... Add support for TerribleFire TF530 SPI controller Change-Id: I109eec4dec89650bb80d3d1da905d33f65f60f5a Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M Makefile M programmer.h A tf530_spi.c 3 files changed, 188 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/54944/1 diff --git a/Makefile b/Makefile index c486c12..0026898 100644 --- a/Makefile +++ b/Makefile @@ -138,6 +138,7 @@ ifeq ($(TARGET_OS), AmigaOS) override CPPFLAGS += -m68000 -mcrt=clib2 override LIBS += -mcrt=clib2 -lamiga -lm -lunix +override CONFIG_TF530_SPI = yes # Bus Pirate, Serprog and PonyProg are not supported under AmigaOS (missing serial support). ifeq ($(CONFIG_BUSPIRATE_SPI), yes) UNSUPPORTED_FEATURES += CONFIG_BUSPIRATE_SPI=yes @@ -1207,6 +1208,11 @@ PROGRAMMER_OBJS += jlink_spi.o endif +ifeq ($(CONFIG_TF530_SPI), yes) +FEATURE_CFLAGS += -D'CONFIG_TF530_SPI=1' +PROGRAMMER_OBJS += tf530_spi.o +endif + ifeq ($(CONFIG_NI845X_SPI), yes) FEATURE_CFLAGS += -D'CONFIG_NI845X_SPI=1' diff --git a/programmer.h b/programmer.h index 790fcc8..cbb5977 100644 --- a/programmer.h +++ b/programmer.h @@ -112,6 +112,9 @@ #if CONFIG_LINUX_SPI == 1 PROGRAMMER_LINUX_SPI, #endif +#if CONFIG_TF530_SPI == 1 + PROGRAMMER_TF530_SPI, +#endif #if CONFIG_USBBLASTER_SPI == 1 PROGRAMMER_USBBLASTER_SPI, #endif @@ -559,6 +562,11 @@ int linux_spi_init(void); #endif +/* tf530_spi.c */ +#if CONFIG_TF530_SPI == 1 +int tf53x_spi_init(void); +#endif + /* dediprog.c */ #if CONFIG_DEDIPROG == 1 int dediprog_init(void); diff --git a/tf530_spi.c b/tf530_spi.c new file mode 100644 index 0000000..76a7e43 --- /dev/null +++ b/tf530_spi.c @@ -0,0 +1,174 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2019 Steven J Leary + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#if CONFIG_TF530_SPI == 1 + +#include <stdio.h> +#include <string.h> +#include <stdlib.h> +#include <fcntl.h> +#include <errno.h> +#include <ctype.h> +#include "flash.h" +#include "chipdrivers.h" +#include "programmer.h" +#include "spi.h" + +#include <exec/resident.h> +#include <exec/errors.h> +#include <exec/memory.h> +#include <exec/lists.h> +#include <exec/alerts.h> +#include <exec/tasks.h> +#include <exec/io.h> +#include <exec/execbase.h> + +#include <libraries/expansion.h> + +#include <devices/trackdisk.h> +#include <devices/timer.h> +#include <devices/scsidisk.h> + +#include <dos/filehandler.h> + +#include <proto/exec.h> +#include <proto/disk.h> +#include <proto/expansion.h> + +struct TF53xSDRegs { + volatile uint8_t ctrl; // Control register + volatile uint8_t unused1; // padding + volatile uint8_t unused2; // padding + volatile uint8_t unused3; // padding + volatile uint8_t data; // data +}; + +static struct ConfigDev *cd = NULL; + +#define TF53x_CTRL_CS0 1 +#define TF53x_CTRL_CS1 2 +#define TF53x_CTRL_BUSY 4 +#define TF53x_CTRL_CS2 8 + +static void spi_send_byte(struct TF53xSDRegs *port, uint8_t value) +{ + uint8_t busy = 0; + + while (busy == 0) { + busy = port->ctrl & TF53x_CTRL_BUSY; + } + + port->data = value; +} + +inline uint8_t spi_recv_byte(struct TF53xSDRegs *port) +{ + uint8_t busy = 0; + + while (busy == 0) { + busy = port->ctrl & TF53x_CTRL_BUSY; + } + + return port->data; +} + +static void spi_cs_unassert(struct TF53xSDRegs *port) +{ + uint8_t current = port->ctrl; + port->ctrl = current | TF53x_CTRL_CS0 | \ + TF53x_CTRL_CS1 | TF53x_CTRL_CS2 | TF53x_CTRL_BUSY; +} + +static void spi_cs_assert(struct TF53xSDRegs *port) +{ + uint8_t current = port->ctrl; + port->ctrl = current & (~TF53x_CTRL_CS2); +} + +static int tf53x_spi_shutdown(void *data) +{ + return 0; +} + +static int tf53x_spi_send_command(const struct flashctx *flash, + unsigned int writecnt, + unsigned int readcnt, + const unsigned char *txbuf, + unsigned char *rxbuf) +{ + struct TF53xSDRegs *port = cd->cd_BoardAddr; + + spi_cs_assert(port); + + for (unsigned int i = 0; i < writecnt; i++) { + spi_send_byte(port, txbuf[i]); + } + + /* read the dummy byte and make sure + * the compiler doesnt optimize it away */ + uint8_t volatile dummy = spi_recv_byte(port); + dummy; + + for (unsigned int i = 0; i < readcnt; i++) { + rxbuf[i] = spi_recv_byte(port); + } + + spi_cs_unassert(port); + + return 0; +} + +static const struct spi_master spi_master_tf53x = { + .features = SPI_MASTER_4BA, + .max_data_read = 256, + .max_data_write = 256, + .command = tf53x_spi_send_command, + .multicommand = default_spi_send_multicommand, + .read = default_spi_read, + .write_256 = default_spi_write_256, + .write_aai = default_spi_write_aai, +}; + +int tf53x_spi_init(void) +{ + struct Library *ExpansionBase = NULL; + + if ((ExpansionBase = (struct Library *) + OpenLibrary((unsigned char *)"expansion.library", 0L)) == NULL) { + return 0; + } + + if (cd = (struct ConfigDev *) FindConfigDev(cd, 0x13D8, 0x81)) { + msg_cinfo("\nTF530 SPI found in autoconfig chain.\n"); + CloseLibrary(ExpansionBase); + } else { + msg_perr("\nTF530 SPI not found in autoconfig chain.\n"); + CloseLibrary(ExpansionBase); + return -1; + } + + if (register_shutdown(tf53x_spi_shutdown, NULL)) + return 1; + + register_spi_master(&spi_master_tf53x, NULL); + + return 0; +} + +#endif // CONFIG_TF530_SPI == 1 -- To view, visit https://review.coreboot.org/c/flashrom/+/54944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I109eec4dec89650bb80d3d1da905d33f65f60f5a Gerrit-Change-Number: 54944 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Add AmigaOS suppport to flashrom
by Stefan Reinauer (Code Review) 26 May '21

26 May '21

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54943 ) Change subject: Add AmigaOS suppport to flashrom ...................................................................... Add AmigaOS suppport to flashrom Change-Id: I3e4a3885f88313aad019454fdbdf4be176b35330 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M Makefile M cli_classic.c M flash.h M helpers.c M os.h M platform.h M udelay.c 7 files changed, 109 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/54943/1 diff --git a/Makefile b/Makefile index b8b40ca..c486c12 100644 --- a/Makefile +++ b/Makefile @@ -135,6 +135,89 @@ override LDFLAGS += -L/usr/local/lib endif +ifeq ($(TARGET_OS), AmigaOS) +override CPPFLAGS += -m68000 -mcrt=clib2 +override LIBS += -mcrt=clib2 -lamiga -lm -lunix +# Bus Pirate, Serprog and PonyProg are not supported under AmigaOS (missing serial support). +ifeq ($(CONFIG_BUSPIRATE_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_BUSPIRATE_SPI=yes +else +override CONFIG_BUSPIRATE_SPI = no +endif +ifeq ($(CONFIG_SERPROG), yes) +UNSUPPORTED_FEATURES += CONFIG_SERPROG=yes +else +override CONFIG_SERPROG = no +endif +ifeq ($(CONFIG_PONY_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_PONY_SPI=yes +else +override CONFIG_PONY_SPI = no +endif +# Digilent SPI, Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under AmigaOS (missing USB support). +ifeq ($(CONFIG_DIGILENT_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_DIGILENT_SPI=yes +else +override CONFIG_DIGILENT_SPI = no +endif +ifeq ($(CONFIG_DEDIPROG), yes) +UNSUPPORTED_FEATURES += CONFIG_DEDIPROG=yes +else +override CONFIG_DEDIPROG = no +endif +ifeq ($(CONFIG_DEVELOPERBOX_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_DEVELOPERBOX_SPI=yes +else +override CONFIG_DEVELOPERBOX_SPI = no +endif +ifeq ($(CONFIG_ENE_LPC), yes) +UNSUPPORTED_FEATURES += CONFIG_ENE_LPC=yes +else +override CONFIG_ENE_LPC = no +endif +ifeq ($(CONFIG_FT2232_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_FT2232_SPI=yes +else +override CONFIG_FT2232_SPI = no +endif +ifeq ($(CONFIG_MEC1308), yes) +UNSUPPORTED_FEATURES += CONFIG_MEC1308=yes +else +override CONFIG_MEC1308 = no +endif +ifeq ($(CONFIG_USBBLASTER_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_USBBLASTER_SPI=yes +else +override CONFIG_USBBLASTER_SPI = no +endif +ifeq ($(CONFIG_PICKIT2_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_PICKIT2_SPI=yes +else +override CONFIG_PICKIT2_SPI = no +endif +ifeq ($(CONFIG_CH341A_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_CH341A_SPI=yes +else +override CONFIG_CH341A_SPI = no +endif +ifeq ($(CONFIG_RAIDEN_DEBUG_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_RAIDEN_DEBUG_SPI=yes +else +override CONFIG_RAIDEN_DEBUG_SPI = no +endif +ifeq ($(CONFIG_STLINKV3_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_STLINKV3_SPI=yes +else +override CONFIG_STLINKV3_SPI = no +endif +# libjaylink is also not available for DOS +ifeq ($(CONFIG_JLINK_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_JLINK_SPI=yes +else +override CONFIG_JLINK_SPI = no +endif +endif + ifeq ($(TARGET_OS), DOS) EXEC_SUFFIX := .exe # DJGPP has odd uint*_t definitions which cause lots of format string warnings. diff --git a/cli_classic.c b/cli_classic.c index 5fd8092..31fac36 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -154,6 +154,11 @@ return 0; } +#if IS_AMIGA +#define ARGV_TYPE (const char **) +#else +#define ARGV_TYPE +#endif int main(int argc, char *argv[]) { const struct flashchip *chip = NULL; @@ -260,7 +265,7 @@ /* FIXME: Delay all operation_specified checks until after command * line parsing to allow --help overriding everything else. */ - while ((opt = getopt_long(argc, argv, optstring, + while ((opt = getopt_long(argc, ARGV_TYPE argv, optstring, long_options, &option_index)) != EOF) { switch (opt) { case 'r': diff --git a/flash.h b/flash.h index dd8e156..c2fef2c 100644 --- a/flash.h +++ b/flash.h @@ -52,6 +52,11 @@ /* TODO: check using code for correct usage of types */ typedef uintptr_t chipaddr; #define PRIxPTR_WIDTH ((int)(sizeof(uintptr_t)*2)) +/* Standard Amiga toolchain defines PRIxPTR wrong. */ +#ifdef __AMIGA__ +#undef PRIxPTR +#define PRIxPTR "x" +#endif int register_shutdown(int (*function) (void *data), void *data); void *programmer_map_flash_region(const char *descr, uintptr_t phys_addr, size_t len); @@ -326,7 +331,7 @@ void tolower_string(char *str); uint8_t reverse_byte(uint8_t x); void reverse_bytes(uint8_t *dst, const uint8_t *src, size_t length); -#ifdef __MINGW32__ +#if defined(__MINGW32__) || IS_AMIGA char* strtok_r(char *str, const char *delim, char **nextp); char *strndup(const char *str, size_t size); #endif diff --git a/helpers.c b/helpers.c index 289848d..56d881c 100644 --- a/helpers.c +++ b/helpers.c @@ -84,7 +84,7 @@ } /* FIXME: Find a better solution for MinGW. Maybe wrap strtok_s (C11) if it becomes available */ -#ifdef __MINGW32__ +#if defined(__MINGW32__) || IS_AMIGA char* strtok_r(char *str, const char *delim, char **nextp) { if (str == NULL) diff --git a/os.h b/os.h index ddfa46b..ba45da0 100644 --- a/os.h +++ b/os.h @@ -55,6 +55,9 @@ // GNU Hurd #elif defined(__gnu_hurd__) #define __FLASHROM_OS__ "Hurd" +// AmigaOS +#elif defined(__AMIGA__) +#define __FLASHROM_OS__ "AmigaOS" // Linux #elif defined(__linux__) // There are various flags in use on Android apparently. __ANDROID__ seems to be the most trustworthy. diff --git a/platform.h b/platform.h index 751957c..5d74f9a 100644 --- a/platform.h +++ b/platform.h @@ -36,6 +36,11 @@ #else #define IS_WINDOWS 0 #endif +#if defined(__AMIGA__) +#define IS_AMIGA 1 +#else +#define IS_AMIGA 0 +#endif // Likewise for target architectures #if defined (__i386__) || defined (__x86_64__) || defined(__amd64__) @@ -122,6 +127,10 @@ #define __FLASHROM_LITTLE_ENDIAN__ 1 #endif +#elif IS_M68K + +#define __FLASHROM_BIG_ENDIAN__ 1 + #elif IS_SPARC /* SPARC is big endian in general (but allows to access data in little endian too). */ #define __FLASHROM_BIG_ENDIAN__ 1 diff --git a/udelay.c b/udelay.c index 6c0efc4..b4f700d 100644 --- a/udelay.c +++ b/udelay.c @@ -226,7 +226,7 @@ { #if IS_WINDOWS Sleep((usecs + 999) / 1000); -#elif defined(__DJGPP__) +#elif defined(__DJGPP__) || IS_AMIGA sleep(usecs / 1000000); usleep(usecs % 1000000); #else -- To view, visit https://review.coreboot.org/c/flashrom/+/54943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e4a3885f88313aad019454fdbdf4be176b35330 Gerrit-Change-Number: 54943 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: dummyflasher.c: Don't leak `emu_persistent_image`
by Edward O'Callaghan (Code Review) 26 May '21

26 May '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54905 ) Change subject: dummyflasher.c: Don't leak `emu_persistent_image` ...................................................................... Patch Set 1: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54905/comment/0d434101_4ccf521f PS1, Line 1026: free(data->emu_persistent_image); > Is it ok to free something which is !(not) ? […] Good spot. I think we should give dummyflasher a good valgrind workout sometime soon. -- To view, visit https://review.coreboot.org/c/flashrom/+/54905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76529973cefcc6a1472681e1f4da8239fcbf07a6 Gerrit-Change-Number: 54905 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 26 May 2021 02:00:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Extract params processing into a separate function
by Anastasia Klimchuk (Code Review) 25 May '21

25 May '21

Attention is currently required from: Nico Huber, Namyoon Woo, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 ) Change subject: dummyflasher.c: Extract params processing into a separate function ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm sorry that you'll have to manually rebase this change, but I *really* had to make CB:54905 CB:54 […] Sure no problem, I will rebase! Dummy is the happiest driver today, it got so much attention :) -- To view, visit https://review.coreboot.org/c/flashrom/+/54748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87 Gerrit-Change-Number: 54748 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 25 May 2021 22:14:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Don't leak `emu_persistent_image`
by Anastasia Klimchuk (Code Review) 25 May '21

25 May '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54905 ) Change subject: dummyflasher.c: Don't leak `emu_persistent_image` ...................................................................... Patch Set 1: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54905/comment/8a8fc2f4_cc55e96e PS1, Line 1026: free(data->emu_persistent_image); Is it ok to free something which is !(not) ? Line 999 checks if (!data->emu_persistent_image) {goto dummy_init_out;} and dummy_init_out is doing free(data->emu_persistent_image) And I think similar thing is happening in shutdown -- To view, visit https://review.coreboot.org/c/flashrom/+/54905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76529973cefcc6a1472681e1f4da8239fcbf07a6 Gerrit-Change-Number: 54905 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 25 May 2021 22:12:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Move `flashchip_contents` allocation
by Anastasia Klimchuk (Code Review) 25 May '21

25 May '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54908 ) Change subject: dummyflasher.c: Move `flashchip_contents` allocation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/54908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie907ac88dfe4ca018c97d9ce6ce042b4ffacf36a Gerrit-Change-Number: 54908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 25 May 2021 22:07:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Prevent use-after-free bug
by Anastasia Klimchuk (Code Review) 25 May '21

25 May '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54909 ) Change subject: dummyflasher.c: Prevent use-after-free bug ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/54909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1b56834004fe18918213a7df0a09a8a7ecb56985 Gerrit-Change-Number: 54909 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 25 May 2021 22:05:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Fix typo in log message
by Anastasia Klimchuk (Code Review) 25 May '21

25 May '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54910 ) Change subject: dummyflasher.c: Fix typo in log message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/54910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I16fbc0072c82ac152af5f1d65df196cdd113e03b Gerrit-Change-Number: 54910 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 25 May 2021 22:04:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Get rid of get_data_from_context()
by Anastasia Klimchuk (Code Review) 25 May '21

25 May '21

Attention is currently required from: Namyoon Woo, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54907 ) Change subject: dummyflasher.c: Get rid of get_data_from_context() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/54907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I07a34faf50ff0679cb3d6bc683142f82160010b1 Gerrit-Change-Number: 54907 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 25 May 2021 22:03:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2021