April 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashrom.c: allow - as filename for stdin/stdout
by Daniel Campello (Code Review) 15 Apr '21

15 Apr '21

Daniel Campello has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52383 ) Change subject: flashrom.c: allow - as filename for stdin/stdout ...................................................................... flashrom.c: allow - as filename for stdin/stdout Allows - as filename for -r/-w/-v options Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d --- M cli_classic.c M flashrom.c 2 files changed, 21 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/52383/1 diff --git a/cli_classic.c b/cli_classic.c index 203bda9..caa06bb 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -46,9 +46,12 @@ printf(" -h | --help print this help text\n" " -R | --version print version (release)\n" - " -r | --read [<file>] read flash and save to <file>\n" - " -w | --write [<file>] write <file> to flash\n" - " -v | --verify [<file>] verify flash against <file>\n" + " -r | --read [<file|->] read flash and save to <file>\n" + " or write on the standard output\n" + " -w | --write [<file|->] write <file> or the content provided\n" + " on the standard input to flash\n" + " -v | --verify [<file|->] verify flash against <file>\n" + " or the content provided on the standard input\n" " -E | --erase erase flash memory\n" " -V | --verbose more verbose output\n" " -c | --chip <chipname> probe only for specified flash chip\n" @@ -145,7 +148,8 @@ if (optarg != NULL) filename = strdup(optarg); /* filename is on optind if it is not another flag (i.e. -r filename) */ - else if (optarg == NULL && argv[optind] != NULL && argv[optind][0] != '-') + else if (optarg == NULL && argv[optind] != NULL && + (argv[optind][0] != '-' || argv[optind][1] == '\0')) filename = strdup(argv[optind++]); return filename; @@ -458,7 +462,7 @@ if (optind < argc) cli_classic_abort_usage("Error: Extra parameter found.\n"); - if ((read_it | write_it | verify_it) && (!filename || check_filename(filename, "image"))) + if ((read_it | write_it | verify_it) && (!filename || filename[0] == '\0')) cli_classic_abort_usage(NULL); if (layoutfile && check_filename(layoutfile, "layout")) cli_classic_abort_usage(NULL); diff --git a/flashrom.c b/flashrom.c index 5b52491..b8061a5 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1348,7 +1348,11 @@ int ret = 0; FILE *image; - if ((image = fopen(filename, "rb")) == NULL) { + if (!strncmp(filename, "-", sizeof("-"))) + image = fdopen(STDIN_FILENO, "rb"); + else + image = fopen(filename, "rb"); + if (image == NULL) { msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno)); return 1; } @@ -1359,7 +1363,8 @@ ret = 1; goto out; } - if (image_stat.st_size != (intmax_t)size) { + if ((image_stat.st_size != (__off_t)size) && + (strncmp(filename, "-", sizeof("-")))) { msg_gerr("Error: Image size (%jd B) doesn't match the expected size (%lu B)!\n", (intmax_t)image_stat.st_size, size); ret = 1; @@ -1436,7 +1441,11 @@ msg_gerr("No filename specified.\n"); return 1; } - if ((image = fopen(filename, "wb")) == NULL) { + if (!strncmp(filename, "-", sizeof("-"))) + image = fdopen(STDOUT_FILENO, "wb"); + else + image = fopen(filename, "wb"); + if (image == NULL) { msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno)); return 1; } -- To view, visit https://review.coreboot.org/c/flashrom/+/52383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d Gerrit-Change-Number: 52383 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: cli_classic: Make -r/-w/-v argument optional
by Daniel Campello (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52362 to look at the new patch set (#2). Change subject: cli_classic: Make -r/-w/-v argument optional ...................................................................... cli_classic: Make -r/-w/-v argument optional Makes filename optional from -r/-w/-v since the -i parameter allows building the image to be written from multiple files, and regions to be read from flash and written to separate image files, Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41 --- M cli_classic.c M flashrom.c 2 files changed, 81 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/52362/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41 Gerrit-Change-Number: 52362 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: cli_classic: Make -r/-w/-v argument optional
by Daniel Campello (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52362 ) Change subject: cli_classic: Make -r/-w/-v argument optional ...................................................................... Patch Set 1: (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/52362/comment/ae6dd7ff_4484f148 PS1, Line 46: > I'm not too familiar with what the design considerations are here, so take this with a grain of salt, but I wonder if there is a way to make the flags more orthogonal. Right now, these two invocations would be equivalent: > -r some_file.bin -i some_region > -r -i some_region:some_file.bin These are not the same: the first one will create a ROM size some_file.bin with 0s and the some_region contents, the second one will be some_file.bin sized to the region size. A third option will create both files with different sizes/contents as above: -r some_ROM_file.bin -i some_region:some_file.bin > > One option is to get rid of "-i" completely and make -r/-w/-v repeated with optional region parameters, e.g. something like > -r some_file.bin > -r some_file.bin:some_region > -r some_file.bin:some_region -r some_other_file.bin:some_other_region > > But if we need to keep "-i" around, then everything here seems reasonable. -- To view, visit https://review.coreboot.org/c/flashrom/+/52362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41 Gerrit-Change-Number: 52362 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 15 Apr 2021 14:52:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Fixup stale FIXME comment when doit() was removed
by Angel Pons (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52365 ) Change subject: flashrom.c: Fixup stale FIXME comment when doit() was removed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52365 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40d815b7154456c323b4230cd3fed2cc2e8e3641 Gerrit-Change-Number: 52365 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Apr 2021 12:23:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h,chipset_enable.c: Make penable cb more descript
by Angel Pons (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52364 ) Change subject: programmer.h,chipset_enable.c: Make penable cb more descript ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/52364/comment/b9912f28_0edb9a88 PS1, Line 7: Make penable cb more descript Maybe it's just me, but `cb` resolves to `coreboot`. How about: Rename penable callback https://review.coreboot.org/c/flashrom/+/52364/comment/537cdc12_f7bb2356 PS1, Line 15: use typo use*d* File programmer.h: https://review.coreboot.org/c/flashrom/+/52364/comment/87bff6ba_275817c9 PS1, Line 228: enable_flash_xxx > What does xxx mean here? Maybe there is the reason for xxx? Is it possible to have the function name […] I'd prefer `enable_flash` too. -- To view, visit https://review.coreboot.org/c/flashrom/+/52364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b3a4ec51ea488c40c20ccafea883f8dea93577d Gerrit-Change-Number: 52364 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Apr 2021 12:20:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add Spansion/Cypress S25FL256L
by Angel Pons (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Nico Huber, Thomas Walker. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52310 ) Change subject: flashchips: Add Spansion/Cypress S25FL256L ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS1: > Thank you, I'm pretty new to contributing to public repositories, and this review process is a littl […] No worries. Mistakes are a part of the learning process 😊 File flashchips.c: https://review.coreboot.org/c/flashrom/+/52310/comment/ef4207c9_555870cb PS3, Line 16380: nit: tabs here too (see other chips) -- To view, visit https://review.coreboot.org/c/flashrom/+/52310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4e8cba554d0590c94dac92aa91e9ab400efca281 Gerrit-Change-Number: 52310 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Walker <thh.walker(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Walker <thh.walker(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Apr 2021 12:09:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Walker <thh.walker(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Fixup stale FIXME comment when doit() was removed
by Paul Menzel (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52365 ) Change subject: flashrom.c: Fixup stale FIXME comment when doit() was removed ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52365/comment/5c7ceed3_e4e66068 PS1, Line 7: Fixup Nit: The verb is spelled with a space: Fix up -- To view, visit https://review.coreboot.org/c/flashrom/+/52365 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40d815b7154456c323b4230cd3fed2cc2e8e3641 Gerrit-Change-Number: 52365 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Apr 2021 08:15:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Fixup stale FIXME comment when doit() was removed
by Anastasia Klimchuk (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52365 ) Change subject: flashrom.c: Fixup stale FIXME comment when doit() was removed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/52365 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I40d815b7154456c323b4230cd3fed2cc2e8e3641 Gerrit-Change-Number: 52365 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Apr 2021 05:10:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h,chipset_enable.c: Make penable cb more descript
by Anastasia Klimchuk (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52364 ) Change subject: programmer.h,chipset_enable.c: Make penable cb more descript ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/52364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b3a4ec51ea488c40c20ccafea883f8dea93577d Gerrit-Change-Number: 52364 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Apr 2021 05:09:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h,chipset_enable.c: Make penable cb more descript
by Anastasia Klimchuk (Code Review) 15 Apr '21

15 Apr '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52364 ) Change subject: programmer.h,chipset_enable.c: Make penable cb more descript ...................................................................... Patch Set 1: (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/52364/comment/a5bce4ad_6b3ce4f3 PS1, Line 228: enable_flash_xxx What does xxx mean here? Maybe there is the reason for xxx? Is it possible to have the function name just "enable_flash"? Thank you for renaming doit. -- To view, visit https://review.coreboot.org/c/flashrom/+/52364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b3a4ec51ea488c40c20ccafea883f8dea93577d Gerrit-Change-Number: 52364 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Apr 2021 05:09:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2021