April 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: dummyflasher.c: Fix memory leak on shutdown
by Anastasia Klimchuk (Code Review) 20 Apr '21

20 Apr '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52557 ) Change subject: dummyflasher.c: Fix memory leak on shutdown ...................................................................... dummyflasher.c: Fix memory leak on shutdown emu_data *data is allocated in init function and needs to be freed in shutdown function. BUG=b:181803212 TEST=builds and ninja test Change-Id: I36f76d84d3547d081c64857e06da23ee63cc5594 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M dummyflasher.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/52557/1 diff --git a/dummyflasher.c b/dummyflasher.c index 5190282..ec5060d 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -650,6 +650,7 @@ free(flashchip_contents); } #endif + free(data); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/52557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I36f76d84d3547d081c64857e06da23ee63cc5594 Gerrit-Change-Number: 52557 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Add unit test to run init/shutdown for mec1308.c
by Anastasia Klimchuk (Code Review) 20 Apr '21

20 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/51487 to look at the new patch set (#7). Change subject: tests: Add unit test to run init/shutdown for mec1308.c ...................................................................... tests: Add unit test to run init/shutdown for mec1308.c This patch includes mocks for io operations in hwaccess_io.h because those are needed to test lifecycle of mec1308.c BUG=b:181803212 TEST=builds and ninja test Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A hwaccess_io_unittest.h M meson.build M tests/init_shutdown.c M tests/meson.build M tests/tests.c M tests/tests.h 6 files changed, 137 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/51487/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/51487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc Gerrit-Change-Number: 51487 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: hwaccess.h: Split hwaccess.h and extract hwaccess_io.h out of it
by Anastasia Klimchuk (Code Review) 20 Apr '21

20 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52499 to look at the new patch set (#4). Change subject: hwaccess.h: Split hwaccess.h and extract hwaccess_io.h out of it ...................................................................... hwaccess.h: Split hwaccess.h and extract hwaccess_io.h out of it This change makes it possible to mock functions from hwaccess_io.h in tests by replacing this header with a different one when built for a test environment. The rest of hwaccess.h is fine and works for the test environment. BUG=b:181803212 TEST=make clean && make CONFIG_EVERYTHING=yes VERSION=none Build flashrom before and after this patch, flashrom binary is the same (diff flashrom_before flashrom_after shows no diffs) Change-Id: Idd04c7b36b24e9da339348a015df4f43a03744f7 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M hwaccess.h A hwaccess_io.h 2 files changed, 157 insertions(+), 136 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/52499/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/52499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd04c7b36b24e9da339348a015df4f43a03744f7 Gerrit-Change-Number: 52499 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Add unit test to run init/shutdown for linux_spi.c
by Anastasia Klimchuk (Code Review) 20 Apr '21

20 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52498 to look at the new patch set (#3). Change subject: tests: Add unit test to run init/shutdown for linux_spi.c ...................................................................... tests: Add unit test to run init/shutdown for linux_spi.c Extract from meson-logs/testlog.txt for new test: [ RUN ] linux_spi_init_and_shutdown_test_success Testing programmer_init for programmer=25 ... __wrap_open64 is called __wrap_ioctl is called __wrap_ioctl is called __wrap_ioctl is called __wrap_fopen64 is called ... programmer_init for programmer=25 successful Testing programmer_shutdown for programmer=25 ... ... programmer_shutdown for programmer=25 successful [ OK ] linux_spi_init_and_shutdown_test_success BUG=b:181803212 TEST=builds and ninja test Change-Id: I4911fbb6f04371283f0e62d2196bdd691a227584 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/init_shutdown.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/52498/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/52498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4911fbb6f04371283f0e62d2196bdd691a227584 Gerrit-Change-Number: 52498 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Add unit test to run init/shutdown for dummyflasher.c
by Anastasia Klimchuk (Code Review) 20 Apr '21

20 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52497 to look at the new patch set (#3). Change subject: tests: Add unit test to run init/shutdown for dummyflasher.c ...................................................................... tests: Add unit test to run init/shutdown for dummyflasher.c Introduce test to exercise that init and shutdown of drivers correctly manage the drivers life-time state. We constrain ourselves to dummyflasher in particular here as it does not need any mocking. BUG=b:181803212 TEST=builds and ninja test Change-Id: I3c0ef73397f00c1db7aabb5f9f00cb43525af29c Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A tests/init_shutdown.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/52497/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/52497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3c0ef73397f00c1db7aabb5f9f00cb43525af29c Gerrit-Change-Number: 52497 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Add logging to STDOUT when __wrap function is called
by Anastasia Klimchuk (Code Review) 20 Apr '21

20 Apr '21

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52496 to look at the new patch set (#2). Change subject: tests: Add logging to STDOUT when __wrap function is called ...................................................................... tests: Add logging to STDOUT when __wrap function is called Calls to __wrap functions are now logged to stdout, makes it easier to understand what’s happening, really helps when writing tests (and can be useful when debugging tests). TEST=builds and ninja test BUG=b:181803212 Change-Id: Ifcef55c9cdb7756c38dcc44fdc57cd88c3d65e70 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/tests.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/52496/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifcef55c9cdb7756c38dcc44fdc57cd88c3d65e70 Gerrit-Change-Number: 52496 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add support for Boya/BoHong Microelectronics B_25D16A
by Angel Pons (Code Review) 20 Apr '21

20 Apr '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, coreboot(a)kudera.at. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52555 ) Change subject: flashchips: Add support for Boya/BoHong Microelectronics B_25D16A ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25b776204affda94cc7e753e7671ef9d3d9508f1 Gerrit-Change-Number: 52555 Gerrit-PatchSet: 1 Gerrit-Owner: coreboot(a)kudera.at Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: coreboot(a)kudera.at Gerrit-Comment-Date: Tue, 20 Apr 2021 21:09:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for Boya/BoHong Microelectronics B_25D16A
by Name of user not set (Code Review) 20 Apr '21

20 Apr '21

coreboot(a)kudera.at has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52555 ) Change subject: flashchips: Add support for Boya/BoHong Microelectronics B_25D16A ...................................................................... flashchips: Add support for Boya/BoHong Microelectronics B_25D16A Read tested on CH341A Change-Id: I25b776204affda94cc7e753e7671ef9d3d9508f1 Signed-off-by: Christian Kudera <coreboot(a)kudera.at> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/52555/1 diff --git a/flashchips.c b/flashchips.c index 7a8e857..8bf2cd9 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3482,6 +3482,44 @@ { .vendor = "Boya/BoHong Microelectronics", + .name = "B.25D16A", + .bustype = BUS_SPI, + .manufacture_id = BOYA_BOHONG_ID, + .model_id = BOYA_BOHONG_B_25D16A, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PR, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_srwd, + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Boya/BoHong Microelectronics", .name = "B.25Q128AS", .bustype = BUS_SPI, .manufacture_id = BOYA_BOHONG_ID, diff --git a/flashchips.h b/flashchips.h index 4e155d3..12e7143 100644 --- a/flashchips.h +++ b/flashchips.h @@ -210,6 +210,7 @@ /* Boya/BoHong Microelectronics Inc. */ #define BOYA_BOHONG_ID 0x68 +#define BOYA_BOHONG_B_25D16A 0x4015 #define BOYA_BOHONG_B_25Q128AS 0x4018 /* Bright Microelectronics has the same manufacturer ID as Hyundai... */ -- To view, visit https://review.coreboot.org/c/flashrom/+/52555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25b776204affda94cc7e753e7671ef9d3d9508f1 Gerrit-Change-Number: 52555 Gerrit-PatchSet: 1 Gerrit-Owner: coreboot(a)kudera.at Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: Adapt IDs for Boya Microelectronics
by Name of user not set (Code Review) 20 Apr '21

20 Apr '21

Attention is currently required from: Nico Huber, Jack Olsen, David Hendricks, Edward O'Callaghan. coreboot(a)kudera.at has uploaded a new patch set (#2) to the change originally created by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/52550 ) Change subject: flashchips: Adapt IDs for Boya Microelectronics ...................................................................... flashchips: Adapt IDs for Boya Microelectronics Looks like BoHong Microelectronics has the same vendor ID and makes very similar chips. For instance, Boya BY25Q128AS and BoHong BH25Q128AS have the same specifications and their datasheets are mostly identical. Change-Id: I8d6951797daeeecca6af200c995297c0394adefd Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/52550/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8d6951797daeeecca6af200c995297c0394adefd Gerrit-Change-Number: 52550 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Olsen <omegasec(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jack Olsen <omegasec(a)tutanota.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Adapt IDs for Boya Microelectronics
by Angel Pons (Code Review) 20 Apr '21

20 Apr '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52550 ) Change subject: flashchips: Adapt IDs for Boya Microelectronics ...................................................................... flashchips: Adapt IDs for Boya Microelectronics Looks like BoHong Microelectronics has the same vendor ID and makes very similar chips. For instance, Boya BY25Q128AS and BoHong BH25Q128AS have the same specifications and their datasheets are mostly identical. Change-Id: I8d6951797daeeecca6af200c995297c0394adefd Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/52550/1 diff --git a/flashchips.c b/flashchips.c index 5b328f8..7a8e857 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3481,11 +3481,11 @@ }, { - .vendor = "Boya Microelectronics", - .name = "BY25Q128AS", + .vendor = "Boya/BoHong Microelectronics", + .name = "B.25Q128AS", .bustype = BUS_SPI, - .manufacture_id = BOYA_ID, - .model_id = BOYA_BY25Q128AS, + .manufacture_id = BOYA_BOHONG_ID, + .model_id = BOYA_BOHONG_B_25Q128AS, .total_size = 16384, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, diff --git a/flashchips.h b/flashchips.h index 2ad09df..4e155d3 100644 --- a/flashchips.h +++ b/flashchips.h @@ -208,9 +208,9 @@ #define ATMEL_AT49F080 0x23 #define ATMEL_AT49F080T 0x27 -/* Boya Microelectronics Inc.*/ -#define BOYA_ID 0x68 -#define BOYA_BY25Q128AS 0x4018 +/* Boya/BoHong Microelectronics Inc. */ +#define BOYA_BOHONG_ID 0x68 +#define BOYA_BOHONG_B_25Q128AS 0x4018 /* Bright Microelectronics has the same manufacturer ID as Hyundai... */ #define BRIGHT_ID 0xAD /* Bright Microelectronics */ -- To view, visit https://review.coreboot.org/c/flashrom/+/52550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8d6951797daeeecca6af200c995297c0394adefd Gerrit-Change-Number: 52550 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2021