March 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Douglas Anderson (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Patrick Rudolph. Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 ) Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Sorry for the delay and thanks for driving changes in upstream first. This does seems fine to me, however, I guess the commit message needs a bit more convincing elaboration for anyone not familiar with the complete context here. OK, I updated the description. Please confirm that it looks OK now. -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 2 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 11 Mar 2021 15:51:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Douglas Anderson (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Douglas Anderson, Angel Pons, Patrick Rudolph. Hello Hung-Te Lin, build bot (Jenkins), Edward O'Callaghan, Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/50206 to look at the new patch set (#2). Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... linux_mtd: Switch fopen() to open() for MTD devices There's no benefit to using the higher level "FILE *" for file operations for writing to mtd devices. Let's move to the lower level ones which matches the kernel more closely. For background here, using the higher level "FILE *" operations: * Gives us access to a bunch of higher level functions for file reading like fscanf(), fgets(), fgetc(), fflush(), ... Many of those are just wrappers for the lower level operations. Those that aren't (like fscanf) are things that we don't need for dealing with flash. * By default provides higher performance by buffering things behind our back. This is actually something we specifically _don't_ want because if we send a command like "erase" the C library doesn't know to throw away its buffers. NOTE: we actually already turned off buffering in commit a2f2f3f5ee1b ("linux_mtd: Disable buffering on the mtd device"). So in summary: this change is a no-op but simply removes a layer of overhead / translation that we just don't need. Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d --- M linux_mtd.c 1 file changed, 16 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/50206/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 2 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: chipset_enable.c: Add PCI ID for Comet Lake U Base
by Angel Pons (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Sam McNally. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51401 ) Change subject: chipset_enable.c: Add PCI ID for Comet Lake U Base ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I627dcacdad167343287ac0ec26b47505c2f823ee Gerrit-Change-Number: 51401 Gerrit-PatchSet: 1 Gerrit-Owner: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Comment-Date: Thu, 11 Mar 2021 09:05:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Enable dynamic memory allocation checks for cmocka unit tests.
by Daniel Kurtz (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Anastasia Klimchuk. Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51243 ) Change subject: Enable dynamic memory allocation checks for cmocka unit tests. ...................................................................... Patch Set 1: Code-Review+1 (1 comment) This change is ready for review. Patchset: PS1: Oh, I like this. I've found this kind of leak detection in unittests quite valuable in other projects. -- To view, visit https://review.coreboot.org/c/flashrom/+/51243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c6b6b8dc17aaee28640e3fca3d1fc9f7feabf5f Gerrit-Change-Number: 51243 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 11 Mar 2021 08:05:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add AT25DF011
by Nikolai Artemiev (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Hanno Heinrichs. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048 ) Change subject: flashchips: Add AT25DF011 ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: This looks OK to me based on the datasheet File flashchips.c: https://review.coreboot.org/c/flashrom/+/51048/comment/56a9fe2e_2d1223e5 PS2, Line 1495: TEST_OK_PREW Maybe add some details to the commit message about how you tested the chip. https://review.coreboot.org/c/flashrom/+/51048/comment/55f765ed_ef67ffa1 PS2, Line 1521: /* 2.3-3.6V & 2.7-3.6V models available */ The DS-25DF011–032F–5/2017 datasheet states that the range is 1.65v-3.6v. -- To view, visit https://review.coreboot.org/c/flashrom/+/51048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 2 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Comment-Date: Thu, 11 Mar 2021 06:26:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Add PCI ID for Comet Lake U Base
by Edward O'Callaghan (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Sam McNally, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51401 ) Change subject: chipset_enable.c: Add PCI ID for Comet Lake U Base ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I627dcacdad167343287ac0ec26b47505c2f823ee Gerrit-Change-Number: 51401 Gerrit-PatchSet: 1 Gerrit-Owner: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 11 Mar 2021 02:13:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Add PCI ID for Comet Lake U Base
by Sam McNally (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Edward O'Callaghan. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51401 ) Change subject: chipset_enable.c: Add PCI ID for Comet Lake U Base ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/51401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I627dcacdad167343287ac0ec26b47505c2f823ee Gerrit-Change-Number: 51401 Gerrit-PatchSet: 1 Gerrit-Owner: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 11 Mar 2021 00:55:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase
by Edward O'Callaghan (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Xiang Wang, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 ) Change subject: bitbang-spi.c: support clock polarity and phase ...................................................................... Patch Set 26: Code-Review+2 (1 comment) Patchset: PS26: Angel is there any conflict here or is this work good to merge? Seems good to me now. -- To view, visit https://review.coreboot.org/c/flashrom/+/49255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04c1dfe132d756119229b27c3cd611d1be1abc8d Gerrit-Change-Number: 49255 Gerrit-PatchSet: 26 Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 11 Mar 2021 00:34:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: flashrom: update .tested field for EN25QH128
by Nikolai Artemiev (Code Review) 11 Mar '21

11 Mar '21

Hello Tim Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/48104 to review the following change. Change subject: CHROMIUM: flashrom: update .tested field for EN25QH128 ...................................................................... CHROMIUM: flashrom: update .tested field for EN25QH128 update .tested field from TEST_UNTESTED to TEST_OK_PREW BUG=b:159768722 BRANCH=none TEST=Flash Duffy bios pass on running `flashrom_tester /usr/sbin/flashrom host` Original-Change-Id: I9467588988c2cab0987737c53ace0832144ef169 Original-Signed-off-by: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… Original-Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Original-Commit-Queue: Edward O'Callaghan <quasisec(a)chromium.org> (cherry picked from commit 045e05eb92e3dd826e8ce61973c0d1004195a3ff) Change-Id: Ic111f1a9cc5c7b5b5100ddda362c11c91e8a4165 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/48104/1 diff --git a/flashchips.c b/flashchips.c index c4ba4c6..d10bb91 100644 --- a/flashchips.c +++ b/flashchips.c @@ -4249,7 +4249,7 @@ .total_size = 1024, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/48104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic111f1a9cc5c7b5b5100ddda362c11c91e8a4165 Gerrit-Change-Number: 48104 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

2 5

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Edward O'Callaghan (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Douglas Anderson, Angel Pons, Patrick Rudolph. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 ) Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > How should we proceed here? I don't have a great environment for testing pure upstream flashrom but […] Sorry for the delay and thanks for driving changes in upstream first. This does seems fine to me, however, I guess the commit message needs a bit more convincing elaboration for anyone not familiar with the complete context here. -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 1 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 11 Mar 2021 00:29:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2021