March 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: bitbang_spi.c: Do not set MOSI during initialization
by Angel Pons (Code Review) 12 Mar '21

12 Mar '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49270 ) Change subject: bitbang_spi.c: Do not set MOSI during initialization ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/49270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I925d0ae55ae006dfcc6e7fb90364235526c576ef Gerrit-Change-Number: 49270 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: bitbang_spi: Refactor `set_sck_set_mosi`
by Angel Pons (Code Review) 12 Mar '21

12 Mar '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49269 ) Change subject: bitbang_spi: Refactor `set_sck_set_mosi` ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/49269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia84d32965e56ca563062893ebbefbbea5c35814c Gerrit-Change-Number: 49269 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: bitbang_spi: Drop `set_mosi` and `get_miso` operations
by Angel Pons (Code Review) 12 Mar '21

12 Mar '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49268 ) Change subject: bitbang_spi: Drop `set_mosi` and `get_miso` operations ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/49268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6b1edb1e01330feffc5f1ed2ca2c2ebc4fb3b66 Gerrit-Change-Number: 49268 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: nicintel_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso`
by Angel Pons (Code Review) 12 Mar '21

12 Mar '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49267 ) Change subject: nicintel_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso` ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/49267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I52a0ae5ff331ee2ed41652eb5c2ed7ebe7253d74 Gerrit-Change-Number: 49267 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: mcp6x_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso`
by Angel Pons (Code Review) 12 Mar '21

12 Mar '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49266 ) Change subject: mcp6x_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso` ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/49266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie86cc9d4df6c7f0609c30ff00d6f2d77fbb8b836 Gerrit-Change-Number: 49266 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: rayer_spi.c: Implement `set_sck_set_mosi` operation
by Angel Pons (Code Review) 12 Mar '21

12 Mar '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49265 ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` operation ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/49265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: Add support for GD25LQ256D
by Drew Fustini (Code Review) 12 Mar '21

12 Mar '21

Attention is currently required from: Nikolai Artemiev. Drew Fustini has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51113 ) Change subject: Add support for GD25LQ256D ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I have to admit this is the first time I've looked at the flashrom source code so I may not be the best person to submit this patch. I can say though that I able able to both write and read a 32MiB binary to this part OK. I put verbose logs of reading and writing successfully to the chip in this gist: https://gist.github.com/pdp7/d3939139c07f76bb2d0bf1294b35db7a Is there additional information that would be useful for me to provide? Thank you, Drew -- To view, visit https://review.coreboot.org/c/flashrom/+/51113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1b745cac070d8deb96ce65137fd9060b148b965 Gerrit-Change-Number: 51113 Gerrit-PatchSet: 1 Gerrit-Owner: Drew Fustini <drew(a)beagleboard.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 12 Mar 2021 03:52:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Add PCI ID for Comet Lake U Base
by Edward O'Callaghan (Code Review) 12 Mar '21

12 Mar '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/51401 ) Change subject: chipset_enable.c: Add PCI ID for Comet Lake U Base ...................................................................... chipset_enable.c: Add PCI ID for Comet Lake U Base TEST=`flashrom -r` on a kindred chromebook with a Celeron 5205U. Change-Id: I627dcacdad167343287ac0ec26b47505c2f823ee Signed-off-by: Sam McNally <sammc(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/51401 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M chipset_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index 138cb12..d5c10c4 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2020,6 +2020,7 @@ {0x8086, 0x9d58, B_S, NT, "Intel", "Kaby Lake U Premium", enable_flash_pch100}, {0x8086, 0x9d84, B_S, DEP, "Intel", "Cannon Lake U Premium", enable_flash_pch300}, {0x8086, 0x0284, B_S, DEP, "Intel", "Comet Lake U Premium", enable_flash_pch400}, + {0x8086, 0x0285, B_S, DEP, "Intel", "Comet Lake U Base", enable_flash_pch400}, {0x8086, 0xa141, B_S, NT, "Intel", "Sunrise Point Desktop Sample", enable_flash_pch100}, {0x8086, 0xa142, B_S, NT, "Intel", "Sunrise Point Unknown Sample", enable_flash_pch100}, {0x8086, 0xa143, B_S, DEP, "Intel", "H110", enable_flash_pch100}, -- To view, visit https://review.coreboot.org/c/flashrom/+/51401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I627dcacdad167343287ac0ec26b47505c2f823ee Gerrit-Change-Number: 51401 Gerrit-PatchSet: 2 Gerrit-Owner: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Douglas Anderson (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Patrick Rudolph. Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 ) Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Sorry for the delay and thanks for driving changes in upstream first. This does seems fine to me, however, I guess the commit message needs a bit more convincing elaboration for anyone not familiar with the complete context here. OK, I updated the description. Please confirm that it looks OK now. -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 2 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 11 Mar 2021 15:51:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Douglas Anderson (Code Review) 11 Mar '21

11 Mar '21

Attention is currently required from: Douglas Anderson, Angel Pons, Patrick Rudolph. Hello Hung-Te Lin, build bot (Jenkins), Edward O'Callaghan, Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/50206 to look at the new patch set (#2). Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... linux_mtd: Switch fopen() to open() for MTD devices There's no benefit to using the higher level "FILE *" for file operations for writing to mtd devices. Let's move to the lower level ones which matches the kernel more closely. For background here, using the higher level "FILE *" operations: * Gives us access to a bunch of higher level functions for file reading like fscanf(), fgets(), fgetc(), fflush(), ... Many of those are just wrappers for the lower level operations. Those that aren't (like fscanf) are things that we don't need for dealing with flash. * By default provides higher performance by buffering things behind our back. This is actually something we specifically _don't_ want because if we send a command like "erase" the C library doesn't know to throw away its buffers. NOTE: we actually already turned off buffering in commit a2f2f3f5ee1b ("linux_mtd: Disable buffering on the mtd device"). So in summary: this change is a no-op but simply removes a layer of overhead / translation that we just don't need. Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d --- M linux_mtd.c 1 file changed, 16 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/50206/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 2 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2021