Change in flashrom[master]: Add support for GD25LQ256D

[Drew Fustini (Code Review)]

Attention is currently required from: Nikolai Artemiev.
Drew Fustini has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51113 )

Change subject: Add support for GD25LQ256D
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
I have to admit this is the first time I've looked at the flashrom source code so I may not be the best person to submit this patch.  I can say though that I able able to both write and read a 32MiB binary to this part OK.  I put verbose logs of reading and writing successfully to the chip in this gist: https://gist.github.com/pdp7/d3939139c07f76bb2d0bf1294b35db7a   Is there additional information that would be useful for me to provide?  

Thank you,
Drew



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If1b745cac070d8deb96ce65137fd9060b148b965
Gerrit-Change-Number: 51113
Gerrit-PatchSet: 1
Gerrit-Owner: Drew Fustini <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Comment-Date: Fri, 12 Mar 2021 03:52:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment