Attention is currently required from: Hanno Heinrichs. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048 )
Change subject: flashchips: Add AT25DF011 ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: This looks OK to me based on the datasheet
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/51048/comment/56a9fe2e_2d1223e5 PS2, Line 1495: TEST_OK_PREW Maybe add some details to the commit message about how you tested the chip.
https://review.coreboot.org/c/flashrom/+/51048/comment/55f765ed_ef67ffa1 PS2, Line 1521: /* 2.3-3.6V & 2.7-3.6V models available */ The DS-25DF011–032F–5/2017 datasheet states that the range is 1.65v-3.6v.
-
Nikolai Artemiev (Code Review)