December 2021 - flashrom-gerrit

Change in flashrom[master]: [RFC][WPTST] tests: test write protection
by Angel Pons (Code Review) Dec. 2, 2021

Dec. 2, 2021

Attention is currently required from: Nico Huber, Anastasia Klimchuk, Sergii Dmytruk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: [RFC][WPTST] tests: test write protection ...................................................................... Patch Set 12: (1 comment) File tests/chip_wp.c: https://review.coreboot.org/c/flashrom/+/59075/comment/4b517f5e_aa184d82 PS11, Line 326: assert_int_equal(0x004000, range.start); : assert_int_equal(0xffc000, range.len); > In the comment above: […] Ah, so everything except for the first 16 KiB are write protected. -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 12 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 12:29:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][WPTST] tests: test write protection
by Sergii Dmytruk (Code Review) Dec. 2, 2021

Dec. 2, 2021

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: [RFC][WPTST] tests: test write protection ...................................................................... Patch Set 11: (3 comments) File tests/chip_wp.c: https://review.coreboot.org/c/flashrom/+/59075/comment/ae7c96f8_921ab392 PS11, Line 143: 0x00fff000 > Where does this magic number come from? It's size of the chip (16 MiB) minus 4 KiB. Made code compute it instead. https://review.coreboot.org/c/flashrom/+/59075/comment/995f3d67_4a872d7a PS11, Line 326: assert_int_equal(0x004000, range.start); : assert_int_equal(0xffc000, range.len); > Maybe I don't understand this properly, but aren't the values flipped? In the comment above: * Multiplaying that by base unit gives 16 KiB protected region at the * bottom, which is then complemented. So the values are correct. This is the protected range and it starts at 16 KiB and goes until the end of the chip 16 MiB. I've added that "bottom" means start of the chip. https://review.coreboot.org/c/flashrom/+/59075/comment/4adbb025_385c9584 PS11, Line 391: 0x1000 > Sorry I have just realised, for this test to work as expected range. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 02 Dec 2021 12:27:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][WPTST] tests: test write protection
by Sergii Dmytruk (Code Review) Dec. 2, 2021

Dec. 2, 2021

Attention is currently required from: Nico Huber, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59075 to look at the new patch set (#12). Change subject: [RFC][WPTST] tests: test write protection ...................................................................... [RFC][WPTST] tests: test write protection Tests both WP implementation and its emulation in dummy programmer. Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- A tests/chip_wp.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 445 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/59075/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 12 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [RFC][WPTST] tests: test write protection
by Angel Pons (Code Review) Dec. 2, 2021

Dec. 2, 2021

Attention is currently required from: Nico Huber, Sergii Dmytruk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: [RFC][WPTST] tests: test write protection ...................................................................... Patch Set 11: (2 comments) File tests/chip_wp.c: https://review.coreboot.org/c/flashrom/+/59075/comment/632f48cd_cdda1c59 PS11, Line 143: 0x00fff000 Where does this magic number come from? https://review.coreboot.org/c/flashrom/+/59075/comment/37dcffab_bceff060 PS11, Line 326: assert_int_equal(0x004000, range.start); : assert_int_equal(0xffc000, range.len); Maybe I don't understand this properly, but aren't the values flipped? -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 10:26:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][WPTST] tests: test write protection
by Anastasia Klimchuk (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: [RFC][WPTST] tests: test write protection ...................................................................... Patch Set 11: Code-Review+1 (2 comments) Patchset: PS11: This looks good ! I have one comment left. File tests/chip_wp.c: https://review.coreboot.org/c/flashrom/+/59075/comment/84fa2f30_37ab92ce PS11, Line 391: 0x1000 Sorry I have just realised, for this test to work as expected range.start should be exactly the same as start of "tail" region in layout? Can you make it a macro and use in both places? LAYOUT_TAIL_REGION_START -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 01:55:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: remove outdated warning about v1.0
by Angel Pons (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Edward O'Callaghan, Nico Huber, Sergii Dmytruk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59408 ) Change subject: flashrom.8.tmpl: remove outdated warning about v1.0 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/59408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7e0ce412901ccb27124a9958d5ef214ab289518 Gerrit-Change-Number: 59408 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Dec 2021 22:42:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: document W25Q128FV is emulated by dummyflasher
by Angel Pons (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Edward O'Callaghan, Sergii Dmytruk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59811 ) Change subject: flashrom.8.tmpl: document W25Q128FV is emulated by dummyflasher ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/59811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50f6cd6c5d853d6c70921e8027ada52d27982708 Gerrit-Change-Number: 59811 Gerrit-PatchSet: 3 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Dec 2021 22:41:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][WPTST] tests: test write protection
by Sergii Dmytruk (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: [RFC][WPTST] tests: test write protection ...................................................................... Patch Set 11: (10 comments) File tests/chip_wp.c: https://review.coreboot.org/c/flashrom/+/59075/comment/a0965549_7a649db4 PS10, Line 141: /* Use first 4 KiB for a range. */ : range.len = 0x1000; : assert_int_equal(0, flashrom_wp_set_range(&flash, &cfg, &range)); : : /* Change range to last 4 KiB. */ : range.start = 0x00fff000; : assert_int_equal(0, flashrom_wp_set_range(&flash, &cfg, &range)); > This looks like 2 in 1 tests (1 for first 4KiB range, 2 for last 4KiB). […] One range should be enough. https://review.coreboot.org/c/flashrom/+/59075/comment/c446348b_f0429daa PS10, Line 159: set_wp_mode_dummyflasher_test_success > I think the test is now good, given the comment, but maybe better name is "switch_wp_mode_.... […] Done https://review.coreboot.org/c/flashrom/+/59075/comment/b501dcb1_7861b677 PS10, Line 188: /* : * Check that "permanent" mode can't be unset and it's not considered to be : * an error at the level of library calls (verification should be done : * higher). : */ > That's a very good comment, thank you! Only need to fix indentation. Done https://review.coreboot.org/c/flashrom/+/59075/comment/59f70075_abfa3e45 PS10, Line 220: cfg.srp_bit_count = 1; : assert_int_equal(0, flashrom_wp_set_mode(&cfg, WP_MODE_DISABLED)); > I see two parts here: 1) with srp_bit_count = 2, 2) with srp_bit_count = 1 […] Split these four tests. https://review.coreboot.org/c/flashrom/+/59075/comment/2497edad_e2fa43fb PS10, Line 290: assert_int_equal(0x004000, range.start); : assert_int_equal(0xffc000, range.len); > just to check, do range start/len come from spi_status? the comment above param_dup only mentions re […] Yes, range is encoded by those bits. Datasheets contain tables of bit values and ranges that they produce (there is some logic to individual bits, but it's not very straightforward). Expanded that commend and fixed, since it diverged from the code. https://review.coreboot.org/c/flashrom/+/59075/comment/0c7f128f_a8e174e9 PS10, Line 310: assert_int_equal(0, flashrom_layout_include_region(layout, "head")); : assert_int_equal(0, flashrom_layout_include_region(layout, "tail")); > It is not clear in the context of test method where "head" and "tail" come from. […] I've added comments. These calls are here, because the test below this one includes only the "head". https://review.coreboot.org/c/flashrom/+/59075/comment/951e060c_8e05110c PS10, Line 313: Write protection takes effect only after changing SRP values. > if you can add a bit more for example […] Done https://review.coreboot.org/c/flashrom/+/59075/comment/04750d50_8a4f977e PS10, Line 329: Try erasing the chip again > also you can add continue the comment say […] Done https://review.coreboot.org/c/flashrom/+/59075/comment/de0ef341_9f3b1a9c PS10, Line 364: printf("Erase chip operation started.\n"); : assert_int_equal(0, do_erase(&flash)); : printf("Erase chip operation done.\n"); > Oh now I compare this test scenario and previous, and looks like first 4 KiB are special? Because in […] Done File tests/write_protect.c: https://review.coreboot.org/c/flashrom/+/59075/comment/97976bd0_6e14b1c5 PS5, Line 143: wp=no > Here "wp" means WP pin of the flash chip. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 22:19:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][WPTST] dummyflasher: enforce write protection for W25Q128FV
by Sergii Dmytruk (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59074 ) Change subject: [RFC][WPTST] dummyflasher: enforce write protection for W25Q128FV ...................................................................... Patch Set 11: (6 comments) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/59074/comment/53a034e2_d039d171 PS10, Line 63: bool wp; /* state of hardware write protection */ > And this name also can be hwwp Done https://review.coreboot.org/c/flashrom/+/59074/comment/83befa54_5ca45f78 PS10, Line 244: write_flash_part > The name is a bit confusing, what "part" means here? And same for erase_flash_part Part of the emulated flash defined by the range. Changed to "data". https://review.coreboot.org/c/flashrom/+/59074/comment/d39a105c_b524f362 PS10, Line 264: /* XXX: should data->erase_to_zero be taken into account here? */ > Is it a TODO, or work-in-progress note? It's a question to anyone who'll read the code. It just looks like a bug, but I'm not entirely sure. https://review.coreboot.org/c/flashrom/+/59074/comment/8a015d3c_28e7d25b PS10, Line 967: will have WP enabled > Hardware WP? Done File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/59074/comment/ac4b5373_a46ebc23 PS10, Line 696: Winbond " W25Q128FV " SPI flash chip (16384 kB, RDID)" > Oh wow this was missing in the man for all the time?! Thank you for spotting! […] Sent in CB:59811 https://review.coreboot.org/c/flashrom/+/59074/comment/21232b59_1b262fdb PS10, Line 792: wp=state > I remember we discussed that in the patch with test, yes now I see that "hwwp" would be a better nam […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/59074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fd1417f941186391bd213bd355530143c8f04a0 Gerrit-Change-Number: 59074 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 22:19:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][WPTST] dummyflasher: emualte SR2 for W25Q128FV
by Sergii Dmytruk (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59073 ) Change subject: [RFC][WPTST] dummyflasher: emualte SR2 for W25Q128FV ...................................................................... Patch Set 11: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/59073/comment/4a2e9f6f_9ec80c88 PS10, Line 8: : By the way, W25Q128FV has three status registers, but no plans to use : the third one yet. > If you remove "by the way", it is a very good second paragraph for this commit message! […] Done File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/59073/comment/e787373b_fc8ab20f PS10, Line 922: data->emu_status_len = 2; > I added a comment to previous patch about emu_status_len always 1, I see that it becomes 2 in this p […] These changes are split into addition of SR2 and use of SR2. Can squash commits into one, but I thought it's better to separate general support from a chip-specific one. -- To view, visit https://review.coreboot.org/c/flashrom/+/59073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I79f9b4a0b604663d3288ad70dcbe3ea4075dede5 Gerrit-Change-Number: 59073 Gerrit-PatchSet: 11 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 22:18:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0