January 2021 - flashrom-gerrit

Change in flashrom[master]: programmer.h: remove unused declaration
by Alan Green (Code Review) 21 Jan '21

21 Jan '21

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/49800 ) Change subject: programmer.h: remove unused declaration ...................................................................... programmer.h: remove unused declaration Removes unused declaration of noop_shutdown(). The implementation was removed in 386cc556a448fe05139f5eddf43d9fcadce41e0e and this declaration ought to have been removed at the same time. Signed-off-by: Alan Green <avg(a)google.com> Change-Id: I7599ace08f3635251a80612df4b4d29001f81d35 --- M programmer.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/49800/1 diff --git a/programmer.h b/programmer.h index 1c9ef38..29a100b 100644 --- a/programmer.h +++ b/programmer.h @@ -727,7 +727,6 @@ int register_opaque_master(const struct opaque_master *mst); /* programmer.c */ -int noop_shutdown(void); void *fallback_map(const char *descr, uintptr_t phys_addr, size_t len); void fallback_unmap(void *virt_addr, size_t len); void fallback_chip_writew(const struct flashctx *flash, uint16_t val, chipaddr addr); -- To view, visit https://review.coreboot.org/c/flashrom/+/49800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7599ace08f3635251a80612df4b4d29001f81d35 Gerrit-Change-Number: 49800 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ft2232_spi.c: release I/Os on shutdown
by Angel Pons (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Alan Green, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49632 ) Change subject: ft2232_spi.c: release I/Os on shutdown ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49632/comment/b9d1317e_982911a6 PS7, Line 9: Resets nit: Reset -- To view, visit https://review.coreboot.org/c/flashrom/+/49632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fae55e532595752983f55fac2298f81699dbe5b Gerrit-Change-Number: 49632 Gerrit-PatchSet: 7 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Jan 2021 19:11:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi.c: release I/Os on shutdown
by Alan Green (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Alan Green, Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49632 to look at the new patch set (#7). Change subject: ft2232_spi.c: release I/Os on shutdown ...................................................................... ft2232_spi.c: release I/Os on shutdown Resets FTDI I/O pins to high-Z (input) when shutting down. This allows other devices to use the SPI bus without having to disconnect the programmer. This change will introduce a backward incompatibility in the case where a user is relying on the state of FTDI outputs post-programming (eg. to disallow another device from driving CS low). However, there are likely more cases where releasing the SPI bus is the correct thing to do. Signed-off-by: Alan Green <avg(a)google.com> Change-Id: I9fae55e532595752983f55fac2298f81699dbe5b --- M ft2232_spi.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/49632/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/49632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fae55e532595752983f55fac2298f81699dbe5b Gerrit-Change-Number: 49632 Gerrit-PatchSet: 7 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Skip return value check for reset function
by Shiyu Sun (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Shiyu Sun. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49786 to look at the new patch set (#2). Change subject: realtek_mst_i2c_spi.c: Skip return value check for reset function ...................................................................... realtek_mst_i2c_spi.c: Skip return value check for reset function The return value for reset function can not be guaranteed when reset success. There is no way to check if reset success or not. BUG=b:147402710,b:152558985 BRANCH=none TEST=builds Signed-off-by: Shiyu Sun <sshiyu(a)chromium.org> Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06 --- M realtek_mst_i2c_spi.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/49786/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06 Gerrit-Change-Number: 49786 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
by Shiyu Sun (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Shiyu Sun, Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49785 to look at the new patch set (#2). Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ...................................................................... realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function Gpio 88 toggle is used as write protection disable/enable now and we need that to happen at the initialization of programmer. BUG=b:147402710,b:152558985 BRANCH=none TEST=flashrom -p realtek_mst_i2c_spi:bus=x,reset-mcu=1,enter-isp=1 -w image.bin Signed-off-by: Shiyu Sun <sshiyu(a)chromium.org> Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1 --- M realtek_mst_i2c_spi.c 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/49785/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1 Gerrit-Change-Number: 49785 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Fix indentation
by Shiyu Sun (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Shiyu Sun. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49784 to look at the new patch set (#2). Change subject: realtek_mst_i2c_spi.c: Fix indentation ...................................................................... realtek_mst_i2c_spi.c: Fix indentation BUG=none BRANCH=none TEST=builds Signed-off-by: Shiyu Sun <sshiyu(a)chromium.org> Change-Id: I730882c97926dfbe8b68b286c3805d6470993da8 --- M realtek_mst_i2c_spi.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/49784/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I730882c97926dfbe8b68b286c3805d6470993da8 Gerrit-Change-Number: 49784 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer: remove unused noop_shutdown function
by Edward O'Callaghan (Code Review) 21 Jan '21

21 Jan '21

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49631 ) Change subject: programmer: remove unused noop_shutdown function ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Unfortunately I missed this the first time in review Alan, however you left the function prototype in programmer.h can you fix this as well please by removing it. -- To view, visit https://review.coreboot.org/c/flashrom/+/49631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1b67223aed8be54b60771aa1b2d498836ed28060 Gerrit-Change-Number: 49631 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 21 Jan 2021 13:22:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi.c: Generalize GPIOL pin control
by Angel Pons (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Alan Green, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49637 ) Change subject: ft2232_spi.c: Generalize GPIOL pin control ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1f2b3b968577e62e3c5b11bcdf4afe2de6eb84ab Gerrit-Change-Number: 49637 Gerrit-PatchSet: 9 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 21 Jan 2021 09:14:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Skip return value check for reset function
by Angel Pons (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Shiyu Sun. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49786 ) Change subject: realtek_mst_i2c_spi.c: Skip return value check for reset function ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File realtek_mst_i2c_spi.c: https://review.coreboot.org/c/flashrom/+/49786/comment/379f5bc7_c83ccdd4 PS1, Line 431: /* Return value for reset mpu is not checked since : * the return value is not guaranteed to be 0 on a : * success reset. Currently there is no way to fix that. : * For more details see b:147402710. */ Comment style should be: /* * Return value for reset mpu is not checked since * the return value is not guaranteed to be 0 on a * success reset. Currently there is no way to fix * that. For more details see b:147402710. */ -- To view, visit https://review.coreboot.org/c/flashrom/+/49786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06 Gerrit-Change-Number: 49786 Gerrit-PatchSet: 1 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-Comment-Date: Thu, 21 Jan 2021 09:10:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
by Angel Pons (Code Review) 21 Jan '21

21 Jan '21

Attention is currently required from: Shiyu Sun, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 ) Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49785/comment/019aa887_d54459de PS1, Line 9: used as write protection disable/enable is it always used to toggle write-protect, or is it board-specific? -- To view, visit https://review.coreboot.org/c/flashrom/+/49785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1 Gerrit-Change-Number: 49785 Gerrit-PatchSet: 1 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Jan 2021 09:08:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2021