January 2021 - flashrom-gerrit

Change in flashrom[master]: it87spi.c: Simplify param free like cros
by Angel Pons (Code Review) 22 Jan '21

22 Jan '21

Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49823 ) Change subject: it87spi.c: Simplify param free like cros ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: This undoes what CB:46551 fixed. -- To view, visit https://review.coreboot.org/c/flashrom/+/49823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia17dfcaf758f729ae25b35d807bfbe5dc3dc5ff6 Gerrit-Change-Number: 49823 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Jan 2021 12:14:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: it87spi.c: Simplify param free like cros
by Edward O'Callaghan (Code Review) 22 Jan '21

22 Jan '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/49823 ) Change subject: it87spi.c: Simplify param free like cros ...................................................................... it87spi.c: Simplify param free like cros The CrOS fork of Flashrom has a little bit of a simplier path for free'ing the param. Replicate it here. Change-Id: Ia17dfcaf758f729ae25b35d807bfbe5dc3dc5ff6 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it87spi.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/49823/1 diff --git a/it87spi.c b/it87spi.c index 868b479..04c9aef 100644 --- a/it87spi.c +++ b/it87spi.c @@ -324,13 +324,12 @@ char *dualbiosindex_suffix; errno = 0; long chip_index = strtol(param, &dualbiosindex_suffix, 0); + free(param); if (errno != 0 || *dualbiosindex_suffix != '\0' || chip_index < 0 || chip_index > 1) { msg_perr("DualBIOS: Invalid chip index requested - choose 0 or 1.\n"); - free(param); exit_conf_mode_ite(port); return 1; } - free(param); if (chip_index != (tmp & 1)) { msg_pdbg("DualBIOS: Previous chip index: %d\n", tmp & 1); sio_write(port, 0xEF, (tmp & 0xFE) | chip_index); -- To view, visit https://review.coreboot.org/c/flashrom/+/49823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia17dfcaf758f729ae25b35d807bfbe5dc3dc5ff6 Gerrit-Change-Number: 49823 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
by Shiyu Sun (Code Review) 22 Jan '21

22 Jan '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 ) Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49785/comment/fa73e26f_b8a3c655 PS1, Line 9: used as write protection disable/enable > is it always used to toggle write-protect, or is it board-specific? I believe it is board specific GPIO 88 could be connected to other pin. -- To view, visit https://review.coreboot.org/c/flashrom/+/49785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1 Gerrit-Change-Number: 49785 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Jan 2021 03:53:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi.c: release I/Os on shutdown
by Edward O'Callaghan (Code Review) 22 Jan '21

22 Jan '21

Attention is currently required from: Alan Green, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49632 ) Change subject: ft2232_spi.c: release I/Os on shutdown ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fae55e532595752983f55fac2298f81699dbe5b Gerrit-Change-Number: 49632 Gerrit-PatchSet: 8 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Jan 2021 03:22:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: remove unused declaration
by Edward O'Callaghan (Code Review) 22 Jan '21

22 Jan '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/49800 ) Change subject: programmer.h: remove unused declaration ...................................................................... programmer.h: remove unused declaration Removes unused declaration of noop_shutdown(). The implementation was removed in 386cc556a4 and this declaration ought to have been removed at the same time. Signed-off-by: Alan Green <avg(a)google.com> Change-Id: I7599ace08f3635251a80612df4b4d29001f81d35 Reviewed-on: https://review.coreboot.org/c/flashrom/+/49800 Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Sam McNally <sammc(a)google.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M programmer.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved diff --git a/programmer.h b/programmer.h index 1c9ef38..29a100b 100644 --- a/programmer.h +++ b/programmer.h @@ -727,7 +727,6 @@ int register_opaque_master(const struct opaque_master *mst); /* programmer.c */ -int noop_shutdown(void); void *fallback_map(const char *descr, uintptr_t phys_addr, size_t len); void fallback_unmap(void *virt_addr, size_t len); void fallback_chip_writew(const struct flashctx *flash, uint16_t val, chipaddr addr); -- To view, visit https://review.coreboot.org/c/flashrom/+/49800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7599ace08f3635251a80612df4b4d29001f81d35 Gerrit-Change-Number: 49800 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: programmer.h: remove unused declaration
by Sam McNally (Code Review) 22 Jan '21

22 Jan '21

Attention is currently required from: Alan Green, Angel Pons. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49800 ) Change subject: programmer.h: remove unused declaration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7599ace08f3635251a80612df4b4d29001f81d35 Gerrit-Change-Number: 49800 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Jan 2021 02:54:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: remove unused declaration
by Edward O'Callaghan (Code Review) 22 Jan '21

22 Jan '21

Attention is currently required from: Alan Green, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49800 ) Change subject: programmer.h: remove unused declaration ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49800/comment/1ee958f0_7a8960c7 PS1, Line 10: 386cc556a448fe05139f5eddf43d9fcadce41e0e > Done . -- To view, visit https://review.coreboot.org/c/flashrom/+/49800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7599ace08f3635251a80612df4b4d29001f81d35 Gerrit-Change-Number: 49800 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Jan 2021 02:52:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alan Green <avg(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Skip return value check for reset function
by Edward O'Callaghan (Code Review) 22 Jan '21

22 Jan '21

Attention is currently required from: Shiyu Sun. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49786 ) Change subject: realtek_mst_i2c_spi.c: Skip return value check for reset function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06 Gerrit-Change-Number: 49786 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-Comment-Date: Fri, 22 Jan 2021 02:06:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Fix indentation
by Edward O'Callaghan (Code Review) 22 Jan '21

22 Jan '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/49784 ) Change subject: realtek_mst_i2c_spi.c: Fix indentation ...................................................................... realtek_mst_i2c_spi.c: Fix indentation BUG=none BRANCH=none TEST=builds Signed-off-by: Shiyu Sun <sshiyu(a)chromium.org> Change-Id: I730882c97926dfbe8b68b286c3805d6470993da8 Reviewed-on: https://review.coreboot.org/c/flashrom/+/49784 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M realtek_mst_i2c_spi.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index a0cd7c6..3dd1b36 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -26,7 +26,7 @@ #include "i2c_helper.h" -#define MCU_I2C_SLAVE_ADDR 0x94 +#define MCU_I2C_SLAVE_ADDR 0x94 #define REGISTER_ADDRESS (0x94 >> 1) #define PAGE_SIZE 128 #define MAX_SPI_WAIT_RETRIES 1000 @@ -78,7 +78,7 @@ msg_perr("Unable to extract fd from flash context.\n"); return SPI_GENERIC_ERROR; } - const struct realtek_mst_i2c_spi_data *data = + const struct realtek_mst_i2c_spi_data *data = (const struct realtek_mst_i2c_spi_data *)flash->mst->spi.data; return data->fd; @@ -429,7 +429,7 @@ static int realtek_mst_i2c_spi_shutdown(void *data) { int ret = 0; - struct realtek_mst_i2c_spi_data *realtek_mst_data = + struct realtek_mst_i2c_spi_data *realtek_mst_data = (struct realtek_mst_i2c_spi_data *)data; int fd = realtek_mst_data->fd; if (realtek_mst_data->reset) { -- To view, visit https://review.coreboot.org/c/flashrom/+/49784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I730882c97926dfbe8b68b286c3805d6470993da8 Gerrit-Change-Number: 49784 Gerrit-PatchSet: 3 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: programmer.h: remove unused declaration
by Edward O'Callaghan (Code Review) 22 Jan '21

22 Jan '21

Attention is currently required from: Alan Green, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49800 ) Change subject: programmer.h: remove unused declaration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7599ace08f3635251a80612df4b4d29001f81d35 Gerrit-Change-Number: 49800 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Jan 2021 23:32:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2021