February 2019 - flashrom-gerrit

Change in ...flashrom[master]: Fix several -Wno-implicit-fallthrough warnings

by Nico Huber (Code Review)

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30406 ) Change subject: Fix several -Wno-implicit-fallthrough warnings ...................................................................... Patch Set 3: Code-Review+2 Thanks. And welcome to Gerrit! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/30406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I05db2fb34025fefe2c6ddd1274c8e45b7cc5a4b6 Gerrit-Change-Number: 30406 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Feb 2019 09:59:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

Change in ...flashrom[master]: Fix several -Wno-implicit-fallthrough warnings

by Richard Hughes (Code Review)

Richard Hughes has uploaded a new patch set (#3) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/30406 ) Change subject: Fix several -Wno-implicit-fallthrough warnings ...................................................................... Fix several -Wno-implicit-fallthrough warnings GCC is picky about the comment being where the break should go. Change-Id: I05db2fb34025fefe2c6ddd1274c8e45b7cc5a4b6 Signed-off-by: Richard Hughes <richard(a)hughsie.com> --- M ich_descriptors.c M ichspi.c M sb600spi.c M spi25_statusreg.c 4 files changed, 9 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/30406/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I05db2fb34025fefe2c6ddd1274c8e45b7cc5a4b6 Gerrit-Change-Number: 30406 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 year, 6 months

1
0
0 0

Change in ...flashrom[master]: Fix several -Wno-implicit-fallthrough warnings

by Richard Hughes (Code Review)

Richard Hughes has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/30406 ) Change subject: Fix several -Wno-implicit-fallthrough warnings ...................................................................... Fix several -Wno-implicit-fallthrough warnings GCC is picky about the comment being where the break should go. Change-Id: I05db2fb34025fefe2c6ddd1274c8e45b7cc5a4b6 Signed-off-by: Richard Hughes <richard(a)hughsie.com> --- M ich_descriptors.c M ichspi.c M sb600spi.c M spi25_statusreg.c 4 files changed, 9 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/30406/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I05db2fb34025fefe2c6ddd1274c8e45b7cc5a4b6 Gerrit-Change-Number: 30406 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 year, 6 months

1
0
0 0

Change in ...flashrom[master]: [WIP]layout: Use a linked list for layouts

by Arthur Heymans (Code Review)

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/27102 ) Change subject: [WIP]layout: Use a linked list for layouts ...................................................................... Patch Set 1: Note to self if this get's used. Instead of appending entries to a single linked list either: - use a double linked list - replace the list HEAD instead. -- To view, visit https://review.coreboot.org/c/flashrom/+/27102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I049657805ce5676ea4c4b5e49f26d0e8a1f26a3e Gerrit-Change-Number: 27102 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Feb 2019 14:38:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

Change in ...flashrom[master]: Fix one more -Wmissing-field-initializers warning

by Nico Huber (Code Review)

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31224 Change subject: Fix one more -Wmissing-field-initializers warning ...................................................................... Fix one more -Wmissing-field-initializers warning Fixes: ichspi.c: In function ‘ich_init_spi’: ichspi.c:1707:9: warning: missing initializer for field ‘component’ Change-Id: Iee5728167963fece24822ad2e3ab7bd9d444b42c Signed-off-by: Richard Hughes <richard(a)hughsie.com> --- M ichspi.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/31224/1 diff --git a/ichspi.c b/ichspi.c index 507d443..911f50a 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1704,7 +1704,7 @@ char *arg; int ich_spi_rw_restricted = 0; int desc_valid = 0; - struct ich_descriptors desc = { 0 }; + struct ich_descriptors desc; enum ich_spi_mode { ich_auto, ich_hwseq, @@ -1715,6 +1715,8 @@ ich_generation = ich_gen; ich_spibar = spibar; + memset(&desc, 0x00, sizeof(struct ich_descriptors)); + /* Moving registers / bits */ if (ich_generation == CHIPSET_100_SERIES_SUNRISE_POINT) { num_freg = 10; -- To view, visit https://review.coreboot.org/c/flashrom/+/31224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee5728167963fece24822ad2e3ab7bd9d444b42c Gerrit-Change-Number: 31224 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 year, 6 months

1
2
0 0

Change in ...flashrom[master]: Fix a trivial calloc warning

by Nico Huber (Code Review)

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31223 Change subject: Fix a trivial calloc warning ...................................................................... Fix a trivial calloc warning Change-Id: Id457c15555a6ca6333474601f92982446afa40ab Signed-off-by: Richard Hughes <richard(a)hughsie.com> --- M flashrom.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/31223/1 diff --git a/flashrom.c b/flashrom.c index cb2da46..e82c32e 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1461,7 +1461,7 @@ int read_flash_to_file(struct flashctx *flash, const char *filename) { unsigned long size = flash->chip->total_size * 1024; - unsigned char *buf = calloc(size, sizeof(char)); + unsigned char *buf = calloc(size, sizeof(unsigned char)); int ret = 0; msg_cinfo("Reading flash... "); -- To view, visit https://review.coreboot.org/c/flashrom/+/31223 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id457c15555a6ca6333474601f92982446afa40ab Gerrit-Change-Number: 31223 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 year, 6 months

1
2
0 0

Change in ...flashrom[master]: Fix several -Wno-missing-field-initializers warnings

by Nico Huber (Code Review)

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30405 ) Change subject: Fix several -Wno-missing-field-initializers warnings ...................................................................... Fix several -Wno-missing-field-initializers warnings Change-Id: Ib4487d4c1a38fa8471fa1f9034604412e9d14cf7 Signed-off-by: Richard Hughes <richard(a)hughsie.com> Reviewed-on: https://review.coreboot.org/c/30405 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M ichspi.c M spi25.c M util/ich_descriptors_tool/ich_descriptors_tool.c 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/ichspi.c b/ichspi.c index 2144208..507d443 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1704,7 +1704,7 @@ char *arg; int ich_spi_rw_restricted = 0; int desc_valid = 0; - struct ich_descriptors desc = {{ 0 }}; + struct ich_descriptors desc = { 0 }; enum ich_spi_mode { ich_auto, ich_hwseq, diff --git a/spi25.c b/spi25.c index f3a35a1..8b6c462 100644 --- a/spi25.c +++ b/spi25.c @@ -321,9 +321,11 @@ { struct spi_command cmds[] = { { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ JEDEC_WREN }, }, { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ op }, }, @@ -344,9 +346,11 @@ const uint8_t op = flash->chip->wrea_override ? : JEDEC_WRITE_EXT_ADDR_REG; struct spi_command cmds[] = { { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ JEDEC_WREN }, }, { + .readarr = 0, .writecnt = 2, .writearr = (const unsigned char[]){ op, regdata }, }, @@ -419,9 +423,11 @@ uint8_t cmd[1 + JEDEC_MAX_ADDR_LEN + 256]; struct spi_command cmds[] = { { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ JEDEC_WREN }, }, { + .readarr = 0, .writearr = cmd, }, NULL_SPI_CMD, diff --git a/util/ich_descriptors_tool/ich_descriptors_tool.c b/util/ich_descriptors_tool/ich_descriptors_tool.c index aec97d0..aa857c8 100644 --- a/util/ich_descriptors_tool/ich_descriptors_tool.c +++ b/util/ich_descriptors_tool/ich_descriptors_tool.c @@ -150,7 +150,7 @@ const char *fn = NULL; const char *csn = NULL; enum ich_chipset cs = CHIPSET_ICH_UNKNOWN; - struct ich_descriptors desc = {{ 0 }}; + struct ich_descriptors desc = { 0 }; while ((opt = getopt(argc, argv, "df:c:")) != -1) { switch (opt) { -- To view, visit https://review.coreboot.org/c/flashrom/+/30405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib4487d4c1a38fa8471fa1f9034604412e9d14cf7 Gerrit-Change-Number: 30405 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

Change in ...flashrom[master]: Fix several -Wold-style-declaration warnings

by Nico Huber (Code Review)

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30404 ) Change subject: Fix several -Wold-style-declaration warnings ...................................................................... Fix several -Wold-style-declaration warnings Change-Id: Iffe5e652779a13ee7f64696fb5df4a781fe9a632 Signed-off-by: Richard Hughes <richard(a)hughsie.com> Reviewed-on: https://review.coreboot.org/c/30404 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M board_enable.c M flashrom.c M ichspi.c M nicintel_spi.c 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index 9d45813..00809f7 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2585,7 +2585,7 @@ * Match boards on PCI IDs and subsystem IDs. * Second set of IDs can be either main+subsystem IDs, main IDs or no IDs. */ -const static struct board_match *board_match_pci_ids(enum board_match_phase phase) +static const struct board_match *board_match_pci_ids(enum board_match_phase phase) { const struct board_match *board = board_matches; diff --git a/flashrom.c b/flashrom.c index 7129a51..cb2da46 100644 --- a/flashrom.c +++ b/flashrom.c @@ -455,10 +455,10 @@ #define SHUTDOWN_MAXFN 32 static int shutdown_fn_count = 0; /** @private */ -struct shutdown_func_data { +static struct shutdown_func_data { int (*func) (void *data); void *data; -} static shutdown_fn[SHUTDOWN_MAXFN]; +} shutdown_fn[SHUTDOWN_MAXFN]; /* Initialize to 0 to make sure nobody registers a shutdown function before * programmer init. */ diff --git a/ichspi.c b/ichspi.c index 9eb24a9..2144208 100644 --- a/ichspi.c +++ b/ichspi.c @@ -676,7 +676,7 @@ * - at least one program opcode (BYTE_PROGRAM, AAI_WORD_PROGRAM, ...?) * - necessary preops? (EWSR, WREN, ...?) */ -static int ich_missing_opcodes() +static int ich_missing_opcodes(void) { uint8_t ops[] = { JEDEC_READ, diff --git a/nicintel_spi.c b/nicintel_spi.c index 4d20c40..f31a2f9 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -218,7 +218,7 @@ return 0; } -static int nicintel_spi_i210_enable_flash() +static int nicintel_spi_i210_enable_flash(void) { uint32_t tmp; -- To view, visit https://review.coreboot.org/c/flashrom/+/30404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffe5e652779a13ee7f64696fb5df4a781fe9a632 Gerrit-Change-Number: 30404 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

2020

2019

2018

2017

flashrom-gerrit February 2019