flashrom-gerrit February 2019

flashrom-gerrit@flashrom.org

1 participants
32 discussions

Change in ...flashrom[master]: Fix several -Wno-missing-field-initializers warnings
by Nico Huber (Code Review) 04 Feb '19

04 Feb '19

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30405 ) Change subject: Fix several -Wno-missing-field-initializers warnings ...................................................................... Fix several -Wno-missing-field-initializers warnings Change-Id: Ib4487d4c1a38fa8471fa1f9034604412e9d14cf7 Signed-off-by: Richard Hughes <richard(a)hughsie.com> Reviewed-on: https://review.coreboot.org/c/30405 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M ichspi.c M spi25.c M util/ich_descriptors_tool/ich_descriptors_tool.c 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/ichspi.c b/ichspi.c index 2144208..507d443 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1704,7 +1704,7 @@ char *arg; int ich_spi_rw_restricted = 0; int desc_valid = 0; - struct ich_descriptors desc = {{ 0 }}; + struct ich_descriptors desc = { 0 }; enum ich_spi_mode { ich_auto, ich_hwseq, diff --git a/spi25.c b/spi25.c index f3a35a1..8b6c462 100644 --- a/spi25.c +++ b/spi25.c @@ -321,9 +321,11 @@ { struct spi_command cmds[] = { { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ JEDEC_WREN }, }, { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ op }, }, @@ -344,9 +346,11 @@ const uint8_t op = flash->chip->wrea_override ? : JEDEC_WRITE_EXT_ADDR_REG; struct spi_command cmds[] = { { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ JEDEC_WREN }, }, { + .readarr = 0, .writecnt = 2, .writearr = (const unsigned char[]){ op, regdata }, }, @@ -419,9 +423,11 @@ uint8_t cmd[1 + JEDEC_MAX_ADDR_LEN + 256]; struct spi_command cmds[] = { { + .readarr = 0, .writecnt = 1, .writearr = (const unsigned char[]){ JEDEC_WREN }, }, { + .readarr = 0, .writearr = cmd, }, NULL_SPI_CMD, diff --git a/util/ich_descriptors_tool/ich_descriptors_tool.c b/util/ich_descriptors_tool/ich_descriptors_tool.c index aec97d0..aa857c8 100644 --- a/util/ich_descriptors_tool/ich_descriptors_tool.c +++ b/util/ich_descriptors_tool/ich_descriptors_tool.c @@ -150,7 +150,7 @@ const char *fn = NULL; const char *csn = NULL; enum ich_chipset cs = CHIPSET_ICH_UNKNOWN; - struct ich_descriptors desc = {{ 0 }}; + struct ich_descriptors desc = { 0 }; while ((opt = getopt(argc, argv, "df:c:")) != -1) { switch (opt) { -- To view, visit https://review.coreboot.org/c/flashrom/+/30405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib4487d4c1a38fa8471fa1f9034604412e9d14cf7 Gerrit-Change-Number: 30405 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[master]: Fix several -Wold-style-declaration warnings
by Nico Huber (Code Review) 04 Feb '19

04 Feb '19

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30404 ) Change subject: Fix several -Wold-style-declaration warnings ...................................................................... Fix several -Wold-style-declaration warnings Change-Id: Iffe5e652779a13ee7f64696fb5df4a781fe9a632 Signed-off-by: Richard Hughes <richard(a)hughsie.com> Reviewed-on: https://review.coreboot.org/c/30404 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M board_enable.c M flashrom.c M ichspi.c M nicintel_spi.c 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index 9d45813..00809f7 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2585,7 +2585,7 @@ * Match boards on PCI IDs and subsystem IDs. * Second set of IDs can be either main+subsystem IDs, main IDs or no IDs. */ -const static struct board_match *board_match_pci_ids(enum board_match_phase phase) +static const struct board_match *board_match_pci_ids(enum board_match_phase phase) { const struct board_match *board = board_matches; diff --git a/flashrom.c b/flashrom.c index 7129a51..cb2da46 100644 --- a/flashrom.c +++ b/flashrom.c @@ -455,10 +455,10 @@ #define SHUTDOWN_MAXFN 32 static int shutdown_fn_count = 0; /** @private */ -struct shutdown_func_data { +static struct shutdown_func_data { int (*func) (void *data); void *data; -} static shutdown_fn[SHUTDOWN_MAXFN]; +} shutdown_fn[SHUTDOWN_MAXFN]; /* Initialize to 0 to make sure nobody registers a shutdown function before * programmer init. */ diff --git a/ichspi.c b/ichspi.c index 9eb24a9..2144208 100644 --- a/ichspi.c +++ b/ichspi.c @@ -676,7 +676,7 @@ * - at least one program opcode (BYTE_PROGRAM, AAI_WORD_PROGRAM, ...?) * - necessary preops? (EWSR, WREN, ...?) */ -static int ich_missing_opcodes() +static int ich_missing_opcodes(void) { uint8_t ops[] = { JEDEC_READ, diff --git a/nicintel_spi.c b/nicintel_spi.c index 4d20c40..f31a2f9 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -218,7 +218,7 @@ return 0; } -static int nicintel_spi_i210_enable_flash() +static int nicintel_spi_i210_enable_flash(void) { uint32_t tmp; -- To view, visit https://review.coreboot.org/c/flashrom/+/30404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffe5e652779a13ee7f64696fb5df4a781fe9a632 Gerrit-Change-Number: 30404 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2019