David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/36986 )
Change subject: mysteries_intel: Add a section about SMM_BWP
......................................................................
mysteries_intel: Add a section about SMM_BWP
Something to point users to when SMM_BWP might be causing problems.
Change-Id: I394c033e8d4ff96433162f86aefb428d8acf6349
Signed-off-by: David Hendricks <david.hendricks(a)gmail.com>
---
M Documentation/mysteries_intel.txt
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/36986/1
diff --git a/Documentation/mysteries_intel.txt b/Documentation/mysteries_intel.txt
index 10cb37d..d6ceb6a 100644
--- a/Documentation/mysteries_intel.txt
+++ b/Documentation/mysteries_intel.txt
@@ -5,6 +5,25 @@
A0h), so we have no clue if or where it is on ICH8. Out current policy is to
not touch it at all and assume/hope it is 0.
+= SMM BIOS write protection =
+Sometimes a hardware vendor will enable "SMM BIOS Write Protect" (SMM_BWP).
+The bits that control this are in the BIOS_CNTL register in the LPC interface.
+
+When enabled, the SPI flash can only be written when the system is operating in
+in System Management Mode (SMM). In other words, only code that was installed by
+the BIOS can write to the flash chip. Reads are still possible with code that
+runs outside of SMM, such as flashrom.
+
+Flashrom will attempt to detect this and print a message such as the following:
+"Warning: BIOS region SMM protection is enabled!"
+
+Many vendor-supplied firmware update utilities do not actually write to the ROM;
+instead they transfer data to/from memory which is read/written by a routine
+running in SMM and is responsible for writing to the firmware ROM. This causes
+severe system performance degradataion since all processors must be in SMM
+context (ring -2) instead of OS context (ring 0) while the firmware ROM is being
+written.
+
= Accesses beyond region bounds in descriptor mode =
Intel's flash image tool will always expand the last region so that it covers
the whole flash chip, but some boards ship with a different configuration.
--
To view, visit https://review.coreboot.org/c/flashrom/+/36986
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I394c033e8d4ff96433162f86aefb428d8acf6349
Gerrit-Change-Number: 36986
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-MessageType: newchange
David Hendricks has uploaded a new patch set (#5) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/30418 )
Change subject: manibuilder: Add list of tags used for the 1.0.x branch
......................................................................
manibuilder: Add list of tags used for the 1.0.x branch
Also add two new make targets `1.0.x` and `show-1.0.x`.
Change-Id: I2bc2e79729016a8f9908f316b051deeb73dc096f
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M util/manibuilder/Makefile.targets
1 file changed, 55 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/30418/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/30418
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2bc2e79729016a8f9908f316b051deeb73dc096f
Gerrit-Change-Number: 30418
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
David Hendricks has uploaded a new patch set (#5) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/23005 )
Change subject: Add Manibuilder
......................................................................
Add Manibuilder
Add a set of Dockerfiles for build testing. If you have an x86 machine
and ~20GiB free disk space, run `make register` and `make -jxx` in
util/manibuilder and go eat some pizza. The former runs a privileged
docker container to set binfmt_misc up for qemu (read the code, don't
trust it).
Change-Id: I60863a5c7d70dde71486fccb66cb59b30ba4d982
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
A util/manibuilder/Dockerfile.alpine
A util/manibuilder/Dockerfile.anita
A util/manibuilder/Dockerfile.centos
A util/manibuilder/Dockerfile.debian-debootstrap
A util/manibuilder/Dockerfile.djgpp
A util/manibuilder/Dockerfile.fedora
A util/manibuilder/Dockerfile.qemu-user-static
A util/manibuilder/Dockerfile.ubuntu-debootstrap
A util/manibuilder/Makefile
A util/manibuilder/Makefile.targets
A util/manibuilder/README.md
A util/manibuilder/anita-wrapper.sh
A util/manibuilder/mani-wrapper.sh
13 files changed, 470 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/23005/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/23005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I60863a5c7d70dde71486fccb66cb59b30ba4d982
Gerrit-Change-Number: 23005
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23005 )
Change subject: Add Manibuilder
......................................................................
Patch Set 4:
> Patch Set 3: Code-Review+2
>
> > Patch Set 3: Code-Review+2
> >
> > All-in-all this seems like a great step forward for build testing. I looked over the patch chain and it seems OK (nice Make-fu), but unfortunately it failed to run and I couldn't figure out why in the short amount of time I had.
> >
> > Some day I'd like to re-write most of the Makefile logic in Go or shell and hopefully make it easier to understand and modify, but that shouldn't block this patch.
>
> I was able to run this on poweredgy (my Dell Poweredge R900 space heater) some time ago.
I should clarify - I was able to run it, but there were a couple errors such as:
make[1]: *** [Makefile:39: fedora:30-aarch64-build] Error 1
I'm just not sure how to determine what's going on and how to fix it. It doesn't seem to be the fault of manibuilder per se, so I think we should get this in, use it, and improve it and add more documentation as we go.
--
To view, visit https://review.coreboot.org/c/flashrom/+/23005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I60863a5c7d70dde71486fccb66cb59b30ba4d982
Gerrit-Change-Number: 23005
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 08 Dec 2019 22:47:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Edward O'Callaghan, David Hendricks,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/36909
to review the following change.
Change subject: Revert "print.c: Dedup 'test_state_to_text()' logic"
......................................................................
Revert "print.c: Dedup 'test_state_to_text()' logic"
This reverts commit 61e16e549a52194ac80ef40504f2dc661d1ff99c.
Obviously throws alignment in the table off and changes output
class from `general` to `programmer` for no visible reason.
Change-Id: I864044b9fac6af9cf6a89c053eccdcb36f17c7bd
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M print.c
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/36909/1
diff --git a/print.c b/print.c
index 596fc53..6a7ff5d 100644
--- a/print.c
+++ b/print.c
@@ -401,7 +401,14 @@
for (i = 0; i < maxboardlen - strlen(b->name); i++)
msg_ginfo(" ");
- msg_pinfo(test_state_to_text(b->working));
+ switch (b->working) {
+ case OK: msg_ginfo("OK "); break;
+ case NT: msg_ginfo("NT "); break;
+ case DEP: msg_ginfo("DEP "); break;
+ case NA: msg_ginfo("N/A "); break;
+ case BAD:
+ default: msg_ginfo("BAD "); break;
+ }
for (e = board_matches; e->vendor_name != NULL; e++) {
if (strcmp(e->vendor_name, b->vendor)
--
To view, visit https://review.coreboot.org/c/flashrom/+/36909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I864044b9fac6af9cf6a89c053eccdcb36f17c7bd
Gerrit-Change-Number: 36909
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/37372 )
Change subject: print.c: Fix pp str format alignment in print_supported_boards_helper()
......................................................................
print.c: Fix pp str format alignment in print_supported_boards_helper()
Fix a print format regression introduced in commit
61e16e549a52194ac80ef40504f2dc661d1ff99c.
Change-Id: Ic25512bc6f31e62dfc77e32a4c71519bdde01598
Signed-off-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M print.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/37372/1
diff --git a/print.c b/print.c
index 596fc53..aeb56cb 100644
--- a/print.c
+++ b/print.c
@@ -401,7 +401,7 @@
for (i = 0; i < maxboardlen - strlen(b->name); i++)
msg_ginfo(" ");
- msg_pinfo(test_state_to_text(b->working));
+ msg_pinfo("%s\t", test_state_to_text(b->working));
for (e = board_matches; e->vendor_name != NULL; e++) {
if (strcmp(e->vendor_name, b->vendor)
--
To view, visit https://review.coreboot.org/c/flashrom/+/37372
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic25512bc6f31e62dfc77e32a4c71519bdde01598
Gerrit-Change-Number: 37372
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange