August 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Add initial J-Link SPI programmer
by Marc Schink (Code Review) 20 Aug '18

20 Aug '18

Marc Schink has posted comments on this change. ( https://review.coreboot.org/28087 ) Change subject: Add initial J-Link SPI programmer ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/28087/2/jlink_spi.c File jlink_spi.c: https://review.coreboot.org/#/c/28087/2/jlink_spi.c@344 PS2, Line 344: > Isn't this `dev` (as part of `devs`) free'd yet? No, the device instance is not free'd because we still have a reference on it (jaylink_open()) -- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 19:16:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add initial J-Link SPI programmer
by Marc Schink (Code Review) 20 Aug '18

20 Aug '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28087 to look at the new patch set (#4). Change subject: Add initial J-Link SPI programmer ...................................................................... Add initial J-Link SPI programmer Tested with SEGGER J-Link EDU, Flasher ARM and flash chip W25Q16.V. Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Signed-off-by: Marc Schink <flashrom-dev(a)marcschink.de> --- M Makefile M README M flashrom.8.tmpl M flashrom.c A jlink_spi.c M programmer.h 6 files changed, 586 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/28087/4 -- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add initial J-Link SPI programmer
by Marc Schink (Code Review) 20 Aug '18

20 Aug '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28087 to look at the new patch set (#3). Change subject: Add initial J-Link SPI programmer ...................................................................... Add initial J-Link SPI programmer Tested with SEGGER J-Link EDU, Flasher ARM and flash chip W25Q16.V. Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Signed-off-by: Marc Schink <flashrom-dev(a)marcschink.de> --- M Makefile M README M flashrom.8.tmpl M flashrom.c A jlink_spi.c M programmer.h 6 files changed, 586 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/28087/3 -- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 3 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add initial J-Link SPI programmer
by Nico Huber (Code Review) 20 Aug '18

20 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28087 ) Change subject: Add initial J-Link SPI programmer ...................................................................... Patch Set 2: (4 comments) https://review.coreboot.org/#/c/28087/1/jlink_spi.c File jlink_spi.c: https://review.coreboot.org/#/c/28087/1/jlink_spi.c@130 PS1, Line 130: > Do not free it here or set `buffer = NULL;`. Otherwise we'd […] Ping? Also, `buffer_size` should be set to zero too if we keep the free(). Btw., it would all get less complex if we'd just malloc()/free() on every call, w/o the global buffer. https://review.coreboot.org/#/c/28087/2/jlink_spi.c File jlink_spi.c: https://review.coreboot.org/#/c/28087/2/jlink_spi.c@191 PS2, Line 191: /* TODO: Use kHz for speed and update manual! */ already obsolete? https://review.coreboot.org/#/c/28087/2/jlink_spi.c@195 PS2, Line 195: && strlen(arg) > 0 Why check the strlen? if it's 0, the user literally typed `:spispeed=` without a value. Why allow that? https://review.coreboot.org/#/c/28087/2/jlink_spi.c@344 PS2, Line 344: dev Isn't this `dev` (as part of `devs`) free'd yet? -- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 16:46:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add initial J-Link SPI programmer
by Marc Schink (Code Review) 20 Aug '18

20 Aug '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28087 to look at the new patch set (#2). Change subject: Add initial J-Link SPI programmer ...................................................................... Add initial J-Link SPI programmer Tested with SEGGER J-Link EDU, Flasher ARM and flash chip W25Q16.V. Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Signed-off-by: Marc Schink <flashrom-dev(a)marcschink.de> --- M Makefile M README M flashrom.8.tmpl M flashrom.c A jlink_spi.c M programmer.h 6 files changed, 594 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/28087/2 -- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Nico Huber (Code Review) 19 Aug '18

19 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/#/c/25683/8/ni845x_spi.c File ni845x_spi.c: https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@63 PS8, Line 63: /* Copied from dediprog.c */ > Actually it is copied from the pickit2 code: > https://github.com/flashrom/flashrom/blob/master/pickit2_spi.c#L302 > > I am under the impression too that these spi clock speed > calculation functions shall be uniformized & placed to a common > place. This is about voltage ;) but, yeah, `spispeed` suffers the same. > What do you recommend? Should I create an another patchset > which modifies dediprog, pickit and rebase this onto the top of > that? That would be a good way, if you want to do it. A common place for `voltage` and `spispeed` parameter parsing would be great and much appreciated. Though, be warned, when it comes to `spipeed` there are a lot more drivers to touch. -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 8 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Sun, 19 Aug 2018 20:25:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Márton Miklós (Code Review) 19 Aug '18

19 Aug '18

Márton Miklós has posted comments on this change. ( https://review.coreboot.org/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 8: (3 comments) https://review.coreboot.org/#/c/25683/3/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/25683/3/flashrom.c@417 PS3, Line 417: { : .name = "digilent_spi", : .type = USB, : .devs.dev = devs_digilent_spi, : .init = digilent_spi_init, : .map_flash_region = fallback_map, : .unmap_flash_region = fallback_unmap, : .delay = internal_delay, : }, > Please use tabs for indentation Done https://review.coreboot.org/#/c/25683/8/ni845x_spi.c File ni845x_spi.c: PS8: > I'm only through half the file yet, will have to continue another time... hopefully soon. Thanks for the review I will fix the comments soon! https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@63 PS8, Line 63: /* Copied from dediprog.c */ > If it's really a verbatim copy, please place it into its own file […] Actually it is copied from the pickit2 code: https://github.com/flashrom/flashrom/blob/master/pickit2_spi.c#L302 I am under the impression too that these spi clock speed calculation functions shall be uniformized & placed to a common place. What do you recommend? Should I create an another patchset which modifies dediprog, pickit and rebase this onto the top of that? -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 8 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Sun, 19 Aug 2018 13:54:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Nico Huber (Code Review) 19 Aug '18

19 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 8: (18 comments) https://review.coreboot.org/#/c/25683/8/Makefile File Makefile: https://review.coreboot.org/#/c/25683/8/Makefile@967 PS8, Line 967: NI845X_LIBS += -L'C:\Program Files\National Instruments\NI-845x\MS Visual C' Please try the following: NI845X_LIBS += -L'${ProgramFiles}\National Instruments\NI-845x\MS Visual C' NI845X_LIBS += -L'${ProgramFiles(x86)}\National Instruments\NI-845x\MS Visual C' https://review.coreboot.org/#/c/25683/8/flashrom.8.tmpl File flashrom.8.tmpl: https://review.coreboot.org/#/c/25683/8/flashrom.8.tmpl@a1094 PS8, Line 1094: : it seems you dropped this from the digilent_spi description https://review.coreboot.org/#/c/25683/8/ni845x_spi.c File ni845x_spi.c: PS8: I'm only through half the file yet, will have to continue another time... hopefully soon. https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@15 PS8, Line 15: * : * You should have received a copy of the GNU General Public License : * along with this program; if not, write to the Free Software : * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Please remove this paragraph. https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@20 PS8, Line 20: #if CONFIG_NI845X_SPI == 1 remove, please. Makefile already takes care of that. https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@34 PS8, Line 34: USB845xType No CamelCase please, same for all other new identifiers. https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@43 PS8, Line 43: static char *serial_number = NULL; // by default open the first connected device This is not supposed to be global, as you added it as an argument to ni845x_spi_open(). https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@50 PS8, Line 50: // forward declaration obviously https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@52 PS8, Line 52: no space after asterisk https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@55 PS8, Line 55: static uint8_t usb8452_io_voltages_in_100mV[5] = { should be `static const` https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@63 PS8, Line 63: /* Copied from dediprog.c */ If it's really a verbatim copy, please place it into its own file (e.g. `parameters.c`). If not, the original code is GPL v2 only licensed... https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@117 PS8, Line 117: no space after asterisk https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@117 PS8, Line 117: char *serial should be `const char` https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@119 PS8, Line 119: resource_handle Why is it called `handle`? isn't it rather `resource_value`? https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@136 PS8, Line 136: serial_number should use the `serial` function parameter instead https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@160 PS8, Line 160: } else (if != 0)? https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@166 PS8, Line 166: ARRAY_SIZE You can use `sizeof()` instead, as we know it's a char array. https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@169 PS8, Line 169: } This whole block is very confusing. I don't see bigger problems, but think we can save many indentation levels and redundant code if we use a control flow as follows: tmp = ni845xFindDevice(...); if (tmp != 0) { ... return -1; } for (; serial && found_devices_count; --found_devices_count) { sscanf(resource_handle, ...); if (strtol(serial, ...) == serial_as_number) break; if (found_devices_count > 1) { if (ni845xFindDeviceNext(...) != 0) goto _close_ret; } } if (found_devices_count) ret = ni845x_spi_open_resource(...); _close_ret: Just a sketch, I guess we should check the return value of sscanf() too and (as I didn't look at the library API) I don't know if we should call ni845xCloseFindDeviceHandle() at all if ni845xFindDeviceNext() failed? -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 8 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Sun, 19 Aug 2018 13:01:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fix typos
by Nico Huber (Code Review) 19 Aug '18

19 Aug '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/28206 ) Change subject: Fix typos ...................................................................... Fix typos Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/28206 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M atapromise.c M buspirate_spi.c M ch341a_spi.c M flashchips.c M mstarddc_spi.c M physmap.c M platform.h M serial.c 8 files changed, 10 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/atapromise.c b/atapromise.c index ca63df7..ab34a1e 100644 --- a/atapromise.c +++ b/atapromise.c @@ -144,7 +144,7 @@ msg_pwarn("Do not use this device as a generic programmer. It will leave anything outside\n" "the first %zu kB of the flash chip in an undefined state. It works fine for the\n" - "purpose of updating the firmware of this device (padding may neccessary).\n", + "purpose of updating the firmware of this device (padding may necessary).\n", rom_size / 1024); return 0; diff --git a/buspirate_spi.c b/buspirate_spi.c index fad309f..437aa74 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -252,7 +252,7 @@ } free(tmp); - /* Extract serialspeed paramater */ + /* Extract serialspeed parameter */ tmp = extract_programmer_param("serialspeed"); if (tmp) { for (i = 0; serialspeeds[i].name; i++) { diff --git a/ch341a_spi.c b/ch341a_spi.c index f88b624..9ebda0d 100644 --- a/ch341a_spi.c +++ b/ch341a_spi.c @@ -315,7 +315,7 @@ /* De-assert and assert CS in one operation. */ static void pluck_cs(uint8_t *ptr) { - /* This was measured to give a minumum deassertion time of 2.25 us, + /* This was measured to give a minimum deassertion time of 2.25 us, * >20x more than needed for most SPI chips (100ns). */ int delay_cnt = 2; if (stored_delay_us) { diff --git a/flashchips.c b/flashchips.c index 1a73ba4..2001d8c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -5533,7 +5533,7 @@ .model_id = EXCEL_ES25P40, .total_size = 512, .page_size = 256, - /* 256-byte paramter page separate from memory array: + /* 256-byte parameter page separate from memory array: * supports read (0x53), fast read (0x5B), erase (0xD5) and program (0x52) instructions. */ .feature_bits = FEATURE_WRSR_WREN, .tested = TEST_UNTESTED, @@ -5564,7 +5564,7 @@ .model_id = EXCEL_ES25P80, .total_size = 1024, .page_size = 256, - /* 256-byte paramter page separate from memory array: + /* 256-byte parameter page separate from memory array: * supports read (0x53), fast read (0x5B), erase (0xD5) and program (0x52) instructions. */ .feature_bits = FEATURE_WRSR_WREN, .tested = TEST_UNTESTED, @@ -5595,7 +5595,7 @@ .model_id = EXCEL_ES25P16, .total_size = 2 * 1024, .page_size = 256, - /* 256-byte paramter page separate from memory array: + /* 256-byte parameter page separate from memory array: * supports read (0x53), fast read (0x5B), erase (0xD5) and program (0x52) instructions. */ .feature_bits = FEATURE_WRSR_WREN, .tested = TEST_UNTESTED, diff --git a/mstarddc_spi.c b/mstarddc_spi.c index f6e573a..afe4e12 100644 --- a/mstarddc_spi.c +++ b/mstarddc_spi.c @@ -57,7 +57,7 @@ } else { msg_pinfo("Info: Reset command was not sent. " "Either the noreset=1 option was used, " - "or an error occured.\n"); + "or an error occurred.\n"); } if (close(mstarddc_fd) < 0) { diff --git a/physmap.c b/physmap.c index 8dd50a5..8e80925 100644 --- a/physmap.c +++ b/physmap.c @@ -364,7 +364,7 @@ } /* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload - * and a non-working default implemenation on the bottom. See also hwaccess.h for some (re)declarations. */ + * and a non-working default implementation on the bottom. See also hwaccess.h for some (re)declarations. */ #if defined(__i386__) || defined(__x86_64__) #ifdef __linux__ diff --git a/platform.h b/platform.h index 4af1c48..d290afc 100644 --- a/platform.h +++ b/platform.h @@ -80,7 +80,7 @@ #error Unknown architecture #endif -/* The next big hunk tries to guess endianess from various preprocessor macros */ +/* The next big hunk tries to guess endianness from various preprocessor macros */ /* First some error checking in case some weird header has defined both. * NB: OpenBSD always defines _BIG_ENDIAN and _LITTLE_ENDIAN. */ #if defined (__LITTLE_ENDIAN__) && defined (__BIG_ENDIAN__) diff --git a/serial.c b/serial.c index f08542d..e61df74 100644 --- a/serial.c +++ b/serial.c @@ -194,7 +194,7 @@ return 1; } /* We want whatever the termios looks like now, so the rest of the - setup doesnt mess up the custom rate. */ + setup doesn't mess up the custom rate. */ if (tcgetattr(fd, &wanted) != 0) { /* This should pretty much never happen (see above), but.. */ msg_perr_strerror("Could not fetch serial port configuration: "); -- To view, visit https://review.coreboot.org/28206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Gerrit-Change-Number: 28206 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove empty line at EOF
by Nico Huber (Code Review) 19 Aug '18

19 Aug '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/28207 ) Change subject: Remove empty line at EOF ...................................................................... Remove empty line at EOF Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/28207 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M cli_common.c M jedec.c M print_wiki.c M sst_fwhub.c 4 files changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/cli_common.c b/cli_common.c index 2ccfe07..9375859 100644 --- a/cli_common.c +++ b/cli_common.c @@ -76,4 +76,3 @@ "Thanks for your help!\n"); } } - diff --git a/jedec.c b/jedec.c index 3343e99..54b7da7 100644 --- a/jedec.c +++ b/jedec.c @@ -751,4 +751,3 @@ (const struct unlockblock *)flash->chip->block_erasers[1].eraseblocks; return regspace2_walk_unlockblocks(flash, unlockblocks, &unlock_regspace2_block_generic); } - diff --git a/print_wiki.c b/print_wiki.c index 95158f7..ea8c4d7 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -450,4 +450,3 @@ #endif print_supported_devs_wiki(); } - diff --git a/sst_fwhub.c b/sst_fwhub.c index 306415c..398b01b 100644 --- a/sst_fwhub.c +++ b/sst_fwhub.c @@ -88,4 +88,3 @@ } return ret; } - -- To view, visit https://review.coreboot.org/28207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Gerrit-Change-Number: 28207 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2018