August 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Mark GigaDevice GD25Q512 as tested
by Nico Huber (Code Review) 19 Aug '18

19 Aug '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/28209 ) Change subject: flashchips: Mark GigaDevice GD25Q512 as tested ...................................................................... flashchips: Mark GigaDevice GD25Q512 as tested As reported by `nvflash` on IRC. Change-Id: Id3928e3790ddac34645959535e646d552ce5328e Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/28209 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Tauner <stefan.tauner(a)gmx.at> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Stefan Tauner: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 464e9b5..1a73ba4 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6054,7 +6054,7 @@ .total_size = 64, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { -- To view, visit https://review.coreboot.org/28209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id3928e3790ddac34645959535e646d552ce5328e Gerrit-Change-Number: 28209 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>

1 0

Change in flashrom[master]: usbdev: Extract libusb1 device discovery into a seperate file
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27443 ) Change subject: usbdev: Extract libusb1 device discovery into a seperate file ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27443/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27443/2//COMMIT_MSG@7 PS2, Line 7: e sep*a*rate (Paul? :-P) -- To view, visit https://review.coreboot.org/27443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idfcc79371241c2c1dea97faf5e532aa971546a79 Gerrit-Change-Number: 27443 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Thompson <daniel.thompson(a)linaro.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 18 Aug 2018 14:46:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: usbdev: Refactor device discovery code
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27444 ) Change subject: usbdev: Refactor device discovery code ...................................................................... Patch Set 2: Code-Review+1 (5 comments) Looks good, just some minor issues. https://review.coreboot.org/#/c/27444/2/usbdev.c File usbdev.c: https://review.coreboot.org/#/c/27444/2/usbdev.c@25 PS2, Line 25: _t _t is for standard libraries, _func maybe? Actually, as it's only used in a single place, you don't need a typedef. https://review.coreboot.org/#/c/27444/2/usbdev.c@84 PS2, Line 84: void * `const void *` to make that clear (unless the compiler won't let us) https://review.coreboot.org/#/c/27444/2/usbdev.c@105 PS2, Line 105: /* no need to NULL check handle; the conditional decrement makes it unnecessary */ No idea what this is supposed to mean. If you need to read the code to understand the comment, commenting is futile. https://review.coreboot.org/#/c/27444/2/usbdev.c@118 PS2, Line 118: no space after closing parenthesis https://review.coreboot.org/#/c/27444/2/usbdev.c@115 PS2, Line 115: struct libusb_device_handle *usb_dev_get_by_vid_pid_serial( : struct libusb_context *usb_ctx, uint16_t vid, uint16_t pid, const char *serialno) : { : return get_by_vid_pid_filter(usb_ctx, vid, pid, filter_by_serial, (void *) serialno); : } please group with the used filter function -- To view, visit https://review.coreboot.org/27444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31ed572501e4314b9455e1b70a5e934ec96408b1 Gerrit-Change-Number: 27444 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Thompson <daniel.thompson(a)linaro.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Aug 2018 14:45:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: usbdev: Extract libusb1 device discovery into a seperate file
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27443 ) Change subject: usbdev: Extract libusb1 device discovery into a seperate file ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/27443/2/usbdev.c File usbdev.c: https://review.coreboot.org/#/c/27443/2/usbdev.c@18 PS2, Line 18: #include "platform.h" doesn't seem useful here? https://review.coreboot.org/#/c/27443/2/usbdev.c@22 PS2, Line 22: #include "programmer.h" Do we need this? or just fash.h? -- To view, visit https://review.coreboot.org/27443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idfcc79371241c2c1dea97faf5e532aa971546a79 Gerrit-Change-Number: 27443 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Thompson <daniel.thompson(a)linaro.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 18 Aug 2018 14:27:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[staging]: Add initial J-Link SPI programmer
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has abandoned this change. ( https://review.coreboot.org/19994 ) Change subject: Add initial J-Link SPI programmer ...................................................................... Abandoned picked to master and staging is abandoned -- To view, visit https://review.coreboot.org/19994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 19994 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: helpers: Add reverse_byte() and reverse_bytes()
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has abandoned this change. ( https://review.coreboot.org/19993 ) Change subject: helpers: Add reverse_byte() and reverse_bytes() ...................................................................... Abandoned picked to master and staging is abandoned -- To view, visit https://review.coreboot.org/19993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I9d2e1e2856c835d22eed3b3a34bc0379773dd831 Gerrit-Change-Number: 19993 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has abandoned this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Abandoned picked to master long ago and staging is abandoned -- To view, visit https://review.coreboot.org/22263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove empty line at EOF
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28207 ) Change subject: Remove empty line at EOF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Gerrit-Change-Number: 28207 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Aug 2018 11:06:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove empty line at EOF
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28207 ) Change subject: Remove empty line at EOF ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28207/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28207/1//COMMIT_MSG@7 PS1, Line 7: line line*s*, actually -- To view, visit https://review.coreboot.org/28207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Gerrit-Change-Number: 28207 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 18 Aug 2018 11:06:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fix typos
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28206 ) Change subject: Fix typos ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Gerrit-Change-Number: 28206 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Aug 2018 11:05:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2018