Miklós Márton has uploaded a new patch set (#7) to the change originally created by David Hendricks. ( https://review.coreboot.org/25683 )
Change subject: Add support for National Instruments USB-845x devices
......................................................................
Add support for National Instruments USB-845x devices
Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com>
---
M Makefile
M flashrom.8.tmpl
M flashrom.c
A ni845x_spi.c
M programmer.h
5 files changed, 641 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/25683/7
--
To view, visit https://review.coreboot.org/25683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Gerrit-Change-Number: 25683
Gerrit-PatchSet: 7
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com>
Miklós Márton has posted comments on this change. ( https://review.coreboot.org/25683 )
Change subject: Add support for National Instruments USB-845x devices
......................................................................
Patch Set 6: Code-Review+1
(7 comments)
https://review.coreboot.org/#/c/25683/2/Makefile
File Makefile:
https://review.coreboot.org/#/c/25683/2/Makefile@943
PS2, Line 943:
: ifeq ($(CONFIG_CH341A_SPI), yes)
: FEATURE_CFLAGS += -D'CONFIG_CH341A_SPI=1'
: PROGRAMMER_OBJS += ch341a_spi.o
> If there is no reasonable way to probe for this path, I would prefer […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@948
PS2, Line 948: endif
> How is it licensed? If it's not GPLv2 compatible, should we print a […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@948
PS2, Line 948: endif
> I have not find an explicit license for the NI 845x, but a txt file in the installation folder links […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@948
PS2, Line 948: endif
> I didn't mean to warn anybody of NI's wrath but ours. flashrom authors […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@1349
PS2, Line 1349:
> spurious space
Done
https://review.coreboot.org/#/c/25683/3/flashrom.c
File flashrom.c:
https://review.coreboot.org/#/c/25683/3/flashrom.c@417
PS3, Line 417: {
: .name = "ni845x_spi",
: .type = OTHER, // choose other because NI-845x uses own USB implementation
: .devs.note = "National Instruments USB-845x\n",
: .init = ni845x_spi_init,
: .map_flash_region = fallback_map,
: .unmap_flash_region = fallback_unmap,
: .delay = internal_delay,
: },
> Please use tabs for indentation
Done
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c
File ni845x_spi.c:
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c@8
PS2, Line 8: * the Free Software Foundation; either version 2 of the License, or
> Please do not restrict the code to version 2 unless you really […]
Done
--
To view, visit https://review.coreboot.org/25683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Gerrit-Change-Number: 25683
Gerrit-PatchSet: 6
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com>
Gerrit-Comment-Date: Wed, 04 Jul 2018 20:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes