Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27480
to look at the new patch set (#5).
Change subject: Add ability to read fmap from ROM
......................................................................
Add ability to read fmap from ROM
This adds logic to search the ROM for the flashmap.
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
Change-Id: I83119528afeef7a864e7b774b7b7d60cb9750bb4
---
M cli_classic.c
M flashrom.8.tmpl
M fmap.c
M fmap.h
M libflashrom.c
5 files changed, 160 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/27480/5
--
To view, visit https://review.coreboot.org/27480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83119528afeef7a864e7b774b7b7d60cb9750bb4
Gerrit-Change-Number: 27480
Gerrit-PatchSet: 5
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
David Hendricks has uploaded a new patch set (#15) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................
Add support to get layout from fmap (e.g. coreboot rom)
Using the --fmap-file argument one can give flashrom a layout in fmap
binary format like is found of coreboot roms (it will also look for
this on coreboot roms).
An example of how to use:
"flashrom -p programmer --fmap-file coreboot.rom -w coreboot.rom -i COREBOOT"
to only flash the COREBOOT fmap region.
The fmap functions are mostly copied from cbfstool.
Currently it is made mutually exclusive with --ifd while still
allowing --layout until we are more clever about this input.
Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
---
M Makefile
M cli_classic.c
M flashrom.8.tmpl
A fmap.c
A fmap.h
M layout.c
M libflashrom.c
M libflashrom.h
8 files changed, 288 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/15
--
To view, visit https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
David Hendricks has abandoned this change. ( https://review.coreboot.org/27554 )
Change subject: cli_classic: Rename --fmap to --fmap-file
......................................................................
Abandoned
Squashed into 23203
--
To view, visit https://review.coreboot.org/27554
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I31e010ea99475964decfe878724000b555b6372d
Gerrit-Change-Number: 27554
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
David Hendricks has abandoned this change. ( https://review.coreboot.org/27479 )
Change subject: Forward-port Arthur's patch for latest upstream flashrom
......................................................................
Abandoned
Squashed into 23203
--
To view, visit https://review.coreboot.org/27479
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I0e0866cb836e6a3af2294d4bdcfefe38d65d0e6a
Gerrit-Change-Number: 27479
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
David Hendricks has posted comments on this change. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................
Patch Set 14: Verified+1
PS14 squashes 27479 and 27554 into this one. Please re-review.
The man page needs to be updated, but otherwise I hope this is ready for merging.
--
To view, visit https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Fri, 20 Jul 2018 00:16:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
David Hendricks has uploaded a new patch set (#14) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................
Add support to get layout from fmap (e.g. coreboot rom)
Using the --fmap-file argument one can give flashrom a layout in fmap
binary format like is found of coreboot roms (it will also look for
this on coreboot roms).
An example of how to use:
"flashrom -p programmer --fmap-file coreboot.rom -w coreboot.rom -i COREBOOT"
to only flash the COREBOOT fmap region.
The fmap functions are mostly copied from cbfstool.
Currently it is made mutually exclusive with --ifd while still
allowing --layout until we are more clever about this input.
Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
---
M Makefile
M cli_classic.c
M flashrom.8.tmpl
A fmap.c
A fmap.h
M layout.c
M libflashrom.c
M libflashrom.h
8 files changed, 288 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/14
--
To view, visit https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27480
to look at the new patch set (#3).
Change subject: Add ability to read fmap from ROM
......................................................................
Add ability to read fmap from ROM
This adds logic to search the ROM for the flashmap.
It also changes the fmap-related CLI options so that --fmap will cause
flashrom to search the ROM for the fmap, while --fmap-file <filename>
will look in <filename>.
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
Change-Id: I83119528afeef7a864e7b774b7b7d60cb9750bb4
---
M cli_classic.c
M fmap.c
M fmap.h
M libflashrom.c
4 files changed, 145 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/27480/3
--
To view, visit https://review.coreboot.org/27480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83119528afeef7a864e7b774b7b7d60cb9750bb4
Gerrit-Change-Number: 27480
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27479
to look at the new patch set (#3).
Change subject: Forward-port Arthur's patch for latest upstream flashrom
......................................................................
Forward-port Arthur's patch for latest upstream flashrom
This should probably be squashed into Arthur's patch.
Change-Id: I0e0866cb836e6a3af2294d4bdcfefe38d65d0e6a
Signed-off-by: David Hendricks <dhendricks(a)fb.com>
---
M cli_classic.c
M fmap.h
M layout.c
M libflashrom.c
M libflashrom.h
5 files changed, 84 insertions(+), 52 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/27479/3
--
To view, visit https://review.coreboot.org/27479
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e0866cb836e6a3af2294d4bdcfefe38d65d0e6a
Gerrit-Change-Number: 27479
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
David Hendricks has uploaded a new patch set (#13) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................
Add support to get layout from fmap (e.g. coreboot rom)
Using the --fmap argument one can give flashrom a layout in fmap
binary format like is found of coreboot roms (it will also look for
this on coreboot roms).
An example of how to use:
"flashrom -p programmer --fmap coreboot.rom -w coreboot.rom -i COREBOOT"
to only flash the COREBOOT fmap region.
The fmap functions are mostly copied from cbfstool.
Currently it is made mutually exclusive with --ifd while still
allowing --layout until we are more clever about this input.
Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile
M cli_classic.c
M flashrom.8.tmpl
A fmap.c
A fmap.h
M layout.c
6 files changed, 254 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/13
--
To view, visit https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>