May 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... Patch Set 3: Verified+1 Hello, Jenkins? -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 3 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 16:32:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by build bot (Jenkins) (Code Review) 11 May '18

11 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1290/ : SUCCESS -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 16:15:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... buspirate_spi: Tristate IOs when using using pullup=on Avoid putting 3.3V on IO pins when pullup=on to avoid damage to 1.8V chips. Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Reviewed-on: https://review.coreboot.org/23864 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M buspirate_spi.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/buspirate_spi.c b/buspirate_spi.c index db8b310..fad309f 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -543,6 +543,10 @@ /* Set SPI config: output type, idle, clock edge, sample */ bp_commbuf[0] = 0x80 | 0xa; + if (pullup == 1) { + bp_commbuf[0] &= ~(1 << 3); + msg_pdbg("Pull-ups enabled, so using HiZ pin output! (Open-Drain mode)\n"); + } ret = buspirate_sendrecv(bp_commbuf, 1, 1); if (ret) return 1; -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs
by build bot (Jenkins) (Code Review) 11 May '18

11 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26232 ) Change subject: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1069/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1288/ : SUCCESS -- To view, visit https://review.coreboot.org/26232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 May 2018 14:44:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs
by Nico Huber (Code Review) 11 May '18

11 May '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26232 Change subject: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs ...................................................................... chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs The Kaby Lake "200 Series" PCHs [1,2] share the register layout of their Skylake "100 Series" siblings. [1] Intel® 200 Series (including X299) Chipset Family Platform Controller Hub (PCH) Datasheet - Volume 1 of 2 Revision 002 Document Number 335192 [2] Intel® 200 Series (including X299) Chipset Family Platform Controller Hub (PCH) Datasheet - Volume 2 of 2 Revision 003 Document Number 335193 Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M chipset_enable.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/26232/1 diff --git a/chipset_enable.c b/chipset_enable.c index 15b760b..72d5de0 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1945,6 +1945,12 @@ {0x8086, 0xa245, NT, "Intel", "C627 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa246, NT, "Intel", "C628 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa247, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, + {0x8086, 0xa2c4, NT, "Intel", "H270", enable_flash_pch100}, + {0x8086, 0xa2c5, NT, "Intel", "Z270", enable_flash_pch100}, + {0x8086, 0xa2c6, NT, "Intel", "Q270", enable_flash_pch100}, + {0x8086, 0xa2c7, NT, "Intel", "Q250", enable_flash_pch100}, + {0x8086, 0xa2c8, NT, "Intel", "B250", enable_flash_pch100}, + {0x8086, 0xa2d2, NT, "Intel", "X299", enable_flash_pch100}, #endif {0}, }; -- To view, visit https://review.coreboot.org/26232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Miklós Márton (Code Review) 07 May '18

07 May '18

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: (1 comment) > > > Patch Set 1: > > > > > > (7 comments) > > Thank you very much for the review Nico! > > > > Actually tgotic proposed a much simpler (and I think better) > > approach for checking the MingW environment: > > https://github.com/flashrom/flashrom/pull/33 > > > > Is it possible to upload a new patchset if I am not an owner at > the > > gerrit? > > Hi Márton, > Did you plan to upload a revision to address Nico's comments? It > would be great to get this merged soon and reduce the patch queue. I have not been able to find where can I update my patchset. Could you please upload this as a new version of the patchset: https://patch-diff.githubusercontent.com/raw/flashrom/flashrom/pull/33.diff I have simplified the check to make it not depending on bash neither using regexps so it should address Nico comments. https://review.coreboot.org/#/c/23865/1/Makefile File Makefile: https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes) > I'm not familiar with the syntax. […] Well kind of. It is a regular expression, inspiration came from here: https://stackoverflow.com/questions/31111360/how-to-use-regular-expression-… If you have any recommendation how to make a better conditional check based on a regexp please let me know. -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Mon, 07 May 2018 18:51:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: improve termios settings on some OSes
by build bot (Jenkins) (Code Review) 07 May '18

07 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23693 ) Change subject: improve termios settings on some OSes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1287/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1068/ : SUCCESS -- To view, visit https://review.coreboot.org/23693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5da80f541e02c3b8e676e47a45388bfb115b4762 Gerrit-Change-Number: 23693 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 May 2018 17:56:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by David Hendricks (Code Review) 07 May '18

07 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: > > Patch Set 1: > > > > (7 comments) > Thank you very much for the review Nico! > > Actually tgotic proposed a much simpler (and I think better) > approach for checking the MingW environment: > https://github.com/flashrom/flashrom/pull/33 > > Is it possible to upload a new patchset if I am not an owner at the > gerrit? Hi Márton, Did you plan to upload a revision to address Nico's comments? It would be great to get this merged soon and reduce the patch queue. -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Mon, 07 May 2018 02:26:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by David Hendricks (Code Review) 07 May '18

07 May '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/23864/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23864/2//COMMIT_MSG@12 PS2, Line 12: Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> It's a tiny patch submitted via Github so I think it's safe to just add this. -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 May 2018 02:01:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: buspirate_spi: Tristate IOs when using using pullup=on
by build bot (Jenkins) (Code Review) 07 May '18

07 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: Tristate IOs when using using pullup=on ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1286/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1067/ : SUCCESS -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 May 2018 02:00:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2018