March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Nico Huber (Code Review) 07 Mar '18

07 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: >> Patch Set 1: >> >> (7 comments) > Thank you very much for the review Nico! > > Actually tgotic proposed a much simpler (and I think better) > approach for checking the MingW environment: > https://github.com/flashrom/flashrom/pull/33 > > Is it possible to upload a new patchset if I am not an owner at the > gerrit? Yes, that works. Generally, you should ask the change's owner first, but as you are the author anyway in this case, just do it. -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 16:12:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Márton Miklós (Code Review) 07 Mar '18

07 Mar '18

Márton Miklós has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: > Patch Set 1: > > (7 comments) Thank you very much for the review Nico! Actually tgotic proposed a much simpler (and I think better) approach for checking the MingW environment: https://github.com/flashrom/flashrom/pull/33 Is it possible to upload a new patchset if I am not an owner at the gerrit? -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 15:57:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add "gingerly" flashing mode for the unreliable ISP environments
by Nico Huber (Code Review) 07 Mar '18

07 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23840 ) Change subject: Add "gingerly" flashing mode for the unreliable ISP environments ...................................................................... Patch Set 2: Um, bigger things like this should actually be discussed on the mailing list first, e.g. to avoid spending time on something that might not get merged. Doesn't matter now, you already wrote it. Regarding your original problem, I guess it could be solved with some tuning of your hardware setup. Did you try to get the SoC into a better state? (reset preferred; though, as you already work with two masters on the SPI bus, did you try to boot the SoC up and halt the OS?). About this implementation, when I read "gingerly" I expected something more sophisticated (e.g. some sort of collision avoidance, listening on the bus instead of jamming it). Though, I have nothing against the way you do it, I would call it brute-force. Also, if I call `flashrom --gingerly` I would expect something that is safer to use, but it kind of is the opposite, isn't it? I don't like to clutter up spi_read_chunked() and spi_write_chunked(), most changes to them seem to be there only to avoid malloc() in your spi_rw_gingerly()? I would rather move it there. And... this might be the biggest issue: the possible endless loop in spi_rw_gingerly(). For a mergeable solution, you'd have to put some kind of timeout there. And that is where the problems start... if it can fail, we have to handle the failure correctly, otherwise flashrom (in its current implementation) would probably fall back to erase the whole chip and make things worse. Last but not least, why do it at the SPI level? Retries due to unre- liable connections should be handled at a higher level, IMO. -- To view, visit https://review.coreboot.org/23840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f18276d9fb7233d082720cb29d154f31c77100 Gerrit-Change-Number: 23840 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 14:01:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by Paul Menzel (Code Review) 07 Mar '18

07 Mar '18

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 13:32:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Nico Huber (Code Review) 07 Mar '18

07 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: (7 comments) https://review.coreboot.org/#/c/23865/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23865/1//COMMIT_MSG@7 PS1, Line 7: > Sure: […] Maybe prefix with `Makefile: `, line length should be <=55 chars, 65 maximum. https://review.coreboot.org/#/c/23865/1/Makefile File Makefile: https://review.coreboot.org/#/c/23865/1/Makefile@101 PS1, Line 101: enviroment enviro*n*ment https://review.coreboot.org/#/c/23865/1/Makefile@102 PS1, Line 102: # uname returns MINGW32_NT-5.1 on XP, MINGW32_NT-6.1 on Windows 7 missing full-stop https://review.coreboot.org/#/c/23865/1/Makefile@103 PS1, Line 103: # the regexp should support 64 bit variant of mingw if exists Please write a complete sentence, starting in upper-case, ending with a full-stop. https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: else echo no; no need for the `echo no` https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes) > Kind of. It is a regexp check inspired by this: […] Can we assume that bash is always available in MinGW/MSYS? If so, we should redirect stderr at least (`2>/dev/null` maybe? please test with MinGW). https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: $$(uname) you could use "$(HOST_OS)" instead of $$(uname) -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 13:29:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1174/ : SUCCESS -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 13:00:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by Nico Huber (Code Review) 07 Mar '18

07 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/23802/2/dmi.c File dmi.c: https://review.coreboot.org/#/c/23802/2/dmi.c@296 PS2, Line 296: #if IS_WINDOWS Updated this to use IS_WINDOWS (probably didn't exist when the original commit was written). -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 13:00:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by Nico Huber (Code Review) 07 Mar '18

07 Mar '18

Hello Stefan Tauner, Stefan Reinauer, David Hendricks, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23802 to look at the new patch set (#3). Change subject: dmi: Don't print dmidecode shell error ...................................................................... dmi: Don't print dmidecode shell error Don't print the error "sh: dmidecode: not found" if dmidecode is not there. Uses stderr redirection to /dev/null (or NUL on Windows). Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M dmi.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/23802/3 -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1173/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/982/ : SUCCESS -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 12:57:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by Nico Huber (Code Review) 07 Mar '18

07 Mar '18

Hello Stefan Tauner, Stefan Reinauer, David Hendricks, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23802 to look at the new patch set (#2). Change subject: dmi: Don't print dmidecode shell error ...................................................................... dmi: Don't print dmidecode shell error Don't print the error "sh: dmidecode: not found" if dmidecode is not there. Uses stderr redirection to /dev/null (or NUL on win32). Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M dmi.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/23802/2 -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2018