March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 10 Mar '18

10 Mar '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25047 to look at the new patch set (#8). Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Add support for Atmel / Adesto AT25SF041 SPI flash chip probe/erase/read/write/verify hardware-tests were done. Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: Julian von Mendel <git(a)jinvent.de> Signed-off-by: jvm <git(a)jinvent.de> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/25047/8 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 8 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Nico Huber (Code Review) 10 Mar '18

10 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 7: (2 comments) https://review.coreboot.org/#/c/25047/7/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/25047/7/flashchips.c@2178 PS7, Line 2178: Copy of AT25DF041A not any more https://review.coreboot.org/#/c/25047/7/flashchips.c@2209 PS7, Line 2209: .printlock = spi_prettyprint_status_register_at25df, : .unlock = spi_disable_blockprotect_at2x_global_unprotect, These do not match the chip's status register at all. Please use the generic implementations (spi_prettyprint_status_register_plain(), spi_disable_blockprotect()) unless you want to implement an at25sf variant. -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 7 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 10 Mar 2018 16:53:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 09 Mar '18

09 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1182/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/985/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 7 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 09 Mar 2018 16:32:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 09 Mar '18

09 Mar '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25047 to look at the new patch set (#7). Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Add support for Atmel / Adesto AT25SF041 SPI flash chip probe/erase/read/write/verify hardware-tests were done. Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: Julian von Mendel <git(a)jinvent.de> Signed-off-by: jvm <git(a)jinvent.de> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/25047/7 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 7 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by David Hendricks (Code Review) 09 Mar '18

09 Mar '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/25047/6/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/25047/6/flashchips.c@2213 PS6, Line 2213: 2700 2500 for the min -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 6 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 09 Mar 2018 16:26:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 09 Mar '18

09 Mar '18

Julian von Mendel has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 6: Thank you for noticing, Nico! This was an honest mistake when syncing from the Pi... AT25DF041A is the correct version. I just tested and probe/read/write works with either, erase only with the AT25DF041A version. Should be fixed now. -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 6 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 09 Mar 2018 14:35:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 09 Mar '18

09 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1181/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/984/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 6 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 09 Mar 2018 14:32:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 09 Mar '18

09 Mar '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25047 to look at the new patch set (#6). Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Add support for Atmel / Adesto AT25SF041 SPI flash chip probe/erase/read/write/verify hardware-tests were done. Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: Julian von Mendel <git(a)jinvent.de> Signed-off-by: jvm <git(a)jinvent.de> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/25047/6 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 6 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 09 Mar '18

09 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1180/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 5 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 09 Mar 2018 14:29:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 09 Mar '18

09 Mar '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25047 to look at the new patch set (#5). Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Add support for Atmel / Adesto AT25SF041 SPI flash chip probe/erase/read/write/verify hardware-tests were done. Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: Julian von Mendel <git(a)jinvent.de> Signed-off-by: jvm <git(a)jinvent.de> --- M flashchips.c M flashchips.h 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/25047/5 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 5 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2018