March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Add "gingerly" flashing mode for the unreliable ISP environments
by Mike Banon (Code Review) 08 Mar '18

08 Mar '18

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23840 ) Change subject: Add "gingerly" flashing mode for the unreliable ISP environments ...................................................................... Patch Set 2: > Bigger things like this should actually be discussed on > the mailing list first, e.g. to avoid spending time on > something that might not get merged. Doesn't matter now, > you already wrote it. In any case it wouldn't be a waste of time: before this patch there were no existing methods to read a firmware in such an unreliable ISP environment while I desperately needed a method; - now there is one :) And so far it's very successful, although a little bit slow - read it many times and all my checksums are matching! Btw I'm sure I could erase/write back in a similar way - the code for "writing" is already there, just still-not-tested on the real hardware > Regarding your original problem, I guess it could be solved > with some tuning of your hardware setup. Did you try to get > the SoC into a better state? (reset preferred) QCA 9533 SoC has the active low RESET_L pin, which theoretically could have be shortened to GND for the SoC to enter the "reset state" - but this pin isn't at the front row, its' under a chip at the rear row ( check out https://forum.openwrt.org/viewtopic.php?id=73100 for the pinout diagram ) so I couldn't touch it with multimeter to find the exposure of this pin at some convenient place on a board where it could have been shortened Also, I can't find a datasheet for this router board - but a datasheet for this SoC tells: "It is recommended to leave this signal floating if resetting the chip externally is not required", so its quite likely this pin is simply floating - not connected to anything on the board - and, since its at the rear row under a chip, it is impossible to shorten it with GND > ... though, as you already work with two masters on the > SPI bus, did you try to boot the SoC up and halt the OS? Maybe it is possible to put this SoC to reset from the firmware, but we need a universal method to read/flash the firmware without relying on what is already flashed at the router's flash chip: in example, what if my router is bricked and its' firmware cannot be loaded to halt a router? > About this implementation, when I read "gingerly" I > expected something more sophisticated (e.g. some sort of > collision avoidance, listening on the bus instead of > jamming it). Though, I have nothing against the way > you do it, I would call it brute-force. Could be renamed of course! "gingerly" was a temporary name I've chosen partially because it starts with unoccupied 'g' letter while giving an impression of what we're trying to do. If you'd like I could rename this mode to "-b | --brute-force" ("b" isn't occupied too) while freeing a "gingerly" name for the something more significant > Also, if I call `flashrom --gingerly` I would expect > something that is safer to use, but it kind of is > the opposite, isn't it? I can't see how this new mode could be more dangerous than a normal operation; also, dangerous to what - software or hardware? > > I don't like to clutter up spi_read_chunked() and > spi_write_chunked(), most changes to them seem to be there > only to avoid malloc() in your spi_rw_gingerly()? > I would rather move it there. > I agree with you, but can't see a good way of how this could be avoided. spi_rw_gingerly has to be called for each chunk, and right now there are just two malloc's for two buffers which are constantly being reused by spi_rw_gingerly. If I'd move the malloc's inside the "spi_rw_gingerly" - it will significantly raise the frequency of malloc/free calls, reducing the efficiency of flashrom. E.g. if we'd try to read a 4MB chip by those 256 byte chunks, there would be at least 32768 extra malloc's and free's > And... this might be the biggest issue: the possible > endless loop in spi_rw_gingerly(). For a mergeable solution, > you'd have to put some kind of timeout there Yes, it will hang a flashrom if this chip never becomes available even for a split second; but I don't see it as a problem: the user can terminate flashrom / restart his hardware programmer and understand that perhaps even with this mode its' impossible to read a firmware of his board and the desoldering of a chip can't be avoided with ISP mode Also, if we'd introduce a timeout - it shouldn't be hardcoded. In example: if I'd hardcode it to 5 seconds - it will block a way for the boards whose chip is available for 1 second per each 10 seconds; hardcode to 15 seconds - blocks those which are 1sec/20sec available, and so on Most likely we'll have to introduce a new flag "-t | --timeout <seconds>" ("t" is also not occupied) but lets' have more discussions to clarify our further steps > And that is where the problems start... if it can fail, > we have to handle the failure correctly, otherwise > flashrom (in its current implementation) would probably > fall back to erase the whole chip and make things worse. If there is a timeout: we could just print some error message and shutdown the flashrom, then it shouldn't do anything else... also, why would it try to erase the whole chip if we didn't specify such an operation? > Last but not least, why do it at the SPI level? Retries > due to unreliable connections should be handled at a higher > level, IMO. Sorry, I could not see a way to do this low level verification of each chunk at the higher level than the same level where these individual chunks are being read/written -- To view, visit https://review.coreboot.org/23840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f18276d9fb7233d082720cb29d154f31c77100 Gerrit-Change-Number: 23840 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 15:47:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 08 Mar '18

08 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1178/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 3 Gerrit-Owner: Julian von Mendel Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 15:07:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 08 Mar '18

08 Mar '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25047 to look at the new patch set (#3). Change subject: Support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Support for Atmel / Adesto AT25SF041 SPI flash chip Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: Julian von Mendel <git(a)jinvent.de> --- M flashchips.c M flashchips.h 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/25047/3 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 3 Gerrit-Owner: Julian von Mendel Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 08 Mar '18

08 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1177/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 2 Gerrit-Owner: Julian von Mendel Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 15:00:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 08 Mar '18

08 Mar '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25047 to look at the new patch set (#2). Change subject: Support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Support for Atmel / Adesto AT25SF041 SPI flash chip Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: jvm <git(a)jinvent.de> --- M flashchips.c M flashchips.h 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/25047/2 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 2 Gerrit-Owner: Julian von Mendel Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 08 Mar '18

08 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/983/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1176/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 1 Gerrit-Owner: Julian von Mendel Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 14:55:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Support for Atmel / Adesto AT25SF041 SPI flash chip
by Julian von Mendel (Code Review) 08 Mar '18

08 Mar '18

Julian von Mendel has uploaded this change for review. ( https://review.coreboot.org/25047 Change subject: Support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Support for Atmel / Adesto AT25SF041 SPI flash chip Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 --- M flashchips.c M flashchips.h 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/25047/1 diff --git a/flashchips.c b/flashchips.c index 1ab4986..2a2855f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2177,6 +2177,38 @@ { .vendor = "Atmel", + .name = "AT25SF041", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25SF041, + .total_size = 512, + .page_size = 256, + /* does not support EWSR nor WREN and has no writable status register bits whatsoever */ + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {256, 2048} }, + .block_erase = spi_block_erase_81, + }, { + .eraseblocks = { {2 * 1024, 256} }, + .block_erase = spi_block_erase_50, + }, { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + } + }, + .printlock = spi_prettyprint_status_register_plain, + /* Supports also an incompatible page write (of exactly 256 B) and an auto-erasing write. */ + .write = spi_chip_write_1, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, /* 3.0-3.6V for higher speed, 2.7-3.6V normal */ + }, + + { + .vendor = "Atmel", .name = "AT26DF041", .bustype = BUS_SPI, .manufacture_id = ATMEL_ID, diff --git a/flashchips.h b/flashchips.h index 452f776..98d6e03 100644 --- a/flashchips.h +++ b/flashchips.h @@ -150,6 +150,7 @@ #define ATMEL_AT25F4096 0x64 /* Needs AT25F_RDID */ #define ATMEL_AT25FS010 0x6601 #define ATMEL_AT25FS040 0x6604 +#define ATMEL_AT25SF041 0x8401 #define ATMEL_AT26DF041 0x4400 #define ATMEL_AT26DF081 0x4500 /* guessed, no datasheet available */ #define ATMEL_AT26DF081A 0x4501 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 1 Gerrit-Owner: Julian von Mendel

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by build bot (Jenkins) (Code Review) 08 Mar '18

08 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1175/ : SUCCESS -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 09:18:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by Nico Huber (Code Review) 08 Mar '18

08 Mar '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... dmi: Don't print dmidecode shell error Don't print the error "sh: dmidecode: not found" if dmidecode is not there. Uses stderr redirection to /dev/null (or NUL on Windows). Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/23802 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- M dmi.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve diff --git a/dmi.c b/dmi.c index 729cdb1..70b1177 100644 --- a/dmi.c +++ b/dmi.c @@ -34,6 +34,7 @@ #include <stdio.h> #include <stdlib.h> +#include "platform.h" #include "flash.h" #include "programmer.h" @@ -292,7 +293,11 @@ #else /* CONFIG_INTERNAL_DMI */ #define DMI_COMMAND_LEN_MAX 300 -static const char *dmidecode_command = "dmidecode"; +#if IS_WINDOWS +static const char *dmidecode_command = "dmidecode.exe 2>NUL"; +#else +static const char *dmidecode_command = "dmidecode 2>/dev/null"; +#endif static char *get_dmi_string(const char *string_name) { -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by Stefan Reinauer (Code Review) 08 Mar '18

08 Mar '18

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 00:24:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2018