October 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add Macronix MX25U8032E
by Nico Huber (Code Review) 07 Oct '18

07 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28821 ) Change subject: flashchips: Add Macronix MX25U8032E ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0 Gerrit-Change-Number: 28821 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 07 Oct 2018 11:16:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: chipset_enable.c: Mark Intel HM65 as DEP
by Angel Pons (Code Review) 07 Oct '18

07 Oct '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28955 Change subject: chipset_enable.c: Mark Intel HM65 as DEP ...................................................................... chipset_enable.c: Mark Intel HM65 as DEP Tested reading, writing and erasing the internal flash chip using a Toshiba L755 laptop with an Intel HM65. However, since all ME-enabled chipsets are marked as DEP instead of OK, this one shall follow suit as well. Change-Id: I3fd62c3b4ee17a403cc3937422f3d850fd2878a4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/28955/1 diff --git a/chipset_enable.c b/chipset_enable.c index b689aec..22021a7 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1724,7 +1724,7 @@ {0x8086, 0x1c44, DEP, "Intel", "Z68", enable_flash_pch6}, {0x8086, 0x1c46, DEP, "Intel", "P67", enable_flash_pch6}, {0x8086, 0x1c47, NT, "Intel", "UM67", enable_flash_pch6}, - {0x8086, 0x1c49, NT, "Intel", "HM65", enable_flash_pch6}, + {0x8086, 0x1c49, DEP, "Intel", "HM65", enable_flash_pch6}, {0x8086, 0x1c4a, DEP, "Intel", "H67", enable_flash_pch6}, {0x8086, 0x1c4b, NT, "Intel", "HM67", enable_flash_pch6}, {0x8086, 0x1c4c, NT, "Intel", "Q65", enable_flash_pch6}, -- To view, visit https://review.coreboot.org/28955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3fd62c3b4ee17a403cc3937422f3d850fd2878a4 Gerrit-Change-Number: 28955 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add Macronix MX25U8032E
by Angel Pons (Code Review) 07 Oct '18

07 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28821 ) Change subject: flashchips: Add Macronix MX25U8032E ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/28821/1/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28821/1/flashchips.c@8449 PS1, Line 8449: .block_erase = spi_block_erase_d8, > I don't see that in the datasheet... Gone https://review.coreboot.org/#/c/28821/1/flashchips.c@8450 PS1, Line 8450: > should probably be removed too Gone -- To view, visit https://review.coreboot.org/28821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0 Gerrit-Change-Number: 28821 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 07 Oct 2018 11:06:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Macronix MX25U8032E
by Angel Pons (Code Review) 07 Oct '18

07 Oct '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28821 to look at the new patch set (#3). Change subject: flashchips: Add Macronix MX25U8032E ...................................................................... flashchips: Add Macronix MX25U8032E As per `The_Raven Raven` on the mailing list. Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/28821/3 -- To view, visit https://review.coreboot.org/28821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0 Gerrit-Change-Number: 28821 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Nico Huber (Code Review) 05 Oct '18

05 Oct '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/28910 ) Change subject: flashchips: Add W25Q128.V..W ...................................................................... flashchips: Add W25Q128.V..W Port the code from chromeos flashrom. Tested using W25Q128JVSIM in SPI mode. Change-Id: I38397a0c831407afa21cddca8485664576fce92c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/28910 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index d2773d6..e066e03 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15431,6 +15431,43 @@ { .vendor = "Winbond", + .name = "W25Q128.V..M", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q128_V_M, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Winbond", .name = "W25Q256.V", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, diff --git a/flashchips.h b/flashchips.h index 6bc4094..7c1a523 100644 --- a/flashchips.h +++ b/flashchips.h @@ -925,6 +925,7 @@ #define WINBOND_NEX_W25Q32_W 0x6016 /* W25Q32DW; W25Q32FV in QPI mode */ #define WINBOND_NEX_W25Q64_W 0x6017 /* W25Q64DW; W25Q64FV in QPI mode */ #define WINBOND_NEX_W25Q128_W 0x6018 /* W25Q128FW; W25Q128FV in QPI mode */ +#define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */ #define WINBOND_ID 0xDA /* Winbond */ #define WINBOND_W19B160BB 0x49 -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove unneeded whitespace
by Nico Huber (Code Review) 05 Oct '18

05 Oct '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/28707 ) Change subject: Remove unneeded whitespace ...................................................................... Remove unneeded whitespace Change-Id: I0e72e3e3736a39685b7f166c5e6b06cc241b26be Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/28707 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M chipset_enable.c M flashrom.c 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index 4b28924..b689aec 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -151,7 +151,7 @@ tmp &= (~0x20); tmp |= 0x4; sio_write(0x22, 0x70, tmp); - + return ret; } diff --git a/flashrom.c b/flashrom.c index c41801a..59a7531 100644 --- a/flashrom.c +++ b/flashrom.c @@ -654,7 +654,6 @@ return NULL; /* Needle followed by '='? */ if (param_pos[needlelen] == '=') { - /* Beginning of the string? */ if (param_pos == *haystack) break; -- To view, visit https://review.coreboot.org/28707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0e72e3e3736a39685b7f166c5e6b06cc241b26be Gerrit-Change-Number: 28707 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: ft2232_spi: add an ability to use GPIO for chip selection
by Sergey Alirzaev (Code Review) 04 Oct '18

04 Oct '18

Sergey Alirzaev has uploaded this change for review. ( https://review.coreboot.org/28911 Change subject: ft2232_spi: add an ability to use GPIO for chip selection ...................................................................... ft2232_spi: add an ability to use GPIO for chip selection Change-Id: I6db05619e0d69ad18549c8556ef69225337b1532 Signed-off-by: Sergey Alirzaev <zl29ah(a)gmail.com> --- M flashrom.8.tmpl M ft2232_spi.c 2 files changed, 27 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/28911/1 diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 70af395..cbb3378 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -722,9 +722,9 @@ Multi-Protocol Adapter (TUMPA), TUMPA Lite, GOEPEL PicoTAP and Google Servo v1/v2. .sp An optional parameter specifies the controller -type and channel/interface/port it should support. For that you have to use the +type and channel/interface/port/GPIO-based chip select it should support. For that you have to use the .sp -.B " flashrom \-p ft2232_spi:type=model,port=interface" +.B " flashrom \-p ft2232_spi:type=model,port=interface,csgpiol=gpio" .sp syntax where .B model @@ -733,14 +733,17 @@ arm-usb-tiny ", " arm-usb-tiny-h ", " arm-usb-ocd ", " arm-usb-ocd-h \ ", " tumpa ", " tumpalite ", " picotap ", " google-servo ", " google-servo-v2 \ " or " google-servo-v2-legacy -and .B interface can be -.BR A ", " B ", " C ", or " D . +.BR A ", " B ", " C ", or " D +and +.B csgpiol +can be a number between 0 and 3, denoting GPIOL0-GPIOL3 correspondingly. The default model is .B 4232H -and the default interface is -.BR A . +the default interface is +.BR A +and GPIO is not used by default. .sp If there is more than one ft2232_spi-compatible device connected, you can select which one should be used by specifying its serial number with the diff --git a/ft2232_spi.c b/ft2232_spi.c index 819744c..79d9d82 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -327,6 +327,24 @@ } free(arg); + arg = extract_programmer_param("csgpiol"); + if (arg && strlen(arg)) { + unsigned int temp = 0; + char *endptr; + temp = strtoul(arg, &endptr, 10); + if (*endptr || temp > 3) { + msg_perr("Error: Invalid GPIOL specified: \"%s\".\n" + "Valid values are between 0 and 3.\n", arg); + free(arg); + return -2; + } else { + unsigned pin = temp + 4; + cs_bits |= 1 << pin; + pindir |= 1 << pin; + } + } + free(arg); + msg_pdbg("Using device type %s %s ", get_ft2232_vendorname(ft2232_vid, ft2232_type), get_ft2232_devicename(ft2232_vid, ft2232_type)); -- To view, visit https://review.coreboot.org/28911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6db05619e0d69ad18549c8556ef69225337b1532 Gerrit-Change-Number: 28911 Gerrit-PatchSet: 1 Gerrit-Owner: Sergey Alirzaev <zl29ah(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Nico Huber (Code Review) 04 Oct '18

04 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28910 ) Change subject: flashchips: Add W25Q128.V..W ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Oct 2018 15:39:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Patrick Rudolph (Code Review) 04 Oct '18

04 Oct '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28910 ) Change subject: flashchips: Add W25Q128.V..W ...................................................................... Patch Set 5: (2 comments) Removed all whitespace and replaced by tabs https://review.coreboot.org/#/c/28910/2/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/28910/2/flashchips.h@928 PS2, Line 928: #define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */ > comment should be indented with a tab Done https://review.coreboot.org/#/c/28910/2/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28910/2/flashchips.c@15671 PS2, Line 15671: .manufacture_id = WINBOND_NEX_ID, > Entries should be ordered alphabetically. So this would come after […] Done -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 04 Oct 2018 14:54:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Patrick Rudolph (Code Review) 04 Oct '18

04 Oct '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28910 to look at the new patch set (#5). Change subject: flashchips: Add W25Q128.V..W ...................................................................... flashchips: Add W25Q128.V..W Port the code from chromeos flashrom. Tested using W25Q128JVSIM in SPI mode. Change-Id: I38397a0c831407afa21cddca8485664576fce92c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28910/5 -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2018