October 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Patrick Rudolph (Code Review) 04 Oct '18

04 Oct '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28910 to look at the new patch set (#4). Change subject: flashchips: Add W25Q128.V..W ...................................................................... flashchips: Add W25Q128.V..W Port the code from chromeos flashrom. Tested using W25Q128JVSIM in SPI mode. Change-Id: I38397a0c831407afa21cddca8485664576fce92c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28910/4 -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Patrick Rudolph (Code Review) 04 Oct '18

04 Oct '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28910 to look at the new patch set (#3). Change subject: flashchips: Add W25Q128.V..W ...................................................................... flashchips: Add W25Q128.V..W Port the code from chromeos flashrom. Tested using W25Q128JVSIM in SPI mode. Change-Id: I38397a0c831407afa21cddca8485664576fce92c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28910/3 -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Nico Huber (Code Review) 04 Oct '18

04 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28910 ) Change subject: flashchips: Add W25Q128.V..W ...................................................................... Patch Set 2: (2 comments) only some nits left https://review.coreboot.org/#/c/28910/2/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/28910/2/flashchips.h@928 PS2, Line 928: #define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */ comment should be indented with a tab https://review.coreboot.org/#/c/28910/2/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28910/2/flashchips.c@15671 PS2, Line 15671: .name = "W25Q128.V..M", Entries should be ordered alphabetically. So this would come after W25Q128.V I guess -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 04 Oct 2018 13:51:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add W25Q128.V..W
by Patrick Rudolph (Code Review) 04 Oct '18

04 Oct '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28910 to look at the new patch set (#2). Change subject: flashchips: Add W25Q128.V..W ...................................................................... flashchips: Add W25Q128.V..W Port the code from chromeos flashrom. Tested using W25Q128JVSIM in SPI mode. Change-Id: I38397a0c831407afa21cddca8485664576fce92c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28910/2 -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: flashchips: Add W25Q128J
by Nico Huber (Code Review) 04 Oct '18

04 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28910 ) Change subject: flashchips: Add W25Q128J ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28910/1/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/28910/1/flashchips.h@928 PS1, Line 928: #define WINBOND_NEX_W25Q128J 0x7018 /* W25Q128J */ As mentioned on IRC, for this id it would have to be "W25Q128.V..M" maybe WINDBOND_NEX_W25Q128_V_M as the macro name. -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 04 Oct 2018 13:40:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add W25Q128J
by Patrick Rudolph (Code Review) 04 Oct '18

04 Oct '18

Hello Patrick Rudolph, I'd like you to do a code review. Please visit https://review.coreboot.org/28910 to review the following change. Change subject: flashchips: Add W25Q128J ...................................................................... flashchips: Add W25Q128J Port the code from chromeos flashrom. Tested using W25Q128J in SPI mode. Change-Id: I38397a0c831407afa21cddca8485664576fce92c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28910/1 diff --git a/flashchips.c b/flashchips.c index d2773d6..3c8dfe5 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15666,6 +15666,43 @@ .voltage = {1650, 1950}, /* Fast read (0x0B) and multi I/O supported */ }, + { + .vendor = "Winbond", + .name = "W25Q128J", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q128J, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + { .vendor = "Winbond", .name = "W25Q16.W", diff --git a/flashchips.h b/flashchips.h index 6bc4094..7ec7aab 100644 --- a/flashchips.h +++ b/flashchips.h @@ -925,6 +925,7 @@ #define WINBOND_NEX_W25Q32_W 0x6016 /* W25Q32DW; W25Q32FV in QPI mode */ #define WINBOND_NEX_W25Q64_W 0x6017 /* W25Q64DW; W25Q64FV in QPI mode */ #define WINBOND_NEX_W25Q128_W 0x6018 /* W25Q128FW; W25Q128FV in QPI mode */ +#define WINBOND_NEX_W25Q128J 0x7018 /* W25Q128J */ #define WINBOND_ID 0xDA /* Winbond */ #define WINBOND_W19B160BB 0x49 -- To view, visit https://review.coreboot.org/28910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c Gerrit-Change-Number: 28910 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in flashrom[master]: Remove unneeded whitespace
by Nico Huber (Code Review) 04 Oct '18

04 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28707 ) Change subject: Remove unneeded whitespace ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/28707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e72e3e3736a39685b7f166c5e6b06cc241b26be Gerrit-Change-Number: 28707 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Oct 2018 12:54:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove unneeded whitespace
by Elyes HAOUAS (Code Review) 04 Oct '18

04 Oct '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28707 ) Change subject: Remove unneeded whitespace ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/28707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e72e3e3736a39685b7f166c5e6b06cc241b26be Gerrit-Change-Number: 28707 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Oct 2018 08:45:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Remove unneeded whitespace and fix char line limit
by Elyes HAOUAS (Code Review) 04 Oct '18

04 Oct '18

Elyes HAOUAS has restored this change. ( https://review.coreboot.org/28707 ) Change subject: Remove unneeded whitespace and fix char line limit ...................................................................... Restored -- To view, visit https://review.coreboot.org/28707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: I0e72e3e3736a39685b7f166c5e6b06cc241b26be Gerrit-Change-Number: 28707 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove unneeded whitespace and fix char line limit
by Elyes HAOUAS (Code Review) 04 Oct '18

04 Oct '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28707 ) Change subject: Remove unneeded whitespace and fix char line limit ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0e72e3e3736a39685b7f166c5e6b06cc241b26be Gerrit-Change-Number: 28707 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2018