January 2018 - flashrom-gerrit

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by Arthur Heymans (Code Review) 08 Jan '18

08 Jan '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/23021/5/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/5/flashrom.c@1387 PS5, Line 1387: if ((entry->start > size) || (entry->end > size)) { > Checking `entry->end` should suffice. is entry->start always smaller than entry->end? afaik coreboot/util/ifdtool generates regions where this is not the case for unused regions... https://review.coreboot.org/#/c/23021/5/layout.c File layout.c: https://review.coreboot.org/#/c/23021/5/layout.c@189 PS5, Line 189: /* Quotes or whitespace are not allowed in region names. */ > why test it here? why add it now? I suppose this could go in the read_romlayout() function for when a layout file is provided. when fetched with --ifd, " } else if (ifd && (flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0) || process_include_args(layout))) { " one can expect the layout to be sane right? -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 11:13:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: board_enable: Wyse Cx0 thin client is not a laptop
by build bot (Jenkins) (Code Review) 08 Jan '18

08 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23157 ) Change subject: board_enable: Wyse Cx0 thin client is not a laptop ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1015/ : SUCCESS -- To view, visit https://review.coreboot.org/23157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Gerrit-Change-Number: 23157 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 10:35:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: board_enable: Wyse Cx0 thin client is not a laptop
by Lubomir Rintel (Code Review) 08 Jan '18

08 Jan '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23157 to look at the new patch set (#2). Change subject: board_enable: Wyse Cx0 thin client is not a laptop ...................................................................... board_enable: Wyse Cx0 thin client is not a laptop Add it to the whitelist. The subsystem IDs on the machine look completely random. Hopefully they're stable across the boards. The PCI gigabit ethernet is external to the chipset. Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/23157/2 -- To view, visit https://review.coreboot.org/23157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Gerrit-Change-Number: 23157 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: board_enable: Wyse Cx0 thin client is not a laptop
by Paul Menzel (Code Review) 08 Jan '18

08 Jan '18

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/23157 ) Change subject: board_enable: Wyse Cx0 thin client is not a laptop ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23157/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23157/1//COMMIT_MSG@11 PS1, Line 11: no on -- To view, visit https://review.coreboot.org/23157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Gerrit-Change-Number: 23157 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 10:03:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: board_enable: Wyse Cx0 thin client is not a laptop
by Paul Menzel (Code Review) 08 Jan '18

08 Jan '18

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/23157 ) Change subject: board_enable: Wyse Cx0 thin client is not a laptop ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/23157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Gerrit-Change-Number: 23157 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 10:01:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: chipset_enable: Mark VX855 as tested
by Paul Menzel (Code Review) 08 Jan '18

08 Jan '18

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/23158 ) Change subject: chipset_enable: Mark VX855 as tested ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/23158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f48b49ccb760f69d676ec6cbb233e532b12fbe8 Gerrit-Change-Number: 23158 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 10:01:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: board_enable: Wyse Cx0 thin client is not a laptop
by build bot (Jenkins) (Code Review) 08 Jan '18

08 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23157 ) Change subject: board_enable: Wyse Cx0 thin client is not a laptop ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/864/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1014/ : SUCCESS -- To view, visit https://review.coreboot.org/23157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Gerrit-Change-Number: 23157 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 08:25:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: chipset_enable: Mark VX855 as tested
by build bot (Jenkins) (Code Review) 08 Jan '18

08 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23158 ) Change subject: chipset_enable: Mark VX855 as tested ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/863/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1013/ : SUCCESS -- To view, visit https://review.coreboot.org/23158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f48b49ccb760f69d676ec6cbb233e532b12fbe8 Gerrit-Change-Number: 23158 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Jan 2018 08:24:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: board_enable: Wyse Cx0 thin client is not a laptop
by Lubomir Rintel (Code Review) 08 Jan '18

08 Jan '18

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/23157 Change subject: board_enable: Wyse Cx0 thin client is not a laptop ...................................................................... board_enable: Wyse Cx0 thin client is not a laptop Add it to the whitelist. The subsystem IDs no the machine look completely random. Hopefully they're stable across the boards. The PCI gigabit ethernet is external to the chipset. Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/23157/1 diff --git a/board_enable.c b/board_enable.c index b6e17ef..83d16a0 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2471,6 +2471,7 @@ {0x1106, 0x0259, 0x1106, 0xAA07, 0x1106, 0x3227, 0x1106, 0xAA07, NULL, NULL, NULL, P3, "VIA", "EPIA EK", 0, NT, via_vt823x_gpio9_raise}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, P3, "VIA", "EPIA M/MII/...", 0, OK, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, P3, "VIA", "EPIA-N/NL", 0, OK, via_vt823x_gpio9_raise}, + {0x1106, 0x0409, 0x6334, 0x0920, 0x1106, 0x3119, 0x1106, 0x0110, "^C CLASS$", NULL, NULL, P2, "Wyse", "Cx0", 0, OK, p2_not_a_laptop}, #endif { 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL, NULL, P3, NULL, NULL, 0, NT, NULL}, /* end marker */ }; -- To view, visit https://review.coreboot.org/23157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb Gerrit-Change-Number: 23157 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in flashrom[master]: chipset_enable: Mark VX855 as tested
by Lubomir Rintel (Code Review) 08 Jan '18

08 Jan '18

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/23158 Change subject: chipset_enable: Mark VX855 as tested ...................................................................... chipset_enable: Mark VX855 as tested I can confirm a successful reading and writing of SST49LF080A (LPC) on a Wyse Cx0 Thin Client (Phoenix BIOS 1.0G). Change-Id: I8f48b49ccb760f69d676ec6cbb233e532b12fbe8 Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/23158/1 diff --git a/chipset_enable.c b/chipset_enable.c index a46651f..8243455 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1713,7 +1713,7 @@ {0x1106, 0x8231, NT, "VIA", "VT8231", enable_flash_vt823x}, {0x1106, 0x8324, OK, "VIA", "CX700", enable_flash_vt823x}, {0x1106, 0x8353, NT, "VIA", "VX800/VX820", enable_flash_vt_vx}, - {0x1106, 0x8409, NT, "VIA", "VX855/VX875", enable_flash_vt_vx}, + {0x1106, 0x8409, OK, "VIA", "VX855/VX875", enable_flash_vt_vx}, {0x1106, 0x8410, OK, "VIA", "VX900", enable_flash_vt_vx}, {0x1166, 0x0200, OK, "Broadcom", "OSB4", enable_flash_osb4}, {0x1166, 0x0205, OK, "Broadcom", "HT-1000", enable_flash_ht1000}, -- To view, visit https://review.coreboot.org/23158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8f48b49ccb760f69d676ec6cbb233e532b12fbe8 Gerrit-Change-Number: 23158 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2018