January 2018 - flashrom-gerrit

Change in flashrom[master]: [UNTESTED] Whitelist Lenovo X220 Thinkpad
by build bot (Jenkins) (Code Review) 11 Jan '18

11 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23225 ) Change subject: [UNTESTED] Whitelist Lenovo X220 Thinkpad ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/871/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1022/ : SUCCESS -- To view, visit https://review.coreboot.org/23225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Gerrit-Change-Number: 23225 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 11 Jan 2018 22:32:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [UNTESTED] Whitelist Lenovo X220 Thinkpad
by Arthur Heymans (Code Review) 11 Jan '18

11 Jan '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23225 Change subject: [UNTESTED] Whitelist Lenovo X220 Thinkpad ...................................................................... [UNTESTED] Whitelist Lenovo X220 Thinkpad Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/23225/1 diff --git a/board_enable.c b/board_enable.c index b6e17ef..625ed88 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2434,6 +2434,7 @@ {0x8086, 0x27a0, 0x17aa, 0x2017, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad X200", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X200", 0, OK, p2_whitelist_laptop}, {0x8086, 0x3B07, 0x17AA, 0x2166, 0x8086, 0x3B30, 0x17AA, 0x2167, "^Lenovo X201", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X201", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x1C22, 0x17AA, 0x21DA, 0x8086, 0x1C45, 0x17AA, 0x21DA, "^ThinkPad X220", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X220", 0, OK, p2_whitelist_laptop}, {0x8086, 0x1E22, 0x17AA, 0x21FA, 0x8086, 0x1E55, 0x17AA, 0x21FA, "^ThinkPad X230", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X230", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x17AA, 0x2017, 0x8086, 0x27B9, 0x17AA, 0x2009, "^ThinkPad X60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2411, 0x8086, 0x2411, 0x8086, 0x7125, 0x0e11, 0xb165, NULL, NULL, NULL, P3, "Mitac", "6513WU", 0, OK, board_mitac_6513wu}, -- To view, visit https://review.coreboot.org/23225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Gerrit-Change-Number: 23225 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in flashrom[master]: make args for -r/-w/-v non-positional and optional
by Nico Huber (Code Review) 10 Jan '18

10 Jan '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23022 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 6: Code-Review-2 I'm missing a check for spurious arguments. I have no idea how to implement it (straightforward) together with the non-positional file names. Currently, if you have a typo in your command line (e.g. forget a dash before an option), things may just be ignored... So why make it non-positional? -- To view, visit https://review.coreboot.org/23022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-Change-Number: 23022 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jan 2018 12:48:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by Nico Huber (Code Review) 10 Jan '18

10 Jan '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 7: (10 comments) There are still some issues when it comes to the updated behaviour due to that http://crbug.com/263495 * Manpage needs update. * Separation of this and the next commit makes no sense because the introduced if/else relies on the file arguments to -w/-v being optional. * I think we need a check for the case that both files to -w/-v and to -i are given (it seems to me the latter would be silently ignored, didn't test though). https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl File flashrom.8.tmpl: https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl@227 PS7, Line 227: write spurious https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl@229 PS7, Line 229: For write operations, files specified using : .B "\-i" : take precedence over content from the argument to : .B "\-w." That's no more true. -i and -w filenames are mutually exclusive, right? https://review.coreboot.org/#/c/23021/7/flashrom.8.tmpl@252 PS7, Line 252: .B " flashrom \-p prog \-l <layout> \-i foo:foo.bin -i bar:bar.bin -w rom.bin Hmmm, just realized that this doesn't work. The -i files are just ignored when -w gets a file passed. I'd be fine if you document the final behaviour here. But maybe it's yet easier to squash the two commits... https://review.coreboot.org/#/c/23021/7/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/7/flashrom.c@1380 PS7, Line 1380: if (!entry->included || !entry->file) : continue; Optionally: if (!entry->included) continue; if (!entry->file) { msg_gerr("Error: No image file given for region \"%s\".\n", entry->name); return 1; } I know this is already covered in the next commit for the CLI, but I would feel much better if the code here looks consistent. https://review.coreboot.org/#/c/23021/7/flashrom.c@1383 PS7, Line 1383: buf + entry->start ? https://review.coreboot.org/#/c/23021/7/flashrom.c@1464 PS7, Line 1464: const char *filename) Should fit a single line. https://review.coreboot.org/#/c/23021/7/flashrom.c@2647 PS7, Line 2647: * processed and merged into newcontents since -i files take priority. This comment still makes no sense to me. I'd guess it was written before the if / else decision was introduced. https://review.coreboot.org/#/c/23021/7/layout.c File layout.c: https://review.coreboot.org/#/c/23021/7/layout.c@239 PS7, Line 239: 0 i + 1 ? https://review.coreboot.org/#/c/23021/7/layout.c@244 PS7, Line 244: continue; Not needed if we start with `j > i`. https://review.coreboot.org/#/c/23021/7/layout.c@272 PS7, Line 272: for (i = 0; i < layout.num_entries; i++) { : free(layout.entries[i].file); : layout.entries[i].file = NULL; : layout.entries[i].included = 0; : } : layout.num_entries = 0; This should actually be done in flashrom_layout_release() (before the `if (layout == get_global_layout())` check). It's a bit ugly atm, because nobody took the time yet, to untangle the CLI parts and the static layout struct here. Hmmm, now it doesn't look like much work: read_romlayout() would allocate a new layout, normalize_romentries() should work on the layout linked to the `flashctx`. Everything else doesn't seem to use the static struct. -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jan 2018 12:29:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by build bot (Jenkins) (Code Review) 10 Jan '18

10 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/870/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1021/ : SUCCESS -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jan 2018 11:58:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by Arthur Heymans (Code Review) 10 Jan '18

10 Jan '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23203 to look at the new patch set (#2). Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... [WIP]Add support to get layout from a binary fmap file Already seems to mostly work, but needs to be cleaned up. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c A fmap.c A fmap.h M layout.c 5 files changed, 166 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/2 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by build bot (Jenkins) (Code Review) 10 Jan '18

10 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/869/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1020/ : SUCCESS -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jan 2018 11:49:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by Arthur Heymans (Code Review) 10 Jan '18

10 Jan '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23203 Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... [WIP]Add support to get layout from a binary fmap file Already seems to mostly work, but needs to be cleaned up. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c A fmap.c A fmap.h M layout.c 5 files changed, 166 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/1 diff --git a/Makefile b/Makefile index 3370247..64f1f1e 100644 --- a/Makefile +++ b/Makefile @@ -524,7 +524,7 @@ ############################################################################### # Library code. -LIB_OBJS = libflashrom.o layout.o flashrom.o udelay.o programmer.o helpers.o ich_descriptors.o +LIB_OBJS = libflashrom.o layout.o flashrom.o udelay.o programmer.o helpers.o ich_descriptors.o fmap.o ############################################################################### # Frontend related stuff. diff --git a/cli_classic.c b/cli_classic.c index 527bb9f..aa0ed02 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -29,6 +29,7 @@ #include <getopt.h> #include "flash.h" #include "flashchips.h" +#include "fmap.h" #include "programmer.h" #include "libflashrom.h" @@ -124,6 +125,7 @@ {"force", 0, NULL, 'f'}, {"layout", 1, NULL, 'l'}, {"ifd", 0, NULL, 0x0100}, + {"fmap", 1, NULL, 0x0101}, {"image", 1, NULL, 'i'}, {"list-supported", 0, NULL, 'L'}, {"list-supported-wiki", 0, NULL, 'z'}, @@ -136,6 +138,7 @@ char *filename = NULL; char *layoutfile = NULL; + char *fmapfile = NULL; #ifndef STANDALONE char *logfile = NULL; #endif /* !STANDALONE */ @@ -221,19 +224,31 @@ "more than once. Aborting.\n"); cli_classic_abort_usage(); } - if (ifd) { - fprintf(stderr, "Error: --layout and --ifd both specified. Aborting.\n"); + if (ifd || fmapfile) { + fprintf(stderr, "Error: --layout and --ifd/--fmap both specified. Aborting.\n"); cli_classic_abort_usage(); } layoutfile = strdup(optarg); break; case 0x0100: - if (layoutfile) { - fprintf(stderr, "Error: --layout and --ifd both specified. Aborting.\n"); + if (layoutfile || fmapfile) { + fprintf(stderr, "Error: --ifd and --layout/--fmap both specified. Aborting.\n"); cli_classic_abort_usage(); } ifd = 1; break; + case 0x0101: + if (fmapfile) { + fprintf(stderr, "Error: --fmap specified " + "more than once. Aborting.\n"); + cli_classic_abort_usage(); + } + if (ifd || layoutfile) { + fprintf(stderr, "Error: --fmap and --ifd/--layout both specified. Aborting.\n"); + cli_classic_abort_usage(); + } + fmapfile = strdup(optarg); + break; case 'i': tempstr = strdup(optarg); if (register_include_arg(tempstr)) { @@ -388,6 +403,10 @@ ret = 1; goto out; } + if (fmapfile && read_fmapfile(fmapfile)) { + ret = 1; + goto out; + } if (!ifd && process_include_args(get_global_layout())) { ret = 1; goto out; @@ -541,7 +560,7 @@ goto out_shutdown; } - if (layoutfile) { + if (layoutfile || fmapfile) { layout = get_global_layout(); } else if (ifd && (flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0) || process_include_args(layout))) { diff --git a/fmap.c b/fmap.c new file mode 100644 index 0000000..c63a1fa --- /dev/null +++ b/fmap.c @@ -0,0 +1,74 @@ +#include <ctype.h> +#include <stdio.h> +#include <string.h> +#include <stdlib.h> +#include "fmap.h" +#include "flash.h" + +int is_valid_fmap(const struct fmap *fmap) +{ + if (memcmp(fmap, FMAP_SIGNATURE, strlen(FMAP_SIGNATURE)) != 0) + return 0; + /* strings containing the magic tend to fail here */ + if (fmap->ver_major != FMAP_VER_MAJOR) + return 0; + /* a basic consistency check: flash should be larger than fmap */ + if (fmap->size < + sizeof(*fmap) + fmap->nareas * sizeof(struct fmap_area)) + return 0; + + /* fmap-alikes along binary data tend to fail on having a valid, + * null-terminated string in the name field.*/ + int i = 0; + while (i < FMAP_STRLEN) { + if (fmap->name[i] == 0) + break; + if (!isgraph(fmap->name[i])) + return 0; + if (i == FMAP_STRLEN - 1) { + /* name is specified to be null terminated single-word string + * without spaces. We did not break in the 0 test, we know it + * is a printable spaceless string but we're seeing FMAP_STRLEN + * symbols, which is one too many. + */ + return 0; + } + i++; + } + return 1; + +} + +static uint64_t to_le(const uint8_t *const dump, const size_t len) +{ + int i; + uint64_t var = 0; + for (i = 0; i < len; i++) { + var |= ((uint64_t)dump[i] & 0xff) << (8 * i); + } + return var; +} + +#define READ_LE_DUMP_INCEASE_IDX(x, dump, i, le) x = to_le(dump, sizeof(x)); \ + i += sizeof(x); if (i > len) return 1; +#define READ_MEMCPY_DUMP_INCREASE_IDX(x, dump, i, len) memcpy(x, dump, sizeof(x)); \ + i += sizeof(x); if (i > len) return 1; + +int read_fmap_from_dump(const uint8_t *const dump, const size_t len, struct fmap *fmap) +{ + int i = 0, j; + READ_MEMCPY_DUMP_INCREASE_IDX(fmap->signature, &dump[i], i, len); + fmap->ver_major = dump[i++]; + fmap->ver_minor = dump[i++]; + READ_LE_DUMP_INCEASE_IDX(fmap->base, &dump[i], i, len); + READ_LE_DUMP_INCEASE_IDX(fmap->size, &dump[i], i, len); + READ_MEMCPY_DUMP_INCREASE_IDX(fmap->name, &dump[i], i, len); + READ_LE_DUMP_INCEASE_IDX(fmap->nareas, &dump[i], i, len); + for (j = 0; j < fmap->nareas; j++) { + READ_LE_DUMP_INCEASE_IDX(fmap->areas[j].offset, &dump[i], i, len); + READ_LE_DUMP_INCEASE_IDX(fmap->areas[j].size, &dump[i], i, len); + READ_MEMCPY_DUMP_INCREASE_IDX(fmap->areas[j].name, &dump[i], i, len); + READ_LE_DUMP_INCEASE_IDX(fmap->areas[j].flags, &dump[i], i, len); + } + return 0; +} diff --git a/fmap.h b/fmap.h new file mode 100644 index 0000000..513c4f9 --- /dev/null +++ b/fmap.h @@ -0,0 +1,32 @@ +#include <inttypes.h> +//#include <compiler.h> +//#include <valstr.h> + + +#define FMAP_SIGNATURE "__FMAP__" +#define FMAP_VER_MAJOR 1 /* this header's FMAP minor version */ +#define FMAP_VER_MINOR 1 /* this header's FMAP minor version */ +#define FMAP_STRLEN 32 /* maximum length for strings, */ + +struct fmap_area { + uint32_t offset; /* offset relative to base */ + uint32_t size; /* size in bytes */ + uint8_t name[FMAP_STRLEN]; /* descriptive name */ + uint16_t flags; /* flags for this area */ +} __attribute__((packed)); + +struct fmap { + uint8_t signature[8]; /* "__FMAP__" (0x5F5F464D41505F5F) */ + uint8_t ver_major; /* major version */ + uint8_t ver_minor; /* minor version */ + uint64_t base; /* address of the firmware binary */ + uint32_t size; /* size of firmware binary in bytes */ + uint8_t name[FMAP_STRLEN]; /* name of this firmware binary */ + uint16_t nareas; /* number of areas described by + fmap_areas[] below */ + struct fmap_area areas[]; +} __attribute__((packed)); + +int is_valid_fmap(const struct fmap *fmap); +int read_fmapfile(const char *filename); +int read_fmap_from_dump(const uint8_t *const dump, const size_t len, struct fmap *fmap); diff --git a/layout.c b/layout.c index a990adc..53c2bb4 100644 --- a/layout.c +++ b/layout.c @@ -23,7 +23,9 @@ #include <stdlib.h> #include <string.h> #include <limits.h> +#include <sys/stat.h> #include "flash.h" +#include "fmap.h" #include "programmer.h" #include "layout.h" @@ -103,6 +105,39 @@ return 0; } + +int read_fmapfile(const char *filename) +{ + int i; + FILE *fmapfile; + struct fmap fmap; + uint8_t buffer[5000]; + struct stat st; + + stat(filename, &st); + size_t size = st.st_size; + + fmapfile = fopen(filename, "r"); + + if (!fmapfile) { + msg_gerr("ERROR: Could not open layout file (%s).\n", filename); + return -1; + } + + fread(buffer, size, 1, fmapfile); + if (read_fmap_from_dump(buffer, size, &fmap)) + return -1; + + layout.num_entries = fmap.nareas; + for (i = 0; i < fmap.nareas; i++) { + layout.entries[i].start = fmap.areas[i].offset; + layout.entries[i].end = fmap.areas[i].offset + fmap.areas[i].size - 1; + layout.entries[i].included = 0; + layout.entries[i].file = NULL; + memcpy(layout.entries[i].name, fmap.areas[i].name, sizeof(layout.entries[i].name)); + } + return 0; +} #endif /* returns the index of the entry (or a negative value if it is not found) */ -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by build bot (Jenkins) (Code Review) 09 Jan '18

09 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/868/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1019/ : SUCCESS -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 09 Jan 2018 22:59:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: make args for -r/-w/-v non-positional and optional
by build bot (Jenkins) (Code Review) 09 Jan '18

09 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23022 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/867/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1018/ : SUCCESS -- To view, visit https://review.coreboot.org/23022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-Change-Number: 23022 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 09 Jan 2018 22:59:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2018