flashrom

flashrom@flashrom.org

3 participants
9189 discussions

alix1d board
by Raphael Nestler 07 Oct '10

07 Oct '10

Hi flashrom devs, flashrom suggested to send it's output to this address. Board URL: http://www.pcengines.ch/alix1d.htm $ sudo flashrom flashrom v0.9.2-runknown on Linux 2.6.31-ARCH (i586), built with libpci 3.1.4, GCC 4.4.1, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. No coreboot table found. Found chipset "AMD CS5536", enabling flash write... OK. WARNING: unexpected second chipset match: "AMD CS5536" ignoring, please report lspci and board URL to flashrom(a)flashrom.org! This chipset supports the following protocols: Non-SPI. Found chip "Winbond W39V040(F)C" (512 KB, LPC) at physical address 0xfff80000. === This flash part has status UNTESTED for operations: PROBE READ ERASE WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -Vw, -VE), and mention which mainboard or programmer you tested. Thanks for your help! === No operations were specified. $ lspci 00:01.0 Host bridge: Advanced Micro Devices [AMD] CS5536 [Geode companion] Host Bridge (rev 31) 00:01.1 VGA compatible controller: Advanced Micro Devices [AMD] Geode LX Video 00:01.2 Entertainment encryption device: Advanced Micro Devices [AMD] Geode LX AES Security Block 00:0d.0 Ethernet controller: VIA Technologies, Inc. VT6105M [Rhine-III] (rev 96) 00:0f.0 ISA bridge: Advanced Micro Devices [AMD] CS5536 [Geode companion] ISA (rev 03) 00:0f.2 IDE interface: Advanced Micro Devices [AMD] CS5536 [Geode companion] IDE (rev 01) 00:0f.3 Multimedia audio controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] Audio (rev 01) 00:0f.4 USB Controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] OHC (rev 02) 00:0f.5 USB Controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] EHC (rev 02) regards, roughL

1 0

M2N68-AM SE2 output
by Farkas Tama s 07 Oct '10

07 Oct '10

Hi, here is the output of flashrom -V on a M2N68-AM SE2 motherboard. Bye: Tamas

1 0

Flashrom Feedback
by Andrew Wierzan 07 Oct '10

07 Oct '10

Hi, I have successfully flashed ASUS P7H57-D-EVO using the current trunk at svn://coreboot.org/flashrom/trunk (trunk @ 1199). I used an Ubuntu 9.1 Live USB environment and followed the guide on the downloads page. The latest Asus BIOS (1606) for this board disables the ability to roll-back bios version using their own utility EZFlash. Many many thanks for continuing this project, it's saved a lot of hassle :) Thanks again, Andrew -- Andrew Wierzan Technical Manager eMerging Ltd 020 8941 6547 IMPORTANT NOTICE This e-mail and any files transmitted are confidential and intended solely for the use of the individual to whom they are addressed. If you have received it in error please delete it from your system, do not use or disclose the information in any way, and notify the sender by reply. Views and opinions expressed do not represent those of eMerging Limited unless specifically stated. This message has been scanned for viruses and dangerous content and is believed to be clean. eMerging Limited, registered in England under the number 06258057 Registered Office: Devonshire House, Manor Way, Borehamwood, Hertfordshire. WD6 1QQ ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

1 0

[PATCH] Switch to AAI for some more SST chips
by Joshua Roys 07 Oct '10

07 Oct '10

Hello, Attached is a patch to switch a few more chips to AAI write. A comment is added to two entries due to the datasheets claiming AAI support but via a different opcode. I was able to test programming on one chip and the write time was more than halved. Signed-off-by: Joshua Roys <roysjosh(a)gmail.com> Josh

1 0

[commit] r1199 - trunk
by repository service 07 Oct '10

07 Oct '10

Author: hailfinger Date: Thu Oct 7 01:48:34 2010 New Revision: 1199 URL: http://flashrom.org/trac/flashrom/changeset/1199 Log: flashrom -L output did not contain a list of programmers nor were all programmers listed. Fix it and mention at least the name of each programmer. Wiki output is unchanged, and will need separate fixups. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/atahpt.c trunk/cli_classic.c trunk/flash.h trunk/flashrom.c trunk/ft2232_spi.c trunk/pcidev.c trunk/print.c Modified: trunk/atahpt.c ============================================================================== --- trunk/atahpt.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/atahpt.c Thu Oct 7 01:48:34 2010 (r1199) @@ -30,7 +30,7 @@ #define PCI_VENDOR_ID_HPT 0x1103 -struct pcidev_status ata_hpt[] = { +const struct pcidev_status ata_hpt[] = { {0x1103, 0x0004, NT, "Highpoint", "HPT366/368/370/370A/372/372N"}, {0x1103, 0x0005, NT, "Highpoint", "HPT372A/372N"}, {0x1103, 0x0006, NT, "Highpoint", "HPT302/302N"}, Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/cli_classic.c Thu Oct 7 01:48:34 2010 (r1199) @@ -33,11 +33,6 @@ static void cli_classic_usage(const char *name) { - const char *pname; - int pnamelen; - int remaining = 0; - enum programmer p; - printf("Usage: flashrom [-n] [-V] [-f] [-h|-R|-L|" #if CONFIG_PRINT_WIKI == 1 "-z|" @@ -83,32 +78,9 @@ "in wiki syntax\n" #endif " -p | --programmer <name>[:<param>] specify the programmer " - "device"); - - for (p = 0; p < PROGRAMMER_INVALID; p++) { - pname = programmer_table[p].name; - pnamelen = strlen(pname); - if (remaining - pnamelen - 2 < 0) { - printf("\n "); - remaining = 43; - } else { - printf(" "); - remaining--; - } - if (p == 0) { - printf("("); - remaining--; - } - printf("%s", pname); - remaining -= pnamelen; - if (p < PROGRAMMER_INVALID - 1) { - printf(","); - remaining--; - } else { - printf(")\n"); - } - } + "device\n"); + list_programmers_linebreak(37, 80, 1); printf("\nYou can specify one of -h, -R, -L, " #if CONFIG_PRINT_WIKI == 1 "-z, " Modified: trunk/flash.h ============================================================================== --- trunk/flash.h Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/flash.h Thu Oct 7 01:48:34 2010 (r1199) @@ -200,6 +200,7 @@ char *strcat_realloc(char *dest, const char *src); void print_version(void); void print_banner(void); +void list_programmers_linebreak(int startcol, int cols, int paren); int selfcheck(void); int doit(struct flashchip *flash, int force, char *filename, int read_it, int write_it, int erase_it, int verify_it); Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/flashrom.c Thu Oct 7 01:48:34 2010 (r1199) @@ -1332,6 +1332,47 @@ msg_ginfo("\n"); } +void list_programmers_linebreak(int startcol, int cols, int paren) +{ + const char *pname; + int pnamelen; + int remaining = 0; + int firstline = 1; + enum programmer p; + int i; + + for (p = 0; p < PROGRAMMER_INVALID; p++) { + pname = programmer_table[p].name; + pnamelen = strlen(pname); + if (remaining - pnamelen - 2 < 0) { + if (firstline) + firstline = 0; + else + printf("\n"); + for (i = 0; i < startcol; i++) + printf(" "); + remaining = cols - startcol; + } else { + printf(" "); + remaining--; + } + if (paren && (p == 0)) { + printf("("); + remaining--; + } + printf("%s", pname); + remaining -= pnamelen; + if (p < PROGRAMMER_INVALID - 1) { + printf(","); + remaining--; + } else { + if (paren) + printf(")"); + printf("\n"); + } + } +} + void print_sysinfo(void) { #if HAVE_UTSNAME == 1 Modified: trunk/ft2232_spi.c ============================================================================== --- trunk/ft2232_spi.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/ft2232_spi.c Thu Oct 7 01:48:34 2010 (r1199) @@ -346,6 +346,7 @@ { int i; + msg_pinfo("USB devices:\n"); for (i = 0; devs[i].vendor_name != NULL; i++) { msg_pinfo("%s %s [%04x:%04x]%s\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/pcidev.c Thu Oct 7 01:48:34 2010 (r1199) @@ -132,6 +132,7 @@ { int i; + msg_pinfo("PCI devices:\n"); for (i = 0; devs[i].vendor_name != NULL; i++) { msg_pinfo("%s %s [%02x:%02x]%s\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, Modified: trunk/print.c ============================================================================== --- trunk/print.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/print.c Thu Oct 7 01:48:34 2010 (r1199) @@ -223,49 +223,89 @@ void print_supported(void) { - print_supported_chips(); + print_supported_chips(); + + printf("\nSupported programmers:\n"); + list_programmers_linebreak(0, 80, 0); #if CONFIG_INTERNAL == 1 - print_supported_chipsets(); - print_supported_boards_helper(boards_known, "boards"); - print_supported_boards_helper(laptops_known, "laptops"); -#endif -#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT >= 1 - printf("\nSupported PCI devices flashrom can use " - "as programmer:\n\n"); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_INTERNAL].name); + print_supported_chipsets(); + print_supported_boards_helper(boards_known, "boards"); + print_supported_boards_helper(laptops_known, "laptops"); +#endif +#if CONFIG_DUMMY == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_DUMMY].name); + /* FIXME */ #endif #if CONFIG_NIC3COM == 1 - print_supported_pcidevs(nics_3com); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NIC3COM].name); + print_supported_pcidevs(nics_3com); #endif #if CONFIG_NICREALTEK == 1 - print_supported_pcidevs(nics_realtek); - print_supported_pcidevs(nics_realteksmc1211); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICREALTEK].name); + print_supported_pcidevs(nics_realtek); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICREALTEK2].name); + print_supported_pcidevs(nics_realteksmc1211); #endif #if CONFIG_NICNATSEMI == 1 - print_supported_pcidevs(nics_natsemi); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICNATSEMI].name); + print_supported_pcidevs(nics_natsemi); #endif #if CONFIG_GFXNVIDIA == 1 - print_supported_pcidevs(gfx_nvidia); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_GFXNVIDIA].name); + print_supported_pcidevs(gfx_nvidia); #endif #if CONFIG_DRKAISER == 1 - print_supported_pcidevs(drkaiser_pcidev); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_DRKAISER].name); + print_supported_pcidevs(drkaiser_pcidev); #endif #if CONFIG_SATASII == 1 - print_supported_pcidevs(satas_sii); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_SATASII].name); + print_supported_pcidevs(satas_sii); #endif #if CONFIG_ATAHPT == 1 - print_supported_pcidevs(ata_hpt); -#endif -#if CONFIG_NICINTEL_SPI == 1 - print_supported_pcidevs(nics_intel_spi); -#endif - -#if CONFIG_FT2232_SPI+CONFIG_DEDIPROG >= 1 - printf("\nSupported USB devices flashrom can use " - "as programmer:\n\n"); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_ATAHPT].name); + print_supported_pcidevs(ata_hpt); #endif - #if CONFIG_FT2232_SPI == 1 - print_supported_usbdevs(devs_ft2232spi); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_FT2232_SPI].name); + print_supported_usbdevs(devs_ft2232spi); +#endif +#if CONFIG_SERPROG == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_SERPROG].name); + /* FIXME */ +#endif +#if CONFIG_BUSPIRATE_SPI == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_BUSPIRATE_SPI].name); + /* FIXME */ +#endif +#if CONFIG_DEDIPROG == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_DEDIPROG].name); + /* FIXME */ +#endif +#if CONFIG_RAYER_SPI == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_RAYER_SPI].name); + /* FIXME */ +#endif +#if CONFIG_NICINTEL_SPI == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICINTEL_SPI].name); + print_supported_pcidevs(nics_intel_spi); #endif }

1 0

[PATCH] Rename DirectIO to DirectHW
by Carl-Daniel Hailfinger 07 Oct '10

07 Oct '10

The Direct I/O library for Mac OS X is now called DirectHW to make sure people can find it via an internet search. DirectIO was a generic name for a concept and thus not a good distinguisher for a library. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-directio_directhw_rename/hwaccess.h =================================================================== --- flashrom-directio_directhw_rename/hwaccess.h (Revision 1194) +++ flashrom-directio_directhw_rename/hwaccess.h (Arbeitskopie) @@ -193,6 +193,7 @@ #define INL(x) __extension__ ({ u_int inl_tmp = (x); inl(inl_tmp); }) #else #if defined(__DARWIN__) + /* Header is part of the DirectHW library. */ #include <DirectIO/darwinio.h> #define off64_t off_t #define lseek64 lseek Index: flashrom-directio_directhw_rename/Makefile =================================================================== --- flashrom-directio_directhw_rename/Makefile (Revision 1194) +++ flashrom-directio_directhw_rename/Makefile (Arbeitskopie) @@ -42,6 +42,7 @@ endif ifeq ($(OS_ARCH), Darwin) CPPFLAGS += -I/opt/local/include -I/usr/local/include +# DirectIO framework can be found in the DirectHW library. LDFLAGS += -framework IOKit -framework DirectIO -L/opt/local/lib -L/usr/local/lib endif ifeq ($(OS_ARCH), FreeBSD) Index: flashrom-directio_directhw_rename/cbtable.c =================================================================== --- flashrom-directio_directhw_rename/cbtable.c (Revision 1194) +++ flashrom-directio_directhw_rename/cbtable.c (Arbeitskopie) @@ -204,7 +204,7 @@ struct lb_record *rec, *last; #ifdef __DARWIN__ - /* This is a hack. DirectIO fails to map physical address 0x00000000. + /* This is a hack. DirectHW fails to map physical address 0x00000000. * Why? */ start = 0x400; Index: flashrom-directio_directhw_rename/physmap.c =================================================================== --- flashrom-directio_directhw_rename/physmap.c (Revision 1194) +++ flashrom-directio_directhw_rename/physmap.c (Arbeitskopie) @@ -131,6 +131,7 @@ } #elif defined(__DARWIN__) +/* Header is part of the DirectHW library. */ #include <DirectIO/darwinio.h> #define MEM_DEV "DirectIO" Index: flashrom-directio_directhw_rename/README =================================================================== --- flashrom-directio_directhw_rename/README (Revision 1194) +++ flashrom-directio_directhw_rename/README (Arbeitskopie) @@ -87,8 +87,8 @@ To compile and run on Darwin/Mac OS X: - Install DirectIO from coresystems GmbH. - DirectIO is available at http://www.coresystems.de/en/directio. + Install DirectHW from coresystems GmbH. + DirectHW is available at http://www.coresystems.de/en/directhw . To cross-compile on Linux for DOS: -- http://www.hailfinger.org/

2 2

[commit] r1198 - trunk
by repository service 07 Oct '10

07 Oct '10

Author: hailfinger Date: Thu Oct 7 01:16:10 2010 New Revision: 1198 URL: http://flashrom.org/trac/flashrom/changeset/1198 Log: The Direct I/O library for Mac OS X is now called DirectHW to make sure people can find it via an internet search. DirectIO was a generic name for a concept and thus not a good distinguisher for a library. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Modified: trunk/Makefile trunk/README trunk/cbtable.c trunk/hwaccess.h Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/Makefile Thu Oct 7 01:16:10 2010 (r1198) @@ -42,6 +42,7 @@ endif ifeq ($(OS_ARCH), Darwin) CPPFLAGS += -I/opt/local/include -I/usr/local/include +# DirectIO framework can be found in the DirectHW library. LDFLAGS += -framework IOKit -framework DirectIO -L/opt/local/lib -L/usr/local/lib endif ifeq ($(OS_ARCH), FreeBSD) Modified: trunk/README ============================================================================== --- trunk/README Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/README Thu Oct 7 01:16:10 2010 (r1198) @@ -87,8 +87,8 @@ To compile and run on Darwin/Mac OS X: - Install DirectIO from coresystems GmbH. - DirectIO is available at http://www.coresystems.de/en/directio. + Install DirectHW from coresystems GmbH. + DirectHW is available at http://www.coresystems.de/en/directhw . To cross-compile on Linux for DOS: Modified: trunk/cbtable.c ============================================================================== --- trunk/cbtable.c Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/cbtable.c Thu Oct 7 01:16:10 2010 (r1198) @@ -203,7 +203,7 @@ struct lb_record *rec, *last; #ifdef __DARWIN__ - /* This is a hack. DirectIO fails to map physical address 0x00000000. + /* This is a hack. DirectHW fails to map physical address 0x00000000. * Why? */ start = 0x400; Modified: trunk/hwaccess.h ============================================================================== --- trunk/hwaccess.h Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/hwaccess.h Thu Oct 7 01:16:10 2010 (r1198) @@ -193,6 +193,7 @@ #define INL(x) __extension__ ({ u_int inl_tmp = (x); inl(inl_tmp); }) #else #if defined(__DARWIN__) + /* Header is part of the DirectHW library. */ #include <DirectIO/darwinio.h> #define off64_t off_t #define lseek64 lseek

1 0

[commit] r1197 - trunk
by repository service 07 Oct '10

07 Oct '10

Author: hailfinger Date: Thu Oct 7 01:03:21 2010 New Revision: 1197 URL: http://flashrom.org/trac/flashrom/changeset/1197 Log: Update the author list in the man page. Update programmer parameter documentation. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/flashrom.8 trunk/pcidev.c Modified: trunk/flashrom.8 ============================================================================== --- trunk/flashrom.8 Wed Oct 6 04:56:44 2010 (r1196) +++ trunk/flashrom.8 Thu Oct 7 01:03:21 2010 (r1197) @@ -97,7 +97,7 @@ .sp * Force chip read and pretend the chip is there. .sp -* Force chip access even if the chip is bigger than the maximum supported\ +* Force chip access even if the chip is bigger than the maximum supported \ size for the flash bus. .sp * Force erase even if erase is known bad. @@ -169,6 +169,9 @@ .sp .BR "* nicsmc1211" " (for flash ROMs on RTL8139-compatible SMC2 network cards)" .sp +.BR "* nicnatsemi" " (for flash ROMs on National Semiconductor DP838* network \ +cards)" +.sp .BR "* gfxnvidia" " (for flash ROMs on NVIDIA graphics cards)" .sp .BR "* drkaiser" " (for flash ROMs on Dr. Kaiser PC-Waechter PCI cards)" @@ -187,6 +190,8 @@ .sp .BR "* buspirate_spi" " (for SPI flash ROMs attached to a Bus Pirate)" .sp +.BR "* dediprog" " (for SPI flash ROMs attached to a Dediprog SF100)" +.sp .BR "* rayer_spi" " (for SPI flash ROMs attached to a RayeR parport \ based programmer)" .sp @@ -313,8 +318,8 @@ Example: .B "flashrom \-p dummy:bus=lpc+fwh" .TP -.BR "nic3com" , " nicrealtek" , " nicsmc1211" , " gfxnvidia" , " satasii \ -" and " atahpt " programmers +.BR "nic3com" , " nicrealtek" , " nicsmc1211" , " nicnatsemi" , " gfxnvidia\ +" , " satasii " and " atahpt " programmers These programmers have an option to specify the PCI address of the card your want to use, which must be specified if more than one card supported by the selected programmer is installed in your system. The syntax is @@ -396,6 +401,9 @@ .BR 30k ", " 125k ", " 250k ", " 1M ", " 2M ", " 2.6M ", " 4M ", " 8M (in Hz). The default is the maximum frequency of 8 MHz. .TP +.BR "dediprog " programmer +No parameters defined yet. +.TP .BR "rayer_spi " programmer The default I/O base address used for the parallel port is 0x378 and you can use the optional @@ -484,28 +492,48 @@ .br Please see the individual files. .SH AUTHORS +Andrew Morgan <ziltro(a)ziltro.com> +.br Carl-Daniel Hailfinger .br Claus Gindhart <claus.gindhart(a)kontron.com> .br +David Borg <borg.db(a)gmail.com> +.br +David Hendricks <dhendrix(a)google.com> +.br Dominik Geyer <dominik.geyer(a)kontron.com> .br Eric Biederman .br Giampiero Giancipoli <gianci(a)email.it> .br +Helge Wagner <helge.wagner(a)ge.com> +.br +Idwer Vollering <vidwer+flashrom(a)gmail.com> +.br Joe Bao <Zheng.Bao(a)amd.com> .br +Jörg Fischer <turboj(a)gmx.de> +.br +Joshua Roys <roysjosh(a)gmail.com> +.br Luc Verhaegen <libv(a)skynet.be> .br Li-Ta Lo .br Markus Boas <ryven(a)ryven.de> .br +Mattias Mattsson <vitplister(a)gmail.com> +.br Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> .br Nikolay Petukhov <nikolay.petukhov(a)gmail.com> .br +Patrick Georgi <patrick.georgi(a)coresystems.de> +.br +Peter Lemenkov <lemenkov(a)gmail.com> +.br Peter Stuge <peter(a)stuge.se> .br Reinder E.N. de Haan <lb_reha(a)mveas.com> @@ -520,6 +548,8 @@ .br Stefan Wildemann <stefan.wildemann(a)kontron.com> .br +Stephan Guilloux <stephan.guilloux(a)free.fr> +.br Steven James <pyro(a)linuxlabs.com> .br Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Wed Oct 6 04:56:44 2010 (r1196) +++ trunk/pcidev.c Thu Oct 7 01:03:21 2010 (r1197) @@ -119,7 +119,7 @@ exit(1); } else if (found > 1) { msg_perr("Error: Multiple supported PCI devices found. " - "Use 'flashrom -p xxxx:bb:dd.f' \n" + "Use 'flashrom -p xxxx:pci=bb:dd.f' \n" "to explicitly select the card with the given BDF " "(PCI bus, device, function).\n"); exit(1);

1 0

[PATCH] remove duplicate includes
by Stefan Reinauer 06 Oct '10

06 Oct '10

See patch. -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

2 2

[commit] r1196 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: stepan Date: Wed Oct 6 04:56:44 2010 New Revision: 1196 URL: http://flashrom.org/trac/flashrom/changeset/1196 Log: Remove duplicate includes from the code. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/atahpt.c trunk/bitbang_spi.c trunk/buspirate_spi.c trunk/cbtable.c trunk/chipset_enable.c trunk/cli_classic.c trunk/dummyflasher.c trunk/ft2232_spi.c trunk/gfxnvidia.c trunk/hwaccess.h trunk/internal.c trunk/mcp6x_spi.c trunk/pcidev.c trunk/physmap.c trunk/serial.c trunk/serprog.c Modified: trunk/atahpt.c ============================================================================== --- trunk/atahpt.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/atahpt.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/bitbang_spi.c ============================================================================== --- trunk/bitbang_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/bitbang_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,7 +18,6 @@ */ #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/buspirate_spi.c ============================================================================== --- trunk/buspirate_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/buspirate_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,7 +18,6 @@ */ #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/cbtable.c ============================================================================== --- trunk/cbtable.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/cbtable.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <unistd.h> #include <stdio.h> #include <stdlib.h> -#include <sys/types.h> #include <string.h> #include "flash.h" #include "programmer.h" Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/chipset_enable.c Wed Oct 6 04:56:44 2010 (r1196) @@ -29,7 +29,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include <unistd.h> #include "flash.h" #include "programmer.h" Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/cli_classic.c Wed Oct 6 04:56:44 2010 (r1196) @@ -23,7 +23,6 @@ #include <stdio.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/stat.h> #include <string.h> #include <stdlib.h> Modified: trunk/dummyflasher.c ============================================================================== --- trunk/dummyflasher.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/dummyflasher.c Wed Oct 6 04:56:44 2010 (r1196) @@ -21,7 +21,6 @@ #include <string.h> #include <stdlib.h> #include <ctype.h> -#include <sys/types.h> #include "flash.h" #include "chipdrivers.h" #include "programmer.h" Modified: trunk/ft2232_spi.c ============================================================================== --- trunk/ft2232_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/ft2232_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -21,7 +21,6 @@ #if CONFIG_FT2232_SPI == 1 #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/gfxnvidia.c ============================================================================== --- trunk/gfxnvidia.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/gfxnvidia.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/hwaccess.h ============================================================================== --- trunk/hwaccess.h Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/hwaccess.h Wed Oct 6 04:56:44 2010 (r1196) @@ -252,7 +252,6 @@ #define iopl amd64_iopl #endif #endif - #include <stdint.h> static inline void outb(uint8_t value, uint16_t port) { Modified: trunk/internal.c ============================================================================== --- trunk/internal.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/internal.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,10 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <stdint.h> #include <string.h> #include <stdlib.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/mcp6x_spi.c ============================================================================== --- trunk/mcp6x_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/mcp6x_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #if defined(__i386__) || defined(__x86_64__) -#include <stdint.h> #include <stdlib.h> #include <ctype.h> #include "flash.h" Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/pcidev.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/physmap.c Wed Oct 6 04:56:44 2010 (r1196) @@ -22,7 +22,6 @@ #include <unistd.h> #include <stdio.h> -#include <sys/types.h> #include <stdlib.h> #include <string.h> #include "flash.h" @@ -135,8 +134,6 @@ } #elif defined(__DARWIN__) -#include <DirectIO/darwinio.h> - #define MEM_DEV "DirectIO" static void *sys_physmap(unsigned long phys_addr, size_t len) Modified: trunk/serial.c ============================================================================== --- trunk/serial.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/serial.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <string.h> #include <ctype.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/stat.h> #include <errno.h> #include <inttypes.h> Modified: trunk/serprog.c ============================================================================== --- trunk/serprog.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/serprog.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <string.h> #include <ctype.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/socket.h> #include <arpa/inet.h> #include <netinet/in.h>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom