Good day,
I wanted to confirm that we are splitting flashchips.c file into
separate files per vendor. flashchips.c will still stay in the source
code but it will be much smaller and will only contain "generic" chip
entries.
The patch is here: https://review.coreboot.org/c/flashrom/+/83307 , it
will be submitted after v1.5.0 tag is done. The patch will not be
included in v1.5.0 release.
There will be no changes to the usage, and everything that's supported
stays the same.
If you are a flashrom user who does not look into source code: this
does not affect you at all.
If you are working on adding support for a chip model: when the patch
is submitted (I will post again) you will need to copy your code from
flashchips.c into a vendor-specific file. Thank you!
--
Anastasia.
Good day everyone,
We are doing one more release this year! It's a smaller scope than the
previous one, but will contain some important things.
We now have a document describing release process in details:
https://flashrom.org/dev_guide/release_process.html so I will just
tell the dates:
15 November: tagging v1.5.0-rc1
6 December: tagging the release v1.5.0
Between 15 November and 6 December we are focused on testing and
bugfixing, so no new features will be submitted during that time. The
patches can still be pushed and reviewed, but submit will need to wait
for after we tag v1.5.0 (ETA 6 December).
Bugfixes will be submitted as usual.
Any help with buildind/testing/bugfixing is very much appreciated!
https://flashrom.org/how_to_support_flashrom.html#building-and-testing-1
What's included in the next release?
We now have a document which accumulates info about recent development
(for any next release): https://flashrom.org/release_notes/devel.html
It's not full final release notes, some things might be missing: for
example I will soon add the "Bugs fixed" section there.
Lastly, we plan to split flashchips.c into separate smaller files per
vendor. The file grew huge, and it's time to split. To minimise the
disruption for contributors who are adding support for new chip
models, we plan to do this between 15 November and 6 December, when
there are less contributions. This work will be submitted only after
v1.5.0 tag.
--
Anastasia.
Hello, attached are two text documents: output from --wp-disable and
output from erase/write - let me know if any other information is
needed.
Chip in question is "W25Q64JW...M"
Thanks,
Tim
Hello,
I can not disable write protect with flashrom on these devices. It keeps
saying, "unknown WP error" or "Your flash chip is in an unknown state". Any
information would be helpful.
Thank you,
John
Dear flashrom team,
I am encountering an issue when trying to use flashrom on a system with an
AMD FP4 chipset. Upon attempting to access the flash memory, I receive the
following error messages:
flashrom v1.2 on Linux 6.4.0-150600.23.25-default (x86_64)
flashrom is free software, get the source code at https://flashrom.org
Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
Found chipset "AMD FP4".
Enabling flash write... Disabling read write protection of flash addresses
from 0xfffff800 to 0x0007f7ff failed.
Disabling read write protection of flash addresses from 0xfffff800 to
0x0007f7ff failed.
Disabling read write protection of flash addresses from 0xfffff800 to
0x0007f7ff failed.
Disabling read write protection of flash addresses from 0xfffff800 to
0x0007f7ff failed.
FCH device found but SMBus revision 0x71 does not match known values.
Please report this to flashrom(a)flashrom.org and include this log and
the output of lspci -nnvx, thanks!.
Could not determine chipset generation. PROBLEMS, continuing anyway
No EEPROM/flash device found.
Note: flashrom can never write if the flash chip isn't found automatically.
I have attached the lspci_output.txt file with the full output from the lspci
-nnvx command, as suggested by the error message.
I am seeking a solution to access the flash memory for reading or writing,
but it appears that my chipset and SMBus revision may not be fully
supported or recognized by flashrom. I would greatly appreciate any
guidance or solutions you can provide.
Thank you for your attention and for the excellent work on flashrom. I look
forward to your response.
Best regards,
David
Hello,
Over the last few weeks I have been adding support for the Replay
protected monotonic counter commands to flashrom. Their functionality is
defined in the JESD260 specification [1].
Currently they only work by manually setting the flash chip to use
SFDP-capable chip. This is done with `-c "SFDP-capable chip"`. This
enables automatic feature detection by parsing the corresponding SFDP-table.
If you want to enable this new feature on supporting flashchips, this is
done by setting the FEATURE_FLASH_HARDENING bit and then setting the
correct values within the rpmc_ctx struct.
Usage of the commands is explained here [2].
They just made the cutoff and so this new feature will be a part of
flashrom v1.5.
Best Regards,
Matti.
[1] https://www.jedec.org/standards-documents/docs/jesd260
[2] https://www.flashrom.org/classic_cli_manpage.html#rpmc-commands
Victor,
Thank you so much for the datasheets! I did a review of the pending
patch, and now it will be possible to finally finish the patch from
2021 and get the chips submitted.
Also thank you for attaching the log.
Not sure if the log is complete? It ends at the start of the reading
operation, but there is no final message of SUCCESS or FAIL.
However, importantly, I could see in the beginning of the log which
platform was detected, and it is Promontory. Which means...
Avinash,
Most likely you are hitting a known issue, you can read more details
here: https://ticket.coreboot.org/issues/370
The issue is for Promontory, and also for chips larger than 16Mbyte:
which is exactly what you have.
I was actually trying to get help from AMD with this issue, so it's
really good to have you here on the mailing list! Maybe you can help?
Someone from AMD would be in the best position to fix Promontory, you
have all the datasheets available, and all the hardware.
Thank you!
On Sat, May 11, 2024 at 9:40 PM Vlim <vlim(a)gigadevice.com> wrote:
>
> Hi, Anastasia,
>
> Please find the attached datasheet for GD25LR256E and GD25LR512ME.
>
> There are actually two issues.
>
> the released flashrom does not support GD25LR256E and GD25LR512ME.
> With my patch, the dediprog programmer works for GD25LR512ME. But the AMD internal programmer for Birman Plus Board does not work. Output file attached.
>
>
> This is the comment about Birman Plus Board
>
> Now, Flashrom can detect the flash chip.
> Using dediprog programmer I can read/write the flash chip successfully.
> Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> Please give your input on this.
>
>
> Regards,
>
> Victor
>
>
> ________________________________
> From: Anastasia Klimchuk <aklm(a)chromium.org>
> Sent: Saturday, May 11, 2024 17:59
> To: Vlim <vlim(a)gigadevice.com>; Munduru, Avinash <avinash.munduru(a)amd.com>
> Cc: flashrom(a)flashrom.org <flashrom(a)flashrom.org>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> 此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息
> This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
>
> There is another thing, in addition to my previous message.
>
> I looked into the patch which adds chip definitions (this one
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.co…) and the reason it is
> pending is there are no links to datasheets (old links are not working
> anymore).
> It is unfortunate that the patch is pending since 2021, but I want to
> try to fix the situation now, in the year 2024.
>
> Victor, maybe you know, is it possible to find datasheets for
> GD25LR256E and GD251R512ME? I could finish the old patch and get chips
> into the tree.
>
> This is a separate question to Avinash's issue with internal
> programmer, but for this we need the very verbose log (which is log
> with -VVV option on command line).
>
> Thank you!
>
> On Thu, May 9, 2024 at 11:03 PM Anastasia Klimchuk <aklm(a)chromium.org> wrote:
> >
> > Avinash, I read the thread and I see you are saying "I am attaching
> > the log here" but I don't see the log? maybe you can re-send it again,
> > now with the mailing list? (perhaps you sent it to Victor only?)
> > Yes it is also important to know your board, since you are saying the
> > chip worked successfully with dediprog, but not with the internal
> > programmer.
> >
> > Victor, thank you so much for helping!
> >
> >
> > On Mon, May 6, 2024 at 6:42 PM Vlim <vlim(a)gigadevice.com> wrote:
> > >
> > > Thanks, Avinash,
> > >
> > > Can you advise which board are you using?
> > > I have tested this patch with the USB programmer only since I do not have access to the motherboard.
> > >
> > > Hi, Flashrom team,
> > > Can you also help on this?
> > >
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > FAE Director
> > > GigaDevice Semiconductor
> > > 4088833856
> > > vlim(a)gigadevice.com
> > >
> > > ________________________________
> > > From: Munduru, Avinash <Avinash.Munduru(a)amd.com>
> > > Sent: Monday, May 6, 2024 16:24
> > > To: Vlim <vlim(a)gigadevice.com>; flashrom(a)flashrom.org <flashrom(a)flashrom.org>
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > You don't often get email from avinash.munduru(a)amd.com. Learn why this is important
> > > 此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > >
> > >
> > > Hi Victor,
> > >
> > > Thanks for sharing the patch. Here is an update after trying the shared patch.
> > >
> > > Now, Flashrom can detect the flash chip.
> > > Using dediprog programmer I can read/write the flash chip successfully.
> > > Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> > > Please give your input on this.
> > >
> > > Once again! Thanks for your help!
> > >
> > >
> > > ________________________________
> > > From: Vlim <vlim(a)gigadevice.com>
> > > Sent: Sunday, May 5, 2024 1:54 PM
> > > To: flashrom(a)flashrom.org <flashrom(a)flashrom.org>; Munduru, Avinash <Avinash.Munduru(a)amd.com>
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> > >
> > > Hi, Avinash,
> > >
> > > Sorry that I am working on adding this part to Flashrom, but has not completed the entire process.
> > >
> > > Can you please use the attached flashchips.c and flashshchips.h and replace that in flashrom distribution?
> > >
> > > This is the process.
> > >
> > > git clone "https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.co…"
> > >
> > > meson setup builddir
> > > meson compile -C builddir
> > > meson test -C builddir
> > > meson install -C builddir
> > >
> > >
> > > Please also refer to the following link for compilation of the code.
> > > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fflashrom.…
> > >
> > > I have a compiled version for Ubuntu Linux, if that will help, I can share with you.
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > GigaDevice Semiconductors Inc.
> > > 4088833856
> > > vlim(a)gigadevice.com
> > >
> > >
> > > ________________________________
> > > From: Munduru, Avinash via flashrom <flashrom(a)flashrom.org>
> > > Sent: Tuesday, April 30, 2024 16:54
> > > To: flashrom(a)flashrom.org <flashrom(a)flashrom.org>
> > > Subject: [flashrom] Re: Support for GD25LR512ME flash chip.
> > >
> > > 此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > >
> > >
> > > + attaching the output log
> > >
> > > ________________________________
> > > From: Munduru, Avinash
> > > Sent: Tuesday, April 30, 2024 2:04 PM
> > > To: flashrom(a)flashrom.org <flashrom(a)flashrom.org>
> > > Subject: Support for GD25LR512ME flash chip.
> > >
> > > Hi,
> > >
> > > Currently, flash chip support for GD25LR512ME is not supported in flashrom utility.
> > > Please share a patch if it is already available. If not let me know how I can modify it.
> > >
> > > _______________________________________________
> > > flashrom mailing list -- flashrom(a)flashrom.org
> > > To unsubscribe send an email to flashrom-leave(a)flashrom.org
> >
> >
> >
> > --
> > Anastasia.
>
>
>
> --
> Anastasia.
--
Anastasia.