flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[PATCH] remove duplicate includes
by Stefan Reinauer 06 Oct '10

06 Oct '10

See patch. -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

2 2

[commit] r1196 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: stepan Date: Wed Oct 6 04:56:44 2010 New Revision: 1196 URL: http://flashrom.org/trac/flashrom/changeset/1196 Log: Remove duplicate includes from the code. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/atahpt.c trunk/bitbang_spi.c trunk/buspirate_spi.c trunk/cbtable.c trunk/chipset_enable.c trunk/cli_classic.c trunk/dummyflasher.c trunk/ft2232_spi.c trunk/gfxnvidia.c trunk/hwaccess.h trunk/internal.c trunk/mcp6x_spi.c trunk/pcidev.c trunk/physmap.c trunk/serial.c trunk/serprog.c Modified: trunk/atahpt.c ============================================================================== --- trunk/atahpt.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/atahpt.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/bitbang_spi.c ============================================================================== --- trunk/bitbang_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/bitbang_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,7 +18,6 @@ */ #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/buspirate_spi.c ============================================================================== --- trunk/buspirate_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/buspirate_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,7 +18,6 @@ */ #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/cbtable.c ============================================================================== --- trunk/cbtable.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/cbtable.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <unistd.h> #include <stdio.h> #include <stdlib.h> -#include <sys/types.h> #include <string.h> #include "flash.h" #include "programmer.h" Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/chipset_enable.c Wed Oct 6 04:56:44 2010 (r1196) @@ -29,7 +29,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include <unistd.h> #include "flash.h" #include "programmer.h" Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/cli_classic.c Wed Oct 6 04:56:44 2010 (r1196) @@ -23,7 +23,6 @@ #include <stdio.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/stat.h> #include <string.h> #include <stdlib.h> Modified: trunk/dummyflasher.c ============================================================================== --- trunk/dummyflasher.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/dummyflasher.c Wed Oct 6 04:56:44 2010 (r1196) @@ -21,7 +21,6 @@ #include <string.h> #include <stdlib.h> #include <ctype.h> -#include <sys/types.h> #include "flash.h" #include "chipdrivers.h" #include "programmer.h" Modified: trunk/ft2232_spi.c ============================================================================== --- trunk/ft2232_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/ft2232_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -21,7 +21,6 @@ #if CONFIG_FT2232_SPI == 1 #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/gfxnvidia.c ============================================================================== --- trunk/gfxnvidia.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/gfxnvidia.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/hwaccess.h ============================================================================== --- trunk/hwaccess.h Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/hwaccess.h Wed Oct 6 04:56:44 2010 (r1196) @@ -252,7 +252,6 @@ #define iopl amd64_iopl #endif #endif - #include <stdint.h> static inline void outb(uint8_t value, uint16_t port) { Modified: trunk/internal.c ============================================================================== --- trunk/internal.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/internal.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,10 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <stdint.h> #include <string.h> #include <stdlib.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/mcp6x_spi.c ============================================================================== --- trunk/mcp6x_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/mcp6x_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #if defined(__i386__) || defined(__x86_64__) -#include <stdint.h> #include <stdlib.h> #include <ctype.h> #include "flash.h" Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/pcidev.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/physmap.c Wed Oct 6 04:56:44 2010 (r1196) @@ -22,7 +22,6 @@ #include <unistd.h> #include <stdio.h> -#include <sys/types.h> #include <stdlib.h> #include <string.h> #include "flash.h" @@ -135,8 +134,6 @@ } #elif defined(__DARWIN__) -#include <DirectIO/darwinio.h> - #define MEM_DEV "DirectIO" static void *sys_physmap(unsigned long phys_addr, size_t len) Modified: trunk/serial.c ============================================================================== --- trunk/serial.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/serial.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <string.h> #include <ctype.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/stat.h> #include <errno.h> #include <inttypes.h> Modified: trunk/serprog.c ============================================================================== --- trunk/serprog.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/serprog.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <string.h> #include <ctype.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/socket.h> #include <arpa/inet.h> #include <netinet/in.h>

1 0

Multiple PCI devices found, typo
by Iain Paton 06 Oct '10

06 Oct '10

Hi, When testing the with a dual port nic recently I saw a small typo in the error message when flashrom finds multiple devices: Error: Multiple supported PCI devices found. Use 'flashrom -p xxxx:bb:dd.f' to explicitly select the card with the given BDF (PCI bus, device, function). From the man page it seems this should really be 'flashrom -p xxxx:pci=bb:dd.f' as the first form has no effect. Rgds, Iain

2 1

flashrom bios ecs k725a help
by I N 06 Oct '10

06 Oct '10

can someone please help me understand this from the output: No coreboot table found. sh: dmidecode: command not found dmidecode execution unsucessfull - continuing without DMI info Found ITE Super I/O, id 8705 Found chipset "SiS 735", enabling flash write... OK. This chipset supports the following protocols: Non-SPI. Calibrating delay loop... OK. No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. i provide as requested on irc attachments of 'flashrom -V', 'lspci -nnvvvxxx', 'superiotool -deV', exact name board: EliteGroup K7S5A, link to bios update: http://www.ecs.com.tw/ECSWebSite/Product/Product_Detail.aspx?CategoryID=1&D… i really don't know which one to get from that page. please tell me if i can use flashrom to update my bios. thank you.

2 1

[PATCH] Mark SST49LF160C tested for erase
by Ed Swierk 06 Oct '10

06 Oct '10

I have tested the erase operation with the SST49LF160C LPC flash chip. Signed-off-by: Ed Swierk <eswierk(a)aristanetworks.com> --- Index: flashrom-0.9.2-r1057/flashchips.c =================================================================== --- flashrom-0.9.2-r1057.orig/flashchips.c +++ flashrom-0.9.2-r1057/flashchips.c @@ -4582,7 +4582,7 @@ struct flashchip flashchips[] = { .total_size = 2048, .page_size = 4 * 1024, .feature_bits = FEATURE_REGISTERMAP, - .tested = TEST_OK_PRW, + .tested = TEST_OK_PREW, .probe = probe_82802ab, .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ .block_erasers =

2 1

[PATCH] DJGPP: Avoid leak on lowmem mapping error
by Carl-Daniel Hailfinger 06 Oct '10

06 Oct '10

DJGPP: Avoid leaking memory on lowmem mapping error. Add a clarifying comment about why low memory is never unmapped. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-djgpp_physmap_noleaks/physmap.c =================================================================== --- flashrom-djgpp_physmap_noleaks/physmap.c (Revision 1194) +++ flashrom-djgpp_physmap_noleaks/physmap.c (Arbeitskopie) @@ -56,6 +56,8 @@ } if (__djgpp_map_physical_memory(realmem_map, (1024 * 1024), 0)) { + free(realmem_map); + realmem_map = NULL; return ERROR_PTR; } @@ -95,7 +97,9 @@ { __dpmi_meminfo mi; - /* we ignore unmaps for our first 1MB */ + /* There is no known way to unmap the first 1 MB. The DPMI server will + * do this for us on exit. + */ if ((virt_addr >= realmem_map) && ((virt_addr + len) <= (realmem_map + (1024 * 1024)))) { return; } -- http://www.hailfinger.org/

1 1

[commit] r1195 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: hailfinger Date: Wed Oct 6 01:21:51 2010 New Revision: 1195 URL: http://flashrom.org/trac/flashrom/changeset/1195 Log: DJGPP: Avoid leaking memory on lowmem mapping error. Add a clarifying comment about why low memory is never unmapped. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Rudolf Marek <r.marek(a)assembler.cz> Modified: trunk/physmap.c Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Wed Oct 6 00:29:08 2010 (r1194) +++ trunk/physmap.c Wed Oct 6 01:21:51 2010 (r1195) @@ -56,6 +56,8 @@ } if (__djgpp_map_physical_memory(realmem_map, (1024 * 1024), 0)) { + free(realmem_map); + realmem_map = NULL; return ERROR_PTR; } @@ -95,7 +97,9 @@ { __dpmi_meminfo mi; - /* we ignore unmaps for our first 1MB */ + /* There is no known way to unmap the first 1 MB. The DPMI server will + * do this for us on exit. + */ if ((virt_addr >= realmem_map) && ((virt_addr + len) <= (realmem_map + (1024 * 1024)))) { return; }

1 0

flash log of a LENOVO A57 - 97048HG
by Maurizio Pedrazzi 06 Oct '10

06 Oct '10

3 2

Re: [flashrom] Speedup SST 25VF032B and 25VF064C programming
by Carl-Daniel Hailfinger 06 Oct '10

06 Oct '10

Hi Helge, I'm very sorry, it seems that the patch repeatedly slipped through the cracks because patchwork didn't pick it up (application/octet-stream for the attachment may have been the reason, but that is fixed now). On 06.08.2010 15:28, Wagner, Helge (GE Intelligent Platforms) wrote: > I have tested both SST 25VF032B and SST 25VF064C on a QM57 (IbexPeak) > system and found that the reprogramming of these chips is very slow. > > So i have changed the programming engine for the 25VF064C from > "spi_chip_write_1" to "spi_chip_write_256". > I have tested the 25VF064C with the new engine and it works fine. > > For the 25VF032B i have changed the programming engine from > "spi_chip_write_1" to "spi_aai_write". > I have tested this engine, too, and found it working (speedup was from > 228 to 113 seconds). > > While testing i found that some commands needed by some of the > algorithms are not in the OPCODE table. So i have implemented the > on-the-fly reprogramming of the OPCODE table (in the ICH engine). > > Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> > > Speedup for new 25VF032B programming algorithm: from 3091 [sic!] to 123 > seconds > This patch is a huge step forward for many Intel chipsets. Thank you! > diff -urN flashrom-0.9.2/ichspi.c flashrom/ichspi.c > --- flashrom-0.9.2/ichspi.c 2010-07-28 00:41:39.000000000 +0200 > +++ flashrom/ichspi.c 2010-08-06 14:46:47.000000000 +0200 > @@ -708,11 +777,11 @@ > /* find cmd in opcodes-table */ > opcode_index = find_opcode(curopcodes, cmd); > if (opcode_index == -1) { > - /* FIXME: Reprogram opcodes if possible. Autodetect type of > - * opcode by checking readcnt/writecnt. > - */ > - msg_pdbg("Invalid OPCODE 0x%02x\n", cmd); > - return SPI_INVALID_OPCODE; > + opcode_index = reprogram_opcode_on_the_fly(cmd, writecnt, readcnt); > This line should be conditional on !ichspi_lock. I have changed that in the commit. > + if (opcode_index == -1) { > + msg_pdbg("Invalid OPCODE 0x%02x\n", cmd); > + return SPI_INVALID_OPCODE; > + } > } > > opcode = &(curopcodes->opcode[opcode_index]); > Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> ICH dynamic opcode reprogramming patch committed in r1193. AAI write for SST25VF032B and page write for SST25VF064C committed in r1194. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[commit] r1194 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: hailfinger Date: Wed Oct 6 00:29:08 2010 New Revision: 1194 URL: http://flashrom.org/trac/flashrom/changeset/1194 Log: Use AAI write for SST SST25VF032B. Speedup from 228 to 113 seconds. Use page (256 byte) write for SST SST25VF064C. Speedup from 3091 to 123 seconds. Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/chipdrivers.h trunk/flashchips.c trunk/spi25.c Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Wed Oct 6 00:06:05 2010 (r1193) +++ trunk/chipdrivers.h Wed Oct 6 00:29:08 2010 (r1194) @@ -63,7 +63,8 @@ int spi_nbyte_read(int addr, uint8_t *bytes, int len); int spi_read_chunked(struct flashchip *flash, uint8_t *buf, int start, int len, int chunksize); int spi_write_chunked(struct flashchip *flash, uint8_t *buf, int start, int len, int chunksize); -int spi_aai_write(struct flashchip *flash, uint8_t *buf, int start, int len); +int spi_aai_write_new(struct flashchip *flash, uint8_t *buf, int start, int len); +int spi_aai_write(struct flashchip *flash, uint8_t *buf); /* 82802ab.c */ uint8_t wait_82802ab(chipaddr bios); Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Wed Oct 6 00:06:05 2010 (r1193) +++ trunk/flashchips.c Wed Oct 6 00:29:08 2010 (r1194) @@ -4860,7 +4860,7 @@ .model_id = SST_SST25VF032B, .total_size = 4096, .page_size = 256, - .tested = TEST_OK_PRW, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = @@ -4883,7 +4883,7 @@ }, }, .unlock = spi_disable_blockprotect, - .write = spi_chip_write_1, + .write = spi_aai_write, .read = spi_chip_read, }, @@ -4918,7 +4918,7 @@ }, }, .unlock = spi_disable_blockprotect, - .write = spi_chip_write_1, + .write = spi_chip_write_256, .read = spi_chip_read, }, Modified: trunk/spi25.c ============================================================================== --- trunk/spi25.c Wed Oct 6 00:06:05 2010 (r1193) +++ trunk/spi25.c Wed Oct 6 00:29:08 2010 (r1194) @@ -1300,7 +1300,7 @@ return spi_chip_write_1_new(flash, buf, 0, flash->total_size * 1024); } -int spi_aai_write(struct flashchip *flash, uint8_t *buf, int start, int len) +int spi_aai_write_new(struct flashchip *flash, uint8_t *buf, int start, int len) { uint32_t pos = start; int result; @@ -1391,3 +1391,17 @@ spi_write_disable(); return 0; } + +int spi_aai_write(struct flashchip *flash, uint8_t *buf) +{ + /* Erase first */ + msg_cinfo("Erasing flash before programming... "); + if (erase_flash(flash)) { + msg_cerr("ERASE FAILED!\n"); + return -1; + } + msg_cinfo("done.\n"); + + return spi_aai_write_new(flash, buf, 0, flash->total_size * 1024); +} +

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom