Re: [flashrom] Cleanup patches for flashrom
by Nico Huber
Hi Richard,
On 20.12.18 11:11, Richard Hughes wrote:
> We're slowly moving towards using libflashrom in fwupd, rather than
> exec'ing the flashrom binary and screen scraping. So that it can be
> consumed by users easily, I'm tempted to use flashrom as a subproject
> to the fwupd project rather than waiting for distros to ship any new
> bleeding edge version of flashrom to users. To make some of that
> possible, I've fixed up a few of the CI failures we would see in
> fwupd, which I've filed as a PR here:
> https://github.com/flashrom/flashrom/pull/67
thanks.
>
> If a GitHub PR isn't how you want these kind of general patches please
> let me know. One person already told me that I needed to use Gerrit,
When we switched to Gerrit, we decided to still allow patches per email
and also on GitHub. Though, all patches have to go through Gerrit in the
end as that's where the official repository is.
I've never been active on GitHub (my account is only few months old).
And the developers that set the flashrom mirror up there obviously had
the best intentions (pull requests are mentioned in the project des-
cription) but aren't actively reviewing atm.
I also can't say anymore that everything on Gerrit gets a review, though
smaller changes do. If you'd use Gerrit, you'd hit the remaining active
reviewers right in their everyday workflow.
> but I'm not overly keen on learning a new process if I can avoid it.
> Feedback welcome, thanks.
I just tried, it was horrible ;) I just can't find a way to comment on
individual commits of your PR (beside commenting inline in the code).
I'll leave some comments their and pull those commits that seem ready
to go.
Nico
2 weeks, 2 days
Flashing Asus KGPE-D16 Chip
by Joshua Aspinall
Hi,
I am attempting to write a Libreboot ROM to my BIOS chip. The chip
reports as follows:
sudo flashrom -p linux_spi:dev=/dev/spidev0.0
'Found Winbond flash chip "W25Q16.V" (2048 kB, SPI) on linux_spi.'
All of the online guides show reading the chip before attempting to
flash, and confirming that the checksums match. However, when reading
the contents of the flash chip, the checksums vary wildly. When
attempting to flash the chip with a Libreboot ROM for the board, the
erase function fails on all attempts as follows:
sudo flashrom --programmer linux_spi:dev=/dev/spidev0.0 --write
kgpe-d16_ukqwerty_txtmode.rom
flashrom p1.0-141-g9cecc7e on Linux 4.14.79+ (armv6l)
flashrom is free software, get the source code at https://flashrom.org
Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
Using default 2000kHz clock. Use 'spispeed' parameter to override.
Found Winbond flash chip "W25Q16.V" (2048 kB, SPI) on linux_spi.
Reading old flash chip contents... done.
Erasing and writing flash chip... FAILED at 0x00000000! Expected=0xff,
Found=0x00, failed byte count from 0x00000000-0x00000fff: 0x1000
ERASE FAILED!
Reading current flash chip contents... done. Looking for another erase
function.
FAILED at 0x000007fd! Expected=0xff, Found=0xfe, failed byte count from
0x00000000-0x00007fff: 0x6218
ERASE FAILED!
Reading current flash chip contents... done. Looking for another erase
function.
FAILED at 0x000001bb! Expected=0xff, Found=0xfc, failed byte count from
0x00000000-0x0000ffff: 0xbde4
ERASE FAILED!
Reading current flash chip contents... done. Looking for another erase
function.
FAILED at 0x00000000! Expected=0xff, Found=0x00, failed byte count from
0x00000000-0x001fffff: 0x18a7c0
ERASE FAILED!
Reading current flash chip contents... done. Looking for another erase
function.
FAILED at 0x00000111! Expected=0xff, Found=0xc0, failed byte count from
0x00000000-0x001fffff: 0x18af13
ERASE FAILED!
Reading current flash chip contents... done. Looking for another erase
function.
Looking for another erase function.
Looking for another erase function.
No usable erase functions left.
FAILED!
Uh oh. Erase/write failed. Checking if anything has changed.
Reading current flash chip contents... done.
Apparently at least some data has changed.
Your flash chip is in an unknown state.
Please report this on IRC at chat.freenode.net (channel #flashrom) or
mail flashrom(a)flashrom.org, thanks!
I am trying to determine whether I am doing something incorrectly, or
whether the chip is unserviceable and needs to be replaced.
Any help/hints would be greatly appreciated!
Best Regards,
Joshua Aspinall.
2 weeks, 2 days
Re: FAILED MARS
by Ivan Ivanov
Dear Tom, very happy to see your success :)
Although I hope that you are installing Win7 not Win10 aka "spyware edition" ;)
Happy New Year ! ;)
BR,
Ivan
пн, 31 дек. 2018 г. в 21:44, Tom Santos <tom.81748418(a)gmail.com>:
>
> Good news!!!
>
> i just close and open google chrome and run the script again and done!!
>
> sorry for bad english, thanks for your support!!
>
> happy new year!!!
>
> Em segunda-feira, 31 de dezembro de 2018, Ivan Ivanov <qmastery16(a)gmail.com> escreveu:
>>
>> You may try to flash this image directly using flashrom, not using
>> someone else's scripts because they might be faulty...
>>
>> пн, 31 дек. 2018 г. в 19:36, Tom Santos <tom.81748418(a)gmail.com>:
>> >
>> > Help pleas !!!!
>> >
>> > --
>> > Att,
>> >
>> >
>> > Tom Santos.
>> >
>> >
>> >
>> >
>> > A mente cria, o desejo atrai e a fé realiza.
>> > _______________________________________________
>> > flashrom mailing list -- flashrom(a)flashrom.org
>> > To unsubscribe send an email to flashrom-leave(a)flashrom.org
>
>
>
> --
> Att,
>
>
> Tom Santos.
>
>
>
>
> A mente cria, o desejo atrai e a fé realiza.
>
2 weeks, 4 days
FAILED MARS
by Tom Santos
Help pleas !!!!
--
Att,
Tom Santos.
A mente cria, o desejo atrai e a fé realiza.
2 weeks, 4 days
Successful flash of ASRock soldered BIOS via BIOS_PH header
by David Bartley
I have an ASRock Z390M-ITX/ac motherboard with a soldered/non-removable
BIOS chip (this is apparently not uncommon on ASRock motherboards). I
initially tried using test clips, but I wasn't able to get a good
connection. Fortunately, the motherboard features a BIOS_PH header that is
wired to the BIOS chip. Despite existing on multiple motherboards, its
pinout is seemingly only documented in the J3355M manual (
http://asrock.pc.cdn.bitgravity.com/Manual/J3355M.pdf). Using this pinout,
I was able to connect some jumpers from the BIOS_PH header to a CH341A
programmer and successfully read from and write to the chip (a W25Q128JVSIQ
in my case).
For reference, the BIOS_PH pinout (corresponding to a 25xx chip) is:
DI | GND
CLK | no connection
no pin | DO
VCC | CS
HOLD | WP
2 weeks, 5 days
Thinkpad T410s failed to erase (corrupted?)
by Sea Wright
Hi all,
While trying to get coreboot working on a T410s, in the most recent flash (after multiple working successful flashes) the clip detached in the middle of the write process. I saw some error message briefly (I think it mentioned corrupted) before my ssh session terminated before I could finish reading it.
Now, with a new clip, I can read the chip perfectly, but trying to write/erase leads to these errors: https://paste.flashrom.org/view.php?id=3156
Failed at 0x0000000010! Expected=0xff, Found=0x5a, failed byte count from 0x00000000-0x007fffff: 0x3dc7fe
It is possible to write what is read from the chip (eh cock doesn't match what I tried to write to it) back onto it without failure.
Any suggestions?
menaechmi
2 weeks, 6 days
Report of flashrom failure (Intel DQ67OW motherboard)
by Tom Crane
Dear Flashrom developers,
Please find attached my failure report as suggested in flashrom
O/P. The PC has been updated with the latest BIOS (file
SWQ6710H.86A.0070.BI.zip from Intel) and I am running a built-today git
version of flashrom.
Thanks
Tom Crane
3 weeks
Re: [flashrom] 80/100/132 column line width policy
by Nico Huber
On 19.12.18 20:34, David Hendricks wrote:
> Regarding exceptions, I was taught that function signatures in header
>> files are an exception too. I don't mind either way, but if the rules
>> disagree with the current practice, we should make that explicit.
>>
>
> This makes sense, but can linters be taught the difference between source
> and header files? It would be nice to enforce the hard limit via commit
> hook.
I wouldn't mind a commit hook as long as a human has the last word.
If linters can be taught? I'm sure they can if they are open-source.
Maybe I don't get the question.
Nico
3 weeks, 5 days
