80/100/132 column line width policy
by Carl-Daniel Hailfinger
Hi,
we're hitting the 80 column limit in our code in ways which actually
reduce readability for the code. Examples are various multiline messages
and complicated nested code where refactoring to a separate function
doesn't make sense.
Keeping the old 80 column limit is not really an option anymore.
Standard terminal sizes have one of 80, 100 or 132 columns.
Given the monitor resolutions many people have nowadays, I think it is
safe to say that you can fit two xterms with 100 columns horizonally
next to each other. 100 columns should also be sufficient for a msg_p*
of roughly 80 columns of text.
132 columns provide more leeway, but IMHO that would be too wide for
good readability (and my screen can't fit two xterms side-by-side anymore).
Of course some files have sections where any column limit is not
acceptable (board lists etc.), but the column limit violations should be
limited to the affected file sections, not whole files.
Comments?
I'd like to get this decided today or tomorrow so we know where we need
line breaks in Stefan Tauner's new struct flashchip patch.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
3 months
[PATCH] Fix undefined behavior in OS defines
by Stefan Tauner
Found by clang (warning introduced in r258128), reported by Idwer.
Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
---
platform.h | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/platform.h b/platform.h
index c5a52ef..b58c303 100644
--- a/platform.h
+++ b/platform.h
@@ -24,10 +24,24 @@
#ifndef __PLATFORM_H__
#define __PLATFORM_H__ 1
-// Helper defines for operating systems
-#define IS_LINUX (defined(__gnu_linux__) || defined(__linux__))
-#define IS_MACOSX (defined(__APPLE__) && defined(__MACH__)) /* yes, both. */
-#define IS_WINDOWS (defined(_WIN32) || defined(_WIN64) || defined(__WIN32__) || defined(__WINDOWS__))
+/* Helper defines for operating systems.
+ * This may seem complicated but the following would be undefined behavior:
+ * #define IS_LINUX (defined(__gnu_linux__) || defined(__linux__)) */
+#if defined(__gnu_linux__) || defined(__linux__)
+ #define IS_LINUX (1)
+#else
+ #define IS_LINUX (0)
+#endif
+#if defined(__APPLE__) && defined(__MACH__) /* yes, both. */
+ #define IS_MACOSX (1)
+#else
+ #define IS_MACOSX (0)
+#endif
+#if defined(_WIN32) || defined(_WIN64) || defined(__WIN32__) || defined(__WINDOWS__)
+ #define IS_WINDOWS (1)
+#else
+ #define IS_WINDOWS (0)
+#endif
// Likewise for target architectures
#if defined (__i386__) || defined (__x86_64__) || defined(__amd64__)
--
Kind regards, Stefan Tauner
1 year, 5 months
Re: [flashrom] error during install to new Raspbian Distro
by Nico Huber
Hi Billy,
On 24.08.2017 09:03, Billy Isom wrote:
> hello friend
>
> I have been using flashrom for a little while now with great results, but i
> upgraded to the latest Raspbian Distro.
> upon attempting to reinstall Flashrom on my Raspberry PI 3 I receive an
> error.
>
> I was hoping you could shed some light on the cause and hopefully a
> solution to this.
>
> thank you for your help.
>
> [...]
> internal.c:148:32: error: 'par_master_internal' defined but not used
> [-Werror=unused-const-variable=]
> static const struct par_master par_master_internal = {
> ^~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
this is likely due to a change in the default warning options of your
compiler. As flashrom also defaults to not allow any warnings, the build
fails. You can deactivate this rule with WARNERROR=no added to your make
command, e.g. `sudo make WARNERROR=no`.
Hope that helps,
Nico
1 year, 6 months
Re: [flashrom] linux_spi:speed does not work?
by Stefan Tauner
On Thu, 24 Aug 2017 06:44:13 +0000
"Hänel-Baas, Alexander" <alexander.haenel-baas(a)sieb-meyer.de> wrote:
> You are right: 50Mhz is a high spi speed. In the data sheet from Spansion chip is
> described: "Normal READ 40Mhz, Fast READ 104MHz.
And they don't mention the legal RDID frequency at all... but I'd assume
40MHz as well.
>
> But the important question is:
> Why does the linux spidev use the wrong spi speed and was called repeatedly?
> In my test prog when we called ioctl(*spi_cs_fd, SPI_IOC_WR_MAX_SPEED_HZ, &spi_speed)
> the linux driver was called repeatedly too.
Yeah, I first thought it might be flashrom's shutdown/restore on exit
but that can't be the case... so again I expect the kernel driver doing
something wrong.
> So i will ask my question in the linux_spi mailing list.
>
Please report back when you find something out, thanks.
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
1 year, 6 months
error during install to new Raspbian Distro
by Billy Isom
hello friend
I have been using flashrom for a little while now with great results, but i
upgraded to the latest Raspbian Distro.
upon attempting to reinstall Flashrom on my Raspberry PI 3 I receive an
error.
I was hoping you could shed some light on the cause and hopefully a
solution to this.
thank you for your help.
sudo make
Replacing all version templates with 0.9.9-47-gaa91d5c.
Checking for a C compiler... found.
Target arch is arm
Target OS is Linux
Checking for libpci headers... found.
Checking version of pci_get_dev... new version (including PCI domain
parameter).
Checking if libpci is present and sufficient... yes.
Checking for libusb-0.1/libusb-compat headers... found.
Checking if libusb-0.1 is usable... yes.
Checking for libusb-1.0 headers... found.
Checking if libusb-1.0 is usable... yes.
Checking for FTDI support... found.
Checking for FT232H support in libftdi... found.
Checking if Linux SPI headers are present... yes.
Checking for utsname support... found.
Checking for clock_gettime support... found.
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
cli_classic.o -c cli_classic.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
cli_output.o -c cli_output.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
cli_common.o -c cli_common.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
print.o -c print.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
jedec.o -c jedec.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
stm50.o -c stm50.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o w39.o
-c w39.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
w29ee011.o -c w29ee011.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
sst28sf040.o -c sst28sf040.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
82802ab.o -c 82802ab.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
sst49lfxxxc.o -c sst49lfxxxc.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
sst_fwhub.o -c sst_fwhub.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
flashchips.o -c flashchips.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o spi.o
-c spi.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
spi25.o -c spi25.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
spi25_statusreg.o -c spi25_statusreg.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
opaque.o -c opaque.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o sfdp.o
-c sfdp.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
en29lv640b.o -c en29lv640b.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
at45db.o -c at45db.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
processor_enable.o -c processor_enable.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
chipset_enable.o -c chipset_enable.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
board_enable.o -c board_enable.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
cbtable.o -c cbtable.c
cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0
-D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
-D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
-D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
-D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1'
-D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1'
-D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_LINUX_SPI=1'
-D'CONFIG_CH341A_SPI=1' -D'NEED_PCI=1' -D'NEED_RAW_ACCESS=1'
-D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1'
-D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="0.9.9-47-gaa91d5c"' -o
internal.o -c internal.c
internal.c:148:32: error: 'par_master_internal' defined but not used
[-Werror=unused-const-variable=]
static const struct par_master par_master_internal = {
^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:1043: recipe for target 'internal.o' failed
make: *** [internal.o] Error 1
1 year, 6 months
Re: [flashrom] linux_spi:speed does not work?
by Stefan Tauner
On Tue, 22 Aug 2017 13:10:07 +0000
"Hänel-Baas, Alexander" <alexander.haenel-baas(a)sieb-meyer.de> wrote:
> Hi,
>
> we use flashrom 0.99 to program the Spansion flash chip "S25FL064A/P" with the spi interface from the QoriQ LS1021a.
> The linux version is: 4.4.26.
>
> In the dts the spi speed is set to 16MHz, flashrom is lucky and programs the flash chip fine.
> To increase the programming time, we set the spi speed up to 50MHz in the dts, but now flashrom can't find the spansion chip.
>
> My dts:
> &dspi0 {
> bus-num = <0>;
> status = "okay";
>
> spidev0: spidev@0 {
> compatible = "rohm,dh2228fv";
> reg = <0>;
> spi-max-frequency = <50000000>; //16MHz works
> };
>
> In this case I pass the spi speed with the parameter: linux_spi:spispeed=16000 but this parameter doesn't help.
>
> My flashrom call:
> flashrom -p linux_spi:spispeed=16000,dev=/dev/spidev0.0 -n -w /opt/SIEBMEYER/fpga/readout_SPI_FEED_F00D.bin -c S25FL064A/P
>
> The flashrom output:
> flashrom v0.9.9-r1955 on Linux 4.4.26-TQMLS102xA-BSP-0100-Alex (armv7l)
> flashrom is free software, get the source code at https://flashrom.org
>
> flashrom was built with libpci 3.2.1, GCC 5.4.0, little endian
> Command line (8 args): flashrom -p linux_spi:spispeed=16000,dev=/dev/spidev0.0 -n -w /opt/SIEBMEYER/fpga/readout_SPI_FEED_F00D.bin -c S25FL064A/P -V
> Calibrating delay loop... OS timer resolution is 2 usecs, 467M loops per second, 10 myus = 10 us, 100 myus = 94 us, 1000 myus = 949 us, 10000 myus = 9433 us, 8 myus = 8 us, OK.
> Initializing linux_spi programmer
> Using device /dev/spidev0.0
> Using 16000 kHz clock
> The following protocols are supported: SPI.
> Probing for Spansion S25FL064A/P, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x10b
> No EEPROM/flash device found.
>
> And here the important kernel message: (spi support is compile with debug)
> [ 87.194660] spidev spi0.0: setup mode 0, 8 bits/w, 16000000 Hz max --> 0 <-- this is my speed given by linux_spi:spispeed
> [ 87.194706] spidev spi0.0: setup mode 0, 8 bits/w, 50000000 Hz max --> 0 <-- this is the default speed given by dts
> [ 87.194841] spidev spi0.0: setup mode 0, 8 bits/w, 50000000 Hz max --> 0
>
> What can I do, to set the spi speed from userland correctly?
> Can one flashrom call produce different spi_setup() outputs?
>
> I hope we can clarify this.
Hi Alexander,
we are using the standard Linux SPI interface and set the SPI clock via
the SPI_IOC_WR_MAX_SPEED_HZ ioctl (cf. linux_spi.c). The last time I
checked there was no possibility to read back the currently set
frequency, so the only thing we can do within flashrom is check if the
ioctl succeeded and it apparently does. My experience with these
drivers is limited, but my best guess is that there is a bug in the
implementation of the LS1021a-specific SPI driver. And that it
actually uses 50 MHz which is too much for the connection (and chip) in
question.
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
1 year, 6 months
linux_spi:speed does not work?
by Hänel-Baas, Alexander
Hi,
we use flashrom 0.99 to program the Spansion flash chip "S25FL064A/P" with the spi interface from the QoriQ LS1021a.
The linux version is: 4.4.26.
In the dts the spi speed is set to 16MHz, flashrom is lucky and programs the flash chip fine.
To increase the programming time, we set the spi speed up to 50MHz in the dts, but now flashrom can't find the spansion chip.
My dts:
&dspi0 {
bus-num = <0>;
status = "okay";
spidev0: spidev@0 {
compatible = "rohm,dh2228fv";
reg = <0>;
spi-max-frequency = <50000000>; //16MHz works
};
In this case I pass the spi speed with the parameter: linux_spi:spispeed=16000 but this parameter doesn't help.
My flashrom call:
flashrom -p linux_spi:spispeed=16000,dev=/dev/spidev0.0 -n -w /opt/SIEBMEYER/fpga/readout_SPI_FEED_F00D.bin -c S25FL064A/P
The flashrom output:
flashrom v0.9.9-r1955 on Linux 4.4.26-TQMLS102xA-BSP-0100-Alex (armv7l)
flashrom is free software, get the source code at https://flashrom.org
flashrom was built with libpci 3.2.1, GCC 5.4.0, little endian
Command line (8 args): flashrom -p linux_spi:spispeed=16000,dev=/dev/spidev0.0 -n -w /opt/SIEBMEYER/fpga/readout_SPI_FEED_F00D.bin -c S25FL064A/P -V
Calibrating delay loop... OS timer resolution is 2 usecs, 467M loops per second, 10 myus = 10 us, 100 myus = 94 us, 1000 myus = 949 us, 10000 myus = 9433 us, 8 myus = 8 us, OK.
Initializing linux_spi programmer
Using device /dev/spidev0.0
Using 16000 kHz clock
The following protocols are supported: SPI.
Probing for Spansion S25FL064A/P, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x10b
No EEPROM/flash device found.
And here the important kernel message: (spi support is compile with debug)
[ 87.194660] spidev spi0.0: setup mode 0, 8 bits/w, 16000000 Hz max --> 0 <-- this is my speed given by linux_spi:spispeed
[ 87.194706] spidev spi0.0: setup mode 0, 8 bits/w, 50000000 Hz max --> 0 <-- this is the default speed given by dts
[ 87.194841] spidev spi0.0: setup mode 0, 8 bits/w, 50000000 Hz max --> 0
What can I do, to set the spi speed from userland correctly?
Can one flashrom call produce different spi_setup() outputs?
I hope we can clarify this.
Thanks,
Alexander
1 year, 6 months
Re: [flashrom] Using libflashrom from fwupd
by Stefan Tauner
On Thu, 17 Aug 2017 10:23:54 +0100
Richard Hughes <hughsient(a)gmail.com> wrote:
> On 17 August 2017 at 10:18, Stefan Tauner <stefan.tauner(a)gmx.at> wrote:
> > However, this is inevitable sometimes as explained before... so maybe
> > we need some additional message passing indicating the different
> > reasons for a "change of plans" so that the UI can react? (which is
> > exactly the type of complication I wanted to avoid ;)
>
> I think a status enum of something like RESET would be enough to show
> something hand-wavey in the UI, e.g. "Sorry for the delay, trying
> harder..."
Am I the only one seeing a contradiction to what you wrote half an hour
ago (below)? Did I miss something?
On Thu, 17 Aug 2017 09:58:25 +0100
Richard Hughes <hughsient(a)gmail.com> wrote:
> If the percentage does go backwards then we need to give the user a
> really good reason of why, otherwise users *will* file issues and bugs
> about it.
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
1 year, 7 months
