flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[patch] Fix compiling r1275 and higher
by Idwer Vollering 07 Mar '11

07 Mar '11

Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Index: flashchips.c =================================================================== --- flashchips.c (revision 1275) +++ flashchips.c (working copy) @@ -5567,7 +5567,7 @@ .total_size = 64, .page_size = 4096, .feature_bits = FEATURE_EITHER_RESET, - .tested = TEST_PREW, + .tested = TEST_OK_PREW, .probe = probe_jedec, .probe_timing = 1, /* 150 ns */ .block_erasers =

2 1

[commit] r1277 - trunk
by repository service 07 Mar '11

07 Mar '11

Author: hailfinger Date: Mon Mar 7 16:32:58 2011 New Revision: 1277 URL: http://flashrom.org/trac/flashrom/changeset/1277 Log: Fix broken compilation caused by a typo in r1275. Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Modified: trunk/flashchips.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Mon Mar 7 11:59:06 2011 (r1276) +++ trunk/flashchips.c Mon Mar 7 16:32:58 2011 (r1277) @@ -5567,7 +5567,7 @@ .total_size = 64, .page_size = 4096, .feature_bits = FEATURE_EITHER_RESET, - .tested = TEST_PREW, + .tested = TEST_OK_PREW, .probe = probe_jedec, .probe_timing = 1, /* 150 ns */ .block_erasers =

1 0

Re: [flashrom] [PATCH] Remove delays in JEDEC erase sequence
by Carl-Daniel Hailfinger 07 Mar '11

07 Mar '11

Auf 06.03.2011 20:11, Michael Karcher schrieb: > t is extremely unlikely that a chip not requiring delays in probe does > require them in erase. We observed unreliable erasing with a SST49LF004A > with these delays, so remove them if the are not required. > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > --- > jedec.c | 33 +++++++++++++++++++++------------ > 1 files changed, 21 insertions(+), 12 deletions(-) > > diff --git a/jedec.c b/jedec.c > index 199c64d..822de88 100644 > --- a/jedec.c > +++ b/jedec.c > @@ -242,21 +242,24 @@ static int erase_sector_jedec_common(struct flashchip *flash, unsigned int page, > unsigned int pagesize, unsigned int mask) > { > chipaddr bios = flash->virtual_memory; > + int delay_us = 10; > + if(flash->probe_timing != TIMING_ZERO) > + delay_us = 0; > Inverted logic. Could you fix the logic like this: + int delay_us = 0; + if(flash->probe_timing != TIMING_ZERO) + delay_us = 10; Default to 0 delay, and only change it if the chip is slow. > > /* Issue the Sector Erase command */ > chip_writeb(0xAA, bios + (0x5555 & mask)); > - programmer_delay(10); > + programmer_delay(delay_us); > probe_jedec goes further by making that call conditional on nonzero delay. I don't have a strong preference, but wanted to mention it. Anyway, with the logic fix this is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[PATCH] mark Erase/Write on MX25L1605 as tested
by Sven Schnelle 07 Mar '11

07 Mar '11

Hi List, i flashed my ThinkPad X60s which contains a Macronix MX25L1605D yesterday with flashrom. Erase and Write worked without problems several times, so i think it is safe to mark that Part as completely tested. Signed-off-by: Sven Schnelle <svens(a)stackframe.org>

2 2

[commit] r1276 - trunk
by repository service 07 Mar '11

07 Mar '11

Author: hailfinger Date: Mon Mar 7 11:59:06 2011 New Revision: 1276 URL: http://flashrom.org/trac/flashrom/changeset/1276 Log: Mark Macronix MX25L1605D as fully tested. Signed-off-by: Sven Schnelle <svens(a)stackframe.org> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flashchips.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Mon Mar 7 02:09:55 2011 (r1275) +++ trunk/flashchips.c Mon Mar 7 11:59:06 2011 (r1276) @@ -3829,7 +3829,7 @@ .total_size = 2048, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PR, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers =

1 0

Re: [flashrom] [PATCH] Add mediatek_pata programmer
by Joseph Smith 07 Mar '11

07 Mar '11

On Mon, 7 Mar 2011 01:05:03 +0100, Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> wrote: > Add support for flashing using CD/DVD drives with mediatek chipsets. > > As the driver is now, it only supports parallel ATA drives with parallel > flash chips. The kind of drive access needed is not possible through IDE > drivers in the OS, flashrom has to access the IDE port directly. This will > interfere with OS drivers for the drive, so you better make sure that > the OS does not access the drive (or another drive on the same PATA > channel) > during the flash process. > > On recent linux kernels (with libata), the invocation > "-p mediatek_pata:devname=sr0" should work. It is supposed to forcibly > unregister all drives on the IDE channel sr0 is on (you better don't have > a file system mounted on a hard drive on the same channel), perform the > flash job, and, if the drive successfully reboots, re-add all detectable > IDE devices on that channel. > > This patch is known to lack a man page section and violate the flashrom > coding style in some places - I send it out to catch some early reviews > on it. > This is really cool :-) It also opens the door to another pata flasher: http://www.loet.de/flasher_en.html Great work! -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

1 0

[Patch] Add coarse-grained IPC locking mechanism to Flashrom
by David Hendricks 07 Mar '11

07 Mar '11

Hi, I have attached a patch which adds a locking mechanism to Flashrom to prevent multiple instances from running simultaneously. It may need some modification to fit different Flashrom use cases better, but I think it's a good start. The size of the patch is somewhat misleading -- The only real changes to Flashrom's current code are some of the exit points in cli_classic() and some added stuff in the Makefile. Everything else is contained in new files. The new files are: csem.{c,h}: Low-level code that interfaces with semctl(), semget(), etc. ipc_lock.{c,h}: Wrapper for csem stuff. locks.h: A listing of locks that Flashrom cares about. big_lock.{c,h}: An even higher-level wrapper around ipc_lock stuff, useful for simple, coarse-grained locking. util/use_big_lock.sh: Used by the Makefile to test for POSIX.1-2001 compliance. The advantages of this approach are: - The semaphore can be shared easily with other processes. - The semaphore is cleaned automagically in case of abnormal program termination. - Semaphore info can be viewed and managed easily using standard utilities like ipcs. - On Linux at least, a second instance of Flashrom will automatically begin immediately after the first instance is done. No busy waiting, no excessive delays. - We avoid errata with other locking mechanisms (there are known issues with flock(), for example). Disadvantages: - The current patch is very coarse-grained, which could be problematic for people who wish to flash multiple chips simultaneously. - Requires >= POSIX.1-2001 compliance. Please note that some files in this patch are BSD-licensed. Much of it is based off code which was open-sourced by Sun Microsystems, after acquiring it from Cobalt Networks. Signed-off-by: David Hendricks <dhendrix(a)google.com> -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.

3 3

Re: [flashrom] rtl8169 support - Final
by Mathias Krause 07 Mar '11

07 Mar '11

On 05.01.2011 18:36, Jon Shadow wrote: > I stole that static from nic3com.c file I suppose. > But there its used in nic3com_init() and nic3com_shutdown(), so needs to be a global variable. Regards, Mathias

3 3

Re: [flashrom] [PATCH] SST39SF512 is tested
by Carl-Daniel Hailfinger 07 Mar '11

07 Mar '11

Hi Michael, thanks for your patch! Auf 07.03.2011 02:44, Michael Karcher schrieb: > flashrom -V -w: http://paste.flashrom.org/view.php?id=389 > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

Re: [flashrom] [PATCH] SST39SF512 is tested
by Michael Karcher 07 Mar '11

07 Mar '11

Am Montag, den 07.03.2011, 02:44 +0100 schrieb Michael Karcher: > flashrom -V -w: http://paste.flashrom.org/view.php?id=389 Sorry, that's without "-V". See here: http://paste.flashrom.org/view.php?id=394 Regards, Michael Karcher

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom