flashrom May 2013

flashrom@flashrom.org

30 participants
97 discussions

Re: [flashrom] [PATCH] dediprog: add support for chip select.
by Carl-Daniel Hailfinger 03 May '13

03 May '13

Am 01.05.2013 01:21 schrieb Stefan Tauner: > Thanks to the traces captured by Martin Roth, and confirmed by tests > and analysis by Joshua Zarr, we can now use both target chips on the > Dediprog SF100. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Excellent detective work! Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

[commit] r1673 - trunk
by repository service 03 May '13

03 May '13

Author: stefanct Date: Fri May 3 23:58:28 2013 New Revision: 1673 URL: http://flashrom.org/trac/flashrom/changeset/1673 Log: dediprog: add support for chip select. Thanks to the traces captured and tests done by Martin Roth, and confirmed by tests and analysis by Joshua Zarr too, we can now use both target chips on the Dediprog SF100. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/dediprog.c trunk/flashrom.8 Modified: trunk/dediprog.c ============================================================================== --- trunk/dediprog.c Wed May 1 16:04:19 2013 (r1672) +++ trunk/dediprog.c Fri May 3 23:58:28 2013 (r1673) @@ -560,19 +560,22 @@ } #endif -/* Command C is only sent after dediprog_check_devicestring, but not after every +/* Command Chip Select is only sent after dediprog_check_devicestring, but not after every * invocation of dediprog_check_devicestring. It is only sent after the first * dediprog_command_a(); dediprog_check_devicestring() sequence in each session. - * I'm tempted to call this one start_SPI_engine or finish_init. + * Bit #1 of the value changes the chip select: 0 is target 1, 1 is target 2 and parameter target can be 1 or 2 + * respectively. We don't know how to encode "3, Socket" and "0, reference card" yet. On SF100 the vendor + * software "DpCmd 6.0.4.06" selects target 2 when requesting 3 (which is unavailable on that hardware). */ -static int dediprog_command_c(void) +static int dediprog_chip_select(int target) { int ret; - - ret = usb_control_msg(dediprog_handle, 0x42, 0x4, 0x0, 0x0, NULL, + uint16_t value = ((target - 1) & 1) << 1; + msg_pdbg("Selecting target chip %i\n", target); + ret = usb_control_msg(dediprog_handle, 0x42, 0x4, value, 0x0, NULL, 0x0, DEFAULT_TIMEOUT); if (ret != 0x0) { - msg_perr("Command C failed (%s)!\n", usb_strerror()); + msg_perr("Command Chip Select failed (%s)!\n", usb_strerror()); return 1; } return 0; @@ -722,7 +725,7 @@ return millivolt; } -static int dediprog_setup(void) +static int dediprog_setup(long target) { /* URB 6. Command A. */ if (dediprog_command_a()) { @@ -737,8 +740,8 @@ if (dediprog_check_devicestring()) { return 1; } - /* URB 10. Command C. */ - if (dediprog_command_c()) { + /* URB 10. Command Chip Select */ + if (dediprog_chip_select(target)) { return 1; } return 0; @@ -785,10 +788,11 @@ int dediprog_init(void) { struct usb_device *dev; - char *voltage, *device, *spispeed; + char *voltage, *device, *spispeed, *target_str; int spispeed_idx = 2; int millivolt = 3500; long usedevice = 0; + long target = 1; int i, ret; msg_pspew("%s\n", __func__); @@ -841,6 +845,30 @@ } free(device); + target_str = extract_programmer_param("target"); + if (target_str) { + char *target_suffix; + errno = 0; + target = strtol(target_str, &target_suffix, 10); + if (errno != 0 || target_str == target_suffix) { + msg_perr("Error: Could not convert 'target'.\n"); + free(target_str); + return 1; + } + if (target < 1 || target > 2) { + msg_perr("Error: Value for 'target' is out of range.\n"); + free(target_str); + return 1; + } + if (strlen(target_suffix) > 0) { + msg_perr("Error: Garbage following 'target' value.\n"); + free(target_str); + return 1; + } + msg_pinfo("Using target %li.\n", target); + } + free(target_str); + /* Here comes the USB stuff. */ usb_init(); usb_find_busses(); @@ -877,13 +905,13 @@ dediprog_set_leds(PASS_ON|BUSY_ON|ERROR_ON); /* Perform basic setup. */ - if (dediprog_setup()) { + if (dediprog_setup(target)) { dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; } /* After setting voltage and speed, perform setup again. */ - if (dediprog_set_spi_voltage(0) || dediprog_set_spi_speed(spispeed_idx) || dediprog_setup()) { + if (dediprog_set_spi_voltage(0) || dediprog_set_spi_speed(spispeed_idx) || dediprog_setup(target)) { dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; } Modified: trunk/flashrom.8 ============================================================================== --- trunk/flashrom.8 Wed May 1 16:04:19 2013 (r1672) +++ trunk/flashrom.8 Fri May 3 23:58:28 2013 (r1673) @@ -692,6 +692,18 @@ can be .BR 375k ", " 750k ", " 1.5M ", " 2.18M ", " 3M ", " 8M ", " 12M " or " 24M (in Hz). The default is a frequency of 12 MHz. +.sp +An optional +.B target +parameter specifies which target chip should be used. Syntax is +.sp +.B " flashrom \-p dediprog:target=value" +.sp +where +.B value +can be +.BR 1 " or " 2 +to select target chip 1 or 2 repectively. The default is target chip 1. .SS .BR "rayer_spi " programmer The default I/O base address used for the parallel port is 0x378 and you can use

1 0

Test report for multiple SPI flash chips on serprog with UNTESTED status
by Chi Zhang 03 May '13

03 May '13

The programmer is my newly built serprog with STM32 MCU. Please refer to https://github.com/dword1511/serprog-stm32vcp . These flash chips are first bought to test the programmer rather than flashrom itself :) The programmer has been verified by me with a commercial CH341A-based programmer, and a few bricks as well :) Some performance information about flashrom with these chips can be found at: https://github.com/dword1511/serprog-stm32vcp/blob/master/PERFORMANCE (btw, SST25VF040B is really slow at writing! Is it supposed to be this slow?) The pasted logs are organized in probe-write-read-erase sequences. AT25F512A: http://paste.flashrom.org/view.php?id=1569 AT26DF161A: http://paste.flashrom.org/view.php?id=1570 EN25F05: http://paste.flashrom.org/view.php?id=1571 MX25L12845E(mistaken as 'MX25L12805(D)'): http://paste.flashrom.org/view.php?id=1572 Pm25LV010A: http://paste.flashrom.org/view.php?id=1573 SST25VF040B: http://paste.flashrom.org/view.php?id=1574 SST25VF040B with REMS: http://paste.flashrom.org/view.php?id=1575 M25P05-A: http://paste.flashrom.org/view.php?id=1576

2 14

Looking for dediprog users...
by Stefan Tauner 03 May '13

03 May '13

hi, if you are using an sf100 with a firmware version between 2.1.1 and 5.1.2 (non-inclusive), I would like to know from you if flashrom version r1649 or newer works for you or not. Probing for a chip (even if there is none attached) suffices as a test. Apparently earlier versions do not support setting the spi clock rate, but we always do that (since r1649) and fail programmer initialization on those versions. I try to find out which versions support setting the speed. BTW did anybody try to contact dediprog and request any information that would help flashrom to support their programmers better? I would also like to know if any dediprog sf300 or sf600 users are reading this and would like to see support for it in flashrom. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

3 3

GSoC Google Summer of Code 2013: Work for flashrom!
by Carl-Daniel Hailfinger 01 May '13

01 May '13

Hi, TL;DR: GSoC student proposal deadline is ~36 hours from now. Submit your proposal now! As you might already know (see the various announcements on IRC and our website), flashrom is participating in GSoC this year as part of the coreboot organization. This is your chance to work on flashrom and earn money at the same time. A list of possible student projects is here: http://www.flashrom.org/GSoC Apply here (we're part of the coreboot org): http://www.google-melange.com/gsoc/org/google/gsoc2013/coreboot Good luck! Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[commit] r1672 - trunk
by repository service 01 May '13

01 May '13

Author: stefanct Date: Wed May 1 16:04:19 2013 New Revision: 1672 URL: http://flashrom.org/trac/flashrom/changeset/1672 Log: Update spi_get_erasefn_from_opcode(). We forgot to add a few SPI erase functions to the helper function that is used for SFDP. Also, sort the declarations in the header. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/chipdrivers.h trunk/spi25.c Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Fri Apr 19 03:59:15 2013 (r1671) +++ trunk/chipdrivers.h Wed May 1 16:04:19 2013 (r1672) @@ -45,12 +45,12 @@ int spi_block_erase_20(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_50(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_52(struct flashctx *flash, unsigned int addr, unsigned int blocklen); -int spi_block_erase_81(struct flashctx *flash, unsigned int addr, unsigned int blocklen); -int spi_block_erase_d7(struct flashctx *flash, unsigned int addr, unsigned int blocklen); -int spi_block_erase_d8(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_60(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_62(struct flashctx *flash, unsigned int addr, unsigned int blocklen); +int spi_block_erase_81(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_c7(struct flashctx *flash, unsigned int addr, unsigned int blocklen); +int spi_block_erase_d7(struct flashctx *flash, unsigned int addr, unsigned int blocklen); +int spi_block_erase_d8(struct flashctx *flash, unsigned int addr, unsigned int blocklen); erasefunc_t *spi_get_erasefn_from_opcode(uint8_t opcode); int spi_chip_write_1(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int spi_byte_program(struct flashctx *flash, unsigned int addr, uint8_t databyte); Modified: trunk/spi25.c ============================================================================== --- trunk/spi25.c Fri Apr 19 03:59:15 2013 (r1671) +++ trunk/spi25.c Wed May 1 16:04:19 2013 (r1672) @@ -729,10 +729,16 @@ return NULL; case 0x20: return &spi_block_erase_20; + case 0x50: + return &spi_block_erase_50; case 0x52: return &spi_block_erase_52; case 0x60: return &spi_block_erase_60; + case 0x62: + return &spi_block_erase_62; + case 0x81: + return &spi_block_erase_81; case 0xc7: return &spi_block_erase_c7; case 0xd7:

1 0

Re: [flashrom] [PATCH] dediprog: add support for chip select.
by Paul Menzel 01 May '13

01 May '13

Am Mittwoch, den 01.05.2013, 01:21 +0200 schrieb Stefan Tauner: > Thanks to the traces captured by Martin Roth, and confirmed by tests > and analysis by Joshua Zarr, we can now use both target chips on the > Dediprog SF100. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> > --- > dediprog.c | 51 +++++++++++++++++++++++++++++++++++++++------------ > flashrom.8 | 12 ++++++++++++ > 2 files changed, 51 insertions(+), 12 deletions(-) > > diff --git a/dediprog.c b/dediprog.c […] > if (ret != 0x0) { > - msg_perr("Command C failed (%s)!\n", usb_strerror()); > + msg_perr("Command Chip Select failed (%s)!\n", usb_strerror()); Just one space after Chip Select? > return 1; > } > return 0; […] Acked-by: Paul Menzel <paulepanter(a)users.sourceforge.ner> Thanks, Paul

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom May 2013