Attention is currently required from: Anastasia Klimchuk.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79229?usp=email )
Change subject: erase_func_algo: Avoid putting 0xff into buffers ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hsuan-ting, I appreciate your effort to create a patch, but I don't understand what is the issue you […]
Hi Anastasia:
Here's my previous note: https://review.coreboot.org/c/flashrom/+/67535/comment/5f7ed5b9_3f1e6037/
Thanks for the prompt reply. Yes, I think I am not really clear about this test.
I am not very clear about the "golden example" should be. For example, ``` .initial_buf = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff}, .written_buf = {0x0, 0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7, 0x8, 0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf}, ```
Should we erase all or should we aware that the initial buf is already 0xFFs so skip erasure?
Please let me know if there's anything I need to study or misunderstood.