Attention is currently required from: Anton Samsonov, Anton Samsonov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email )
Change subject: Remove dependency on C23 __has_include() ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I would avoid introducing new pre-processor conditionals, because we are planning to go in the opposite direction and git rid of them all. Instead resolve this with the help of build system. Meson build file already has a few of examples of `cc.has_header` and `cc.has_function` and it can decide to use different source files/headers depending on whether header present or not.
This effort (removing pre-processor conditionals) needs makefile to be removed first, which in turn can only happen after the release is done. But, all of that is on the near future plans.
Anton, how do you feel about it?
-
Anastasia Klimchuk (Code Review)